GitLab

This CL:
* Introduces NetworkTypePattern::operator| which makes some code a bit
  more intuitive (and reduces overhead).
* Add Physical() for enabling/disabling physical networks during OOBE.
  This reduces log spam on linux and potentially avoids unexpected
  behavior on devices (but the current behavior is probably harmless).

Bug: 756092
Change-Id: Ie27d02fd03875c1bb44e61510acd5179b672bd14
Reviewed-on: https://chromium-review.googlesource.com/828264Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524279}

Fix the lack of autorotation dismissal in the user education bubbles
by:
1. Ensuring that both the new tab and incognito bubbles are dismissed.
2. Ensuring that the presenter objects are not overwritten if the
presentation is triggered more than once.
3. Change dismissal due to autorotation not to be animated, since
animated dismissal does not look good during the rotation.

Bug: 767201
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib30f03b061acd140ee8014b495087854d1e9e82e
Reviewed-on: https://chromium-review.googlesource.com/828143Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524278}

This was never implemented but the capability stuck around.

R=piman
BUG=NONE

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie016c422731eb26508309b7cc4a2a46e63395151
Reviewed-on: https://chromium-review.googlesource.com/828158Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524277}

* Dramatically simplifies the test code, plus tests the public API rather than
  an internal API method.
* Declares said internal API method with private visibility.
* Updates a non-const reference returned type to be a pointer instead.
* Tucks an enum into the anonymous namespace in the implementation file.
* Fixes up some comments: clearer phrasing, plus fixed typos and wrapping.

R=holte@chromium.org

Bug: 727984
Change-Id: I4c394d04cb4f4d24cdcc8a7baa2db54f4dc5c8f7
Reviewed-on: https://chromium-review.googlesource.com/826493Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524276}

This unblocks moving DevToolsAgent to blink.

Bug: 776009
Change-Id: I65b30774d1057402de891acb3a5fec187b6eeee5
Reviewed-on: https://chromium-review.googlesource.com/827926Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524275}

Use of gconf has been removed, and we depend on gsettings (in
libgio/libglib) instead of dconf directly.

Bug: 768027
Change-Id: I2c2dfb7f36db456c8c55af1041ad9497ddca07cd
Reviewed-on: https://chromium-review.googlesource.com/827677Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524274}

And add a couple of calls/overrides for tests to support presentation-callback.

BUG=792214,776877
TEST=covered by test

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1be1e89c65caa971ed108d361f4d9352651d2c35
Reviewed-on: https://chromium-review.googlesource.com/826302Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524273}

These tests are blocking CLs that add new, unrelated UKMs due to how
they test metric collection. Work is already in progress to update these
tests; disable them until that work lands.

Bug: 761524
Change-Id: If5716b417c0c72dac99e49a1440b00c2f1e3466b
Reviewed-on: https://chromium-review.googlesource.com/827666Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524272}

To avoid clashes between test data variables and similar changes,
this patch puts tests that would collide in custom namespaces
following a pattern used successfully in Blink.

Bug: 746953
Change-Id: I093f221ca2017c095f0751d52d70efa44e3fed31
Reviewed-on: https://chromium-review.googlesource.com/826636Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#524271}

AddressFamily is defined in host resolver mojom file. This CL makes it into
its own mojom file.

Bug: 721401
Change-Id: I29585ea8c35a63d543c4280b43d7f3fc70073eef
Reviewed-on: https://chromium-review.googlesource.com/826006Reviewed-by: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524270}

Bug: 783970
Change-Id: Iaa0e4c12e61e746e58aa761dec56b50ecb829ca1
Reviewed-on: https://chromium-review.googlesource.com/764377Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524269}

This fixes  JdkObsolete lint warnings in media_java.

Bug: NONE
Test: build media_java
Change-Id: I198be70370ed4b98336b3f858183c5d65555bc59
Reviewed-on: https://chromium-review.googlesource.com/827674Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524268}

Clusterfuzz tests blow up on this. Change it to DLOG an error and do
no transform.

Add a test that, before this change, would crash, but now passes.

Bug: 786787
Change-Id: Ica5a7f1805516d185ebbc51b53b39b5ca82d71f0
Reviewed-on: https://chromium-review.googlesource.com/826478Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524267}

Change-Id: Ic690e729722f602e3c527e0d43c64c731c863645
Reviewed-on: https://chromium-review.googlesource.com/813097
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524266}

Transitions another set of callers to use the new unique_ptr version of
SetLayoutManager.

Removes the
  using NNBFVL = DesktopLinuxBrowserFrameViewLayout
from desktop_linux_browser_frame_view_layout_unittest.cc
because it was only used twice.

Restructure a conditional in browser_view.cc so as not to trigger a
presubmit error about an if/else block with mismatched {}.

Change-Id: Id7ea28ae968ca7431f6ea61b2e3c95396f7e98e7
Reviewed-on: https://chromium-review.googlesource.com/827788
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524265}

The PlaybackImageProvider is required for using the compositor's image
decode cache during raster. Currently we conditionally create it if the
images are known to exist on a tile from discardable image analysis.
This results in an expectation for skia to implement some optimizations
assumed during analysis. Instead always create the provider to ensure
more predictable behaviour.

R=ericrk@chromium.org

Bug: 794690
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I2e21a88697fd400b43eb54fa6b63e73c591592d5
Reviewed-on: https://chromium-review.googlesource.com/826691Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524264}

CadenceBasedTest was running the same tests for 336 combinations of
frame rate and display rate values. Replaced it with a TEST_P-based test,
so it's executed as multiple small tests which don't timeout even in
debug mode.

Bug: 767166
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7b9c2140cfa515c57360064fa1ebccc607bec0a8
Reviewed-on: https://chromium-review.googlesource.com/828050
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524263}

Enable the X509Certificate printable_string_is_utf8 hack for:
- ClientCertResolver: Parses client certificates to match Issuer/Subject
  patterns
- enterprise.platformKeys.getCertificates API: Parses client
  certificates to get DER representation.

BUG=788655
TEST=chromeos_unittests --gtest_filter=ClientCertResolverTest.*

Change-Id: Iea02c525ed91017ccd1957da2ea0e28597c1bd9f
Reviewed-on: https://chromium-review.googlesource.com/823974
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524262}

This reverts commit 231de835.

Reason for revert: This change seems to break per-build bisects on Windows.

Command run:
python bisect_builds.py -o -a win64 -g 64.0.3282.24 -b 65.0.3294.0 -p S:\src\bisect\profile --use-local-cache

Result:
You are probably looking for a change made after 522661 (known good), but no later than 522662 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/bf8135d0bce64496b872062a07b427ddff825ec5..231de835ae50977881282c8c7fbbc2a93388d4b6

Original change's description:
> gin: Set V8 context snapshot as a default snapshot
> 
> Thanks to the change in V8 to make external reference table optional,
> we can always use v8_context_snapshot.bin on platforms where it is
> avaiable.
> 
> This CL sets the file as the default snapshot blob, and removes
> setting snapshot in Isolate::CreateParam.
> 
> 
> Bug: 764576, 789964
> Change-Id: I16654eef810efcd0103e9a29659f4616c61f790b
> Reviewed-on: https://chromium-review.googlesource.com/802654
> Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#522662}

TBR=peria@chromium.org,rmcilroy@chromium.org,haraken@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 764576, 789964
Change-Id: Ibe8ddd99b86fd00c2c2586645350401896c49084
Reviewed-on: https://chromium-review.googlesource.com/827705
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524261}

Confusion about when to use Binding<> vs. BindingSet<> can cause an
attempt to bind to an interface that is already bound. There is an
existing DCHECK for this -- just add some docs to make that more clear.

Bug: 794581
Change-Id: I14194770190e90e80403c027a65e7820949331f8
Reviewed-on: https://chromium-review.googlesource.com/827903
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524260}

This CL enforces that the target surface for touch events is always the
root surface for ClientControlledShellSurface.

ARC currently disables input for all sub-surfaces such that the target
surface is always the root surface. Newer clients will use a surface
hierarchy consistent with upstream Wayland, so focus will move between
different surfaces. This CL prevents touch events from being discarded
when capture changes during dragging/resizing, as a stopgap until
server-driven dragging/resizing is implemented.

Bug: b:67384524
Test: Input still works in ARC.
Change-Id: I3b419ec14cc04432b5b92618ed45df441da0d8eb
Reviewed-on: https://chromium-review.googlesource.com/812980
Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524259}

This patch changes //device/usb to use base::RefCountedBytes instead of
net::IOBuffer and net::IOBufferWithSize. This has a couple advantages:

1) base::RefCountedBytes always has a size which means in a follow-up
   patch we can stop passing separate length parameters.

2) base::RefCountedBytes is convertable to and from an
   std::vector<uint8_t> which reduces the mismatch between the C++ and
   Mojo interfaces.

3) base::RefCountedBytes holds unsigned data which is more correct for
   managing buffers (operations on signed values lead to bugs).

This patch makes as few changes as possible to effect this conversion.
Follow-up patches will take more advantage of the above to further
simplify the code.

Change-Id: I18dd0a68973c0bf82a7e4c3d0a2b7c2af1d284d7
Reviewed-on: https://chromium-review.googlesource.com/786680Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524258}

BUG=638618
TBR=dgozman

Change-Id: Icf84acbb89baa2a93f1687dd88256add80a892b1
Reviewed-on: https://chromium-review.googlesource.com/827539Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524257}

This CL adds the following:
1. Add support for fixed height single line text. This is useful when we want
to replace SimpleTexture which resize veritically with Text and Rect.
2. Removed texture size parameter from ctor. The backing texture size is
now calculated based on text size.
3. Use a const pixel per meter to make sure that text has consisent resolution.

Bug: NONE
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0714ec86dd87bb7fb1402830ba6ff8523ec85b6c
Reviewed-on: https://chromium-review.googlesource.com/827033
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524256}

The site URL is used in browser-side isolation enforcements and compared
against the origin requested by the renderer (e.g. when a renderer
tries to open localStorage for an origin, or [in the future -
https://crrev.com/c/769647] when a renderer wants to commit a navigation
with a specific origin).

Before this CL, browser-side isolation enforcement code would calculate
site URL for file: URLs as follows:
1. file:///home/lukasza/file.txt => site url = file:
2. file://localhost/home/lukasza/file.txt => site url = file://localhost/

Behavior before this CL was problematic, because the origin requested
by the renderer is the same in both cases above - this means that the
requested origin doesn't match the site URL in the 2nd case (and this
leads to renderer kills, like the one observed in
https://crbug.com/776160).

This CL changes how site URL is calculated by the browser process.
After the change, the same site URL (file:) is used for both the cases
outlined above.  Because of this change, the browser-side and
renderer-side notion of the origin is kept in sync (and we avoid
renderer kills).

Bug: 776160
Change-Id: I99ce397fede346b2278f053e0fa01e8e314741e2
Reviewed-on: https://chromium-review.googlesource.com/827550
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524255}

Also fix some nits and use ASSERT_EQ() where appropriate.

Change-Id: I7c0686c77c3ad3937af19328adbdd7e21a76e6f0
Reviewed-on: https://chromium-review.googlesource.com/827904Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524254}

https://chromium.googlesource.com/catapult.git/+log/928fcfa65b78..941f6397f9e2

$ git log 928fcfa65..941f6397f --date=short --no-merges --format='%ad %ae %s'
2017-12-11 rnephew [Telemetry/TADA] Add support for wildcard disabling of benchmark using expectations parser.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I5daa6ef78e21a354b54706eb4f83be4fad27d669
Reviewed-on: https://chromium-review.googlesource.com/828141
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524253}

This CL makes the cookie name part of the expand button so that clicking
on it will expand/collapse the local data.

Bug: 752821
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id81f16c3ecd435c4e99e4ccd9a6cfacf0cf81ef8
Reviewed-on: https://chromium-review.googlesource.com/820651Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524252}

unit_tests --gtest_filter="SecondaryGoogleAccountSigninPolicyHandlerTest*"
and components_unittests --gtest_filter="SigninHeaderHelperTest*". In addition to these,
manual testing on Public Sessions, Guest Sessions and Multi-Sign in mode.

Bug: 784760
Change-Id: I037cbcde5cd776b1b5a57b4788ea6fe3fd27ad74
Test: browser_tests --gtest_filter="PolicyPrefsTest.PolicyToPrefsMapping*",
Reviewed-on: https://chromium-review.googlesource.com/797590Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524251}

Bug: 778043
Change-Id: If62821bbd2140fc66af9985c11e98569d3b62ecc
Reviewed-on: https://chromium-review.googlesource.com/773780
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524250}

For certain "unusual" html elements, display:contents behaves as
display:none [1].

Frame and frameset always create layout objects, also when inserted into
a body with appendChild (the parser will discard them). This is also the
case for Gecko. I decided not to touch those even though the CSS Display
spec mentions them.

Similarly, there is no test for the applet element which is no longer
supported in Blink, so there is no test for it and it behaves like any
other unknown element supporting display:contents.

[1] https://drafts.csswg.org/css-display/#unbox-html

Bug: 794498
Change-Id: I7ce6f70efff563b6ff770f7c536c9144210ad0be
Reviewed-on: https://chromium-review.googlesource.com/827069Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524249}

Changing from base::Bind to base::BindOnce/Repeating in the
PdfToEmfConverter class.

Bug: 766451
Change-Id: I8e319028f1610a1a0e40cc20af642afa711b25ee
Reviewed-on: https://chromium-review.googlesource.com/826319Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524248}

Creates new trial name for happiness survey

Old field was
  TRIAL_NAME = "ChromeHome"

New fields are
  CHROME_HOME_TRIAL_NAME = "ChromeHome"
  HAPPINESS_SURVEY_TRIAL_NAME = "ChromeHomeHappinessSurvey"


Bug: 795094
Change-Id: Ie891ae29d256fb09d61d5377e8945cce39e9c1ed
Reviewed-on: https://chromium-review.googlesource.com/827707Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Daniel Park <danielpark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524247}

This helps avoid using |class WebView*| syntax to disambiguate
between referring to the WebView class or to the WebViewHelper's
accessor method.

See also the "New Blink Style Guide" at https://goo.gl/s2FC7t which says
"use bare words for getters", but then adds "Where a getter's name
collides with a type name, prefix it with "Get".

Bug: 718489
Change-Id: Ia3ace60b727d6de28e77c77690ddc561fa9b03d6
Tbr: pfeldman@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/773103
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524246}

Comment out Extension::ENABLED_COMPONENT_DEPRECATED to ensure it will
not be used. Also add explicit numbers for the rest of the states to
ensure they are not changed (since they are persisted on disk).

Bug: 794205

Change-Id: I1abaae6190a4e828dfe4768481c611e3ad68ebcd
Reviewed-on: https://chromium-review.googlesource.com/826686Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524245}

The test was adding observer too late.

TBR=dgozman
BUG=700374

Change-Id: Ibbe66b9fa8234142aca0ddeef6dbd8c78fc358cb
Reviewed-on: https://chromium-review.googlesource.com/828142Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524244}

chrome/test/android/javatests/src/org/chromium/chrome/test/TestContentProvider.java:112: warning: [SynchronizeOnNonFinalField] Synchronizing on non-final fields is not safe: if the field is ever updated, different threads may end up locking on different objects.
        synchronized (mLock) {

BUG=

Change-Id: Ic11db41809d951fbebfbafd76757833a4f297ebe
Reviewed-on: https://chromium-review.googlesource.com/827535Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524243}

Both the GPU and compositor threads can make Xlib calls and
XInitThreads() must be called in this situation. Change GPU process to
always call XInitThreads() during startup. GLSurfaceGLX will still call
XInitThreads() on startup because some test paths need it.
XInitThreads() will return immediately for subsequent calls so this
should be safe.

Bug: 730660
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0f3b44d7ac1a0e6c9e711de6d457634435add101
Reviewed-on: https://chromium-review.googlesource.com/818054
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524242}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6e5d5a6a7c91..760ef9c24a40

$ git log 6e5d5a6a7..760ef9c24 --date=short --no-merges --format='%ad %ae %s'
2017-12-14 jchinlee Rename trigger file.

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: I9c717271ed100d8863b7f0e4a879ab7d57e83c47
Reviewed-on: https://chromium-review.googlesource.com/828046Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524241}

https://skia.googlesource.com/skia.git/+log/f53e6c912dd4..f6e6be2da12a

$ git log f53e6c912..f6e6be2da --date=short --no-merges --format='%ad %ae %s'
2017-12-14 angle-deps-roller Roll skia/third_party/externals/angle2/ f15f9cec3..f414121d4 (2 commits)
2017-12-14 reed fix pdf_none
2017-12-14 reed Moving extra options/parameters into PDFMetadata
2017-12-14 mtklein Don't pass a stack address as a pipeline context pointer.
2017-12-14 brianosman Explicitly don't initialize matrix to fix deprecation warning
2017-12-14 benjaminwagner Add cert dimension for Mac Builders.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: I14bdc32a2ba9d956b7d9322204daa0c2f7154660
Reviewed-on: https://chromium-review.googlesource.com/828052Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524240}