GitLab

BUG=416225

Review URL: https://codereview.chromium.org/601003002

Cr-Commit-Position: refs/heads/master@{#296629}

Introduced c/b/ui/views/athena/athena_util so that
arbitrary code under chrome/browser doesn't have to depend on athena/

BUG=414340,410499

Review URL: https://codereview.chromium.org/603033002

Cr-Commit-Position: refs/heads/master@{#296628}

Revert of Add test for ChromeVox keyboard commands. (patchset #21 id:390004 of https://codereview.chromium.org/490443002/)

Reason for revert:
flakes, see http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31850

failures:
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0
LoggedInSpokenFeedbackTest.AddBookmark

Original issue's description:
> Add test for ChromeVox keyboard commands.
>
> This is just a couple of quick sanity checks to prevent future regressions
> like the one in the linked bug. It tests both a Search+Shift shortcut and
> the corresponding Prefix Key shortcut.
>
> Adds support for sending the meta modifier key in
> aura/x11 tests.
>
> BUG=404470
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547
>
> Committed: https://chromium.googlesource.com/chromium/src/+/8cab2737f1cb6e6011b0946f6bef5027868602c0
>
> Committed: https://crrev.com/91703961c10dfa0f452999ed7cb87945ea817362
> Cr-Commit-Position: refs/heads/master@{#293687}
>
> Committed: https://crrev.com/15ea141544fedaf306c94890b5be19b7c5df885a
> Cr-Commit-Position: refs/heads/master@{#296074}

TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404470

Review URL: https://codereview.chromium.org/603823002

Cr-Commit-Position: refs/heads/master@{#296627}

The OSX 10.10 dictionary changed its suggested corrections to "bouy", which
used to include "buoy". I updated the test to check that "bouy" has the
suggested correction "bout", which is present in the dictionary for both OSX
10.9 and OSX 10.10.

BUG=390276

Review URL: https://codereview.chromium.org/591313002

Cr-Commit-Position: refs/heads/master@{#296626}

Only chrome is interested in implementing these methods.
Move the code to ChromeAppDelegate.

BUG=411352

Review URL: https://codereview.chromium.org/557833007

Cr-Commit-Position: refs/heads/master@{#296625}

These may need to be made more elaborate once we start using them in
browser tests, but I've verified that they can be used to mock a basic
connection with resize support.

Review URL: https://codereview.chromium.org/593313003

Cr-Commit-Position: refs/heads/master@{#296624}

The unittests (WebDataServiceAutofillTest.CreditUpdate) assume that the
newly modified credit card information will be the first one returned.
Since it has the highest date_modified value, this imply a descending
ordering of the cards when iterating.

The unittests were previously flaky as the precision of date_modified
is not high enough and both card ended up with the same value most of
the time. When the test was taking slightly more time to run, then the
modified car would end up last and the test would fail.

BUG=None

Review URL: https://codereview.chromium.org/600873002

Cr-Commit-Position: refs/heads/master@{#296623}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/0f7197b..b5fae93

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/597813003

Cr-Commit-Position: refs/heads/master@{#296622}

Some macros in sys/socket.h were using _ASSING() macro, which wasn't
defined anywhere.

BUG=402993

Review URL: https://codereview.chromium.org/598223002

Cr-Commit-Position: refs/heads/master@{#296621}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e229507..1ff6c52

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/601043002

Cr-Commit-Position: refs/heads/master@{#296620}

Installs test CA to android devices as part of browser startup so that apps can be tested with proxy HTTPS server without code changes.

BUG=412826

Review URL: https://codereview.chromium.org/572123002

Cr-Commit-Position: refs/heads/master@{#296619}

Previously, it only checked the major version number (this was a
regression as a result of switching to Git).

Also abstracted version checking to a testable CheckVersion function,
and added tests for ParseVersion and CheckVersion.

Also added better documentation everywhere about the format of the
--check-version option.

BUG=406993

Review URL: https://codereview.chromium.org/506863005

Cr-Commit-Position: refs/heads/master@{#296618}

Previously, caption buttons were set at creation time.
With this CL, minimize and maximize buttons can be added and
removed throughout the lifetime of a window.

BUG=412241

Review URL: https://codereview.chromium.org/581953002

Cr-Commit-Position: refs/heads/master@{#296617}

The test relied on implicit assumptions about the system font. The system font
changed in OSX 10.10. I changed the test to always use a fixed font.

BUG=390276

Review URL: https://codereview.chromium.org/595053002

Cr-Commit-Position: refs/heads/master@{#296616}

R=lcwu@chromium.org
BUG=336640

Review URL: https://codereview.chromium.org/602593004

Cr-Commit-Position: refs/heads/master@{#296615}

At present, the NavigationEntry page type always reports
PAGE_TYPE_NORMAL for all committed entries, even if an
error page is currently showing. There is a need for a
mechanism to detect when an error page is showing in order
to prevent zooming in that case, so we modify the
navigation entry to correctly report error pages.

BUG=403268

Review URL: https://codereview.chromium.org/580133002

Cr-Commit-Position: refs/heads/master@{#296614}

BUG=416722
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/606473002

Cr-Commit-Position: refs/heads/master@{#296613}

The default value for NullableString should be null (was ""). Mojo struct fields whose type is string? should be initialized to null, not "".

BUG=417039

Review URL: https://codereview.chromium.org/605443002

Cr-Commit-Position: refs/heads/master@{#296612}

Revert of Findbugs roll from 2.0.3 to 3.0.0 (patchset #1 id:1 of https://codereview.chromium.org/604623002/)

Reason for revert:
findbugs expectations needs updating together with this roll.

Original issue's description:
> Findbugs roll from 2.0.3 to 3.0.0
>
> BUG=None
>
> Committed: https://crrev.com/cb90500709f6f56788fdd8c15da345220aa5b983
> Cr-Commit-Position: refs/heads/master@{#296595}

TBR=tedchoc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/597263003

Cr-Commit-Position: refs/heads/master@{#296611}

BUG=416722
R=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/605513005

Cr-Commit-Position: refs/heads/master@{#296610}

BUG=416722
R=shadi@chromium.org

Review URL: https://codereview.chromium.org/598243002

Cr-Commit-Position: refs/heads/master@{#296609}

Otherwise the sides may be clipped out.

BUG=417493
TEST=see bug
R=ananta@chromium.org

Review URL: https://codereview.chromium.org/604463003

Cr-Commit-Position: refs/heads/master@{#296608}

After a seek, both audio and video decoder job will start prerolling.
However, audio decoder job can finish prerolling much earlier than video decoder job.
As a result, audio will start playing before video starts.
And we will see some fast motion when video try to catch up with audio after it starts rendering.

internal b/17527385

Review URL: https://codereview.chromium.org/596093002

Cr-Commit-Position: refs/heads/master@{#296607}

I introduced these leaks recently and really should
have run valgrind.  In future out valgrind bot should
find such things pre-submit.

Review URL: https://codereview.chromium.org/605433003

Cr-Commit-Position: refs/heads/master@{#296606}

Notify RenderView webview() when the Page color profile changes so
it can update and repaint all color profiled elements on the Page.

Not used as yet: the IPC from the browser-side will be added later
(need to resolve issue 338130, issue 357443 first), so this change
is just more plumbing.

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
BUG=368663

Review URL: https://codereview.chromium.org/592753003

Cr-Commit-Position: refs/heads/master@{#296605}

BUG=none
TBR=mpearson@chromium.org
R=jiayul@chromium.org

Review URL: https://codereview.chromium.org/601033002

Cr-Commit-Position: refs/heads/master@{#296604}

BUG=416722
R=piman@chromium.org
TBR=cpu@chromium.org (sandbox_win.cc)

Review URL: https://codereview.chromium.org/606463002

Cr-Commit-Position: refs/heads/master@{#296603}

BUG=416722
R=garykac@chromium.org

Review URL: https://codereview.chromium.org/602763003

Cr-Commit-Position: refs/heads/master@{#296602}

This helper method is also used by internal Chromecast calls.

R=lcwu@chromium.org,byungchul@chromium.org
BUG=400914

Review URL: https://codereview.chromium.org/606483002

Cr-Commit-Position: refs/heads/master@{#296601}

The setting is enabled by default for Android builds, but not
practical for Chromecast on Android.

R=byungchul@chromium.org,lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/606453003

Cr-Commit-Position: refs/heads/master@{#296600}

Includes last frame's duration in the determination of
SourceBufferStream's |max_interbuffer_distance_|, to prevent an
unusually long segment-ending frame from triggering discontinuity when
adjacent buffers are appended.  A more correct fix requires
StreamParsers to always emit valid frame durations (crbug 351166), and
would use them exclusively to determine discontinuity.

BUG=351489
R=dalecurtis@chromium.org
TEST=No media_unittest, layout, or yt-dash-mse ToT conformance regression. Fixes b/17570928.

Review URL: https://codereview.chromium.org/597293004

Cr-Commit-Position: refs/heads/master@{#296599}

Output:
Failed to load ../out/Release/xdisplaycheck with cwd=/tmp/run_tha_testSvCWuD/chrome
Xvfb exited, code 1
Xvfb output:
>
> Fatal server error:
> Server is already active for display 9
> 	If this server is no longer running, remove /tmp/.X9-lock
> 	and start again.
>

BUG=414808
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/600283002

Cr-Commit-Position: refs/heads/master@{#296598}

createMediaPlayer() will soon get called with the additional
parameter |initial_cdm|. Adding a method to include it.

BUG=358271
TEST=mojo compiles with upcoming blink changes

Review URL: https://codereview.chromium.org/600233002

Cr-Commit-Position: refs/heads/master@{#296597}

BUG=17297,18218,20582,21479,27315,27644,28847,28072,31634,35164,35625,40429,40659,47949,50286,50297,50638,50968,52681,53742,53989,55773,58860,51682,60873,61737,61929,63024,63670,64463,65940,67291,68090,73036,73299,75136,75142,75714,77265,77388,79994,80239,82328,82682,84329,86303,87461,90976,91889,91892,92579,93036,96300,96559,96671,96689
NOTRY=true
TBR=ericwilligers@chromium.org

Review URL: https://codereview.chromium.org/605543003

Cr-Commit-Position: refs/heads/master@{#296596}

BUG=None

Review URL: https://codereview.chromium.org/604623002

Cr-Commit-Position: refs/heads/master@{#296595}

Offer to download the Software removal tool when the sw_reporter component found something that it can handle.

For chrome/app/chrome_command_ids.h
TBR=cpu@chromium.org

BUG=416582

Review URL: https://codereview.chromium.org/599653002

Cr-Commit-Position: refs/heads/master@{#296594}

BUG=402072
TBR=xiyuan,jamescook

Review URL: https://codereview.chromium.org/596603002

Cr-Commit-Position: refs/heads/master@{#296593}

I missed this in r296574

BUG=414808
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/602873004

Cr-Commit-Position: refs/heads/master@{#296592}

This is flaky because the app list ends up trying to read an ImageSkia
on one of Cocoa's background threads.

While NSView has a `canDrawConcurrently` function, AppKit is not calling
it in the case that is making this test flaky. The documentation says,
"The default is NO for most types of views.." [sic], and I've verified
it is `NO` and tried overriding it, but it was just never called.

However, having -[NSView canDraw] return `NO` seems to work fine.
Returning NO when there is no message loop ensures a draw only occurs on
a thread that Chrome created (not one of Cocoa's background threads),
and doesn't raise any DEPS issues.

BUG=417148, 415264

Review URL: https://codereview.chromium.org/599803002

Cr-Commit-Position: refs/heads/master@{#296591}

BUG=414808
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/599863003

Cr-Commit-Position: refs/heads/master@{#296590}