GitLab

We were recreating the AutofillProvider every time
TabImpl.updateFromBrowser() was called, which cancels the current
autofill request. updateFromBrowser() is called for various reasons, and
can be called multiple times with the same context.

Bug: 1083051
Change-Id: I7336566002b20f4dbcbaa5c489e4bfa92d1c4ec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211041Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770862}

Logging calls to NetLog in the SpdyStream object were inconsistent
and overly verbose. This patch makes them simpler and consistent.
There should be no functional change.

Change-Id: I689dcdbcea4673223c5a34c173065b72125e6686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210553
Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770861}

Added tests showing that the zip-no-nacl flag has no impact on Files App
at the moment.

BUG=912236
TEST=browser_tests --gtest_filter="ZipFiles/*" --gtest_list_tests
TEST=browser_tests --gtest_filter="ZipFiles/*"

Change-Id: I40d3bc780e75b90407e07fcecc4e90f3e0aea83a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203169
Commit-Queue: François Degros <fdegros@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770860}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7f02db5d3be5..c256b1f2a5f3

2020-05-20 soxia@microsoft.com [DevTools Frontend] Add missing icons.
2020-05-20 sigurds@chromium.org Typescriptify HeapProfilerModel

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1079233
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I8c7607af4677265cc63e82611ee7a6b809ba6548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211022Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#770859}

This CL modernizes the test using async/await, arrow functions etc for
improving code readability.

Bug: 1075582
Change-Id: I00b9da946299fd0e9e93204514e0857adc85ef93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208885Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770858}

- Record coverage metrics only when we show the suggestions
- Change current coverage metrics to match metrics.
- Add disabled metrics

Previously we were recording coverage metrics for personal info in a
wrong place. Now we moved it to the correct place and added a new metric
for all the match scenarios.

Add disabled metrics for cases where we could show suggestion but the
feature is turned off.

For personal info suggester, we only record coverage metrics when we
first show a suggestion so that we won't record dup metrics when the
user keeps typing with suggestion shown.

Test: tested with Chrome on Linux
Bug: 1042084
Change-Id: I6559d81f8d3fc5fa2f9385a4df617f0ac06c5848
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208577Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Jing Wang <jiwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770857}

base::TimeDelta will fail a DCHECK if you ever try to add -INF and +INF
time deltas. A consequence of this is if you have a video with a -INF
start_time and you try to seek to +INF, the current code will trigger
that DCHECK. This CL fixes that by settings -INF start times to 0.
This is consistent with how +INF start times are handled.

Bug: 1077685
Change-Id: I4e7fd453aab7a6b15befbb52b708d56febb943ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194917Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#770856}

This changelist includes the following to make |TreeView| explorable:

- Replaces the |kInvisible| state with the |kIgnored| state for unshown
  root nodes. This allows IAccessible2 clients to enter the tree to
  access individual tree items.

- Bridges accessibility hit testing from Views to virtual views so that
  pointer-based assistive technologies can access individual tree items
  using screen coordinates.

             items inside tree views.

AX-Relnotes: In Views, assistive technologies can now hit test tree
Bug: 811277
Change-Id: I56788354aa51b3598ff1afc96cb7214b12d04a85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134415
Commit-Queue: Brian Liu Xu <brx@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770855}

We no longer run finch for underlays. Underlays are enabled by default.

Bug: 868561
Change-Id: I2a2097a03a0aac32a32bb509fc686e2d15c3086c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207971Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770854}

Previously, scrollToTop while the omnibox is focused would scroll to the top and 2 omnibox would be visible.

Now, first unfocus omnibox, then allow scrollToTop.

Before: https://drive.google.com/file/d/1zn69R672sRTRe6GG3s4Mc7WVo2Q6G4xo/view?usp=sharing
After (Patchset 1-6) : https://drive.google.com/file/d/1fiiZZBwWfXb7gb66dCfOwW6yGSBemayi/view?usp=sharing
After stuttering fix (Patchset 7+) : https://drive.google.com/file/d/1A2FavkilxFqFVFjh2A5wN0SATsrMENGx/view?usp=sharing

Change-Id: I3c026bb800a243ef0bab150cfac4f696bbb14c40
Bug: 965473
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201896
Commit-Queue: Maxime Charland <mcharland@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770853}

This CL changes the aria label from simply "Back." to something more
descriptive to the screen reader user: "[Subpage title] back button",
with the role description: "Click to navigate away from [Subpage title]
page" so that the user is aware that they are currently at the
"[name of subpage]" subpage, and that activating the back button will
cause a route change to the previous page.

Videos:
https://drive.google.com/drive/folders/14JjstEYIC3-la2gIlGzo1pRa__NXDYBm?usp=sharing

Bug: 1071284
Change-Id: I4bd6e4400c84b63fe89ad2fe68f62e6d6f468657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200144
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770852}

Implements virtual view targeting for accessibility actions for
|TreeView| nodes so that they may be activated using the accessibility
review cursor. Previously, all actions were routed to the selected node,
even if the review cursor was on a different element.

Since focus is an accessible action, this changelist also includes
improvements to how accessibility focus events get fired around virtual
views:

- If a focused virtual descendant is set when |FocusManager| gives focus
  to the owner view, the descendant (instead of the owner view's
  accessible object) now fires the accessibility focus event.

- Consequently, by setting the |TreeView|'s focused virtual descendant,
  ahead of time, TreeView::OnFocus() no longer needs to redirect focus
  to a virtual view via ViewAccessibility::OverrideFocus(). This avoids
  firing multiple accessibility focus events for a single focus change.

             inside tree views.

AX-Relnotes: In Views, assistive technologies can now select tree items
Bug: 811277
Change-Id: I232c2acf2f4fec79ea30dbe82b5f077a4f9c32b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135205
Commit-Queue: Brian Liu Xu <brx@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770851}

Previously we allow to prefetch any preset number of images, but this is
not required and increases the complexity of code.
This patch simplifies the photo refresh logic. We only prefetch one more
image than displayed, which is used for photo transition animation.

Bug: b/156271483
Test: new unittests.
Change-Id: I0222c8f4db80d98dbd8f65453b4f8fe07bcb59e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209538Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770850}

Bug: 1084831
Change-Id: Ia145d711cc71fdfc698e560ad67e1723390025c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210005Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770849}

Bug: 1083825
Change-Id: I9272bb8031e73b48b23b72822d86844a157b9cce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210173Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770848}

R=dmazzoni@chromium.org

AX-Relnotes: n/a
Change-Id: Id9be642689ddd4898d7d062fad51408642fed204
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204844
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770847}

This CL adds support to the Combobox model to show different text
and icon inside the combobox from that shown inside the dropdown menu.

Bug: 1044038
Change-Id: Iad33be358e24f212db92fd5e774d52ec9bdd772d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207168
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770846}

The logs in media_drm_bridge.cc is critical in investigating issues on
cast receivers on Android TV. So include logging_override_if_enabled.h
so that the DVLOGs are overridden if enabled.

Bug: b/153475498
Change-Id: Iced008defa05339111a394e1f1a9d396e351b21c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210790Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770845}

Bug: 1085075
Change-Id: I0ffcd576cfec8545d466b2d24187e6d3be75160d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209607
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770844}

Bug: 1071659

Change-Id: Ife29376566fc1c6cadabef2f8a9040bbd208842f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209522Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770843}

The mash/mustash project was shut down over a year ago. Clean up some
obsolete comments and DEPS.

Bug: none
Change-Id: I9d9ce137a4cf42330eb104be7c9613a4c4ab0675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210631Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770842}

This CL replaces VideoTrackReader's ReadableStream with an output
callback, to be passed in at construction time.

Switching VTR to use a callback aligns it with the general direction of
WebCodecs. It also works because there isn't the need for backpressure
when using getUserMedia(). Additionally, a change in constraints to the
MediaStreamTrack would mean that we might have to flush the unread frames
from ReadableStream. This shouldn't happen with a callback (but we
don't invalidate pending frames when constraints change, for now).

Bug: 1080834
Change-Id: I5ff424f9440660dadc52ba6d4d76d14b5840a6d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191204
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770841}

Add a routine to determine whether the current network has nameservers
available for DNS resolution.

BUG=chromium:956783
TEST=unit_tests --gtest_filter=ResolverPresentRoutineTest.*

Change-Id: Ic9055f2bdce2df0e5bd8c3e147a635cd0e6a31c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151676Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770840}

Bug: 1084640
Change-Id: I21e89cbe3429c25f8a01f2cc0b79d5b5020c9024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209237
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Auto-Submit: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770839}

A "mouse click" is comprised of a mousedown and a mouseup. During a
mousedown on a scrollbar arrow, a GSB and a GSU are queued up in the
CompositorThreadEventQueue. On mouseup, a GSE gets added to the queue.
These gesture events are VSync aligned. However, if the user is rapidly
clicking on the arrow, we will get another mousedown before the queued
up GSE (from the first mouse click) has had a chance to be processed.
This new mousedown now ends up calling InputHandlerScrollEnd and that
in turn sets handling_gesture_on_impl_thread_ to false. When the queued
up GSE from the first mouse click finally gets dispatched, it notices
that handling_gesture_on_impl_thread_ is false and hence, leads to
DCHECK(!currently_active_gesture_device_.has_value()) failing. This CL
fixes the bug by clearing currently_active_gesture_device_ when the
ongoing scroll ends.

Bug: 1068062
Change-Id: Ie953c1336c2b74895dd0853da7c229928e137fdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191198
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770838}

This reverts commit 8a79ddf4.

Reason for revert: Breaks the build.
https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8879743677570880208/+/steps/compile/0/stdout
Need to investigate gn/build issue.

Original change's description:
> Android: New build target chrome/browser/contextmenu
> 
> This CL moves some interfaces for context menu under
> chrome/browser/contextmenu and defines a new modularized target.
> 
> This allows TabDelegateFactory class to chrome/browser/tab, and
> put |TabImpl.updateAttachment| back to Tab interface.
> 
> Bug: 952703
> Change-Id: Ie5534ce07c8e84593e6033141501e3f3a0ba4704
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201796
> Reviewed-by: Theresa  <twellington@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#770805}

TBR=nyquist@chromium.org,tedchoc@chromium.org,twellington@chromium.org,jinsukkim@chromium.org

Change-Id: I7e86f199aa960b5c3b4bb00609f6d51c1aed1856
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 952703
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211076Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770837}

Bug: 1035448
Change-Id: Ib029e2c3115a5f0d8e9d3c9dcfd014e5851f827b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209339Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770836}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bc0292ca..56b912f2

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org

Change-Id: Id476920ed709f3e04eec2bf68ef740ebf286b7a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210446Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770835}

They no longer use the JSONReader API, other than some enum and string
constant definitions that a later commit will hopefully move over from
JSONReader to JSONParser, once the JSONReader call sites have been
weaned off the JsonParseError enum (crbug.com/1070409).

Originally, there was a single JSON decoder implementation, and the
distinction between json_parser.h and json_reader.h was blurry. More
recently (crbug.com/c/1069271), we are experimenting with alternative
JSON decoder implementations. We may eventually settle on a winner, but
during the transition period, there may be several implementations. The
desired split is for json_reader.h to be the public API and for
json_parser.h to be *a* private implementation (the existing one).

In this new world, it is a layering violation for the lower level
JSONParser code and tests to rely on the higher level JSONReader API.
This commit helps address some of that concern: JSONParser tests now use
the JSONParser API, apart from the enum+string caveat mentioned above.

Bug: 1069271
Bug: 1070409
Change-Id: I5f261ae808b14997ddb748670b14ff4107f4dd33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208837Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770834}

https://dawn.googlesource.com/dawn.git/+log/78f7e8640f14..13e565a5999c

2020-05-20 rharrison@chromium.org Rolling 4 dependencies

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I51b46fca1fec9e0aeec4eea29c8db884b8cbed68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210647Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#770833}

Instead of taking a SearchConcept as a parameter, take some of the
fields included in a SearchConcept. This refactor is required for
modifying URLs for parent subpages/sections, which do not necessarily
have an associated SearchConcept.

Bug: 1082249, 1071700
Change-Id: I953643bb0b82d06270689582b1956bd4e4377b6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211062
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770832}

The previous test patterns had some overlap in them e.g.
SubPageDefault.DiskResizeOpensWhenClicked would run for both
SubPageDefault and DiskResize test suites. Remove the overlap.

Bug: chromium:1082027
Test: Run browser tests, check the DiskResizeOpens... test only runs once
Change-Id: Ib296c872b596f1ecac390bd2f5c26ce991785da7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210330Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Nic Hollingum <hollingum@google.com>
Commit-Queue: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#770831}

- Use iron-dropdown instead of native <select> to support displaying
  printer status icons inside the dropdown. Using iron-dropdown is a
  temporary workaround and will need to be replaced with another
  dropdown element in the future.

Bug: 1059607
Change-Id: I7598600ebb21e7d604ba416eb0a8938bd45e584c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2177274
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770830}

Bug: 100227
Change-Id: I8fd81f1d1584ba49fad35d9d30caec07d92dd8b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210797
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770829}

Bug: 1085209
Change-Id: I9868b9a7012e9dc7d23a710fea21186d8b73107a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210798Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770828}

This reverts commit 496003a3.

Reason for revert: Appears to still be breaking the build. See: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8879762809032212800/+/steps/compile/0/stdout

Original change's description:
> Reland "Add simple info bar to opt-out for conditional tab strip"
> 
> This reverts commit 2808b517.
> 
> Reason for revert: Add missed dependency.
> 
> Original change's description:
> > Revert "Add simple info bar to opt-out for conditional tab strip"
> >
> > This reverts commit e4d36bfb.
> >
> > Reason for revert: breaks download stream compile, might be build issue. please do "gn check target".
> >
> > https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8879764778699702672/+/steps/compile/0/stdout
> >
> > Original change's description:
> > > Add simple info bar to opt-out for conditional tab strip
> > >
> > > This CL adds an info bar for conditional tab strip to allow user to
> > > opt-out the feature. Some behavior of the info bar:
> > >
> > > * It will show after three consecutive sessions of dismissals.
> > > * If user clicks the "Don't show again" button, conditional tab strip
> > >   will never show for this user in later sessions.
> > > * If user clicks the "Show later" button, conditional tab strip
> > >   will show again for this user in later sessions, and the info bar will
> > >   never reshow.
> > > * If user clicks the dismiss button to dismiss the info bar, the info
> > >   bar will reshow after another three consecutive dismissal, but the
> > >   limit times of info bar showing is two, i.e. 6 consecutive sessions of
> > >   dismissal.
> > > * When the info bar shows, the undo snackbar will not show.
> > >
> > > Note that this is the simple version of info bar that we want, in that
> > > it is tied to one tab and cannot live across tab navigation.
> > >
> > > Bug: 1076295
> > > Change-Id: Icbb322af639ff5cf4ab8421d12ce428cc1b006eb
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206216
> > > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> > > Reviewed-by: Evan Stade <estade@chromium.org>
> > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> > > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> > > Reviewed-by: Matthew Jones <mdjones@chromium.org>
> > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#770632}
> >
> > TBR=estade@chromium.org,yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,hnakashima@chromium.org,yuezhanggg@chromium.org
> >
> > Change-Id: Id57987bdbf4cb0bb461e9b3ee44f636fa9db330e
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1076295
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209899
> > Reviewed-by: Xing Liu <xingliu@chromium.org>
> > Commit-Queue: Xing Liu <xingliu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#770647}
> 
> TBR=estade@chromium.org,yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,xingliu@chromium.org,hnakashima@chromium.org,yuezhanggg@chromium.org
> 
> # Not skipping CQ checks because this is a reland.
> 
> Bug: 1076295
> Change-Id: I89ec83eb3211a090f8e21004418eede65330959d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209902
> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#770763}

TBR=estade@chromium.org,yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,xingliu@chromium.org,hnakashima@chromium.org,yuezhanggg@chromium.org

Change-Id: I0681a7197eead16839263f4bdada5058856e73e7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1076295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210973Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770827}

https://android.googlesource.com/platform/external/perfetto.git/+log/f663d41a441e..169feea71d1f

2020-05-20 treehugger-gerrit@google.com Merge "Mark exhaustive time_in_state snapshots"
2020-05-20 simonmacm@google.com Merge "Add counter annotations for time-in-state probes."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I785ab047190b7b735f1776b8f639952a7164ecb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210646Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#770826}

This CL cleans up the disabled feature flags for Assistant not currently
in use, specifically |kEnableClearCutLog|.

This CL also cleans up some code missed in chromium:2207860 which was a
related CL that did a similar clean-up of the launched feature flags
instead.

Bug: b:156993255
Test: Does not change behavior
Change-Id: I3624e3fd15934c3b5bf0dcae43fc58c49d92281d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210324Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Abhijeet Singh <siabhijeet@google.com>
Cr-Commit-Position: refs/heads/master@{#770825}

Most PDFiumAPIStringBufferSizeInBytesAdapter users use it in almost
identical ways, just with different PDFium APIs. It would be nice to
consolidate the repeated code. This adapter is also bit hard to use. To
address these issues, add a templated CallPDFiumWideStringBufferApi()
wrapper to avoid the repeated code, and hide the complexities of the
adapter. Then move PDFiumAPIStringBufferSizeInBytesAdapter to a nested
internal namespace, because it is now just an implementation detail.

Similarly, add CallPDFiumStringBufferApi() for use with
PDFiumAPIStringBufferAdapter<std::string>, and make
PDFiumAPIStringBufferAdapter part of the internal namespace.

For the rare use cases that cannot use either of the two helper
functions above, expose PDFiumAPIStringBufferAdapter outside of the
internal namespace.

Change-Id: I542e442c23d52f7322ec79a1a516fb8c48b28bb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208604
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770824}

Bug: 1073844
Change-Id: Ic4997f6bcf7905d28cdfa9d8fef62293a5e03722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160973
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770823}