GitLab

On the Mac, we populate NSImage from bitmaps in resource bundles. Introduce ImageSkia which contains vector of SkBitmaps. Previously this functionality was within ImageRepSkia. ImageSkia exposes this.

Move gfx::Image::GetSkBitmapAtIndex and gfx::Image::GetNumSkBitmaps to ImageSkia

BUG=122992
TEST=None

Review URL: http://codereview.chromium.org/10086023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=build with chromeos=0/1 use_titlecase=0/1


Review URL: http://codereview.chromium.org/10167025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133606 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10198006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133605 0039d316-1c4b-4281-b951-d872f2087c98

Fix gesture events and touch events to scale delta and touch radius information as well

Review URL: http://codereview.chromium.org/10175002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133604 0039d316-1c4b-4281-b951-d872f2087c98

- Make LauncherView::CalculateIdealBounds to return last visible index;
- In LauncherView::LauncherItemAdded, use the last visible index to determine if
  we need the animation;

BUG=122482
TEST=Verify fix for issue 122482.


Review URL: http://codereview.chromium.org/10068027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133603 0039d316-1c4b-4281-b951-d872f2087c98

In this CL, we replace the old index system with a smarter one.
Its basically the same index system used for default user profile images.


BUG=124035
TEST=


Review URL: http://codereview.chromium.org/10021066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133602 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123961
TEST=added new test


Review URL: http://codereview.chromium.org/10151001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133601 0039d316-1c4b-4281-b951-d872f2087c98

Also fix style issues while I'm here.

BUG=none
TEST=none
R=dbeam


Review URL: http://codereview.chromium.org/10186011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133599 0039d316-1c4b-4281-b951-d872f2087c98

Fix a number of problems with the GoogleURLTracker, mostly around the multiple-searches-simultaneously use case:

* The old code used members to track things like "what's the search URL".  But since there's one GoogleURLTracker and potentially many simultaneously open tabs doing searches, this caused problems with searches overwriting the data for previous searches, leading to infobars that would redo the wrong search.  The new code stuffs this sort of data into the infobar delegate so it's safe to have many simultaneous infobars, which are now tracked in a map.

* Related to the above issue, we'd call registrar_.RemoveAll() any time an infobar was closed or we got a committed or closed notification.  But since multiple tabs could in theory be listening for notifications, this was wrong.  This could cause infobars to sometimes not appear when doing searches in multiple tabs.  Now we are more surgical with our notifications.

* Made accepting one infobar close all of them and trigger all of them to re-search.  Similarly, canceling any one infobar now cancels them all.

* The unittest code has been made more robust, if a bit confusing. I changed the way the helper code provided mock search domain responses to make it safe to provide a response whether or not a query had actually happened.  This way if something goes wrong and we don't query at the places we think we should, we won't have hangs or data corruption or anything else.  The downside here is that in order to avoid actually needing a WebContents*, NavigationController*, InfoBarTabHelper*, etc. to be constructed, I instead use simple ints that are reinterpret_cast<>()ed to the various types to serve as unique pointers.  The GoogleURLTracker itself doesn't actually deref these pointers, so this is safe, and it neatly sidesteps having to mock out a bunch of different things, but it's fairly unorthodox.

* More unittests for cases that the original code didn't cover, e.g. multiple simultaneous infobars.

This does NOT yet deal with a major cause of bug 110158 that the GoogleURLTracker does not correctly handle instant (and maybe also prerendering).  I wanted to make the underlying framework more sane and robust before trying to fix that.

BUG=54274,110158
TEST=Moving to different countries causes a "you moved" infobar to trigger when the user does a search.  No matter how many tabs have infobars, accepting or rejecting the new Google TLD should close them all, and if the TLD was accepted, redo all their searches on the new TLD.
Review URL: https://chromiumcodereview.appspot.com/4880003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133598 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123171
TEST=Verify fix for issue 123171.


Review URL: http://codereview.chromium.org/10197003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133597 0039d316-1c4b-4281-b951-d872f2087c98

This updates the Chrome OS versions of the strings on the
about page that are used to communicate update status to
refer to Chrome OS instead of Google Chrome.

BUG=124347
TEST=manual


Review URL: http://codereview.chromium.org/10186013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133596 0039d316-1c4b-4281-b951-d872f2087c98

Due to a race between when window show/hide animations change IsVisible() and "solo" window counting for determining header transparency, a missed update when windows are hidden, and FramePainter::PaintHeader() being called repeatedly with different clip rects for widget updates, we could get into a state where the window header has different transparency values behind various views::View widgets.

Fix this by using Window::TargetVisibility() instead of IsVisible() and monitoring for window visibility change events.

BUG=123866
TEST=manual, see bug


Review URL: http://codereview.chromium.org/10192001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133595 0039d316-1c4b-4281-b951-d872f2087c98

First committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133472
(was reverted, due to missing SHARED_INTERMEDIATE_DIR include dir in chrome_browser.gypi)

Review URL: http://codereview.chromium.org/10123016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133594 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133593 0039d316-1c4b-4281-b951-d872f2087c98

Lands the FFmpeg roll for M20.  Manual test pass completed
by vendors and myself.  ASAN/Valgrind testing on Linux/Mac
platforms on ia32/x64.  TSAN testing on Windows, no new
traces are expected.

ffmpeg_revision:
http://src.chromium.org/viewvc/chrome?view=rev&revision=133551

ffmpeg_hash:
http://git.chromium.org/gitweb/?p=chromium/third_party/ffmpeg.git;a=commit;h=f8d71c394e071249f26703669baf1093009620d7

List of remaining diff's from upstream:
http://pastebin.com/t5jTbvm9

BUG=49709, 124684
TEST=Video Test Matrix. unittests + asan/valgrind.

Review URL: https://chromiumcodereview.appspot.com/10196006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133592 0039d316-1c4b-4281-b951-d872f2087c98

Also adds it to the build to ensure it doesn't suffer bit-rot again, and
include Java-side component.


Review URL: http://codereview.chromium.org/10171009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133591 0039d316-1c4b-4281-b951-d872f2087c98

Turns out I cannot get the browser to crash reliably using
about:inducebrowsercrashforrealz anymore. The chrome:// URL works fine.

R=dennisjeffrey@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10200010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133589 0039d316-1c4b-4281-b951-d872f2087c98

PanelBrowserTitlebarGtk, derived from BrowserTitlebar, can allow us to add
panel-specific logic easily, instead of mixing everything in BrowserTitlebar.

This is needed when we're going to add custom button support for panels. We need to paint close and minimize button different from the standard ones and we also need to add unminimize button support.

BUG=none
TEST=existing tests due to no new functionaility


Review URL: http://codereview.chromium.org/10169019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133586 0039d316-1c4b-4281-b951-d872f2087c98

We record seek performance using the product of:
- Video formats: webm and ogv.
- Network constraints: cable, wifi, and no constraints.
- Seek cases: long, short, and buffered seeks.
- Video location: cached and un-cached videos.

BUG=122749
TEST=manual run


Review URL: http://codereview.chromium.org/9960063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133585 0039d316-1c4b-4281-b951-d872f2087c98

 -testPrefsLineEntryForFullscreenAllowed
 -testPrefsLineEntryForFullscreenExit
 -testPatternsForAllowFullscreenAndPointerLock
 -testPatternsForAllowMouseLock
 -testNoMouseLockRequest
 -testUnableToLockMouse
 -SearchForTextOutsideOfContainer

Added additional tests:

 -testEnterTabFSWhileInBrowserFS
 -testNoMouseLockInBrowserFS
 -testMouseLockExitWhenBrowserLoseFocus
 -ExitTabFSToBrowserFS
 -F11KeyExistsTabAndBrowserFS

BUG=122481
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10082033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:25279
TEST=dos2unix invocation, and manual inspection of the conversion.
Review URL: https://chromiumcodereview.appspot.com/10207003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133583 0039d316-1c4b-4281-b951-d872f2087c98

Allow the use of unofficial client for the daemon process even
if it is an official build. Which client ID to be used is chosen
by the webapp.

BUG=123693
TEST=Run a dev build webapp with an official daemon


Review URL: http://codereview.chromium.org/10116040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133582 0039d316-1c4b-4281-b951-d872f2087c98

Fix incorrect tab_index in the test.

R=dyu@chromium.org
BUG=119602
TEST=

Review URL: https://chromiumcodereview.appspot.com/10207002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133581 0039d316-1c4b-4281-b951-d872f2087c98

R=sadrul@chromium.org
BUG=chromium-os:119308


Review URL: http://codereview.chromium.org/10116018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133580 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/10179006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133579 0039d316-1c4b-4281-b951-d872f2087c98

DomStorage async IPC message definitions and browser-side handlers. These messages aren't called yet by the renderer-side.
Review URL: https://chromiumcodereview.appspot.com/10160003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133576 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121409
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10181005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133575 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133574 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10205003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133573 0039d316-1c4b-4281-b951-d872f2087c98

In the long run these will go in the version dir, but for now they can just live by chrome.exe

BUG=119242,123316
TEST=Files land correctly at install


Review URL: http://codereview.chromium.org/10041040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133572 0039d316-1c4b-4281-b951-d872f2087c98

Handle the archive file to be mounted like a dirty file, e.g. by moving it to
cache/persistent/<resource_id>.mounted, which prevents it from being modified,
deleted, or moved.

BUG=chromium-os:28678
TEST=Verify that mounting/unmounting archive files on GData works correctly.


Review URL: http://codereview.chromium.org/10116044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133571 0039d316-1c4b-4281-b951-d872f2087c98

TEST=tests run again
BUG=none


Review URL: http://codereview.chromium.org/10181009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133570 0039d316-1c4b-4281-b951-d872f2087c98

    
The behavior of crypto::Encryptor::Decrypt() funcion is different on different platforms. Add this test to test this.
    
BUG=124434
TEST=this is a new test



Review URL: http://codereview.chromium.org/10146012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133569 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122897
TEST=Covered by LayoutTests


Review URL: http://codereview.chromium.org/10164017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133568 0039d316-1c4b-4281-b951-d872f2087c98

R=jrg@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/10186005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133567 0039d316-1c4b-4281-b951-d872f2087c98

test_package_apk is watching adb logcat and will never see EOF.

BUG=
TEST=


Review URL: http://codereview.chromium.org/10204001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133566 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81969
TEST=Open http://www.google.com. Make the window small. Mouse over one
of the links on the bar at the top of the page. Then move the mouse up
out of the window. Now, bring up Exposé. The Chrome window should not
have extra blue space around in Exposé when highlighted.

Review URL: http://codereview.chromium.org/10185005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133565 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122005
TEST=none
TBR=gavinp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10204005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133564 0039d316-1c4b-4281-b951-d872f2087c98

Some of the functions used by perf.py changed names in this CL:
http://codereview.chromium.org/10143008/.

BUG=None
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10199006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133563 0039d316-1c4b-4281-b951-d872f2087c98

this prevents jiggle during load because the profile info is available from when the page first loads, instead of a split second later.

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/10139019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133562 0039d316-1c4b-4281-b951-d872f2087c98