GitLab

Breaks webrtc_call.WebrtcCallTest.testLocalPreview.

> Use NTP time for video frame timestamp.
> Add tracing for capture timestamps.
> 
> BUG=225209
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/13554003

TBR=justinlin@chromium.org
Review URL: https://codereview.chromium.org/13882004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193358 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229708


Review URL: https://chromiumcodereview.appspot.com/13981002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193357 0039d316-1c4b-4281-b951-d872f2087c98

Added new DriveNotificationObserver interface which all observers of Google Drive invalidations should implement.

BUG=173339


Review URL: https://chromiumcodereview.appspot.com/13940004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193356 0039d316-1c4b-4281-b951-d872f2087c98

Use the given Profile instead of the default one when possible.
Fallback to file URL when something is wrong with .gdoc file.

BUG=None
TEST=Open a .gdoc (Google Docs) file in both Google Drive and Downloads from Files.app.


Review URL: https://chromiumcodereview.appspot.com/14012003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193355 0039d316-1c4b-4281-b951-d872f2087c98

FileSystemMountPointProvider::CreateFileStream{Reader,Writer} should return scoped_ptr instead of raw pointer so that the caller can make sure it obtains the ownership of the returned Reader/Writer.


BUG=175934
TEST=should pass all existing tests

Review URL: https://chromiumcodereview.appspot.com/13811013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193354 0039d316-1c4b-4281-b951-d872f2087c98

The argument of SetSurroundingText is relative position from passing surrounding
text. Here selection_range or text_range is absolute position from document
root, thus we need conversion.

BUG=222392
TEST=type "a" 140 times with Thai input and made sure not crashing.


Review URL: https://chromiumcodereview.appspot.com/13812013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193353 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193351 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds new methods into DriveScheduler, which will replace
GetResourceList.

BUG=160932
TEST=Ran unit_tests --gtest_filter=DriveScheduler*


Review URL: https://chromiumcodereview.appspot.com/13450006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193349 0039d316-1c4b-4281-b951-d872f2087c98

  [X] Save details in Google Wallet

checkbox notification and the account chooser (and rest of the dialog).  Previous problems were:

- the notification disappeared when the account chooser wasn't on Wallet
- the account chooser didn't change to "Pay without Wallet" when unchecked
- no way to tell if user is signed in when "Pay without Wallet" showing
- closing a dialog changed the state of an existing dialog (no longer first run)

BUG=224787
R=estade@chromium.org,aruslan@chromium.org,sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13625002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193348 0039d316-1c4b-4281-b951-d872f2087c98

For apps using ContentViewRenderView, make it possible to inject
SurfaceView object that ContentViewRenderView will use. Provide
default operation which just creates a new SurfaceView object.

BUG=229369
R=yfriedman@chromium.org
TBR=yfriedman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13812009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193347 0039d316-1c4b-4281-b951-d872f2087c98

Redundantly capturing the same frame allows iterative quality enhancement, and also allows the buffer to fill in "buffered mode".

TEST=text should become clearer after pausing animation at low bit rate.
BUG=223977,225669

Review URL: https://chromiumcodereview.appspot.com/13956003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193346 0039d316-1c4b-4281-b951-d872f2087c98

Previously it always returned false.
This uses the same implementation as BrowserWindowGtk::IsFullscreen.

BUG=222513

Review URL: https://chromiumcodereview.appspot.com/12854008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193345 0039d316-1c4b-4281-b951-d872f2087c98

This CL updates the private-API spec and pass the corresponding enum to the API.
C++ side implementation is done in another CL.

BUG=168722
TEST=unittests. Open Files App and verify the functions.


Review URL: https://chromiumcodereview.appspot.com/13913009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193344 0039d316-1c4b-4281-b951-d872f2087c98

On windows, we cannot create an file handle for IPC before the process was
created.

BUG=111316
TEST=content_shell.exe --dump-render-tree doesn't crash in a debug build
R=marja@chromium.org

Review URL: https://codereview.chromium.org/13818008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193343 0039d316-1c4b-4281-b951-d872f2087c98

Adds a new option SHARED_WITH_ME, which traverses the tree and return only the entries
- with "shared-with-me" label
- which has non-"shared-with-me" parent

BUG=224186
TEST=unittests


Review URL: https://chromiumcodereview.appspot.com/13909002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193342 0039d316-1c4b-4281-b951-d872f2087c98

Both tests flakily fail

BUG=229791,229792
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/14033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193341 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193340 0039d316-1c4b-4281-b951-d872f2087c98

Swap SendKeyPressToWindowSync / SendKeyPressSync order.
(tests if SendKeyPressToWindowSync alone is sufficient)
(otherwise two [esc] key presses are required, not sure why)

See the bug for more investigation notes/context.

BUG=227444
TEST=None; XP Tests (1) test output yields more info.
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13994002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193339 0039d316-1c4b-4281-b951-d872f2087c98

BUG=222390


Review URL: https://chromiumcodereview.appspot.com/13982004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193338 0039d316-1c4b-4281-b951-d872f2087c98

Adding the checkbox and the wiring necessary to properly change it when
the user adds or edits a shipping address manually.

BUG=222747
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13851002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193337 0039d316-1c4b-4281-b951-d872f2087c98

Fixes handling invalid .isolated.state files.

TBR=csharp@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/13818026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193336 0039d316-1c4b-4281-b951-d872f2087c98

Does this by adding EMAIL_ADDRESS to the list of fields excluded from the condition marked "abandon the import if two fields of the same type are encountered" in PersonalDataManager::IsValidFieldTypeAndValue()

BUG=224364
R=isherman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13760005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193335 0039d316-1c4b-4281-b951-d872f2087c98

expensive operations (by profiling), apart from the template rendering itself,
are calling UnixName (model.py) and removing comments from JSON files
(json_comment_eater.py). This rewrites both and memoizes the former.

BUG=227490

Review URL: https://chromiumcodereview.appspot.com/13599004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193334 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172195


Review URL: https://chromiumcodereview.appspot.com/13509006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193333 0039d316-1c4b-4281-b951-d872f2087c98

on an inspected popup.


BUG=196812


Review URL: https://chromiumcodereview.appspot.com/12572006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193332 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193331 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jsbell

Review URL: https://codereview.chromium.org/14018002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193330 0039d316-1c4b-4281-b951-d872f2087c98

A layer with a non-invertible transform should have an empty
visible content rect, so that we do not try to raster it.

A layer that has a transform that makes it non-visible in the
viewport would also inversely make the viewport non-visible
(empty) in its own space. The prioritization rect for this layer
should be empty, making all tiles not live.

Tests:
PictureLayerTilingTest.EmptyStartingRect
PictureLayerTilingIteratorTest.TilesExist
LayerTreeHostCommonTest.DrawableAndVisibleContentRectsForLayersWithUninvertibleTransform
LayerTreeHostTestUninvertibleTransformDoesNotBlockActivation.RunMultiThread

R=enne
BUG=229409

Review URL: https://chromiumcodereview.appspot.com/13820002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193329 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128079


Review URL: https://chromiumcodereview.appspot.com/13941004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193328 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=unittests


Review URL: https://chromiumcodereview.appspot.com/13945007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193327 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229248
TEST=trybots


Review URL: https://chromiumcodereview.appspot.com/13892002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193326 0039d316-1c4b-4281-b951-d872f2087c98

Profile should be set up before creating Extension.

BUG=229246
TEST=unit_tests --gtest_filter="ExtensionIconManagerTest.LoadComponentExtensionResource"


Review URL: https://chromiumcodereview.appspot.com/13814009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193325 0039d316-1c4b-4281-b951-d872f2087c98

Sometimes, prefetching was fast, which caused evicting the image being loaded from cache. As a result, full resolution image was not being loaded properly. This patch addresses this issue by evicting the full-resolution cache in advance, before loading an image from cache. As a result, there is always a space for cache, so there is a guarantee that the image just fetched from cache will not be evicted by the image being prefetched.

TEST=Follow the bug's description.
BUG=227264


Review URL: https://chromiumcodereview.appspot.com/13775010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193324 0039d316-1c4b-4281-b951-d872f2087c98

The VideoLayerImpl currently does upload of video frames from media::VideoFrame
to hardware/software resources, and displays these resources through quads. This
code is unfriendly to ubercomp as it requires holding onto the hardware resources
when using hardware decode, and because it reuses the same textures every frame
even though they need to be sent to the parent compositor.

This CL introduces the VideoResourceUpdater class, and moves all logic around
media::VideoFrame to that class. The VideoResourceUpdater class takes as input
a VideoFrame, and produces a set of TextureMailboxes for the video layer to
consume.

In the software case, the VideoResourceUpdater sets itself up as the release
callback so it can delete the backing texture when the browser compositor is
done with it (it could recycle it in the future).

In the hardware case, the VideoResourceUpdater takes a callback as input, so
it can have the WebMediaPlayer notified when the texture is given back from
the browser, and the hardware decoder can use it again for writing.

This CL also prepares us better for software uber-compositing video. The video
layer deals now only with abstract "resources", except for the mailboxes for
ubercompositor. The TextureMailbox construct needs to be abstracted in order to
hold a hardware or software backing for ubercompositor. Then the video layer's
special-case code for software can be entirely removed and it will be fully
software-uber-compositor-ready.

Currently, the VideoLayerImpl just makes use of the VideoResourceUpdater class,
making this a refactor without any functional change. This will make video
playback in ubercompositor work correctly for software-decoded video. In order
to address hardware-decoded video, a followup CL will have the WebMediaPlayer
hook up a callback through the VideoResourceUpdater to ensure it doesn't reuse
a texture for decode until it is returned from the parent compositor.

R=enne,jamesr
BUG=179729


Review URL: https://chromiumcodereview.appspot.com/13445009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193323 0039d316-1c4b-4281-b951-d872f2087c98

Each BrowserAccessibility had a "child_id", which was
confusing - the word "child" and "id" both have other
meanings within accessibility. In this context, it's
really an unique ID, that's only needed on Windows,
that can be used to quickly access an object using the
get_accChild function (which is where the "child"
comes in, it should really be "descendant").

BUG=175156

Review URL: https://codereview.chromium.org/13770015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193322 0039d316-1c4b-4281-b951-d872f2087c98

The virtual layout tests moved from LayoutTests/platform/chromium/virtual to
LayoutTests/virtual in blink r148016.

TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/14017002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193321 0039d316-1c4b-4281-b951-d872f2087c98

Webviews are not loaded after inserting a node which contains <webview> tags
Contributed by yupingx.chen@intel.com


BUG=222663


Review URL: https://chromiumcodereview.appspot.com/12465019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193320 0039d316-1c4b-4281-b951-d872f2087c98

BUG=226358
TEST=build


Review URL: https://chromiumcodereview.appspot.com/13929003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193319 0039d316-1c4b-4281-b951-d872f2087c98

Android download manager does not support authentication headers.
This change adds a call to check if a url request contains authentication headers.
If so, we fallback to chrome download path instead of using the download manager.

BUG=159687


Review URL: https://chromiumcodereview.appspot.com/13609002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193318 0039d316-1c4b-4281-b951-d872f2087c98

BUG=225846
TEST=Will test on Lumpy.


Review URL: https://chromiumcodereview.appspot.com/13585003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193317 0039d316-1c4b-4281-b951-d872f2087c98