- 21 Jul, 2020 40 commits
-
-
Hiroki Nakagawa authored
Bug: 860403 Change-Id: I859c54261415e224d97813595a4531c314f65718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308551 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#790231}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I16dde19dab7c5f085f9c72f14a3726ad94891d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309557Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790230}
-
Tomasz Wiszkowski authored
This is a corresponding change to https://crrev.com/c/2255131. Addresses Suggestions List height updates on Android versions preceding R. The change fixes suggestions list not resizing accordingly when the software keyboard is hidden. Bug: 1091880 Change-Id: I5e20235c7bc4d2f0b2424d41855dd6706a315e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307693 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#790229}
-
Gyuyoung Kim authored
This CL migrates PageMsg_AudioStateChanged to the blink's PageBroadcast interface. ExecutePageBroadcastMethod function is added to RenderFrameHostManager in order to execute the given callback in every RenderView similar to SendPageMessage function. Bug: 1102424 Change-Id: I92524a643be10d82d40f9dd6ff66094430f9a932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282634 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#790228}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fa504e744f9b..539e8783de62 2020-07-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision db5fc682..be103000 (790000:790129) 2020-07-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9a6944e0..db5fc682 (789857:790000) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ief29d200b4e2ccd37d14252a385da63fb12e225f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309148Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790227}
-
Tommy Martino authored
This adds a GIF view that will eventually be used for cryptid rendering. The general approach is: * The existing logo is wrapped in a FrameLayout with a new ViewStub. * When we get a callback indicating that no doodle is present, the NTP requests a drawable from the PCR and injects it into an ImageView inflated from the ViewStub. Out-of-scope for this CL is to actually populate the GIF image data; I have been testing locally with a res/raw file read into a byte array. Change-Id: Ib5deae5322856c9d8e8a68f0fd46cdb2aaadbe79 Bug: 1061949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245888Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#790226}
-
Andrew Grieve authored
* Delete java_warnings_as_errors * Use treat_warnings_as_errors for android rules * warnings-as-errors is now default true for debug builds * Add --warnings-as-errors to proguard.py, dex.py, bytecode_processor.py so that these warnings can all be turned off locally. * Made build_utils.CheckOutput fail by default when stderr or stdout is printed. This should prevent build logs from creaping in. * Added "you should use treat_warnings_as_errors=false" into error message when builds fail due to warnings. Bug: 1029357 Change-Id: Ia69e545a110554d76e190cb2da8b20fe10d4d6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232809Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#790225}
-
Luis G Garcia authored
Allow camera access feature to be available only to devices with the WebXRIncubations feature flag and with support for buffers. Fixed: 1101140 Change-Id: I44a15f8ad53e2fff425618f58d74f4ccfaac998d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300365 Commit-Queue: Luis Garcia <luisggarcia@google.com> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#790224}
-
David Tseng authored
This reverts commit 6c45baae. Reason for revert: <INSERT REASONING HERE> Need to stop propagation of key events even if they are repeated. Original change's description: > Prevent repeated keys from providing output in learn mode > > R=akihiroota@chromium.org > > Fixed: 1106462 > AX-Relnotes: only announce a modifier once, when holding down modifiers like Search in ChromeVox Learn Mode. > Change-Id: Iaa9de466462450ccef889a2b789b0c150127c814 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308489 > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790193} TBR=dtseng@chromium.org,akihiroota@chromium.org Change-Id: I4d2646397a765a6e78b11dd2ebdd777ed45be8ef No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309563Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#790223}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I6f871712c18e353845e2c971e056d5a1fa42b65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309451Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790222}
-
Sammie Quon authored
This reverts commit d939a1e1. Reason for revert: breaks RTL Original change's description: > views: Remove InkDropMask from tab close button. > > Modify the highlight path generator to use a round rect override so > that the ink drop clipping code will pick it up. Tab close buttons use > the content bounds, all other usages use the local buttons + fixed > inset, so tweak the API to allow for this. > > Test: manual > Bug: 1056490 > Change-Id: I9815c50ba1f79b3a40284c628eafcf50bcd9ce58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307694 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790197} TBR=pbos@chromium.org,sammiequon@chromium.org Change-Id: I2b62776dd91ab269059fb589528b2fcb0107f37f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1056490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308946Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#790221}
-
Sophie Chang authored
This will allow us to continue to evaluate preconnect accuracy even if the prefetch experiment is on. Change-Id: I1a0d0d2f10203413fc31b6241b0c9b8bbd49af28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308856Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790220}
-
Karandeep Bhatia authored
Plumb DOMWrapperWorld into ResourceLoaderOptions for xhr requests. BUG=1099975 Change-Id: Ib48d522c57239d1c5bbe80c5b5a64b8093c18612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305231Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#790219}
-
Tomasz Wiszkowski authored
This change addresses the case where an empty suggestions list is received, following a very rich suggestions list from previous Omnibox interaction. Mediator's internal logic clears up the locally stored AutocompleteResult as user completes interaction with the Omnibox, making the subsequently received empty list detected as a no-op. Bug: 1107562 Change-Id: Ifa50c9aea78e730a0424af411ea5d08c7dd5b015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308134 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#790218}
-
Reilly Grant authored
This change swaps sets of ScriptPromiseResolvers into local variables in a number of places where it was possible for script to execute during the call to Resolve() or Reject() and modify the set being iterated over, thus invalidating the iterator. Bug: 1106773 Change-Id: Id4eb0cd444a7dbb5de23038ec80f44fee649cfe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304538 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#790217}
-
Oksana Zhuravlova authored
This change updates WebContentsObserverProxy::RenderFrameCreated() to pass process id and render frame id to Java instead of always creating a Java RenderFrameHost. This addresses a memory regression and will allow future code to get a Java RenderFrameHost object on demand. Bug: 1101948 Change-Id: I61bd8dfdf7eedfd57af10c65747aecc42d1cee8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308213Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#790216}
-
nancylingwang authored
This CL modifies the default app icon handling in ArcAppIcon to get the foreground and background images separately for the adaptive icon. Bug: 1083331 Change-Id: I7a4d0b5bc2ad5d40c50a33ad8a24cea94d7aea3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299945Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790215}
-
Brian Sheedy authored
Removes the too-many-arguments PyLint disable in //content/test/gpu and fixes or suppresses the resulting errors. Bug: 1076144 Change-Id: I3742360b524c45f9e5fe01deecb3b7cfeba1419c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305006 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#790214}
-
Fergal Daly authored
This reverts commit ee99ff7f. Reason for revert: Seems to have caused many windows bots to fail https://crbug.com/1107693 Original change's description: > [base] Prepare //net for base::string16 switch > > This change prepares //net for the switch of base::string16 to > std::u16string on all platforms. This was achieved by making > net_unittests compile on Windows after the switch was made. > > Furthermore, it fixes small issues in //base and //sql. > > Bug: 911896 > Change-Id: I11fd80998e9f5e954a87870533685a3f77fa42d9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303431 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790126} TBR=dcheng@chromium.org,mmenke@chromium.org,wfh@chromium.org,pwnall@chromium.org,jdoerrie@chromium.org Change-Id: I55fcbe1f97fb34c943e72498e9f2e7d709a8b89c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 911896, 1107693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308553Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#790213}
-
Andrew Xu authored
My previous CL (https://crrev.com/c/2290766) fails to consider about the situation where hotseat is disabled. It assumes that hotseat is always enabled. Although hotseat is stable now, the flag to enable/disable hotseat still exists. So this CL is created to protect the feature of the old shelf. This CL ensures that the clip rectangle is applied only when the hotseat is enabled. Bug: 1106253 Change-Id: I4f5b56fb6f155450bde562a0e9d20ed4649d9e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308032 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790212}
-
Peter Kasting authored
Without changing functionality, any callers that passed "true" for |is_last_update| could instead (a) ensure |announce_accessible_alert_soon_| is set, to trigger the announcement, and (b) ensure the timer gets stopped after returning, so it's not still running. With some tweaks to guarantee these happen at both such call sites, this argument can be removed. Not only is the resulting code slightly simpler, the function is conceptually clearer too, since there are now fewer ways to trigger announcing, and stopping the timer is always handled at the caller layer instead of being done in different layers in different cases. This also changes a call to AbandonAndStop() to a call to Stop(), which has the same visible effect (there are subtle differences in terms of how tasks in the queue are hooked to the timer, which are irrelevant for this caller). It also makes other minor tweaks to alert-related things, e.g. adding some "const"s. Bug: none Change-Id: I39a2bac70e1e44dbb8d8b015d858b6cdb040be69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305593 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790211}
-
Evan Stade authored
Port PrefServiceBridgeTest to PrefServiceTest. Update docs. Update OWNERS. Bug: 1071603 Change-Id: I48f83e1faade5263a6b105268bfd57ded3db27e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307609 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#790210}
-
yjliu authored
Frame throttling starts and ends accordingly when window cycling starts and ends. Added test helper and unittests. Bug: 1107201 Change-Id: I98d9ac1675ca8fd6d2eb7bb178c5c8961166dae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308131 Auto-Submit: Jun Liu <yjliu@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#790209}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/82a184f9..5ee5fa86 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icb094de5c8592d88f2d359d57a0754953ee5a9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308311Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790208}
-
Karandeep Bhatia authored
The test SSLUIWorkerFetchTest.TestUnsafeContentsInWorkerWithUserException is flaky. Disable it. BUG=1107659 TBR=estark@chromium.org Change-Id: I448295f1e04e14170cc494c4e39170eb4f745b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309039 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#790207}
-
Wan-Teh Chang authored
Run the sRGB Blob tests with multiple image file formats, not just PNG. Change-Id: Ie404c85c2267e6f6bea888e205f180bc9c9a11d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305216Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#790206}
-
Karandeep Bhatia authored
BUG=1107612 TBR=primiano@chromium.org Change-Id: Iea8a925f79b364bb7d603061c4e4e50fc0f62fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308913Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#790205}
-
Kevin McNee authored
User gesture tracking was split across SafeBrowsingNavigationObservers and their SafeBrowsingNavigationObserverManager. We now have the manager hold this state. Bug: 1096115 Change-Id: Ie06e2211cc5f748001107590ba5b6d271361ebf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293634Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#790204}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: If975ef16cd6574a1a3b39fd87bf37b09636462e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308770 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790203}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I16ce002408f98aa76fd1965ccfe93a317c5ecb2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307174Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#790202}
-
Peter Kasting authored
This is only ever used to track if the dropdown is pressed; replace it with a bool. Also removes SchedulePaint() calls around changing the dropdown image, which should be done automatically and thus are redundant. Bug: none Change-Id: I457db5f1bc953d0c97cc51b77a13c433d80c6fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305373 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790201}
-
Miriam Zimmerman authored
Before this CL, if a user triggers a feedback report relating to the quick settings tray, the associated screenshot may show it partially translucent or not at all, because the bubble closes when the user hits alt+shift+I. TEST=Deployed to betty, opened quick settings tray, filed feedback. \ Screenshot contained both settings tray and notification, and \ both closed after feedback window opened. BUG=chromium:1024145 Change-Id: Ia1a79127660ac8bb25ece47b7520978f421f7e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305048Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#790200}
-
Antonio Gomes authored
... and binding logic, pPreparation work for migrating PageMsg_UpdateTextAutosizerPageInfoForRemoteMainFrames to Mojom. This CL is a preparing CL that binds blink::RemoteFrame instances to blink::mojom::RemoteFrameFrame interface, when it is appropriate. It makes use of the existing WebViewImpl::DidAttachRemoteMainFrame() hook. BUG=1102440 R=dtapuska@chromium.org Change-Id: I792f26f38070dc9a168c0c76081941450243a5f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307152Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#790199}
-
Hiroki Nakagawa authored
As a part of the Onion Soup project, this CL moves mojo::Remote<SharedWorkerHost> from content::EmbeddedSharedWorkerStub to blink::WebSharedWorkerImpl. This reduces functions on blink::WebSharedWorker interface defined for jumping over the boundary between blink/ and content/. Bug: 911415 Change-Id: I06a3011fe8c6668c33d314b677d3d876a9fed73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307391 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790198}
-
Sammie Quon authored
Modify the highlight path generator to use a round rect override so that the ink drop clipping code will pick it up. Tab close buttons use the content bounds, all other usages use the local buttons + fixed inset, so tweak the API to allow for this. Test: manual Bug: 1056490 Change-Id: I9815c50ba1f79b3a40284c628eafcf50bcd9ce58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307694 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#790197}
-
Peter Wen authored
Turn off lint for chrome_public_test_apk as it was generating a lot of warnings and errors that prevented relanding this lint CL ASAP. The baseline was generated from monochrome_bundle, which covered almost all the other lint targets with the exception of chrome_public_test_apk. Since it was only possible to easily generate a baseline from one target, it is faster to disable chrome_public_test_apk for the time being. Tbr: Submit before new errors are introduced Bug: 1107450 Fixed: 1107450 Change-Id: Id0aaeaa6eaf7d1b561617a2ff5840401599730ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308852Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790196}
-
Alex Ilin authored
This CL applies 3 minor changes to the reauth dialog style: - Left-align the title - Use the grey color for the body text - Reduce the margin the title and the body text Bug: 1107522 Change-Id: I6d37b4fc968a89dac96e94157c93a427de7ac924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307949 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#790195}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c8ae494401bc..6d0ab954e90c 2020-07-20 reed@google.com read/write m44 2020-07-20 egdaniel@google.com Make sure we free secondary command buffers we don't cache. 2020-07-20 johnstiles@google.com Reduce number of trials needed by ProcessorOptimizationValidationTest. 2020-07-20 brianosman@google.com Rearrange logic in SkRuntimeEffect::Make 2020-07-20 zepenghu@google.com update markdown files 2020-07-20 egdaniel@google.com Add support for holding onto refs for input buffers from bindBuffer calls. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I984fa7f0d5a1bf4e5d54ca5d53e3794d177e2557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790194}
-
David Tseng authored
R=akihiroota@chromium.org Fixed: 1106462 AX-Relnotes: only announce a modifier once, when holding down modifiers like Search in ChromeVox Learn Mode. Change-Id: Iaa9de466462450ccef889a2b789b0c150127c814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308489Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#790193}
-
Kevin McNee authored
|CrashTab| uses 0 as the exit code which makes the process appear to have terminated normally. The exit code passed to |RenderProcessHost::Shutdown| is only actually used on Windows, so this still appeared as a crash on other platforms. We now specify a non-zero exit code, so that callers of |CrashTab| observe a crash on Windows. Bug: None Change-Id: Iaafca2aeed50612ad0de01d06f65183e11d63783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303988 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#790192}
-