- 27 Nov, 2019 40 commits
-
-
Jasper Chapman-Black authored
Follow-up to 1940530. Change-Id: I56a59f0ec561075c250b4d36b1cc327d61be6cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939959Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719766}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b6148c3af63e..2ed71c811da7 git log b6148c3af63e..2ed71c811da7 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 jmadill@chromium.org Vulkan: Isolate DisplayVk.h from Display.cpp. 2019-11-27 jonahr@google.com Add EGLSurfaceTest.ResizeWindowWithDraw 2019-11-27 jmadill@chromium.org Suppress -Wsizeof-array-div in dEQP. Created with: gclient setdep -r src/third_party/angle@2ed71c811da7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I3b66989afc814a4fcde5c99dc59ae03a807a8aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939832Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719765}
-
Sergey Ulanov authored
Flush() was taking base::Closure, which is deprecated. Replaced with OnceClosure. Bug: 751838 Change-Id: I87825cfc58b92e32d6a7e3fff1cf062597fac396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940878 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719764}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4d6c84bf8985..bf46a27cdd73 git log 4d6c84bf8985..bf46a27cdd73 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 benjaminwagner@google.com [infra] Update Win10 in Skolo 2019-11-27 bungeman@google.com Reland "Replace CGFontCreate with CTFontManagerCreate." 2019-11-27 brianosman@google.com Add particle entry points to externs.js to fix missing symbols 2019-11-27 bsalomon@google.com Changes to GrCoordTransform and local coords 2019-11-27 bungeman@google.com Revert "Replace CGFontCreate with CTFontManagerCreate." 2019-11-27 bungeman@google.com Replace CGFontCreate with CTFontManagerCreate. Created with: gclient setdep -r src/third_party/skia@bf46a27cdd73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I2fd819ca49a45d6aebfcf2ce8839a7f06a42998c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939833Reviewed-by:
-
mark a. foltz authored
Migrate the OpenScreen MRP to use the new namespace for OSP-specific types. Bug: openscreen:90 Change-Id: I1c8e315c61ca97c96507e5379b4f20bb52fa57ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940872 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Auto-Submit: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#719762}
-
Shawn Gallea authored
This adds an early out to prevent observation of a null WebContents Bug: Internal b/145212654 Test: Build cast_shell Change-Id: I1bb2ff54246f842997130053f34f5d762cbec985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940717Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#719761}
-
Ben Kelly authored
Bug: 1007272 Change-Id: I38886607963d18d39cd94f3308cc0ea31371f125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940134Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#719760}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. R=boliu@chromium.org Bug: 1007760 Change-Id: Ibd0da08a74d9a68d8f3b9a5e47afa370f7e97e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940883 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719759}
-
danakj authored
After running the callback, the method is done. If it continues it will crash when it tries to use the |gpu_channel_host| or the |callback|. R=boliu@chromium.org Bug: 1007763 Change-Id: I927ad13f113d6702e83257418f6b1ec3240f9d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940877Reviewed-by:
-
Finnur Thorarinsson authored
The background for the Zoom icon is placeholder (haven't received the 9patch image yet). Animations between states will be included in a follow-up CL. Bug: 1029056, 656015 Change-Id: Ic5657246ca21f7d6a1fcf26a42e2148d0771a05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936770 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#719757}
-
Istiaque Ahmed authored
With SW lifetime fix CL (https://chromium-review.googlesource.com/c/chromium/src/+/1832714), this test should not fail/flake anymore. This is also evident as retrying the test thousand times locally doesn't fail. Bug: 1003597 Change-Id: I31f467b10e90e10835f60ebedf6320d40cc7b864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933410Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#719756}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cf59b855..1b6546d2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibfc4571f4018c71bba1bfb2f47fadd62e9320b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940132Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719755}
-
Michael Spang authored
This throws an exception if xkbcommon wasn't built already (oops): Traceback (most recent call last): File "../../../../../third_party/instrumented_libraries/scripts/download_build_install.py", line 528, in <module> main() File "../../../../../third_party/instrumented_libraries/scripts/download_build_install.py", line 525, in main builder.download_build_install() File "../../../../../third_party/instrumented_libraries/scripts/download_build_install.py", line 189, in download_build_install self.build_and_install() File "../../../../../third_party/instrumented_libraries/scripts/download_build_install.py", line 298, in build_and_install self.install_packaged_libs() File "../../../../../third_party/instrumented_libraries/scripts/download_build_install.py", line 313, in install_packaged_libs os.unlink(dest_path) OSError: [Errno 2] No such file or directory: '/ssd/src/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-asan-trusty/instrumented_libraries/asan/lib/libxkbcommon-x11.so.0' Bug: 1027853 Change-Id: Ie759fa2f16dfd3c3a89c6c96e721689db8804ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940886Reviewed-by:Evgenii Stepanov <eugenis@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719754}
-
Peter Kotwicz authored
This CL: - Makes WebappActivity use CustomTabTaskDescriptionHelper - Removes logic for chrome://newtab from CustomTabTaskDescriptionHelper - Fixes WebappSplashScreenTest.testThemeColorWhenNotSpecified() (Thanks to changes to BaseCustomTabActivity) BUG=989912, 1028628 TEST=CustomTabTaskDescriptionHelperTest.* Change-Id: I64e90c1190019356aa7587bb0d47333d6be1463a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914966 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#719753}
-
Peng Huang authored
This CL makes DisplayResourceProvider::ScopedReadLockSharedImage non-copyable to avoid double release problem. Bug: 1023971 Change-Id: I6b75a5e70e5805ea875c3281c17c8542c9ce731f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940529 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#719752}
-
Lukasz Anforowicz authored
This CL reverts 2 CLs that landed during M79: - r700364: Remove ChromeExtensionsRendererClient::ShouldFork. - r705362: Remove ContentRendererClient::ShouldFork. The revert skips (i.e. doesn't restore) obsolete tests in: - ///chrome/browser/prerender/prerender_browsertest.cc (PrerenderBrowserTest.PrerenderCrossProcessClientRedirect) - //content/renderer/render_view_browsertest.cc (AlwaysForkingRenderViewTest.*) The revert only restores the extension-specific part of ChromeContentRendererClient::ShouldFork (e.g. doesn't revert r705290 and r705329). The motivation for the revert is https://crbug.com/1027719 where we discovered that removing ShouldFork affected whether the Omnibox VS the web content get the focus after certain navigations. We should consider relanding the removal of ShouldFork (i.e. reverting the current revert) once we have regression tests and a fix for focus behavior. Bug: 883549, 1027719 Change-Id: I7ee44ca420fe813ae3f4a2b696fb9645de62f808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940449Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#719751}
-
haozhe authored
Both Chrome and Firefox pass Bug: 900581 Change-Id: Ic686da5cf98667dd8c2be2e004c7f9b368a5d03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940871Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#719750}
-
Mike Wittman authored
Coalesces all the chrome level support code in preparation for the addition of new support code for Android. Bug: 1027654 Change-Id: I32312c7616462939a0ccb8ba06f6ef2f75469586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940710 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
-
David Bertoni authored
After testing 1000 iterations on the trybots, there were no failures. The assumption is that recent work the the ServiceWorkerTaskQueue has fixed the flaky behavior. Bug: 997686 Change-Id: I836b23d13eb0994c3a6e3fbf319b95106bc22675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929435Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#719748}
-
Toby Huang authored
As a compound mixin, LoggedInUserMixin should inherit from InProcessBrowserTestMixin, just like all of the other browser test mixins. Doing so enables automatic calling of setup functions such as SetUpOnMainThread(), instead of requiring the test developer to remember to call these setup functions manually. Bug: 1028190 Change-Id: I3d36ddff1060ef7ff254b34d3c76ce069b5f49ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934507Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719747}
-
Devlin Cronin authored
ExtensionView::GetBrowser() is used by the ExtensionViewHost and ExtensionPopup to retrieve the Browser object the ExtensionView is hosted in (if any). However, the Browser is a platform-agnostic concept, and is passed through the ExtensionViewHost when creating the view. Instead, have ExtensionViewHost hold the reference to the browser when the view is created. This cuts down on virtual methods and redirection, and allows the ExtensionViewHost (which was 3/4 of the callers) to use the Browser directly, eliminating it from the ExtensionView (which never actually needed it) API surface. Also a smattering of drive-by cleanups: NULL->nullptr, make_unique, etc Bug: None Change-Id: Ibef4d5c9685f026c44640d01cb948b16405c0e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938030Reviewed-by:
-
John Chen authored
Modified three tests in run_py_tests.py: * testSendCommand: Too similar to testSendCommandAndGetResult, deleted. * testSendCommandNoParams: Replaced with unit test. * testSendCommandAndGetResult: Enabled on CQ. This used to be run exclusively on ChromeDriver waterfall, which no longer exists. Change-Id: I465fd6ccd5949f3b46eabacb951071d4ecbd0e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940488 Auto-Submit: John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#719745}
-
Jonathan Backer authored
SkiaOutputSurfaceImpl owns the SkiaOutputSurfaceDependency. After Impl goes out of scope, there is no more Dependency. We reference the Dependency when we call CreateSafe{Once,Repeating}Callback for things like presentation feedback callbacks. It is possible for presentation feedback to occur after Impl is gone, in which case we can no longer use Dependency. Bug: 1020699 Change-Id: Iedb37a444358e4c543afbb8d8da5907d6b290b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936889 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#719744}
-
Andrew Luo authored
Bug: 1016864 Change-Id: Id260f981248d815fe4eceb59c79c58ea7c054b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937786Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#719743}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8861d02f89f7..79685304182c git log 8861d02f89f7..79685304182c --date=short --first-parent --format='%ad %ae %s' 2019-11-27 sprang@webrtc.org Removes caching SimulcastEncoderAdapter::GetEncoderInfo() 2019-11-27 ilnik@webrtc.org Fix bw_limited_resolution in SendStatisticsProxy GetStats 2019-11-27 danilchap@webrtc.org Add string<->VideoCodecType conversion for all codec types. 2019-11-27 orphis@webrtc.org Revert "Add support for RtpEncodingParameters::max_framerate" Created with: gclient setdep -r src/third_party/webrtc@79685304182c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I06886f4fc323913e6f3a8413978d5d935c2ce2ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940810Reviewed-by:
-
Chris Hall authored
R=dmazzoni Change-Id: I464920afa12ab30208ebf490936ce55d36cf12bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938868 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#719741}
-
Jonathan Freed authored
Change-Id: I0adf2512553c7cfb7b9018b65a8d207f252edafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940548 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Auto-Submit: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#719740}
-
Steve Kobes authored
The original tests are left intact, as they also verify the value of LayoutShiftTracker::Score() which is not directly available to WPT. Bug: 984109 Change-Id: I25d8fd48ac86ebbfc742d6dfe10e7097497b31d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937579 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#719739}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use DynamicTo<SVGTitleElement> as new downcast helper 2. Use IsA<SVGTitleElement>(element) in place of IsSVGTitleElement(element) Bug: 891908 Change-Id: I1001e154870ab13f84d53e25361e9107cad4c4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936687Reviewed-by:Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#719738}
-
Vitaly Buka authored
With crrev.com/c/1914359 merged so we can enable the flag on Windows. Patch is similar to crrev.com/c/1795632 and crrev.com/c/1838383. Bug: 977230 Change-Id: I166392ee0f65ed7fd7f68cbdd5b7a3b7d589539b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854805 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#719737}
-
Carlos Caballero authored
This reverts commit de47eedd. Reason for revert: This is firing for all navigations Original change's description: > [bfcache] Disabling bfcache for PermissionManager. > > Some background on why we sometimes need to disable bfcache: > https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 > > Bug: 1001087 > Change-Id: If3a7b14a0cb6630c8d5754726bf3a10e6b84eeab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852289 > Commit-Queue: Alexander Timin <altimin@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Auto-Submit: Karolina Soltys <ksolt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713803} TBR=mlamouri@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1001087 Change-Id: I34da66bcf77ee5d561abea303f8c2a0d210f283d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940176Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#719736}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4cd5a5469ffe..29815810c944 Created with: gclient setdep -r src-internal@29815810c944 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Iaadf0fb8a79c275487e0ae804d6429f762c391d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940809Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719735}
-
Aga Wronska authored
Wrapper creates an abstraction layer and takes care of types conversion and data filtering, so it is not spread around per-app time limits code. Bug: 1015658 Test: AppServiceWrapperTest Change-Id: Iae04ea99e05f9495b70117e425374223e8583919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938567 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
Move all classes under org.chromium.chrome.browser.preferences which are related to Android settings screens (rather than the underlying preferences persistence layers) to org.chromium.chrome.browser.settings instead. This disambiguation was decided in go/clank-preferences-refactor. Dependent downstream change: https://crrev.com/i/2222930 TBR=tedchoc@chromium.org NOPRESUBMIT=true Binary-Size: Keeping existing method name, see crrev.com/c/1935716 Bug: 1027271 Change-Id: I961a7b13ab0911503ee0e9a59fc267436bebbe90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938467Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#719733}
-
chrome://flagsDemetrios Papadopoulos authored
Bug: 720034 Change-Id: I5042226a6269b3d60884cdc92ba554c2aaacaf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940555 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#719732}
-
Joe DeBlasio authored
This CL updates the cases in which mixed content download blocking will dump without crashing by excluding now-known cases where initiators are missing. These include downloads from webview/cct, internally-initiated downloads and user-initiated downloads of offline pages. It also silences dumps from a not-yet-understood situation where seemingly-normal downloads don't have initiators. The stack trace isn't helping in this case, so crash dumps aren't useful. Bug: 1029003 Change-Id: I77102e361d334e847331f5e0bc1b9ce5321ab4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940723 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#719731}
-
Livvie Lin authored
Bug: 1027626 Change-Id: I70ddfb8cb18b7e045e8c6f30ce7d398d0c2f1c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929862Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719730}
-
Carlos Knippschild authored
TBR=fgorski@chromium.org Bug: 1025251 Change-Id: I9034302de26f8be776045fdb3714da29fed5da74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940867Reviewed-by:
-
Devlin Cronin authored
The only remaining method of DeferredStartRenderHostObserver, OnDeferredStartRenderHostDidStopFirstLoad(), is only used in tests by a class that monitors ExtensionHost loads. Move this method to ExtensionHostObserver (and rename it OnExtensionHostDidStopFirstLoad()), and fully remove DeferredStartRenderFrameHostObserver. Bug: 1028334 Change-Id: I33afa64dd95ccc54903e99dc68c903818e6ef82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937357 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#719728}
-
Bin Wu authored
https://quiche.googlesource.com/quiche.git/+log/7e8ae0dee24d..f54082a0145f $ git log 7e8ae0dee..f54082a01 --date=short --no-merges --format='%ad %ae %s' 2019-11-27 bnc Use IsStreamError() and friends gMock matchers in quic/core (but not subdirectories). 2019-11-27 bnc Use IsStreamError() and friends gMock matchers in quic/core/http. 2019-11-27 bnc Use IsStreamError() and friends gMock matchers in a few tests. 2019-11-27 bnc Use IsStreamError() and friends gMock matchers in quic/quartc. 2019-11-26 dschinazi Deprecate quic_version_negotiation_grease 2019-11-26 dschinazi Deprecate quic_enable_version_49 Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: Ib9a68a549f96a69c07686a06ef23dd6ec6928c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940753 Commit-Queue: Bin Wu <wub@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#719727}
-
