GitLab

This is a reland of http://crrev.com/3882aae7 since
http://crrev.com/40d8624d should have fixed the problem leading to
diff update failures.

BUG=340387
TEST=N/A

Review URL: https://codereview.chromium.org/596353002

Cr-Commit-Position: refs/heads/master@{#296428}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5fa19f3..4d5ca33

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/603573003

Cr-Commit-Position: refs/heads/master@{#296427}

Revert of Revert of Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594) (patchset #1 id:1 of https://codereview.chromium.org/601803002/)

Reason for revert:
Wrong revert. I misread the buildbot failure email.

Original issue's description:
> Revert of Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594) (patchset #1 id:1 of https://codereview.chromium.org/595313002/)
>
> Reason for revert:
> Break build:
> http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/19333
>
> Original issue's description:
> > Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594)
> >
> > Summary of changes available at:
> > https://chromium.googlesource.com/chromium/blink/+log/f2b7b089..5fa19f3
> >
> > TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org
> >
> > Committed: https://crrev.com/0ae73de143b645c376ac0e503e9627d33bb3c4f1
> > Cr-Commit-Position: refs/heads/master@{#296414}
>
> TBR=ager@chromium.org,pdr@chromium.org,wjmaclean@chromium.org,blink-deps-roller@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/677a9222f8fbf4e581ba4461ae700c8c380bc78c
> Cr-Commit-Position: refs/heads/master@{#296418}

TBR=ager@chromium.org,pdr@chromium.org,wjmaclean@chromium.org,blink-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/595353002

Cr-Commit-Position: refs/heads/master@{#296426}

This function can return NULL if it fails to attach a stencil buffer,
or if it fails to allocate a GrGLTexture object.

R=enne@chromium.org
BUG=416795

Review URL: https://codereview.chromium.org/596343002

Cr-Commit-Position: refs/heads/master@{#296425}

Instead of a cryptic Unicode code point, this makes characters that are not
defined by the current braille table show up as dot 8, which should be
a rarely used cell in most or all braille tables.

While it might be nice to give users more information than a single 'unknown
character' dot, this is the only feasable alternative to the hexadecimal
number (\xHHHH).

BUG=321715

Review URL: https://codereview.chromium.org/589133002

Cr-Commit-Position: refs/heads/master@{#296424}

It doesn't make sense for 1-copy rasterizer where we can
control the exact amount of memory used to be affected
by the transfer buffer limit.

This sets the upper bound to 32 resources, which is reduced
to 0 when invisible. A simple constant like this is likely
what we want long term.

BUG=406404

Review URL: https://codereview.chromium.org/597833002

Cr-Commit-Position: refs/heads/master@{#296423}

This makes it so that the plugin can not use blocking completion callbacks while servicing HandleBlockingMessage. This is to discourage leaving JavaScript hung while doing long-running things (e.g. file IO).

(Of course, the plugin can get around this by bouncing to another thread; but I think this adds a useful guideline/deterrent.)

BUG=415351

Review URL: https://codereview.chromium.org/600553002

Cr-Commit-Position: refs/heads/master@{#296422}

BUG=412841

Review URL: https://codereview.chromium.org/584533002

Cr-Commit-Position: refs/heads/master@{#296421}

Since we on ChromeOS don't (always) need to enumerate devices at all.

BUG=345296
NOTRY=true

Review URL: https://codereview.chromium.org/596233003

Cr-Commit-Position: refs/heads/master@{#296420}

https://codereview.chromium.org/554733002 added support to 24K as sample rate, we need to update the uma stat correspondingly.

BUG=411241

Review URL: https://codereview.chromium.org/602503003

Cr-Commit-Position: refs/heads/master@{#296419}

Revert of Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594) (patchset #1 id:1 of https://codereview.chromium.org/595313002/)

Reason for revert:
Break build:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/19333

Original issue's description:
> Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594)
>
> Summary of changes available at:
> https://chromium.googlesource.com/chromium/blink/+log/f2b7b089..5fa19f3
>
> TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org
>
> Committed: https://crrev.com/0ae73de143b645c376ac0e503e9627d33bb3c4f1
> Cr-Commit-Position: refs/heads/master@{#296414}

TBR=ager@chromium.org,pdr@chromium.org,wjmaclean@chromium.org,blink-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/601803002

Cr-Commit-Position: refs/heads/master@{#296418}

Review URL: https://codereview.chromium.org/584313003

Cr-Commit-Position: refs/heads/master@{#296417}

Cr-Commit-Position: refs/heads/master@{#296416}

Enumeration and iteration were passing around void**. With this CL, we
instead use an Iterator object.

TBR=jkarlin@chromium.org,rvargas@chromium.org,clamy@chromium.org,piman@chromium.org
BUG=413644,416059
TEST=None

Review URL: https://codereview.chromium.org/588243002

Cr-Commit-Position: refs/heads/master@{#296415}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f2b7b089..5fa19f3

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/595313002

Cr-Commit-Position: refs/heads/master@{#296414}

Unce upon a time the ASan runtime library used to be statically linked into
the executables on OSX.
Because that library provided a number of API functions needed by the shared
libraries, we had custom ASan-specific .saves files that told the `strip`
utility to preserve those functions when stripping the executables.

Then ASan switched to using dynamic runtime library, which instantly broke the
stripping step, because the executables weren't necessarily referencing all the
ASan API functions (issue 242503).
As a result, stripping has been disabled, and we haven't had .dSYM debug info
for ASan builds for more than a year now (issue 148383).

Because the ASan API functions are now undefined in the executables, it's
actually senseless to use the .saves files to preserve those functions in each
executable. However __asan_default_options still must be preserved to be accessible
from the ASan runtime.

This CL removes all ASan symbols except for __asan_default_options from the .saves files
and makes Chromium.app and Chromium Helper.app correctly use app_asan.saves.
It also turns mac_strip_release on for ASan builds.

BUG=148383,242503,170739,166857
R=mark@chromium.org
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/560323004

Cr-Commit-Position: refs/heads/master@{#296413}

For now, this is used in the SupervisedUserInterstitial instead of listening to pref changes manually.
More clients will follow in later CLs.

BUG=

Review URL: https://codereview.chromium.org/597573002

Cr-Commit-Position: refs/heads/master@{#296412}

Use an internal callback instead of requiring the client to
pass a scoped_ptr<> to a "Delete" function.

BUG=416873

Review URL: https://codereview.chromium.org/600693002

Cr-Commit-Position: refs/heads/master@{#296411}

Enable using a JS dictionary to initialize a the fields in a Mojo struct. For example, to initialize a URLRequest:

  var urlRequest = new loader.URLRequest({
    url: "http://www.cnn.com",
    method: "GET",
    auto_follow_redirects: true
  });

The value of unspecified fields is the Mojo default for the field's type. Values for fields that were not specified in the Mojom struct definition are ignored.

BUG=416163

Review URL: https://codereview.chromium.org/595063002

Cr-Commit-Position: refs/heads/master@{#296410}

Try swarming base_unittests, browser_tests, content_browsertests, interactive_ui_tests, sync_integration_tests and unit_tests on debug Linux bots.

BUG=414808
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/598463004

Cr-Commit-Position: refs/heads/master@{#296409}

"Add New User" screen should have enabled all hardware
keyboards, owner and system input methods.

BUG=365299
TEST=manual

Committed: https://crrev.com/a5a81ef618a26e513a4ae0f2b4b0e77f8224e946
Cr-Commit-Position: refs/heads/master@{#296199}

Review URL: https://codereview.chromium.org/484353005

Cr-Commit-Position: refs/heads/master@{#296408}

Images over 32M pixels exceed IPC message limit size.  In ChromeContentUtilityClient::DecodeImage(), cut image dimensions in half to minimize quality loss and allow decoded image to be returned via IPC message.

BUG=366825
TEST=ChromeContentUtilityClientTest.DecodeImageSizeLimit; Set ChromeOS wallpaper using JPGs attached to bug

Review URL: https://codereview.chromium.org/482163002

Cr-Commit-Position: refs/heads/master@{#296407}

Revert of Revert of [Android] JUnit runner + gyp changes. (patchset #1 id:1 of https://codereview.chromium.org/597123002/)

Reason for revert:
Didn't help. We probably got scheduled on other, flakier Android devices which caused tests to start flaking, or something else is the root cause.

Original issue's description:
> Revert of [Android] JUnit runner + gyp changes. (patchset #15 id:280001 of https://codereview.chromium.org/574433003/)
>
> Reason for revert:
> Speculative revert: Android test started flaking a ton after this landed. Affected targets androidwebview_instrumentation_tests, chromeshell_instrumentation_tests, contentshell_instrumentation_tests. This CL seems the most likely in the blamelist of https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/15905.
>
> Original issue's description:
> > [Android] JUnit runner + gyp changes.
> >
> > This adds Java code for running junit tests, as well as gyp targets for
> > both runnable and non-runnable host-side JARs.
> >
> > BUG=316383
> >
> > Committed: https://crrev.com/2e56d4508e33de5fc60bbbb41c5a5d5534e88174
> > Cr-Commit-Position: refs/heads/master@{#296340}
>
> TBR=cjhopman@chromium.org,nyquist@chromium.org,aurimas@chromium.org,jbudorick@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=316383
>
> Committed: https://crrev.com/54b9408f8b18e3bf3a33343e375186e1949e8e86
> Cr-Commit-Position: refs/heads/master@{#296384}

TBR=cjhopman@chromium.org,nyquist@chromium.org,aurimas@chromium.org,jbudorick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=316383

Review URL: https://codereview.chromium.org/596303002

Cr-Commit-Position: refs/heads/master@{#296406}

2nd Reland of https://codereview.chromium.org/547553005/
after fixing memory issues.

This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/

Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations.

Now, the import itself is asychronous and calls back on completion.

While there, this also removes the GMock of the importer.

BUG=413219
TBR=eroman@chromium.org

Review URL: https://codereview.chromium.org/600803002

Cr-Commit-Position: refs/heads/master@{#296405}

This adds 9 new braille tables, including the highly requested Unified
English Braille (grade 1 and 2).  Support or two new languages: Hebrew
and Korean is also added.

While touching this code, also added locale-aware sorting of the tables
in the list on the options page to make it easier to browse through it.

BUG=341953
R=dtseng@chromium.org

Review URL: https://codereview.chromium.org/578303002

Cr-Commit-Position: refs/heads/master@{#296404}

This should reflect the changes in
https://critique.corp.google.com/#review/72343582

BUG=416806
TEST=unit tests

Review URL: https://codereview.chromium.org/601743002

Cr-Commit-Position: refs/heads/master@{#296403}

BUG=

Review URL: https://codereview.chromium.org/593183004

Cr-Commit-Position: refs/heads/master@{#296402}

TEST=None
NOTRY=True
TBR=achuith@chromium.org
BUG=417224

Review URL: https://codereview.chromium.org/602633002

Cr-Commit-Position: refs/heads/master@{#296401}

Ensure we are not building any of the arm code with gcc4.6
https://codereview.chromium.org/597033002

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/597703004

Cr-Commit-Position: refs/heads/master@{#296400}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2502bcc..f2b7b089

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/596283002

Cr-Commit-Position: refs/heads/master@{#296399}

By default open menus in Cocoa exist until the user makes a choice, but
since the bubble and its backing controller are owned and managed by
cross-platform code, this model doesn't make sense. Hiding the menu
programmatically matches the Views implementation and fixes the crash.

Since triggering the NSPopUpButton's menu with |performClick:| spins
a run loop waiting for user input, getting a test working was extremely
difficult. The solution is to refactor BubbleCombobox to subclass
MenuButton instead of NSPopUpButton; http://crbug.com/415088 created
to track this work, which will then support a test for this bug.

BUG=413267

Review URL: https://codereview.chromium.org/563093003

Cr-Commit-Position: refs/heads/master@{#296398}

Avoid running Write_after_input_sections_task while Write_sections_task is running.

BUG=161942

Review URL: https://codereview.chromium.org/596853002

Cr-Commit-Position: refs/heads/master@{#296397}

BUG=411835

Review URL: https://codereview.chromium.org/593973004

Cr-Commit-Position: refs/heads/master@{#296396}

There has been a security update in Precise which changed the paths somewhat.

BUG=313751
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/600793002

Cr-Commit-Position: refs/heads/master@{#296395}

This is no longer needed as WebNinePatchLayer has removed this method.

TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/595213002

Cr-Commit-Position: refs/heads/master@{#296394}

Simple vary implementation and tests.

Downstream of https://codereview.chromium.org/576973004/

BUG=392621

Review URL: https://codereview.chromium.org/574393002

Cr-Commit-Position: refs/heads/master@{#296393}

Revert of [Athena, Cleanup] rename WidnowManager::GetInstance -> ::Get (patchset #1 id:40001 of https://codereview.chromium.org/599683003/)

Reason for revert:
Seems to cause crash in two tests; the crash is in athena_test_base. Likely it isn't possible to call AthenaEnv::Get()->OnTerminating(); in all cases.

Example: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/36880/steps/athena_unittests/logs/TerminatingCallback

Original issue's description:
> rename WidnowManager::GetInstance -> ::Get
> call OnTerminating in unit test.
>
> BUG=None
>
> Committed: https://crrev.com/828338e278350941febbfbede2b34d721be6dab1
> Cr-Commit-Position: refs/heads/master@{#296348}

TBR=mukai@chromium.org,skuhne@chromium.org,oshima@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/601753002

Cr-Commit-Position: refs/heads/master@{#296392}

$ git log 926dccd2e..79940aeee --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-09-23 maruel Rename swarming.py query to bots and add a new query command.
2014-09-17 jam Fix isolate.py failing when run from src directory.

R=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/595183002

Cr-Commit-Position: refs/heads/master@{#296391}

Previous design:
1. The renderer needed all references to the same ServiceWorekrCache* to have the same CacheID.
2. The renderer would only send an IPC that a CacheID was deleted when the last reference to the CacheID was deleted in javascript.

After https://codereview.chromium.org/474593002/ and https://codereview.chromium.org/433793002/:
1. The renderer doesn't need all references to the same ServiceWorkerCache* to have the same CacheID.
2. The renderer will send an IPC that a CacheID is deleted after each javascript cache object is deleted.

To address the change on the browser side, simply make a new CacheID for every call to GetCache and CreateCache and delete its corresponding refptr when the CacheID is dropped.

BUG=392621

Review URL: https://codereview.chromium.org/599473002

Cr-Commit-Position: refs/heads/master@{#296390}

The flakiness only occurs on ASan builds. The test times out because the
shim does not successfully launch when the app launches.
LSOpenApplication returns procNotFound(-600). It's not clear why this
happens, but it could be some interaction with WaitForSingleProcess.

Reversing the order of the two test cases fixes the flakiness.

BUG=415422

Review URL: https://codereview.chromium.org/597113003

Cr-Commit-Position: refs/heads/master@{#296389}