1. 07 Apr, 2011 33 commits
    • tkent@chromium.org's avatar
      2011-04-07 Kent Tamura <tkent@chromium.org> · 8b18bad5
      tkent@chromium.org authored
              [Chromium] Update Linux x86-64 results for the Skia rounding rect change.
      
              * platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
              * platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.png:
              * platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
              * platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.png:
              * platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
              * platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.png:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83156 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8b18bad5
    • tkent@chromium.org's avatar
      2011-04-07 Kent Tamura <tkent@chromium.org> · 47fff8ef
      tkent@chromium.org authored
              Skip platform/mac/fast/forms/input-appearance-spinbutton-up.html on Mac WebKit2.
              https://bugs.webkit.org/show_bug.cgi?id=56298
      
              * platform/mac-wk2/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83155 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      47fff8ef
    • tkent@chromium.org's avatar
      2011-04-07 Kent Tamura <tkent@chromium.org> · 736d0742
      tkent@chromium.org authored
              Update spinbutton test results for r83145.
      
              * platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
              * platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
              * platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
              * platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
              * platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.txt: Added.
              * platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
              * platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
              * platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
              * platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
              * platform/chromium/test_expectations.txt:
              * platform/win/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83154 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      736d0742
    • commit-queue@webkit.org's avatar
      2011-04-07 Alice Boxhall <aboxhall@chromium.org> · ea642c20
      commit-queue@webkit.org authored
              Reviewed by Ryosuke Niwa.
      
              Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
              https://bugs.webkit.org/show_bug.cgi?id=57921
      
              Moves the MouseEventWithHitTestResults::targetNode() method on to EventHandler, so
              that the same logic can be used for a HitTestResult.
      
              No visible changes, just cleanup, so no tests.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::selectClosestWordFromMouseEvent):
              (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
              (WebCore::EventHandler::handleMousePressEventTripleClick):
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::handleMouseDraggedEvent):
              (WebCore::EventHandler::handleMouseReleaseEvent):
              (WebCore::EventHandler::subframeForHitTestResult):
              Made public static member, so that it can access targetNode(), and be accessed by
              webkitwebview in gtk.
              (WebCore::EventHandler::selectCursor):
              (WebCore::EventHandler::targetNode):
              (WebCore::EventHandler::handleMouseDoubleClickEvent):
              (WebCore::EventHandler::handleMouseMoveEvent):
              (WebCore::EventHandler::updateDragAndDrop):
              (WebCore::EventHandler::sendContextMenuEvent):
              * page/EventHandler.h:
              * page/MouseEventWithHitTestResults.cpp:
              (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
              * page/MouseEventWithHitTestResults.h:
              * page/android/EventHandlerAndroid.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/brew/EventHandlerBrew.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/chromium/EventHandlerChromium.cpp:
              (WebCore::EventHandler::passMousePressEventToSubframe):
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/efl/EventHandlerEfl.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/gtk/EventHandlerGtk.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/haiku/EventHandlerHaiku.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              (WebCore::EventHandler::passSubframeEventToSubframe):
              * page/wx/EventHandlerWx.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
      2011-04-07  Alice Boxhall  <aboxhall@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
              https://bugs.webkit.org/show_bug.cgi?id=57921
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_forward_context_menu_event):
              Call subframeForHitTestResult rather than subframeForTargetNode as the targetNode()
              method has moved on to EventHandler.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83153 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ea642c20
    • mjs@apple.com's avatar
      2011-04-07 Maciej Stachowiak <mjs@apple.com> · e6fe1ca4
      mjs@apple.com authored
              Reviewed by Adam Barth.
      
              REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
              https://bugs.webkit.org/show_bug.cgi?id=58017
      
              * Scripts/webkitpy/common/checkout/scm.py:
              * Scripts/webkitpy/common/checkout/scm_unittest.py:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83152 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e6fe1ca4
    • podivilov@chromium.org's avatar
      2011-04-07 Pavel Podivilov <podivilov@chromium.org> · ab3e9b7f
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: build mapping for formatted scripts based on keywords positions.
              https://bugs.webkit.org/show_bug.cgi?id=57936
      
              Mapping based on [\$\.\w]+ was not accurate because string literals representation
              may be different in original and formatted scripts.
      
              * inspector/front-end/ScriptFormatterWorker.js:
              (buildMapping.regexp.b):
              (buildMapping):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83151 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ab3e9b7f
    • philn@webkit.org's avatar
      2011-04-07 Philippe Normand <pnormand@igalia.com> · 8e577d8f
      philn@webkit.org authored
              Unreviewed, GTK rebaseline after r83145. Also skip
              fast/forms/input-number-large-padding.html which fails. See bug
              58020.
      
              * platform/gtk/Skipped:
              * platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
              * platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
              * platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83150 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8e577d8f
    • philn@webkit.org's avatar
      2011-04-07 Philippe Normand <pnormand@igalia.com> · 94afba9f
      philn@webkit.org authored
              Unreviewed, GTK baselines for 4 new tests.
      
              * platform/gtk/fast/history/visited-link-background-color-expected.checksum: Added.
              * platform/gtk/fast/history/visited-link-background-color-expected.png: Added.
              * platform/gtk/fast/history/visited-link-background-color-expected.txt: Added.
              * platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.checksum: Added.
              * platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
              * platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt: Added.
              * platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.checksum: Added.
              * platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
              * platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
              * platform/gtk/svg/text/text-midpoint-split-bug-expected.checksum: Added.
              * platform/gtk/svg/text/text-midpoint-split-bug-expected.png: Added.
              * platform/gtk/svg/text/text-midpoint-split-bug-expected.txt: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83149 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      94afba9f
    • mjs@apple.com's avatar
      2011-04-07 Maciej Stachowiak <mjs@apple.com> · 2211d104
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              Remove some no longer needed WebProcess sandbox allowances
              https://bugs.webkit.org/show_bug.cgi?id=58015
              <rdar://problem/9232592>
      
              * WebProcess/com.apple.WebProcess.sb: Remove no-longer needed extra network
              and launching privileges, since the bugs that required them are fixed.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83148 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2211d104
    • philn@webkit.org's avatar
      2011-04-07 Philippe Normand <pnormand@igalia.com> · 1285645e
      philn@webkit.org authored
              Unreviewed, GTK rebaseline after r83075.
      
              * platform/gtk/fast/blockflow/text-orientation-basic-expected.txt:
              * platform/gtk/fast/text/capitalize-empty-generated-string-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83147 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1285645e
    • tkent@chromium.org's avatar
      2011-04-07 Kent Tamura <tkent@chromium.org> · c51f43ec
      tkent@chromium.org authored
              [Chromium] Fix a duplicated entry.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83146 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c51f43ec
    • tkent@chromium.org's avatar
      Spinbuttons become unclickable if right padding is large. · 453f104f
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=56298
      
      Reviewed by NOBODY (OOPS!).
      
      Source/WebCore:
      
      An inner-spin-button is put on the right border and ignores right
      padding in RenderTextControlSingleLine::layout(), but forwardEvent()
      checks if a point is in an area just right of an internal text block.
      This inconsistency caused a bug that an inner-spin-button with large
      padding didn't receive mouse events.
      
      To fix this bug, we render spin buttons as layers, and remove manual
      event forwarding code.
      
      Test: fast/forms/input-number-large-padding.html
      
      * css/html.css: Add "position:relative" to make a spin-button a layer.
      (input::-webkit-inner-spin-button):
      (input::-webkit-outer-spin-button):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::forwardEvent):
        Remove manual event forwarding code.
      
      LayoutTests:
      
      Add a test, and skip on platforms which has no inner-spin-button implementation.
      
      * fast/forms/input-number-large-padding-expected.txt: Added.
      * fast/forms/input-number-large-padding.html: Added.
      * platform/chromium/test_expectations.txt:
      * platform/mac/Skipped:
      * platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
      * platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
      * platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
      * platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
      * platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
      * platform/qt/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83145 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      453f104f
    • tkent@chromium.org's avatar
      2011-04-06 Kent Tamura <tkent@chromium.org> · b280d830
      tkent@chromium.org authored
              Fixed an error in the previous commit.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83144 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b280d830
    • tkent@chromium.org's avatar
      2011-04-06 Kent Tamura <tkent@chromium.org> · 4cf159a8
      tkent@chromium.org authored
              [Chromium] Update text expectation.
              fast/repaint/scale-page-shrink.html is expected to fail because of no
              eventSender.scalePageBy().
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83143 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4cf159a8
    • tkent@chromium.org's avatar
      2011-04-06 Kent Tamura <tkent@chromium.org> · dcb51b1e
      tkent@chromium.org authored
              [Chromium] Update test expectation.
              xhr-breakpoints.html and detailed-heapshots-summary.html are flaky.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83142 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dcb51b1e
    • abarth@webkit.org's avatar
      2011-04-06 Adam Barth <abarth@webkit.org> · 463f252b
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              CSP object-src should block plugin loads
              https://bugs.webkit.org/show_bug.cgi?id=57283
      
              This change is pretty straight-forward.  It's slighly unclear to me
              whether this patch is correct w.r.t. the code in DocumentWriter.  I've
              added a FIXME comment, and I'll investigate that case more in the future.
      
              Test: http/tests/security/contentSecurityPolicy/object-src-none.html
      
              * loader/DocumentWriter.cpp:
              (WebCore::DocumentWriter::begin):
              * loader/SubframeLoader.cpp:
              (WebCore::SubframeLoader::requestPlugin):
              * page/ContentSecurityPolicy.cpp:
              (WebCore::ContentSecurityPolicy::allowObjectFromSource):
              (WebCore::ContentSecurityPolicy::addDirective):
              * page/ContentSecurityPolicy.h:
      2011-04-06  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              CSP object-src should block plugin loads
              https://bugs.webkit.org/show_bug.cgi?id=57283
      
              * http/tests/security/contentSecurityPolicy/object-src-none-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/object-src-none.html: Added.
              * http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83141 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      463f252b
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=58009 · 4ac73696
      bdakin@apple.com authored
      Frame::scalePage() results in visual artifacts with scale factors less than 1
      -and corresponding-
      <rdar://problem/8683230>
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore: 
      
      Fall into the case where we fill with a background base color when there is a page 
      scale factor that is less than 1.
      * rendering/RenderView.cpp:
      (WebCore::RenderView::paintBoxDecorations):
      
      LayoutTests: 
      
      * fast/repaint/scale-page-shrink.html: Added.
      * platform/gtk/Skipped:
      * platform/mac/fast/repaint/scale-page-shrink-expected.checksum: Added.
      * platform/mac/fast/repaint/scale-page-shrink-expected.png: Added.
      * platform/mac/fast/repaint/scale-page-shrink-expected.txt: Added.
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83140 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4ac73696
    • commit-queue@webkit.org's avatar
      2011-04-06 Chang Shu <cshu@webkit.org> · 51a16591
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
              https://bugs.webkit.org/show_bug.cgi?id=57984
      
              Unskip passed tests.
      
              * platform/mac-wk2/Skipped:
      2011-04-06  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
              https://bugs.webkit.org/show_bug.cgi?id=57984
      
              * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
              (WKBundlePageSizeAndMarginsInPixels):
              * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
              * WebProcess/InjectedBundle/InjectedBundle.cpp:
              (WebKit::InjectedBundle::pageSizeAndMarginsInPixels):
              * WebProcess/InjectedBundle/InjectedBundle.h:
      2011-04-06  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
              https://bugs.webkit.org/show_bug.cgi?id=57984
      
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83139 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      51a16591
    • crogers@google.com's avatar
      2011-04-06 Chris Rogers <crogers@google.com> · 15c9564c
      crogers@google.com authored
              Reviewed by Tony Chang.
      
              Add web audio support to DumpRenderTree (mac port)
              https://bugs.webkit.org/show_bug.cgi?id=57969
      
              * DumpRenderTree/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (setEncodedAudioDataCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              (LayoutTestController::dumpAsAudio):
              (LayoutTestController::setDumpAsAudio):
              (LayoutTestController::encodedAudioData):
              (LayoutTestController::setEncodedAudioData):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (dumpAudio):
              (dump):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83138 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      15c9564c
    • benjamin.poulain@nokia.com's avatar
      2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com> · 0965409e
      benjamin.poulain@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
              https://bugs.webkit.org/show_bug.cgi?id=56086
      
              * platform/qt/Skipped: Remove the skipped test which required numberOfPendingGeolocationPermissionRequests.
      2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
              https://bugs.webkit.org/show_bug.cgi?id=56086
      
              Add the accessor numberOfPendingGeolocationPermissionRequests to call GeolocationClientMock::numberOfPendingPermissionRequests()
              from the LayoutTestController.
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
              https://bugs.webkit.org/show_bug.cgi?id=56086
      
              Add the missing method.
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83137 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0965409e
    • tkent@chromium.org's avatar
      2011-04-06 Kent Tamura <tkent@chromium.org> · cac4e2ff
      tkent@chromium.org authored
              [Chromium] Update expectations for Geeza Pro and so on.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83136 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cac4e2ff
    • jer.noble@apple.com's avatar
      2011-04-06 Jer Noble <jer.noble@apple.com> · 5dc0a1e0
      jer.noble@apple.com authored
              Reviewed by Darin Adler.
      
              AVF: MediaPlayerPrivateAVFoundationObjC should not use -[AVPlayerItem isPlaybackBufferEmpty]
              https://bugs.webkit.org/show_bug.cgi?id=57982
      
              Query our cached loaded time array instead of asking AVPlayerItem if its buffer is empty.
      
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
              (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83135 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5dc0a1e0
    • jer.noble@apple.com's avatar
      2011-04-06 Jer Noble <jer.noble@apple.com> · 7ef6838a
      jer.noble@apple.com authored
              Reviewed by Eric Carlson.
      
              MediaPlayerPrivateAVFoundation does not change rate due to setRate().
              https://bugs.webkit.org/show_bug.cgi?id=57919
      
              * media/video-set-rate-from-pause-expected.txt: Added.
              * media/video-set-rate-from-pause.html: Added.
      2011-04-06  Jer Noble  <jer.noble@apple.com>
      
              Reviewed by Eric Carlson.
      
              MediaPlayerPrivateAVFoundation does not change rate due to setRate().
              https://bugs.webkit.org/show_bug.cgi?id=57919
      
              Test: media/video-set-rate-from-pause.html
      
              The base class of MediaPlayerPrivateAVFoundation does not actually change the rate
              of the media; instead a subclass must do that work.  So when setRate() is called,
              inform a subclass through a new pure virtual updateRate() function that there's
              work to be done.
      
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
              (WebCore::MediaPlayerPrivateAVFoundation::setRate): Call updateRate()
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
              (WebCore::MediaPlayerPrivateAVFoundationObjC::updateRate): Added.  Set the requested rate.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83134 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7ef6838a
    • kinuko@chromium.org's avatar
      2011-04-06 Dai Mikurube <dmikurube@chromium.org> · 3c7c546d
      kinuko@chromium.org authored
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * win/tools/vsprops/FeatureDefines.vsprops: Added QUOTA build flag
              * win/tools/vsprops/FeatureDefinesCairo.vsprops: Added QUOTA build flag
      2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
      
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * configure.ac: Added QUOTA build flag
      2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
      
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
      2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
      
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
      2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
      
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
              * GNUmakefile.am: Added QUOTA build flag
              * WebCore.pri: Added QUOTA build flag
      2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
      
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * Scripts/build-webkit: Added QUOTA build flag
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83133 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3c7c546d
    • mitz@apple.com's avatar
      Correct results for the Geeza Pro metrics change. · 53ad20b2
      mitz@apple.com authored
      * platform/mac/fast/dom/52776-expected.checksum:
      * platform/mac/fast/dom/52776-expected.png:
      * platform/mac/fast/dom/52776-expected.txt:
      * platform/mac/fast/text/complex-text-opacity-expected.checksum:
      * platform/mac/fast/text/complex-text-opacity-expected.png:
      * platform/mac/fast/text/complex-text-opacity-expected.txt:
      * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
      * platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum:
      * platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
      * platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
      * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
      * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
      * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.png:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
      * platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum:
      * platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83132 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      53ad20b2
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · 90c2da9d
      enne@google.com authored
              Unreviewed, update Chromium expectations for failing test from r83075.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83131 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      90c2da9d
    • dpranke@chromium.org's avatar
      2011-04-06 Dirk Pranke <dpranke@chromium.org> · 0e2e0204
      dpranke@chromium.org authored
              Reviewed by Tony Chang.
      
              Adjust the apple webkit port's default timeout to match
              old-run-webkit-tests at 35 seconds.
      
              https://bugs.webkit.org/show_bug.cgi?id=37738
      
              * Scripts/webkitpy/layout_tests/port/mac.py:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83130 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0e2e0204
    • commit-queue@webkit.org's avatar
      2011-04-06 Scott Cameron <sccameron@rim.com> · 94b8245f
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              Remove global variable $httpdPath and replace with the return value of
              getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
              https://bugs.webkit.org/show_bug.cgi?id=53499
      
              * Scripts/run-iexploder-tests:
              * Scripts/webkitperl/httpd.pm:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83129 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      94b8245f
    • slewis@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=57997 · c943942d
      slewis@apple.com authored
      <rdar://problem/9187856> REGRESSION(r75555): ~5-7 MB increase in memory between iBench runs
      Navigating away from a Scrolled page which queues a scroll event that is never dispatched.
      Cancel all enqueued events when detaching the Document the events cannot keep the Document
      alive.
      
      Reviewed by Darin Adler.
      
      No change in functionality so no new tests.  
      
      * dom/Document.cpp:
      (WebCore::Document::detach):
      * dom/EventQueue.cpp:
      (WebCore::EventQueue::cancelQueuedEvents):
      * dom/EventQueue.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83128 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c943942d
    • levin@chromium.org's avatar
      2011-04-06 David Levin <levin@chromium.org> · 9045bedd
      levin@chromium.org authored
              Reviewed by Ojan Vafai.
      
              Augment style guidelines about meaningless parameters from text the unwritten rules email.
              https://bugs.webkit.org/show_bug.cgi?id=55275
      
              * coding/coding-style.html:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83127 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9045bedd
    • mitz@apple.com's avatar
      <rdar://problem/9084761> REGRESSION (r73993): Default Arabic line spacing has... · 5b96199f
      mitz@apple.com authored
      <rdar://problem/9084761> REGRESSION (r73993): Default Arabic line spacing has gotten very loose when the specified font is not Arabic
      https://bugs.webkit.org/show_bug.cgi?id=58002
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::SimpleFontData::platformInit): The version of Geeza Pro in Snow Leopard
      does not require the vertical metrics tweaks that were needed in Leopard. That the
      tweaks were being applied went mostly unnoticed until r73993, because until then it
      only affected cases where Geeza Pro was specified, not when it occurred as a fallback
      font.
      
      LayoutTests: 
      
      * platform/mac/fast/dom/52776-expected.checksum:
      * platform/mac/fast/dom/52776-expected.png:
      * platform/mac/fast/dom/52776-expected.txt:
      * platform/mac/fast/text/complex-text-opacity-expected.txt:
      * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
      * platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
      * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.png:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
      * platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum:
      * platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83126 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5b96199f
    • commit-queue@webkit.org's avatar
      2011-04-06 Anders Bakken <agbakken@gmail.com> · 984bd06c
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] FrameLoaderClientQt.cpp has coding-style errors
              https://bugs.webkit.org/show_bug.cgi?id=40254
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (drtDescriptionSuitableForTestResult):
              (WebCore::FrameLoaderClientQt::hasWebView):
              (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
              (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
              (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
              (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
              (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
              (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
              (WebCore::FrameLoaderClientQt::postProgressStartedNotification):
              (WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
              (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
              (WebCore::FrameLoaderClientQt::willChangeTitle):
              (WebCore::FrameLoaderClientQt::didChangeTitle):
              (WebCore::FrameLoaderClientQt::finishedLoading):
              (WebCore::FrameLoaderClientQt::frameLoadCompleted):
              (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
              (WebCore::FrameLoaderClientQt::didFinishLoad):
              (WebCore::FrameLoaderClientQt::setTitle):
              (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
              (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
              (WebCore::FrameLoaderClientQt::updateGlobalHistory):
              (WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
              (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem):
              (WebCore::FrameLoaderClientQt::committedLoad):
              (WebCore::FrameLoaderClientQt::download):
              (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
              (WebCore::FrameLoaderClientQt::shouldUseCredentialStorage):
              (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
              (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
              (WebCore::FrameLoaderClientQt::createFrame):
              (WebCore::FrameLoaderClientQt::objectContentType):
              (WebCore::FrameLoaderClientQt::createPlugin):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83125 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      984bd06c
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · c75196e5
      enne@google.com authored
              Unreviewed, update expectations for Chromium visited link test.
              https://bugs.webkit.org/show_bug.cgi?id=58000
      
              Apparently, this just hasn't been working for a while.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83124 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c75196e5
  2. 06 Apr, 2011 7 commits