- 18 Oct, 2019 40 commits
-
-
Fabrice de Gans-Riberi authored
Fix an issue triggered on cross-process navigations that would result in UrlRequestRewriteRulesManager incorrectly keeping track of live RenderFrameHosts for a given Frame. This happens because cross-process navigations trigger a RenderFrameCreated even for a FrameTreeNode ID before the RenderFrameDeleted event for the older RenderFrameHost. The sequence goes like this: * Frame creation * Tracking RFH IDs: [] * RenderFrameCreated(0x1810) with FrameTreeNode ID 2. * Tracking RFH IDs: [2] * RenderFrameCreated(0xa410) with FrameTreeNode ID 2. * Tracking RFH IDs: [2] * RenderFrameDeleted(0x1810) with FrameTreeNode ID 2. * Tracking RFH IDs: [] * RenderFrameDeleted(0xa410) with FrameTreeNode ID 2. * At this point, the DCHECK is triggered because there is no RFH with ID 2 being tracked. The map now keeps track of the currently active RenderFrameHost for a given FrameTreeNode ID so we can now know when it is safe to ignore a "second" RenderFrameDeleted event for the same FrameTreeNode ID. Bug: 1014281 Test: Load gmail.com -> Refresh -> No DCHECK triggered. Change-Id: I82ce437c8c45984c695658d0e2d7deea45aad63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864023 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#707493}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1d6005296701..0e3485c338ff git log 1d6005296701..0e3485c338ff --date=short --no-merges --format='%ad %ae %s' 2019-10-18 mbonadei@webrtc.org Revert "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." 2019-10-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f29003dd..0d702034 (707259:707387) 2019-10-18 saza@webrtc.org AEC3: Multi channel ERL estimator 2019-10-18 jakobi@webrtc.org Update the minimum bitrate when a stream allocation is removed. 2019-10-18 mbonadei@webrtc.org Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. Created with: gclient setdep -r src/third_party/webrtc@0e3485c338ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: I929bf65f75afabda92991128c86b7f79ffa7de87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869441Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707492}
-
Chris Lu authored
This change creates InfobarTranslateCoordinator and implements the basic methods of an InfobarCoordinator and TranslateInfoBarDelegate. It also creates kInfobarTypeTranslate and expands infobar_metrics_recorder to handle this case. Bug: 1014959 Change-Id: I994abf7205f405da3aa20f0fb726a3701b6a145d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864716Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#707491}
-
Dana Fried authored
The new logic was probably more "correct" in an absolute sense but broke existing themes. The old logic is consistent with existing themes. See https://chromium-review.googlesource.com/c/chromium/src/+/1847775 for the consolidation and change that removed the old logic. Fixes: 1013870 Bug: 1013870 Change-Id: I1bed6bd16ac1151110bc07a0fd0d4654b4ae21e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869474Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#707490}
-
Tim Judkins authored
Bug: NONE Change-Id: I30b44520dbd7e69b7ed076afbed964f50e77455a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867123 Commit-Queue: Tim Judkins <tjudkins@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707489}
-
Anton Bikineev authored
Change-Id: I0b85c93dd4e257d056e17699966419e6fb839f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869415Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#707488}
-
Shawn Gallea authored
Split WebviewController into a generic base class that only deals with mutating the WebContents. The split allows implementing a Webview and CastApp controller differently while retaining common functionality in the base class. Bug: b/136460199 Test: Compile Change-Id: I4267e3c6ac4e3904160e7ee34e35d2b220777cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867189Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#707487}
-
Lan Wei authored
This reverts commit 60f3e975. Reason for revert: WelcomeScreenBrowserTest.WelcomeScreenNext is still flaky on ChromeOS, https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTAsSBUZsYWtlIkFjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFdlbGNvbWVTY3JlZW5Ccm93c2VyVGVzdC5XZWxjb21lU2NyZWVuTmV4dAw Original change's description: > Revert "Disable WelcomeScreenBrowserTest.WelcomeScreenNext." > > This reverts commit 2aa5da39. > > Reason for revert: reenabling given crrev.com/1864618 > > Original change's description: > > Disable WelcomeScreenBrowserTest.WelcomeScreenNext. > > > > Bug: 1014952 > > Change-Id: I1df1941c2a0a92d243cb4e4624ae920b150c7694 > > Tbr: achuith@chromium.org > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865351 > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > Commit-Queue: John Budorick <jbudorick@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#706500} > > TBR=achuith@chromium.org,jbudorick@chromium.org > > Change-Id: I86cba6fe329f52b5bdcd7b07d04d1dfb40fa65cf > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1014952 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866407 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706891} TBR=achuith@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1014952 Change-Id: I57bebd90ee517d2c2d729fc91dcef9667ea3ebe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869073Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#707486}
-
Henrique Ferreiro authored
Convert the implementation and all users of the chrome_cleaner::mojom::TestPUPTypemap interface. Bug: 955171 Change-Id: I76024a22fbdca21cd5f92927ef70da685f226a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863806 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#707485}
-
Alex Clarke authored
This returns to the current task's task runner. Note there are some situations where this is not valid: * When we're not running a task (it will DCHECK). * When we're in a one-off base::ThreadPool task (it will DCHECK). * In non-scheduler backed threads (it will DCHECK). Bug: 835323 Change-Id: I3a789557247240e0c36a47339574350d79746144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834094 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#707484}
-
Dave Tapuska authored
Move FrameHostMsg_RegisterProtocolHandler, FrameHostMsg_UnregisterProtocolHandler messages to mojo. This allows blink to not expose them on the WebLocalFrameClient API. BUG=1008432 Change-Id: Ia6a505b9e33a81f6a4c209f275b6344850aeeb0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864397Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#707483}
-
Rodney Ding authored
- This is the first step in implementing never-slow-mode in chrome. - Both flags are disabled by default. - Blink runtime flag will use the chromium feature state. Bug: 892672 Change-Id: I2098e435628219ffe5a798d485d73e1e0c590bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864331Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Rodney Ding <rodneyding@google.com> Cr-Commit-Position: refs/heads/master@{#707482}
-
David Tseng authored
- use base::Optional in all internal AXTreeSourceArc node id usages. This makes it clear where we are setting values and not, forcing the author to think about the id. This also catches various places where optional ids were hard-coded. This change is independent of the broader switch to use kInvalidAXNodeId as an invalid id (which still works), but is not a concern in code internal to AXTreeSourceArc. - refactor common code from AccessibilityWindowInfoDataWrapper and AccessibilityNodeInfoDataWrapper into base class. I've also renamed it to AccessibilityInfoDataWrapper to align naming. - align the ordering of function declarations (in .h) with their order in .cc. Also, declare non-overiddenn methods first in each visibility block in .h. - remove some obsolete forward declares and functions (e.g. Focus()). Unsure why compiler did not catch this. - it is fine to have some AXTreeSource methods as public and some as private, remove TODO and group methods together. Bug: none Test: unit_tests --gtest_filter=AXTreeSourceArc*.* Change-Id: I39f2ae67a213df450327bc70ef540c0aa6f0510e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860524 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#707481}
-
Elly Fong-Jones authored
This dialog had a two-phase construction to supply some state that logically was part of construction but was not yet available at construction time. This change collapses construction of this dialog into a single logical phase. Specifically: 1) ProfileSigninConfirmationDialogViews::ShowDialog now defers construction of the dialog until after ui::CheckShouldPromptForNewProfile 1) CheckShouldPromptForNewProfile now takes a base::OnceCallback instead of a base::Callback, to allow ownership of the ProfileSigninConfirmationDelegate to be passed through it 3) ProfileSigninConfirmationDialogViews::Show now both constructs and shows the ProfileSigninConfirmationDialogViews, passing in the prompt_for_new_profile member 4) The prompt_for_new_profile member is now made const 5) That makes the return values of GetDialogButtonLabel also constant after construction, which opens up migration to set_button_label Bug: 1011446 Change-Id: I975d425546db6e2d231f0003d38f0f3fac64ad88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869489Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#707480}
-
Xianzhu Wang authored
We disabled fixed-attachment background on Android when we needed re-rasterization of all such backgrounds on scroll which would degrade scroll performance. Now we support composited viewport fixed-attachment background (which is the common case), and performance of Android devices has improved. This patch enables fixed-attachment background on Android which removes a platform-specific quirk. Bug: 521555 Change-Id: I1407a2d8a8171e4f1e6e5a3e11d230dabe3a7656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1419010 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707479}
-
Alison Maher authored
PreferredColorScheme is currently being sent to the render process over two pipelines. This change cleans up the repeated code to use the new pipeline introduced in the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1728056 Similar to how system colors are accessed in https://chromium-review.googlesource.com/c/chromium/src/+/1793742, PreferredColorScheme has been removed from WebPreferences/WebSettings and can now accessed through WebThemeEngine. This change is similar to the clean up change for ForcedColors: https://chromium-review.googlesource.com/c/chromium/src/+/1802392 Bug: 970285 Change-Id: Id3971e1efb8e9463f51a91c6c0c3469ae9e6d53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845575 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#707478}
-
Antonio Gomes authored
Apart from the API footprint reduction, this CL also takes the opportunity to rename the header (and its associated .cc file) to test_webrtc_stats_report_obtainer.h, so it matches its purposes better. BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I3ac52d3a1e80c1d0612f705d77b59d49d881b1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869410Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#707477}
-
Aidan Beggs authored
Initially, the keywords generation algorithm would not split the input URLs on "-", creating a conflict with the sensitive keywords search heuristic (which does split on "-"). This CL remedies that, by ensuring that keywords are split on "-" before being put into the keywords list. Bug: 1015843 Change-Id: Iad3127788f4fd363a9ff7817ef55072c07768a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869119Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Aidan Beggs <beggs@google.com> Cr-Commit-Position: refs/heads/master@{#707476}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fcde3ba0a657..acf922ce48cf git log fcde3ba0a657..acf922ce48cf --date=short --no-merges --format='%ad %ae %s' 2019-10-18 ehmaldonado@chromium.org Reland "depot_tools: Stop using oauth2client" Created with: gclient setdep -r src/third_party/depot_tools@acf922ce48cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1001756 Change-Id: I75a4dda56b7853d5459f189158dbea31907ec34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869434Reviewed-by:
-
Nikita Podguzov authored
Bug: 992889 Change-Id: I1e301e40e838e7c8072f47c2a6bf8202473e0f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868883Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7f418fc2677a..72b2be2e56ff git log 7f418fc2677a..72b2be2e56ff --date=short --no-merges --format='%ad %ae %s' 2019-10-18 ianelliott@google.com Vulkan: Add expectations for Swiftshader dEQP failures. Created with: gclient setdep -r src/third_party/angle@72b2be2e56ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: None Change-Id: I9fac4944ed075d8b7fa594d62b624720d592857a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869433Reviewed-by:
-
Ryan Sleevi authored
CertVerifier today guarantees that if the associated CertVerifier::Request is deleted, the caller-supplied callback will not be invoked. However, it does not provide any guarantees as to when the callback itself will be freed. This strengthens the guarantee, such that when a ::Request is deleted, it will also Reset() the callback. Similarly, it provides a strong guarantee that if the CertVerifier is deleted, the associated Callbacks will be Reset. Put differently, if either (CertVerifier is deleted || Request is deleted), then the Callback will be Reset. This makes it easier for callers to be confident of an "eventually consistent" approach. Prior to this change, when the Callback was destroyed was a bit indeterminate. In some cases, when the underlying CertVerifier went away, the Callback would be destroyed. In other cases, it was not until the ::Request was deleted by the caller. And in one, it was not until both the ::Request was deleted and the underlying CertVerifier had been deleted/the asynchronous job completed before the callback would be destroyed. Bug: none Change-Id: I527fa9f3700016269d4236bae03c13510ab69b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862116Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707472}
-
Natalie Chouinard authored
Jelly Bean support has been deprecated. Removing conditions that are no longer necessary to check. Bug: 923477 Change-Id: Ic8fca66acd3199f990e89fb0375d5ce823348e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865687Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#707471}
-
Lan Wei authored
LoginScreenAccessibilityPolicyBrowsertest.DeviceLoginScreenFullScreenMagnifier is flaky from 10/18 on ChromeOS. https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVycAsSBUZsYWtlImVjaHJvbWl1bUBicm93c2VyX3Rlc3RzQExvZ2luU2NyZWVuQWNjZXNzaWJpbGl0eVBvbGljeUJyb3dzZXJ0ZXN0LkRldmljZUxvZ2luU2NyZWVuRnVsbFNjcmVlbk1hZ25pZmllcgw TBR=amraboelkher@google.com Bug: 1015763 Change-Id: I73451c082190a275a75e78ca5d6134a0c369d530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869669Reviewed-by:
-
Michael Lippautz authored
- Avoid looking up GCInfo and one word in memory when pushing an object that was discovered through the write barrier. - Use already existing branch for regular and large objects to compute size, assuming that the object will be marked. Output on Z840 (down from ~17x): [ RUN ] WriteBarrierPerfTest.MemberWritePerformance *RESULT WriteBarrierPerfTest writes during GC: = 36403.349108117945 writes/ms *RESULT WriteBarrierPerfTest writes outside GC: = 476190.4761904762 writes/ms *RESULT WriteBarrierPerfTest relative speed difference: = 13.08095238095238 times [ OK ] WriteBarrierPerfTest.MemberWritePerformance (29 ms) Bug: 1014414 Change-Id: I2c915edd1607bc839ea0478891971d23496b2678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865344Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Wenbin Zhang authored
In order to ensure homogeneous fleets, we need to have more specific dimension values when looking for bots. This set of CLs updated some existing dimensions, and added the synthetic_product_name values for dimensions if appropriate. This CL updated the dimensions for Win 7 Nvidia GPU Perf: - Added synthetic product name 'PowerEdge R220 [01] (Dell Inc.)'; - Updated GPU from '10de:1cb3' to '10de:1cb3-23.21.13.8792' Please check the link below for the available bots based on the old/new dimensions: https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=gpu&c=os&c=pool&c=status&c=synthetic_product_name&d=desc&f=gpu%3A10de%3A1cb3&f=os%3AWindows-2008ServerR2-SP1&f=cpu%3Ax86-64&f=pool%3Achrome.tests.perf&s=synthetic_product_name Bug: chromium:996830 Change-Id: Ida39ce6e53509fc18540ef9eefd77ce15e7e0210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866560Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#707468}
-
Peter Kasting authored
Bug: 82078 Change-Id: Ic24ef9bcc5545ae06468a3c5a5912292ccb10988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867814 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#707467}
-
Philip Rogers authored
There are multiple places where change tracking is cleared: 1. Main thread tree change tracking is cleared in LayerTreeHost::FinishCommitOnImplThread. 2. Pending tree change tracking is cleared in LayerTreeHostImpl::ActivateSyncTree. 3. Active tree change tracking is cleared after drawing in LayerTreeHostImpl::DrawLayers. If drawing was skipped in #3, we would not clear change tracking, but it is possible to have changes that do not cause visible damage. This patch ensures we always clear change tracking after drawing. This is slightly over-invalidating because the typical flow (pending->active) will overwrite the active tree change tracking. This change fixes LayerTreeHostTestSurfaceDamage which had a bug where the 4th step of the testcase would only run flakily due to an EndTest in the 3rd step. Fixing the test bug exposed the real bug of change tracking not being reset. Bug: 1014263 Change-Id: Ib9ec4dbc78e4806ccf1bd0f1d237d33831f29acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868836Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#707466}
-
Tarun Bansal authored
LowerJavaScriptPriorityWhenForceDeferred feature is currently enabled by default. This CL changes it to disabled by default. This change enables us to experiment with this feature (whether it actually helps in the performance or not). Change-Id: I39ec2b4f55550eee870be4d4d26283b92c960952 Bug: 978490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824419Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#707465}
-
Mohammad Refaat authored
Bug: 987646 Change-Id: I480e772f03e2cefe7e66a931bfabc96305cb50e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866924 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Daniel Nicoara authored
* If gRPC initialize failed we don't have a connection to begin with so can't call Read(). * Shutdown the CompletionQueue otherwise the thread won't exit. Bug: b/142400443 Test: internal unittests Change-Id: Ifc2a13e36bbdc640908ca1069afed855fc8cd790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867313 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Auto-Submit: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#707463}
-
Tarun Bansal authored
Update the annotation tags of traffic that's throttled when user has an active WebRTC call. The new tags are the ones for which we have the right approvals. Bug: 1005841 Change-Id: Ic370992a529158863990cae20a29cf0101026bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868009Reviewed-by:
-
Dan Beam authored
I accidentally missed a case (or merge conflicted or something) in which we should be ignoring focusout when the user deletes the focused item. This specific case reproduces with these steps: 0) Search for "what are carbs" (and execute search) 1) Type "what" into realbox on NTP afterward 2) Move focus to "what are carbs" result 3) Press Shift+Delete I've added an assert() to ensure this doesn't happen again, and added a test. I've also updated a test that was triggering the assert() because it was differing from what the prod code actually does (there was a comment admitting that). Bug: 1002689 Change-Id: Ic534ba725931291c3c327a43ea52d65d27ae51a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868092 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#707461}
-
Sammie Quon authored
Extracts parts of the regular grid layout function into a helper, which is then used by the new grid layout function. Test: manual Bug: 1011973 Change-Id: I7bdf40227bbd1df467ea9d56bc84e58b01c12f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867271 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#707460}
-
Caleb Rouleau authored
Now that https://chromium.googlesource.com/catapult/+/8df31ad1d9b887ec31d2ecca1305483501693b79 has landed, we can remove this code to augment expectations, since now that is passed through from the project config. Bug: 985103 Change-Id: Ib8e707bd70fb6cd5744527e20251b9d314010434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867356Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#707459}
-
Kevin Ellis authored
The regression was caused by finished events being queued at the wrong time in the document lifecycle. With this fix, the finished event is deferred until the microtask is run rather than synchronously inside the ApplyUpdates method. Bug: 1015047 Change-Id: If2917b8aab27c5c98e58d78f4a43b4288b439e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869389Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#707458}
-
Lan Wei authored
This reverts commit 3a9215b3. Reason for revert: virtual/split-http-cache-not-site-per-process/http/tests/devtools/isolated-code-cache/same-origin-test.js virtual/split-http-cache-not-site-per-process/http/tests/devtools/isolated-code-cache/same-origin-module-test.js are flaky on WebKit Linux MSAN. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN Original change's description: > Adapt isolated-code-cache web tests to partitioned HTTP Cache > > The not-site-per-process isolated-code-cache web tests currently assume > that cross-origin resources are cached when code cache site isolation is > not active. This causes them to fail when the HTTP Cache is partitioned > by Network Isolation Key. We thus disable the partitioned HTTP Cache for > those tests and add a new test for when site isolation is not active, > but the HTTP Cache is still partitioned. > > Bug: 1009628 > Change-Id: I0d5d438d9564d3f659b93484a5bcc8aa56d2cd26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865421 > Reviewed-by: Shivani Sharma <shivanisha@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Alex Turner <alexmt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707360} TBR=thakis@chromium.org,shivanisha@chromium.org,alexmt@chromium.org Change-Id: I8ebebb654e02d4d3c5d0c7e946ea70710b0b5df7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1009628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869477Reviewed-by:
-
Sidney San Martín authored
Before this change, tooltips from a window might appear as you move your mouse around a different window which covers it, but only after tooltips in the back window have changed at least once. This is because, when tooltips change, the method below sends a fake NSMouseEntered event that allows tooltips to display no matter which window is on top. The method's goal is to clear and re-show tooltips immediately when they update, and with this change that only happens if the mouse is not over a different window. Bug: 883269 Change-Id: I37aace8cf86d5ac5a667d22f68be4da310e92fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869291Reviewed-by:
-
Clark DuVall authored
This adds a way to execute javascript in WebLayer. The script will be executed in a weblayer isolate that will not be able to access any scripts from the page. Change-Id: Ia17bd8476b5d9247d5761f0af24cd4d61edaccb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867300 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#707455}
-
Yicheng Li authored
Add UMA metrics related to positive match secret changes, to monitor how fingerprint authentication works under the positive match secret scheme, and whether migration to this scheme is successful. The associated Chrome OS CLs are CL:1829293, CL:1737809, CL:1737816 BUG=chromium:927095 Signed-off-by:
Yicheng Li <yichengli@chromium.org> Change-Id: I006d2cebaaf054d6ae4bfe53fe62318eda5f4698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864819Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#707454}
-
