GitLab

This allows us to output the exception message even if no test has explicitly failed.

BUG=407976
R=kbr@chromium.org
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/515513003

Cr-Commit-Position: refs/heads/master@{#292250}

Before this refactoring, the ES management was left
to the ES parser implementation.
It is now moved to the EsParser class and ES management
now relies explicitly on an ES byte queue.

BUG=None

Review URL: https://codereview.chromium.org/497203004

Cr-Commit-Position: refs/heads/master@{#292249}

The SelectActionBar currently lacks test coverage. Add several test
cases covering the appearance of the bar when interacting with an input
field.

Review URL: https://codereview.chromium.org/506423003

Cr-Commit-Position: refs/heads/master@{#292248}

The SelectActionBar currently lacks test coverage. Add several test
cases covering the appearance of the bar when interacting with an input
field.

Review URL: https://codereview.chromium.org/506423003

Cr-Commit-Position: refs/heads/master@{#292247}

BUG=

Review URL: https://codereview.chromium.org/508233002

Cr-Commit-Position: refs/heads/master@{#292246}

BUG=279351
For chrome/browser/ui/webui/chromeos/network_config_message_handler.cc:
TBR=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/492383002

Cr-Commit-Position: refs/heads/master@{#292245}

As described in bug 396413, it was possible for a posted task to be run
after CastReceiverImpl/FrameReceiver were destroyed.  This change fixes
the bug by having FrameReceiver post a cancelable task (i.e., using its
WeakPtr) instead.

BUG=396413

Review URL: https://codereview.chromium.org/491953003

Cr-Commit-Position: refs/heads/master@{#292244}

This is a reland of
https://codereview.chromium.org/489373005/
which was reverted because it caused failures in interactive_ui_tests on mac
on OmniboxViewTest.AcceptKeywordBySpace:
https://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20(dbg)(1)/builds/52199
See [1].

It turns out these failures were because the test uses a bookmark with no
title and BookmarkProvider doesn't set classifications for these correctly.
(It set the title as having a classification where, without any text, it
doesn't make sense to have any classification.)

This change fixes this issue and adds a test in BookmarkProvider for it.

I will annotate the *second* patchset I upload with the differences
between the previously-reviewed changelist and this changelist.
(The first patchset has debug lines; ignore it.)

Otherwise, the changelist description remains the same, which I will paste
below [2].

I am marking this change as
TBR=sky
(because he previously reviewed this change and the new parts are
 not under his purview.)

---

[1]

OmniboxViewTest.AcceptKeywordBySpace (run #1):
[ RUN      ] OmniboxViewTest.AcceptKeywordBySpace
[12075:263:0822/122851:ERROR:location_bar_view_mac.mm(592)] Not implemented reached in virtual void LocationBarViewMac::EndOriginChipAnimations(bool)
[12075:263:0822/122852:FATAL:autocomplete_match.cc(516)] Check failed: classifications.empty().
0   libbase.dylib                       0x1ca75c5f base::debug::StackTrace::StackTrace() + 63
1   libbase.dylib                       0x1ca75cbb base::debug::StackTrace::StackTrace() + 43
2   libbase.dylib                       0x1cb21862 logging::LogMessage::~LogMessage() + 82
3   libbase.dylib                       0x1cb2058b logging::LogMessage::~LogMessage() + 43
4   interactive_ui_tests                0x11fb469d AutocompleteMatch::ValidateClassifications(std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, std::vector\u003CAutocompleteMatch::ACMatchClassification, std::allocator\u003CAutocompleteMatch::ACMatchClassification> > const&) const + 317
5   interactive_ui_tests                0x11fb453b AutocompleteMatch::Validate() const + 107
6   interactive_ui_tests                0x11fbbb51 AutocompleteResult::Validate() const + 113
7   interactive_ui_tests                0x0d6f5a3f AutocompleteController::UpdateResult(bool, bool) + 815
8   interactive_ui_tests                0x0d6f55b7 AutocompleteController::Start(AutocompleteInput const&) + 1799
...

[2]

This used to be controlled by a field trial created in
https://codereview.chromium.org/184663002

After evaluating this change, we've decided to launch it.
This change turns the flag on by default and removes the field trial code.
It also removes the index_urls_ parameters everywhere because those will
always be true forevermore.

I tested this interactively.
Also, all the unit tests still apparently pass.  And yes some of these do
exercise this feature.

BUG=157204,378854

Review URL: https://codereview.chromium.org/510533002

Cr-Commit-Position: refs/heads/master@{#292243}

BUG=407863

Review URL: https://codereview.chromium.org/512493003

Cr-Commit-Position: refs/heads/master@{#292242}

BUG=408189

Review URL: https://codereview.chromium.org/509103002

Cr-Commit-Position: refs/heads/master@{#292241}

Brings in the following commits:

1f3591d Export CBS_asn1_ber_to_der.
25c93ff Fix BN_sub documentation.
854dd65 Refactor server-side CertificateVerify handling.
5b8f104 Revise hash management for reading the Finished message.
880b14e Compute the Channel ID hash after ssl_get_message.
590cbe9 Introduce a hash_message parameter to ssl_get_message.
912806b Fix build (broken by MD4_CTX redefine).
bbac844 Add missing <errno.h> include.
3cb50e0 Move a variable declaration to function start.
98ad22e Fix "integer constant is too large for 'long' type" errors.
58f9095 Remove hack in parsing PKCS#12.
0eb1aae Readd EC_GROUP_get_curve_GFp.
539112f Readd EVP_CIPHER_CTX_set_key_length.
c9eb7ea Readd MD4.
8da9906 Rename some message functions for consistency.
e58c4f5 Add a test to ensure False Start occurs.
ef86550 Remove logic for non-signing client certificates.
a08e49d Add basic TLS Channel ID tests.
4e99c52 Fix FalseStart-SessionTicketsDisabled tests.
2561dc3 Introduce a mechanism for base64 options.
d698f32 Introduce EVP_DecodeBase64.
3a66e28 Update ssl3_get_channel_id for the simpler ECDSA_do_verify.
d30a990 Implement TLS Channel ID in runner.go
f9b96fa Fix flipped DTLS checks.
2a0c496 Fix duplicate test name.
8e16b6e Add PKCS#12 parser.
9c01e00 Rework support for ASN.1 BER.
cc8fcf4 Add 40-bit RC2 support.
9169c96 Implement client side of TLS signed certificate stamps extension.
c44d2f4 Convert all zero-argument functions to '(void)'

BUG=none

Review URL: https://codereview.chromium.org/511703002

Cr-Commit-Position: refs/heads/master@{#292240}

The patch that caused the failure has been fixed. (r288954)

BUG=402233
TBR=tommi@chromium.org

Review URL: https://codereview.chromium.org/507913005

Cr-Commit-Position: refs/heads/master@{#292239}

BUG=406538

Review URL: https://codereview.chromium.org/511453003

Cr-Commit-Position: refs/heads/master@{#292238}

The original CL (http://crrev.com/433633002) caused crashes and was
reverted; this CL only forces out-of-bounds indexes in-bounds, and
leaves in the other checks.

BUG=378992,399763

Review URL: https://codereview.chromium.org/510043002

Cr-Commit-Position: refs/heads/master@{#292237}

BUG=404572

Review URL: https://codereview.chromium.org/508783002

Cr-Commit-Position: refs/heads/master@{#292236}

Make sure callers are using GetAuthenticatedUsername and GetAuthenticatedAccountId correctly.

BUG=341408
TBR=bauerb@chromium.org, benwells@chromium.org, gene@chromium.org, asvitkine@chromium.org, noms@chromium.org, tim@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/479353003

Cr-Commit-Position: refs/heads/master@{#292235}

BUG=406053

Review URL: https://codereview.chromium.org/514883002

Cr-Commit-Position: refs/heads/master@{#292234}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/509563003

Cr-Commit-Position: refs/heads/master@{#292233}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/497723004

Cr-Commit-Position: refs/heads/master@{#292232}

Since the code from the ledger* internal repos has now been open-sourced, we should get rid of this code from Chrome.

R=isherman@chromium.org, kalman@chromium.org, thakis@chromium.org
BUG=None.

Review URL: https://codereview.chromium.org/510893003

Cr-Commit-Position: refs/heads/master@{#292231}

BUG=405226

Review URL: https://codereview.chromium.org/509143002

Cr-Commit-Position: refs/heads/master@{#292230}

Revert of Revert "Typecheck JS files for chrome://extensions" (patchset #1 of https://codereview.chromium.org/508283002/)

Reason for revert:
fixed check_licenses issues

Original issue's description:
> Revert "Typecheck JS files for chrome://extensions"
>
> This reverts commit 405253b7.
>
> Caused a liscene failure on android bot:
> http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/64664/steps/check_licenses/logs/stdio
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/87b3206

TBR=vitalyp@chromium.org,eroman@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/512003002

Cr-Commit-Position: refs/heads/master@{#292229}

When the window is not snapped, user resizes should always clear restore
bounds. This allows user initiated resizes to not be unexpectedly
ignored.

BUG=405563
TEST=WorkspaceWindowResizerTest.RestoreClearedOnResize

Review URL: https://codereview.chromium.org/477823003

Cr-Commit-Position: refs/heads/master@{#292228}

The surface aggregator should keep track of the last frame from each surface that was aggregated, and use that to determine what the appropriate damage rect is for the next aggregation.

BUG=
TEST=chrome --use-surfaces --disable-gpu

Review URL: https://codereview.chromium.org/506273002

Cr-Commit-Position: refs/heads/master@{#292227}

Command used: for f in `find ui -name *.grd`; do echo GRD: $f; ./tools/unused-grit-header.py $f android_webview apps ash cc chromecast chromeos content chrome extensions gpu media pdf printing remoting webkit; done

Review URL: https://codereview.chromium.org/515433002

Cr-Commit-Position: refs/heads/master@{#292226}

Having the views observe these notifications is strange -- they don't know when
page actions are updated in any other ways, so they shouldn't need to know for
this. Move the notifications to LocationBarController.

Bonuses:
- Less code! By 50 lines!
- Remove four deprecated notification uses!

This has a very loose dependency on https://codereview.chromium.org/508563003/.

BUG=407672

Review URL: https://codereview.chromium.org/505373002

Cr-Commit-Position: refs/heads/master@{#292225}

BUG=407833

Review URL: https://codereview.chromium.org/512543002

Cr-Commit-Position: refs/heads/master@{#292224}

BUG=400760
NOTRY=True

Review URL: https://codereview.chromium.org/453713002

Cr-Commit-Position: refs/heads/master@{#292223}

If we're going to make mojo a write-once-run-anywhere platform, we'll
have to smooth over platform differences in event handling. Currently,
we have code that tries to emulate this behaviour at different levels
of the chrome stack on Linux. This emulation code lead to the double
character insertion bug on Windows: things looked fine on Linux
because we had another hack to cover up the lack of character events,
which just caused double character insertion on Windows.

In this patch, we declare the Windows style of events (a keydown,
a translated character event, a keyup) as canonical and what
should be targeted going forward.

BUG=403514

Review URL: https://codereview.chromium.org/476283006

Cr-Commit-Position: refs/heads/master@{#292222}

Instead, encode null as NULL (and not just any falsy value) via
a == comparison with null (and use ==, not === to treat undefined
the same way as null).

BUG=407258

Review URL: https://codereview.chromium.org/511443002

Cr-Commit-Position: refs/heads/master@{#292221}

This change attempts to fix a flaky test by changing the KeyPress function to
use SendKeyPressAndWait which will wait for an event. The event that this test
will wait for is the focus change event that should get called when an element
in the web form changes focus.

BUG=405711

Review URL: https://codereview.chromium.org/503863002

Cr-Commit-Position: refs/heads/master@{#292220}

TBR=eroman@chromium.org
BUG=none
TEST=green tree

Review URL: https://codereview.chromium.org/492623005

Cr-Commit-Position: refs/heads/master@{#292219}

Revert of Revert "TestWebServer needs to use a free port." (patchset #1 of https://codereview.chromium.org/514443002/)

Reason for revert:
I will land the following CL to fix the findbugs warning
https://codereview.chromium.org/513583002/

Then I will revert the revert.

Original issue's description:
> Revert "TestWebServer needs to use a free port."
>
> Causing Android Build (dbg) findbugs to fail.
>
> This reverts commit c4a3f88c.
>
> BUG=none
> TBR=hush
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/b055d91

TBR=ajwong@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/512573002

Cr-Commit-Position: refs/heads/master@{#292218}

For the actual changes, see:
https://codereview.chromium.org/506203004/

R=tomfinegan@chromium.org
TBR=tomfinegan@chromium.org
BUG=https://code.google.com/p/webrtc/issues/detail?id=3747

Review URL: https://codereview.chromium.org/513593002

Cr-Commit-Position: refs/heads/master@{#292217}

Note that the LOCATION_CHANGED event isn't explicitly handled, it just gets mapped to a WINDOW_CONTENT_CHANGED event on Android.

BUG=407871

Review URL: https://codereview.chromium.org/510513003

Cr-Commit-Position: refs/heads/master@{#292216}

Due to how the browser plugin is created, it is possible for the
<extensionoptions> element to attempt to attach to the embedder before
the browser plugin has bindings. This occurs when an ExtensionOptions object
gets an extension id and creates a guest, but has not yet been added
to the DOM. Use the deferred attach logic from <webview> so that if this
case occurs, wait until the browser plugin gets its bindings before
trying to attach the guest view.

BUG=386838

Review URL: https://codereview.chromium.org/457653003

Cr-Commit-Position: refs/heads/master@{#292215}

The ReST URL was bad, and somehow it started parsing differently, maybe because I have a newer version of the ReST parser.

TBR= binji@chromium.org, sbc@chromium.org
TEST=none
BUG=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/504343006

Cr-Commit-Position: refs/heads/master@{#292214}

Please let me know if I'm missing anything on the release notes.

Some other files updated, they seem to have been forgotten by previous commits.

R=dmichael@chromium.org, jmedley@chromium.org, binji@chromium.org
BUG= none
TEST= none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/477203002

Cr-Commit-Position: refs/heads/master@{#292213}

BUG=305280
NOTRY=True

Review URL: https://codereview.chromium.org/512453002

Cr-Commit-Position: refs/heads/master@{#292212}

This will make the SDK archive step upload to the correct URL for trunk builds.

No tries because this does not affect the Chrome build.

BUG=none
R=bradnelson@google.com, bradnelson@chromium.org
TEST=ran locally

Review URL: https://codereview.chromium.org/510133002

Cr-Commit-Position: refs/heads/master@{#292211}