- 14 Jun, 2018 40 commits
-
-
Max Moroz authored
The flag is being used for all other configurations for a while. Looks like we've forgotten to add it for the Debug one when it's been implemented. Bug: 852391 Change-Id: I2f3fbd4639fdb81b304f0abdd0c8fe6f3d1dbcb3 Reviewed-on: https://chromium-review.googlesource.com/1100964Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#567318}
-
spqchan authored
Bug: 852521 Change-Id: Ief55e563304cb2ea8677ef7914e1eb065ea1261a Reviewed-on: https://chromium-review.googlesource.com/1099733Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#567317}
-
Kyle Milka authored
Allow users to interact with the custom backgrounds UI with only the keyboard. Bug: 851173 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic442995e2a68d147942ad7625ea0e8a202e40137 Reviewed-on: https://chromium-review.googlesource.com/1097576 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#567316}
-
erikchen authored
After a recent refactor, [cmd + left arrow] would perform history navigation instead of moving the cursor to the beginning of the Omnibox. This happens because the processing for the hotkey [triggering history navigation] has higher priority than the typical event handling flow. The hotkeys [cmd + left arrow] and [cmd + right arrow] are special, and should only trigger if the firstResponder is a WebContents, and the WebContents has chosen not to process the event. This CL removes handleExtraKeyboardShortcut:, which was dead code. Bug: 852332 Change-Id: Id03f5e22337a79d9ca4abfd20d995a8cf8976b2a Reviewed-on: https://chromium-review.googlesource.com/1099648Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567315}
-
Mounir Lamouri authored
Bug: 852212 Change-Id: I4ed79cc13f48aaaac4a68c33e976fdab834deb61 Reviewed-on: https://chromium-review.googlesource.com/1098467 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#567314}
-
Hiroshige Hayashizaki authored
Preparation for https://chromium-review.googlesource.com/c/chromium/src/+/1065061/. Bug: 845285, 841466 Change-Id: I502d296c05ad27a8d974daae5a004fbf58f8791d Reviewed-on: https://chromium-review.googlesource.com/1100537Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#567313}
-
dpapad authored
Tests affected: PDFExtensionTest.Basic PDFExtensionTest.Bookmark PDFExtensionTest.Elements PDFExtensionTest.ToolbarManager Most of the fixes involve adding Custom Elements to be tested in the document, otherwise their local DOM is not populated (unlike Polymer 1). Bug: 849476 Change-Id: Id953179142174cb5922bf53bcaa139011ea76ca9 Reviewed-on: https://chromium-review.googlesource.com/1100304Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#567312}
-
Sadrul Habib Chowdhury authored
With the change to using presentation-feedback for facilitating snapshot requests (crrev.com/c/1095562), the snapshot-specific code in gpu can now be removed. BUG=851504 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I25b563f879bb66c345ba541df736efc65a834f0d Reviewed-on: https://chromium-review.googlesource.com/1096669Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#567311}
-
Raphael Kubo da Costa authored
When the custom bindings were removed in commit 5b84e88a ("Remove custom bindings for CSSStyleDeclaration"), the new anonymous setter code added a check for ScriptState::ContextIsValid() to ensure it had received a valid |script_state|. It turns out this check is too strict, as in addition to verifying a ScriptState has an associated v8::Context it also asserts the ScriptState has a valid |per_context_data_|. This is valid in most cases, but when a node is moved across different documents and its previous document gets removed its |per_context_data_| is disposed of and ScriptState::ContextIsValid() fails. Since the anonymous setter is only invoked by the bindings layer, we can assume it is passed a ScriptState that is in a minimally usable state, so it is possible to relax the ContextIsValid() check and only make sure we can get a valid ExecutionContext from the ScriptState. Bug: 852190 Change-Id: I307de0e003e5258bf1f670b26f1dc86e4dae9286 Reviewed-on: https://chromium-review.googlesource.com/1100836 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#567310}
-
Ahmed Fakhry authored
Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=852387#c4 BUG=852387 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I16227efb940473d3b7aa56d37760483c23d7b799 Reviewed-on: https://chromium-review.googlesource.com/1100158Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#567309}
-
Marijn Kruisselbrink authored
Bug: 852249, 800898 Change-Id: Ic885db66683d40f259f4f8c0ddf82d6ea3b4c144 Reviewed-on: https://chromium-review.googlesource.com/1099361 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#567308}
-
Chris Blume authored
Currently, building with Vulkan support is behind a gn flag (enable_vulkan). It would be easy to not build & test with this flag. As a result, it would also be easy to allow Vulkan support to bitrot. Enabling Vulkan building by default would keep the Vulkan code buildable. This patch does that. (You still need a command line parameter of --enable-vulkan when running Chrome to actually use the Vulkan codepath. This is just for the building.) BUG=848100 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I26fa03f9f6e2dc924691db913f723661b510f272 Reviewed-on: https://chromium-review.googlesource.com/1098117Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Reviewed-by:
-
Katie D authored
This removes a TODO for unnecessary work, and uses FireWebUIListener to send data to the frontend JS. For comments, see https://chromium-review.googlesource.com/c/chromium/src/+/1092071/2/chrome/browser/ui/webui/settings/tts_handler.cc. Bug: 850702 Change-Id: I3891d8d73af3e8f2f63a823b917910e2ee24dfdc Reviewed-on: https://chromium-review.googlesource.com/1099191Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#567306}
-
Sky Malice authored
Bug: 831648 Change-Id: I1154abdb22295cac7f396dd61c2c4f833b56dccf Reviewed-on: https://chromium-review.googlesource.com/1093988 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#567305}
-
Nicolas Pena authored
This CL adds a DCHECK to make sure that PaintTiming::ReportSwapTime is called on the main thread. This is the method that should be called after a swap promise is concluded. This check is added in preparation of the change to PerformanceEntry strings to AtomicString. Bug: 852050 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idc39c69b155c6e90fec32a3b3c0fae7fa987c378 Reviewed-on: https://chromium-review.googlesource.com/1100971Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#567304}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8e631772e342..e16ffd4fc3f2 git log 8e631772e342..e16ffd4fc3f2 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 art-snake@yandex-team.ru Simplify the calculation of Pages Offsets within CPDF_HintsTable. Created with: gclient setdep -r src/third_party/pdfium@e16ffd4fc3f2 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8356eb7aa7cb1496ea97cdb801a874a891ff6f9e Reviewed-on: https://chromium-review.googlesource.com/1101038Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567303}
-
Colin Blundell authored
PowerMonitorBroadcastSource suffers from raciness in that it can procress incoming Mojo messages on one thread while both it and the process-wide PowerMonitor instance are being destroyed on another thread. A previous CL introduced a mitigation for this problem by shutting down the processing of incoming Mojo messages in the PowerMonitorBroadcastSource destructor before proceeding with destruction (https://chromium-review.googlesource.com/1041215). However, that turns out not to be sufficient to eliminate the race: the PowerMonitorBroadcastSource instance can end up waiting for the lock in its destructor while on another thread it is holding the lock to process an incoming Mojo message. That second thread can then call back into the process-wide PowerMonitor instance while it is being torn down, resulting in crashes due to undefined state (specifically, the PowerMonitor instance has already set its PowerMonitorSource instance to nullptr, resulting in a crash when that instance is being accessed -- ironically, the very instance that is currently blocked in its destructor waiting for the processing of the incoming Mojo message to finish :). This CL removes the possibility of that race on shutdown by introducing a two-phase shutdown process for PowerMonitorSource. In PowerMonitor's destructor, it first invokes PowerMonitorSource::Shutdown() before proceeding. The contract of PowerMonitorSource::Shutdown() is that subclasses must take any necessary action to ensure that on return from that method, they will no longer call into PowerMonitor. PowerMonitorBroadcastSource fulfills this contract by stopping the process of incoming Mojo messages in PowerMonitorBroadcastSource::Shutdown(). In the above scenario, the broadcast source will end up waiting for the processing of the incoming Mojo message to finish *inside* PowerMonitorBroadcastSource::Shutdown(), which is safe by design as it is before PowerMonitor has done any teardown. Note that it is possible that there are still other kinds of raciness between PowerMonitorBroadcastSource and PowerMonitor; as I expressed on https://bugs.chromium.org/p/chromium/issues/detail?id=834312#c33, I am not confident about the overall threading model here. TBR=xjz@chromium.org, mmenke@chromium.org Bug: 809031 Change-Id: I9d0f291995b8185e16dff1f88564b6e5344439b2 Reviewed-on: https://chromium-review.googlesource.com/1098932Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
David Reveman authored
Use the compositor frame ack instead of begin-frame callback to trigger these callbacks. The frame ack is sufficient to prevent frames from being dropped, and provides minimal latency back-pressure for clients that implement more advanced scheduling. This makes it possible to improve scheduling of frames for Linux apps significantly. Sommelier can have the next frame prepared as a dmabuf and ready to commit when we receive the callback. This minimizes the chance that we'll miss a frame. BUG=845659 TEST=exo_unittests --gtest_filter=SurfaceTest.RequestFrameCallback TEST=sommelier /usr/lib/weston/weston-simple-shm TEST=sommelier -X glxgears Change-Id: I20f06618d9d550ab501f3945b3d25d4a5c20c218 Reviewed-on: https://chromium-review.googlesource.com/1097776Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#567301}
-
John Abd-El-Malek authored
Handle all combinations of: -reading cookies via JavaScript or by inspecting HTTP request headers -setting cookies via JavaScript or by HTTP response headers Bug: 789632 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9473c9b0b514ada40ac36e07e4df2dc7e44613e1 Reviewed-on: https://chromium-review.googlesource.com/1099482Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#567300}
-
Bailey Berro authored
This change fixes a https://crbug.com/851937 where users are unable to clear auto-opening downloads settings. Bug: chromium:851937 Test: verified manually Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I263ef9497a8a9b298a3514404fc3f31a61393687 Reviewed-on: https://chromium-review.googlesource.com/1099693Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#567299}
-
sczs@chromium.org authored
Adds a condition to history_tab_helper to not return if navigation_context->IsSameDocument YES and navigation hasn't been commited. Bug: 843529 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I19bd101b975c784270e7af61852ad77d9ce7f2a1 Reviewed-on: https://chromium-review.googlesource.com/1098137Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#567298}
-
Sadrul Habib Chowdhury authored
This changes how snapshot-requests via Page.captureScreenshot in devtools are handled. Instead of notifying the browser directly from the display-compositor, the renderer requests a presentation-time for the new force-redraw frame. Upon receipt of the presentation time, renderer notifies the browser, which can then capture the screenshot (either via chrome, or directly from the underlying platform window). This allows removing the snapshots from LatencyInfo, which was an odd fit. This also enables the gpu and display-compositor code to be unaware of snapshot-requests. BUG=851504 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I16d8cb070ce883e95ac40ed5fd05ebaf3e96f0b1 Reviewed-on: https://chromium-review.googlesource.com/1095562Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#567297}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d668be9ce66f..f6e160fa9ca5 git log d668be9ce66f..f6e160fa9ca5 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 lucferron@chromium.org Vulkan: Don't use swizzle state when its not needed Created with: gclient setdep -r src/third_party/angle@f6e160fa9ca5 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Id3528b97656dcab53cbf3c4faff02677b9d34fb8 Reviewed-on: https://chromium-review.googlesource.com/1101037Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567296}
-
Xi Cheng authored
This CL coalesces functions PerformCollectionTask(), RecordSample(), and ScheduleNextSample() of the SamplingThread class into a new class member function named RecordSampleTask(). Redundant code is removed. Bug: 851163 Change-Id: I0ec209a7bebaf295e213ff7e321e52af60465bf8 Reviewed-on: https://chromium-review.googlesource.com/1100047Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#567295}
-
Bruce Dawson authored
This reverts commit f17419f4. Reason for revert: Microsoft responded to twitter reports and fixed their detection so this isn't needed anymore. I'm retaining the typo fix though! Original change's description: > Modify markdown to satisfy Windows Defender > > debugging_gpu_related_code.md explains how to use a Chrome command-line > switch which has been used for arbitrary code execution. Windows > Defender therefore treats it as malware. This means that some Windows > Chromium developers will get anti-virus warnings (with mandatory > quarantining of the file). If Chrome is in a directory that is > excluded from scanning then they will avoid warnings but will hit > problems if they try to use Windows backup. > > This is all very silly since there is no way - short of manually > following the steps, modify to be malicious - to activate this payload. > Windows Defender even complains about the file created by this: > > > echo --no-sandbox --gpu-launcher="x" >foo.txt > > But, sometimes it's not worth arguing. > > This also fixes a typo. > > R=kainino@chromium.org > BUG=851562 > > Change-Id: I85403a1cb1667f45784684179927119058608d40 > Reviewed-on: https://chromium-review.googlesource.com/1096311 > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566245} TBR=brucedawson@chromium.org,kainino@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 851562 Change-Id: I60b09d8e6a698c1646f5c4bb0ecab16f999bfb9c Reviewed-on: https://chromium-review.googlesource.com/1100255 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#567294}
-
Miguel Casas-Sanchez authored
This CL is a reland of crrev.com/c/1079834 and crrev.com/c/1086131 that got reverted (the second is just adding a few forgotten DCHECKs). This is because GpuArcVideoDecodeAccelerator sends empty client and texture id vectors [0]; this CL handles gracefully these cases. [0] https://cs.chromium.org/chromium/src/components/arc/video_accelerator/gpu_arc_video_decode_accelerator.cc?l=468 original cl description ------------------------------------------------ This CL moves part of the logic of VaapiPicture creation from VaVDA to VaapiPictureFactory, passing the PictureBuffer wholesale since we use most of it anyway. The net result is less lines of code. VaapiPicture and derived classes hold on to a |texture_id_| and a |client_texture_id_|, the latter only used with |bind_image_cb_|: - |texture_id_| cannot be zero, either in the tests or in reality, because is a GL texture id; this CL enforces this via a DCHECK() in ctor. That simplifies the body a few methods. - |client_texture_id_| can be zero, and is always zero in the v_d_a_unittests, but it doesn't matter because |bind_image_cb_| is dummy for tests ([1]), so there's no point of enforcing it to be non zero. Moreover, since it's a client-side texture id, it can be any number, so let's skip the confusing checks. Sprinkled a couple of consts and also, there's no need to do !callback.is_null() because CallbackBase provides bool(), so s/!callback.is_null()/callback/ [1] https://cs.chromium.org/chromium/src/media/gpu/video_decode_accelerator_unittest.cc?sq=package:chromium&dr&g=0&l=452 Bug: 822346 Test: compiled+run simplechrome, v_d_a_unittests on eve. media_unittests. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8b211d97e6bcb3f86149224a1c130ca6a24984e8 Reviewed-on: https://chromium-review.googlesource.com/1100535Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#567293}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d1f970dc435a..724a97d08d35 git log d1f970dc435a..724a97d08d35 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 nisse@webrtc.org Drop tools/gyp from dependencies. 2018-06-14 saza@webrtc.org Add ivoc@ and saza@ to audio_processing OWNERS 2018-06-14 magjed@webrtc.org Android: Add tests for VideoFrame.Buffer.toI420() and cropAndScale() Created with: gclient setdep -r src/third_party/webrtc@724a97d08d35 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I61e9cbca6c322134bf4b9b5df9bc5dd44da8055d Reviewed-on: https://chromium-review.googlesource.com/1101039Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567292}
-
rbpotter authored
Setting the plugin before attaching print-preview-app to the document will no longer work in Polymer2. Add an interface for the plugin, similar to the approach for the NativeLayer, and use this to stub out checks for plugin compatibility and other plugin functions. Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8428fba35ff5783e18679f99cc02f8d085f82a2e Reviewed-on: https://chromium-review.googlesource.com/1097514 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Ovidio Henriquez authored
This is a reland of 1ff37758 Original change's description: > Multi-global WebUSB WPT for window and worker > > This change updates the existing web platform tests for WebUSB to use > multi-global tests to test the API in the supported contexts. The > change updates the following tests: > * idlharness > * usb > * usbConnectionEvent > > Bug: 841510 > Change-Id: I6b118aa4121109cd6a48054c2ebc69b831660afc > Reviewed-on: https://chromium-review.googlesource.com/1087209 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564981} Bug: 841510 Change-Id: Ie354fdd54a4cd94a4801ee634c8d3263e0aa6e93 Reviewed-on: https://chromium-review.googlesource.com/1089647 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#567290}
-
Manuel Rego Casasnovas authored
The CSSWG resolved about it in the last meeting: https://github.com/w3c/csswg-drafts/issues/2746 BUG=843329 TEST=external/wpt/css/css-contain/contain-size-012.html Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4 Reviewed-on: https://chromium-review.googlesource.com/1100824Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#567289}
-
Nico Weber authored
The test tries to symbolize Chromium Framework independently, so the outer executable's rpath isn't on the stack. The Framework does have an rpath in component builds, but it is currently os.path.join(5 * ['..']), which relative to out/Release/Chromium.app/Contents/Versions/69.0.3456.0/Chromium Framework.framework/Versions/A gets us to out/Release/Chromium.app/Contents. That doesn't seem useful for anything (from what I can tell, it's always been this way since at least the gn switch), so use 7 * ['..'] instead to get to the build dir. This possibly fixes a regression from the ancient https://codereview.chromium.org/2700013002 Bug: 850055 Change-Id: I9e65a7fa76620539b2492fd6096b70533a523a74 Reviewed-on: https://chromium-review.googlesource.com/1101064 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#567288}
-
Jeremy Roman authored
TimeTicks are less confusing than double (which can be variously seconds and milliseconds). Change-Id: I70badbc63c8f8a1c8226f50b5ccb7d70d8209314 Reviewed-on: https://chromium-review.googlesource.com/1099370Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#567287}
-
Christian Dullweber authored
LocalDataContainer is owned by a unique_ptr in CookiesTreeModel but it is created from the outside and passed as a raw pointer. Fix this by directly creating it as a unique_ptr. Change-Id: I11dadcd91359f2b07f8d021fa3daa62dde80711f Reviewed-on: https://chromium-review.googlesource.com/1100832 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#567286}
-
Francois Doray authored
TBR=rdevlin.cronin@chromium.org Bug: 851655 Change-Id: Ie13d383c007d206aa120e2993fe4f93e4ee6e407 Reviewed-on: https://chromium-review.googlesource.com/1100901 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#567285}
-
Matthew Cary authored
Adds --manual-symbol-offsets, --manual-libname and --manual-objdir to the orderfile generator, allowing custom profiling. For example, with this one can easily collect profile information manual, process it with phased_orderfile.py, and then use the resulting symbol lists to produce a properly patched orderfile that is suitable for performance comparison against the production orderfile. Bug: 758566 Change-Id: I0e41319dfcd537cd7f076e0236dc96b853dd7a4f Reviewed-on: https://chromium-review.googlesource.com/1095274Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#567284}
-
Henrik Boström authored
Tests that can be expressed as LayoutTests (preferreably Web Platform Tests) rather than browser tests should. Browser tests are slow to run and a maintenance burden. The WebRtcRtpBrowserTests are mainly testing behaviors of adding and removing tracks/streams and asserting that the expected outcomes. - The essentials of these tests are already covered in external/wpt/webrtc/ which we are actively maintaining and updating in preparation for Unified Plan and RTCRtpTransceiver support. Almost all of it is overlapping. - The WebRtcRtpBrowserTests were not written to test behaviors, but functions. Each test is asserting a lot of unrelated behaviors. - When running with Unified Plan/RTCRtpTransceiver (WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/1025771) these tests start failing. I started updating these tests but the failures were due to Plan B assumptions (problems in the tests, not in the implementation). - Debugging this part of the code is slow and cumbersome. - I won't miss any of these tests. Conclusion: Nuke it. Bug: 773472, 777617 Change-Id: I099992f1783914d4fb1d5c2d952ff977ec4cc513 Reviewed-on: https://chromium-review.googlesource.com/1100891Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#567283}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f018b7d607a0..8760e2f42857 git log f018b7d607a0..8760e2f42857 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 jvanverth@google.com Add outline concave shadow support Created with: gclient setdep -r src/third_party/skia@8760e2f42857 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I71a1f925f875fe77e05837d9b96eb0c6f6b00d79 Reviewed-on: https://chromium-review.googlesource.com/1100917Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567282}
-
Eugene But authored
Added LoadingErrorPage flag to NavigationContext to mark LoadHTMLString: navigations which feed Error page to WKWebView. These navigations will be ignored in WKWebViewNavigationDelegate callbacks. GoBackFromErrorPage and testGoBackFromErrorPage tests were updated to cover this test case. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1a38685d96997328c4be2a250dcedb5837e76d77 Reviewed-on: https://chromium-review.googlesource.com/1093515Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#567281}
-
Kevin Bailey authored
A result looks crowded with a tab switch button. The spec asks that we use the two line format if the tab switch button is present. This CL also expands the button to 32px, per spec. Bug: 780835 Change-Id: I372cb24646bdd448497f0bcf456d383a04a8a55b Reviewed-on: https://chromium-review.googlesource.com/1087754 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#567280}
-
Luna Lu authored
Bug: 810833 Change-Id: Ia001570d879a714c0002c2270ff8273bf046f508 Reviewed-on: https://chromium-review.googlesource.com/1097228Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#567279}
-
