GitLab

BUG=413233
R=robertshield@chromium.org

Review URL: https://codereview.chromium.org/564833002

Cr-Commit-Position: refs/heads/master@{#294398}

Change renderer_main_platform_delegate_win to set the device scale
factor for the renderer in PlatformInitialize. The blink text rendering
code requires on this value being set.

Depends on Blink change https://codereview.chromium.org/553163002/
which must land and roll before this can be landed.

R=cpu@chromium.org, creis@chromium.org

Review URL: https://codereview.chromium.org/561503002

Cr-Commit-Position: refs/heads/master@{#294397}

Recently, crrev.com/418423002 is landed, but it has a bug in Non-SFI mode.
It introduces CHECK for the file token in ManifestService::OpenResource().
However, in Non-SFI mode, there is no NaClIPCAdapter, so the token is passed
from the renderer directly. (Actually the IPC channel is connected directly
to the renderer).
As a result, if the renderer fills the file token properly, it crashes.
As far as I investigated, it happens, at least, when the fast-path is triggered
(i.e. OpenNaClExecutable works in DownloadFile in ppb_nacl_private_impl.cc).
Anyway, we can ignore file tokens in Non-SFI mode, because it is for
SFI NaCl's validation cache.

BUG=394130
TEST=Ran trybots. Patched locally and run our Non-SFI NaCl app.
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32

Review URL: https://codereview.chromium.org/560983003

Cr-Commit-Position: refs/heads/master@{#294396}

BUG=none
R=marja@chromium.org

Review URL: https://codereview.chromium.org/566603002

Cr-Commit-Position: refs/heads/master@{#294395}

BUG=352293
TBR=darin@chromium.org
darin@ TBR'd for dependency on third_party.

Review URL: https://codereview.chromium.org/541753004

Cr-Commit-Position: refs/heads/master@{#294394}

https://codereview.chromium.org/443393003 introduced code for service
processes that turns off RELRO sharing and retries a library load in
the event of an address clash or other failure to load a library with
shared RELRO.

This change adds the same back off and retry strategy to the libraries
loaded in the main browser process, for cases where low memory devices
aggressively share RELRO as widely as possible.

BUG=411928
TBR=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/551373004

Cr-Commit-Position: refs/heads/master@{#294393}

The CL provides reference counted ServiceWorkerCaches on ServiceWorkerCacheStorage::Get and Create.  Previously only CacheIDs were provided from those functions and there was no way for the client to access the ServiceWorkerCache itself.

This CL makes the following modifications:

1. Make ServiceWorkerCache refcounted
2. Return ServiceWorkerCache* instead of a CacheID from Create() and Put()
3. Removed CacheID from ServiceWorkerCache
4. Removed CacheContext from ServiceWorkerCache (since it really only existed to hold a CacheID)
5. Now keeps track of CacheIDs in ServiceWorkerCacheListener
6. Added memory unit tests

Related CLs:
1. https://crrev.com/542703002: Change ownership of the parameters to ServiceWorkerCache:: Put and Match.
2. https://crrev.com/545533002: Move ServiceWorkerCache backend creation to a lazy init function.
3. https://crrev.com/548533002: Make ServiceWorkerCacheStorage::CacheLoader::LoadCache synchronous
* 4. https://crrev.com/549493002: Expose ServiceWorkerCache objects to ServiceWorkerCacheStorageManager clients.

BUG=392621

Review URL: https://codereview.chromium.org/549493002

Cr-Commit-Position: refs/heads/master@{#294392}

BUG=408189

Review URL: https://codereview.chromium.org/557333003

Cr-Commit-Position: refs/heads/master@{#294391}

Now that Blink fully populates the |WebTouchEvent.touches| field when
offering events to plugins, we can safely stop using
|WebTouchEvent.changedTouches|.

This is part 3 of a 4-sided patch simplifying WebTouchEvent:
1) https://codereview.chromium.org/557863002/
2) https://codereview.chromium.org/558773002/
3) This change
4) https://codereview.chromium.org/560493003/

BUG=358132

Review URL: https://codereview.chromium.org/559693003

Cr-Commit-Position: refs/heads/master@{#294390}

AnalysisCanvas should be notified when drawing text using the new blob
API.

R=jbroman@chromium.org,reed@google.com,reveman@chromium.org
BUG=412445

Review URL: https://codereview.chromium.org/545203004

Cr-Commit-Position: refs/heads/master@{#294389}

Rather than poll for touchscreen devices in ui/display, centralize
X11 hotplug handling into ui/events and have TouchscreenDelegateImpl
reuse the cached device list.

In addition, DeviceDataManager will now cache all the touchscreen
devices and provides an observer pattern such that we can move input
event hotplugging out of ui/display entirely (this will be done in a
follow-up CL).

BUG=381326

Review URL: https://codereview.chromium.org/508303002

Cr-Commit-Position: refs/heads/master@{#294388}

https://skia.googlesource.com/skia/+log/26a4b514999dcbd8c6a4a2e85bcc5dbd55f02236..aa90d00f14414db39b3d990d8d5fd594d6eadc6e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/560303003

Cr-Commit-Position: refs/heads/master@{#294387}

BUG=413215
TBR=zhaoqin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/545153003

Cr-Commit-Position: refs/heads/master@{#294386}

BUG=406014
R=sadrul@chromium.org

Committed: https://crrev.com/817ca9b5c2145d843f6ff154926db79535974778
Cr-Commit-Position: refs/heads/master@{#293781}

Review URL: https://codereview.chromium.org/538143002

Cr-Commit-Position: refs/heads/master@{#294385}

PersonalDataManagerTest should delete temporary directory AFTER WebDataServiceBackend stops using it.

Tests tried to delete temporary directory while it was still in use which
on Windows caused SHFileOperation to block for around 1 second and finally fail.

After this patch test runs at least 15 times faster on Windows.

Review URL: https://codereview.chromium.org/560093002

Cr-Commit-Position: refs/heads/master@{#294384}

This is to revision 7151.

TBR=hellner@chromium.org, sergeyu@chromium.org

Review URL: https://codereview.chromium.org/557223004

Cr-Commit-Position: refs/heads/master@{#294383}

The connection is only needed during sandbox warmup to initialize the default
color space. It was formerly needed by scrollbar NSAnimations, but that was
replaced via https://codereview.chromium.org/529103002/.

A similar CL was landed and reverted:
https://chromium.googlesource.com/chromium/src.git/+/53ffdf90f4646dbde8df72007fbdc97f3f0220de

BUG=397642, 306348
TEST=Manually tested on 10.6-10.10.

Review URL: https://codereview.chromium.org/561833006

Cr-Commit-Position: refs/heads/master@{#294382}

gnome-fallback sessions set XDG_CURRENT_DESKTOP to Unity,
DESKTOP_SESSION needs to be tested as well.

BUG=

Review URL: https://codereview.chromium.org/550173006

Cr-Commit-Position: refs/heads/master@{#294381}

Show paste option on right click of bookmark bar if some URL is copied from outside browser or from any page content

Paste option was not appearing when some URL is copied from outside browser
or web page content. But if some URL is copied from url bar the paste option
appears when right click is performed on bookmark bar. Added check in
CanPasteFromClipboard to handle this scenario.

BUG=400644

Review URL: https://codereview.chromium.org/437423005

Cr-Commit-Position: refs/heads/master@{#294380}

https://chromium.googlesource.com/chromium/blink/+log/a69fea182204b349e347b767a610d9eb201a191c..f0548820182fad9dd6c5f4b444e57d90d83eb605
TBR=jianli@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/563753002

Cr-Commit-Position: refs/heads/master@{#294379}

BUG=413215
TBR=zhaoqin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/564803002

Cr-Commit-Position: refs/heads/master@{#294378}

The CacheLoader has two functions for creating a cache:
1. LoadCache -- mkdir the cache directory and load the cache into memory
2. CreateCache  -- rm -rf the directory and then call LoadCache

This CL:

1. Makes LoadCache synchronous by moving the mkdir to CreateCache (in case of loading an existing cache the mkdir was unnecessary)
2. Deletes a bunch of async code
3. Renames LoadCache to CreateServiceWorkerCache

Related CLs:
1. https://crrev.com/542703002: Change ownership of the parameters to ServiceWorkerCache:: Put and Match.
2. https://crrev.com/545533002: Move ServiceWorkerCache backend creation to a lazy init function.
* 3. https://crrev.com/548533002: Make ServiceWorkerCacheStorage::CacheLoader::LoadCache synchronous
4. https://crrev.com/549493002: Expose ServiceWorkerCache objects to ServiceWorkerCacheStorageManager clients.

BUG=392621

Review URL: https://codereview.chromium.org/548533002

Cr-Commit-Position: refs/heads/master@{#294377}

BUG=413215
TBR=zhaoqin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/564793002

Cr-Commit-Position: refs/heads/master@{#294376}

BUG=397889
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/564763002

Cr-Commit-Position: refs/heads/master@{#294375}

https://chromium.googlesource.com/chromium/blink/+log/c8efcc05b7acf878b1c94ad94d969c08e4d8e9dc..a69fea182204b349e347b767a610d9eb201a191c
TBR=jianli@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/563583003

Cr-Commit-Position: refs/heads/master@{#294374}

Previously, WebSocket has no handshake timeout, i.e. It waited unlimitedly
when the server accepts the TCP connection but doesn't send any handshake
response. This CL fixes the issue.

BUG=391263
R=ricea@chromium.org

Review URL: https://codereview.chromium.org/565573002

Cr-Commit-Position: refs/heads/master@{#294373}

Previously the ServiceWorkerCacheStorage called ServiceWorkerCache::CreateBackend on Get() and Create().  Now the ServiceWorkerCache does it itself lazily.  This is simpler for the ServiceWorkerCache's caller and should improve performance as backends are created only when needed.  This makes the downstream refcounting CL simpler.

Related CLs:
1. https://crrev.com/542703002: Change ownership of the parameters to ServiceWorkerCache:: Put and Match.
* 2. https://crrev.com/545533002: Move ServiceWorkerCache backend creation to a lazy init function.
3. https://crrev.com/548533002: Make ServiceWorkerCacheStorage::CacheLoader::LoadCache synchronous
4. https://crrev.com/549493002: Expose ServiceWorkerCache objects to ServiceWorkerCacheStorageManager clients.

BUG=392621

Review URL: https://codereview.chromium.org/545533002

Cr-Commit-Position: refs/heads/master@{#294372}

https://chromium.googlesource.com/chromium/blink/+log/4ed3f7079546a9ab0414a43783a5b76a806d1ccd..c8efcc05b7acf878b1c94ad94d969c08e4d8e9dc
TBR=jianli@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/559393002

Cr-Commit-Position: refs/heads/master@{#294371}

This reverts commit 484d29dc.

This patch made media/media-controller-playbackrate.html test crash on DEBUG.

it crashes at content/browser/web_contents/web_contents_impl.cc:4296 on DCHECK
Looks like AddMediaPlayerEntry was called twice for the same player_cookie

It is not clear how it happens due to async nature of the notification.
The author is sleeping at the moment, so I decided to roll back the patch.

BUG=
TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/562863002

Cr-Commit-Position: refs/heads/master@{#294370}

BUG=399333
TEST=manually
1. Download .exe file.
2. Click the item in Downloads panel.

Review URL: https://codereview.chromium.org/561133004

Cr-Commit-Position: refs/heads/master@{#294369}

during Telemetry tests consists of sending an "adb force-stop" command
to the device, in order to force kill any previous browsers which did
not close as expected.

Sending a kill -9 to the process is, however, more efficient.
This CL also adds some efficiency improvements to DeviceUtils.KillAll.
The change amounts to a 6-7% speedup when running all of telemetry
unittests.

BUG=379378

Review URL: https://codereview.chromium.org/536343003

Cr-Commit-Position: refs/heads/master@{#294368}

Soon the storage::WatcherManager interface instantiations will want to be an
observer for operations. However, not all backends which have
storage::WatcherManager have storage::QuotaUtil.

To resolve this issue, this CL moves the observer lists one level up to the
storage::FileSystemBackend.

TEST=Just refactoring. Current tests should pass.
BUG=261491

Review URL: https://codereview.chromium.org/549413003

Cr-Commit-Position: refs/heads/master@{#294367}

These functions used to take unowned raw pointers as arguments.  Now the functions own them and they're scoped_ptrs.  This both makes ownership clearer and allows for the functions to terminate early without calling their callbacks (needed for a downstream change to run CreateBackend lazily).

Related CLs:
* 1. https://crrev.com/542703002: Change ownership of the parameters to ServiceWorkerCache:: Put and Match.
2. https://crrev.com/545533002: Move ServiceWorkerCache backend creation to a lazy init function.
3. https://crrev.com/548533002: Make ServiceWorkerCacheStorage::CacheLoader::LoadCache synchronous
4. https://crrev.com/549493002: Expose ServiceWorkerCache objects to ServiceWorkerCacheStorageManager clients.

BUG=392621

Review URL: https://codereview.chromium.org/542703002

Cr-Commit-Position: refs/heads/master@{#294366}

RunLoop::Run() is needed if any of the operation is implemented using
asynchronous I/O in OS layer, or performed in a separate thread.
Currently, only Copy needs RunLoop::Run().

This CL replace all RunUntilIdle() with Run() to keep all test consistent.

BUG=411153
TEST=content_unittest

Review URL: https://codereview.chromium.org/557273002

Cr-Commit-Position: refs/heads/master@{#294365}

Revert of Use changed_button_flags() when converting MouseEvent to blink::WebMouseEvent. (patchset #2 id:20001 of https://codereview.chromium.org/302593002/)

Reason for revert:
Aura builds fail DCHECKs:

ASSERTION FAILED: event.type() == PlatformEvent::MouseMoved || event.button() != NoButton
third_party/WebKit/Source/core/events/MouseEvent.cpp(54)

blink::MouseEvent::create()
blink::Node::dispatchMouseEvent()
blink::EventHandler::dispatchMouseEvent()
blink::EventHandler::handleMousePressEvent()
blink::PageWidgetEventHandler::handleMouseDown()
blink::WebViewImpl::handleMouseDown()
blink::WebViewImpl::handleMouseDown()
blink::PageWidgetDelegate::handleInputEvent()
blink::WebViewImpl::handleInputEvent()
content::RenderWidget::OnHandleInputEvent()

Original issue's description:
> Use changed_button_flags() when converting MouseEvent to blink::WebMouseEvent.
>
> Event::flags() contains all the buttons that are being held down during the event, while MouseEvent::changed_button_flags() contains the buttons that are actually pressed/released during the event (and this is what we really are interested in).
>
> This fixes the issue with LMB being pressed while RMB is being held down. Without the fix, we always get blink::WebMouseEvent::ButtonRight in blink::WebMouseEvent::button.
>
> Committed: https://crrev.com/87e6b0f6d72b12e4b0308b035d1c06f2beb90feb
> Cr-Commit-Position: refs/heads/master@{#293487}

TBR=joleksy@opera.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/563713002

Cr-Commit-Position: refs/heads/master@{#294364}

*src/athena
Change ShellAppActivity to accept both AppWindow and ShellAppWindow.
Implement AppsClient to create NativeAppWindow and AppDelegate instances.

*src/extensions/shell
Add a new method DefaultShellBrowserMainDelegate::CreateAppsClient() to inject athena's AppsClient.

*src/extensions/browser
Add missing dtor to extensions::AppsClient to destroy an instance with a base class pointer in DefaultShellBrowserMainDelegate.

BUG=387288
TBR=benwells@chromium.org for the addition of the missing dtor of extensions::AppsClient.

Review URL: https://codereview.chromium.org/552133003

Cr-Commit-Position: refs/heads/master@{#294363}

https://chromium.googlesource.com/chromium/blink/+log/a54014ac471a9d5980ca18a582f1f4a1a767efa4..4ed3f7079546a9ab0414a43783a5b76a806d1ccd
TBR=jianli@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/566513002

Cr-Commit-Position: refs/heads/master@{#294362}

- Remove the global unstub_client_mask_ and accordingly make DBusThreadManager::IsUsingStub a non-static function. This makes it obvious when it's ok to call this function (and prevents misuse), namely only after the Manager is initialized.

- By moving the mask to the DBusClientBundle, the cyclic dependency between bundle and manager is broken. The Bundle does not know about the Manager anymore.

- Fix the difference between DBusClientTypeMask ("A set of DBusClients") and DBusClientType ("A single DBusClient").

BUG=408617

Review URL: https://codereview.chromium.org/556833003

Cr-Commit-Position: refs/heads/master@{#294361}

Prior to this change we only checked the polymorphic requirements on classes
that declared a trace method. Also, this fixes a typo in condition (2) where we
checked on the derived class instead of the left-most class.

R=ager@chromium.org
BUG=

Review URL: https://codereview.chromium.org/564453002

Cr-Commit-Position: refs/heads/master@{#294360}

AwURLRequestContextGetter now owns an instance of net::NetLog.

BUG=277075
R=boliu@chromium.org

Review URL: https://codereview.chromium.org/557733002

Cr-Commit-Position: refs/heads/master@{#294359}