- 06 Jan, 2020 40 commits
-
-
Greg Thompson authored
Tests may leak files/directories in temp due to ScopedTempDir lifetime issues (see linked bug) or as a result of crashes. This CL augments the TestLauncher to handle such leaks a bit better. When launching a child proc on Windows and macOS, the TestLauncher now directs that child to its own dedicated temporary directory. Upon child exit, the launcher checks for leaked files/directories in that dir and deletes the dir. On test iteration completion, the launcher will emit a list of the tests that produced leaks when run with --test-launcher-print-temp-leaks that looks a lot like this: ERROR: 2 files and/or directories were left behind in the temporary directory by one or more of these tests: PaymentManagerTest.ClearPaymentInstruments:PermissionControllerImplTest.ResettingOverridesForwardsReset:PermissionControllerImplTest.SettingOverridesForwardsUpdates:PermissionControllerImplTest.RequestPermissionsDelegatesIffMissingOverrides:PermissionControllerImplTest.GetPermissionStatusDelegatesIffNoOverrides:PermissionControllerImplTest.GetPermissionStatusForFrameDelegatesIffNoOverrides:PermissionControllerImplTest.NotifyChangedSubscriptionsCallsOnChangeOnly:PermissionControllerImplTest.PermissionsCannotBeOverriddenIfNotOverridable:PermissionControllerImplTest.GrantPermissionsReturnsStatusesBeingSetIfOverridable:PictureInPictureServiceImplTest.EnterPictureInPicture Curious developers can binary search in that short list of tests to find the one(s) that are leaking and clean them up. BUG=546640 TBR=sky@chromium.org Change-Id: If3be7034094827979c225d2eb2beba2d92e6e7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978679 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#728475}
-
Alexandre Courbot authored
The format and plane count variables are closely related, yet they were initialized in different parts of the code. Make sure they are initialized together to make the code more readable. BUG=None TEST=Video playback working on Kevin with VD disabled. Change-Id: I07e8e7e7e833ab818f9ac7d8e8a750805a923a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982505 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#728474}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57923928ffaf..61fe7a44e909 Created with: gclient setdep -r src-internal@61fe7a44e909 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I91507bf0a4cc66097f8fc4710db34bead0cd1fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987317Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728473}
-
Takashi Toyoshima authored
Now the OOR-CORS is enabled by default on TOT, and the main waterfall runs tests with OOR-CORS being enabled. Fyi Builders should be switched to run *without* OOR-CORS now, and their names should be aligned with actual running parameters, Blink-CORS or blink-cors rather than oor-cors. Bug: 1039165 Change-Id: Ib48398cea01fc684d6e6911d2ac1315a9b2ebf5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980264 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#728472}
-
Hayato Ito authored
TBR=robliao@chromium.org,raymes@chromium.org Bug: 1038957 Change-Id: I29e701ad3fe42b2a96968ca40b506d873600c1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986568Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#728471}
-
Colin Blundell authored
This CL prepares BadClockBlockingPage for componentization and sharing with WebLayer by cleaning it of //chrome-level dependencies. Bug: 1025059 Change-Id: Icacd88b16ad1a50b7b93412986b9a113f138cee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982555Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#728470}
-
Ting Shao authored
When 'Service-Worker-Allowed' header takes a cross-origin url to override the scope restriction, it must be rejected for security. Bug: 968436 Change-Id: Ia4e8745d2fd86fe014187ade593363eaedf7c8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984901Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Ting Shao <ting.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#728469}
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on both HALv1 and v3 devices. Change-Id: Idb985eb2585fe80b8d8ade877b994ed3392b878e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986477 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#728468}
-
Alexandre Courbot authored
These variables were useful when the number of planes was something we needed to worry about, but now they are just used in superficial ways, so remove them. We just need to keep the output and GL plane counts in the SVDA, since it uses them for sanity checks. BUG=None TEST=Video playing in Chrome on Hana and Kevin with VD disabled. Change-Id: Ib6cbebd1555a6e7e8bc9113e2d8d3443bad1cd86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982504 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Rachel Carpenter authored
These strings are provided to the untrusted js to read and pass up to the server. TESTED: Manually on device to check the strings are initialised with sensible values. Bug: b/140151178 Change-Id: Id96a28319ed78a68d5bb635ff092c70a976754a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983688Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#728466}
-
Hitoshi Yoshida authored
Defines Create() and accessor functions in the class definition. Bug: 839389 Change-Id: I9a2c0a8ec768fa219f95bdd73e8d923830b09545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983689Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#728465}
-
Kuo Jen Wei authored
This CL add logic for monitering visibility of CCA window and close camera stream when window is idle (not recording) and is non-visible in tablet mode. Bug: 1035653 Test: Pass tast run <DUT> 'camera.CCAUI*'. Test: Manually test camera stream is closed when CCA is idle and is invisible in tablet mode. Test: Manually test recording can be continued when CCA is invisible in tablet mode. Change-Id: I05c1ddf3c16dce3897d694e07208b18fd78acc42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986468Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/03f3f75e4828..f1db2661f17c git log 03f3f75e4828..f1db2661f17c --date=short --first-parent --format='%ad %ae %s' 2020-01-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1fdf6ca5141d..1031d2c65b5e (5 commits) Created with: gclient setdep -r src/third_party/skia@f1db2661f17c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: Id39eeff323d1046a248b4101f66e86246b150934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987316Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728463}
-
Takashi Toyoshima authored
Now the OOR-CORS m79 rollout is started. To follow the best practices for incremental feature rollouts, this patch enables the OOR-CORS by default on TOT. NOAUTOREVERT=true Bug: 905971, 1001450, 1035763, 1039165 Change-Id: I2ca742eab6a14891968892f7f1ef40adbe8bad67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988127 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#728462}
-
Yuzu Saijo authored
This CL implements eviction when clients.claim is called on bfcached client. In order for the claim API to see the bfcached clients, this CL adds |include_cached_clients| option for ServiceWorkerContainerHost iterator, which defaults to false. Bug: 1036744 Change-Id: I654698aee083f881c3dd6ff19486b34835206004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980522 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
As the comment in service_worker_navigation_handle.h, rename ServiceWorkerNavigationHandle to ServiceWorkerMainResourceHandle. This CL has no behavior changes. Change-Id: I44ace8344e6feff740dc89517bafbb96d9c1b229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982513Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1573f3772170..57923928ffaf Created with: gclient setdep -r src-internal@57923928ffaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Id7942703ac9aebf8d4ba17a7f4ce97b9d8ac7163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987207Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d445e2b6fcf1..03f3f75e4828 git log d445e2b6fcf1..03f3f75e4828 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a12a9d87..3beaf136 (315 commits) Created with: gclient setdep -r src/third_party/skia@03f3f75e4828 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: Ib01302f7936b071d3ec13360088e0b4e8dd47812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987382Reviewed-by:
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on both HALv1 and v3 devices. Change-Id: I8273ed4dd738b740700f51098a2456a8d2030581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986537 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on both HALv1 and v3 devices. Change-Id: I3e0c50fa838a2b5ce3878d79f7d7137db66ff17e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986647 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
Incorporate information into the main documentation and link to them. Change-Id: I16432d5454ab39a52fe5212cf38239717e4f132c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983691Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#728455}
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on both HALv1 and v3 devices. Change-Id: I1e51752fc913e8f2d4072f17d170a74a82e72d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980258 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
-
Zhaoliang Ma authored
if blitsurface failed, then return directly. Bug: 1031436 Change-Id: Ie351d8a22d94f1b3116b2470432db9264db6c57a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988024Reviewed-by:
-
Peter Kasting authored
Mostly initializing variables in declarations and shortening code. Also changed AppInfoDialogViewsTest.ViewInStore to call the link callback instead of pressing the link directly, since in a future CL I'll be removing the link member variable, so the test wouldn't work. Bug: none Change-Id: I90c689be86785a9b297b3161dafb01a0a8bb3568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983510 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
Bug: 795989 Change-Id: I8185bf021d255ab279bea5ff03651b70ab4eb2a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982340Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#728451}
-
Alexandre Courbot authored
We used to pass a vector of DMABuf FDs to the GL/EGL image creation functions. This was very error-prone, as these vectors could contain less FDs than there were planes in the buffer, and this information was used to signal that the last FD contained several planes. The function receiving these incomplete FDs would then try to figure out the actual planes layout, with more or less luck, often introducing bugs in the way. Solve this issue once and for all by passing all importable buffer information within the VDAs through NativePixmapHandles: they always contain as many FDs as there are planes, and also have detailed layout information. On top of that, they are what we receive when using import mode (which means we can pass the exact layout information down to GL/EGL), and we already have a function that creates them from a VideoFrame. This helps reduce the amount of code, all the while making it safer and more readable. BUG=b:146842214 TEST=VDAtest passes on Hana. TEST=VDAtest passes on Kevin with VD disabled. TEST=VDAtest passes on Kukui. TEST=crosvideo.appspot.com plays videos properly on Hana. TEST=crosvideo.appspot.com plays videos properly on Kevin with VD disabled. TEST=crosvideo.appspot.com plays videos properly on Kukui. TEST=Youtube Android plays properly on Hana. TEST=Youtube Android plays properly on Kevin with VD disabled. TEST=Youtube Android plays properly on Kukui. Change-Id: I88a78b786b1c90820221c9f0770a52a339913537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982499 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
makes dictionary generation routine follow interface generation. Bug: 89389 Change-Id: I71001dd1e55a739bd0059a101fc05d7d0fb82eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984784Reviewed-by:
-
Yoichi Osato authored
As "[WebSocket] Do not send response headers for failed handshake." https://chromium-review.googlesource.com/c/chromium/src/+/1847592 patch stops sending WebSocketHandshakeResponseInfo for failed handshake, we don't need OnFinishOpeningHandshake in-advance function bringing it but only need to send WebSocketHandshakeResponseInfo with other mojom::WebSocketHandshakeResponse contents (actually we're already doing that on network-renderer mojo level). This patch does similar refactoring between WebSocketStream-network::WebSocket calls. Change-Id: Ie3f2cd114121a8bcfdbb71b10a52c4aa8c0d36c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949808Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#728448}
-
Koji Ishii authored
r728439 <crrev.com/c/1980663> included comments that should have been removed before landing. This patch removes it. TBR=ikilpatrick@chromium.org Bug: 982194 Change-Id: I9e7c61bf2db9a04824f22abe53dc1ed270dabf0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986566 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#728447}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e850d191a29..1573f3772170 Created with: gclient setdep -r src-internal@1573f3772170 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7d5da858802d24d0a02156c38d0fd0effa563bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987581Reviewed-by:
-
Peter Kasting authored
This fixes a variety of color issues: * Reported bugs, e.g. incorrectly using the native theme colors when a custom theme is installed * Unreported bugs, e.g. not correctly plumbing all colors for PWAs Bug: 1033922 Change-Id: I335ab7160bcb0796494c16d53e45494a823fed50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968156 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#728445}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e630bf9d. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id8604e5f4a1c3f6b7ac9e9ea40b6f6225ed075f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986143Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728444}
-
Alexandre Courbot authored
Use the Fourcc class instead of uin32_t with the GL/EGL image creation methods. This simplifies their logic a bit. BUG=None TEST=Video plays properly on Hana and Kevin non-VD. Change-Id: I50ae21d1ce34d3dba4c08bb59887d5f208b41a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982348Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I2b9520d6d7805d7c202a27b9cb72bae27e742812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986022Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728442}
-
Alex Bergman authored
(see: i18n/input/javascript/chos/testing/integration/automation_ext/manifest.json) This extension is used for Essential Inputs testing, and permission is needed to enable typing on Virtual Keyboard. Change-Id: I5fcfc5a8de8d2f12c7302904146e3c36ee21e6bb Bug: 1039158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983686 Commit-Queue: Alex Bergman <abergman@google.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#728441}
-
Matt Falkenhagen authored
These are still useful and for the foreseeable future, so extend by one year (plus one month to avoid alerts during the holiday season). Bug: 1037275, 1037273, 1037272, 1037271, 1037266 Change-Id: I26cad90d4dd9cc366ac7db920b71b2dbf6d225a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981235 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#728440}
-
Koji Ishii authored
This patch changes |NGInlineLayoutAlgorithm| to place inline box placeholders to before children. Before this patch, they were created after children, only when the inline box is not culled. This change: 1. Reduces the insertion to |Vector| in |CreateBoxFragments|, which involves memory copy. This is not common today, but will be common when |NGFragmentItem| is enabled. 2. Allows easier implementation to "disable culled inline boxes" when |NGFragmetnItem| is enabled. There should be no behavior changes. Bug: 982194 Change-Id: I0d7077e4c9b78b99276afc2e7919258b33bd4ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980663Reviewed-by:
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/webgl. Bug: 1001114 Change-Id: Idac16870d09425fbe140ef5ed93b5558d4b555c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986476Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#728438}
-
Alexandre Courbot authored
The V4L2Device::Create(EGL|GL)Image methods took a const reference to the vector of DMAbufs representing the buffer. This suggests that the reference to the DMAbufs is borrowed, while the methods take full ownership of them. The clients of these methods are already correctly duplicating the FDs before passing them. However, for clarity make these methods take explicit ownership through a rvalue reference. BUG=None TEST=VDAtest passes on Hana TEST=crosvideo.appspot.com plays videos properly on Hana. TEST=VDAtest passes on Kevin TEST=crosvideo.appspot.com plays videos properly on Kevin with VD disabled. Change-Id: I91c1ba964c24ed4d8d8db4d0e1612c6eb147b7c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981965Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#728437}
-
Noel Gordon authored
CL:1978684 increased the ChromeOS DEBUG bot timeout, and since that CL FilesApp browser tests do not flake in DEBUG anymore, issue 981420. Re-enable the FilesApp copyBetweenWindows tests that were marked flaky on the DEBUG bots, issue 1008909. Bug: 981420, 1008909 Change-Id: Ibb253b8aa79b093935db312448339f5feaa350f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983681 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#728436}
-
