GitLab

For Windows Ash (metro mode) we did not had timely access to the
real window (aka 'core window') so to keep the compositor from CHECKIing
we gave the shell desktop Window when it wanted a window here

RootWindow::RootWindow(const CreateParams& params) {
  ...
  compositor_.reset(new ui::Compositor(this, host_->GetAcceleratedWidget())); 
 ...
}

This was called from:
ash::DisplayController::AddRootWindowForDisplay
ash::DisplayController::InitPrimaryDisplay
ash::Shell::Init

Because ash was always created. Later on when the viewer process had started
it sends an IPC back with the core window which set the real window with 

void ChromeMetroViewerProcessHost::OnSetTargetSurface(..) {
  scoped_refptr<AcceleratedPresenter> any_window =
      AcceleratedPresenter::GetForWindow(NULL);
  any_window->SetNewTargetWindow(hwnd);
  ....
}

All this hackery can go away because now Ash starts on demand
once the aforementioned IPC arrives.

BUG=none
TEST=chromes starts in metro mode.

Review URL: https://chromiumcodereview.appspot.com/22876030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220694 0039d316-1c4b-4281-b951-d872f2087c98

Addressing sadruls comments from the previous CL https://codereview.chromium.org/22865036/ which was 
already committed.

Changes as below:-
1. We dispatch the GESTURE_BEGIN event before the TAP_DOWN in the repost code as some recipients may rely on
   that behavior.
2. A new test GestureRepostEventOrder has been added to validate that we receive reposted and subsequent events
   in the correct order.

BUG=277018
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/23202016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220693 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=282674
Test=None

Review URL: https://chromiumcodereview.appspot.com/23840002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220692 0039d316-1c4b-4281-b951-d872f2087c98

A recent change in Views causes the mouse move trackers to be
removed when visibility changes, causing the mouseexited event never
to happen if a window is closed underneath the mouse.

BUG=282117
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/23764003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=277773

Review URL: https://chromiumcodereview.appspot.com/23564004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220689 0039d316-1c4b-4281-b951-d872f2087c98

This is a field displayed in an alternate font that adds an extra line
of information about the notification.

BUG=276004

Review URL: https://chromiumcodereview.appspot.com/23462005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220688 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220687 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=156996:157007&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/23621017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220686 0039d316-1c4b-4281-b951-d872f2087c98

BUG=282636

Review URL: https://chromiumcodereview.appspot.com/23441023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220685 0039d316-1c4b-4281-b951-d872f2087c98

BUG=236763
TEST=base_unitttests SystemMetricsTest.*
R=darin@chromium.org, nduca@chromium.org

Review URL: https://codereview.chromium.org/22824008

Patch from Json Mak <jwmak@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220684 0039d316-1c4b-4281-b951-d872f2087c98

As is, OpaqueBrowserFrameView is untestable due to its
dependencies. This patch separates out all the layout and sizing logic
into a LayoutManager subclass, makes OpaqueBrowserFrameView use that,
and then adds tests for the new LayoutManager.

Note that I've deliberately made as few cleanups to the layout logic as
possible. The point is to get this code under test before I start more
radical changes.

BUG=281788

Review URL: https://chromiumcodereview.appspot.com/23531006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220683 0039d316-1c4b-4281-b951-d872f2087c98

The loop action plays HTML5 media in loops and measures the avg time it 
takes to loop, i.e. time from end to start playback again.

BUG=249435

Review URL: https://chromiumcodereview.appspot.com/21134002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220682 0039d316-1c4b-4281-b951-d872f2087c98

Slash is an invalid path character.  Colon isn't used on Mac.  In both cases, an underscore is subsisted.

BUG=281701

Review URL: https://chromiumcodereview.appspot.com/23449015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23757011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220680 0039d316-1c4b-4281-b951-d872f2087c98

TBR=kalman@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23707013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220678 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220677 0039d316-1c4b-4281-b951-d872f2087c98

We don't actually use these resources, we link and load them into
resources.pak.

BUG=52609

Review URL: https://chromiumcodereview.appspot.com/23543010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220676 0039d316-1c4b-4281-b951-d872f2087c98

R=jam@chromium.org

Review URL: https://codereview.chromium.org/23622012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=281815
R=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/23788006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220673 0039d316-1c4b-4281-b951-d872f2087c98

This reflects the current state of master in
https://github.com/eliben/nacl-docs-rst

BUG=None
R=binji@chromium.org

Review URL: https://codereview.chromium.org/23835002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220672 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nhiroki@chromium.org
BUG=282646

Review URL: https://codereview.chromium.org/23572020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220671 0039d316-1c4b-4281-b951-d872f2087c98

This achieves backwards compat with "Classic" Android WebView which
would always set this level of font hinting and enable sub puxel positioning.

BUG=281508

Review URL: https://chromiumcodereview.appspot.com/23461014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220668 0039d316-1c4b-4281-b951-d872f2087c98

BUG=272460

Review URL: https://chromiumcodereview.appspot.com/23496024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220667 0039d316-1c4b-4281-b951-d872f2087c98

All the options used by browser_backends need to be moved from finder_options to browser options.

BUG=269131
TEST=trybot

Review URL: https://chromiumcodereview.appspot.com/23664002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220665 0039d316-1c4b-4281-b951-d872f2087c98

Key systems are now explicitly added rather than loaded from arrays of structs.

This is in preparation for moving knowledge of key systems and registration out
of content/.

BUG=224793
TEST=exsting content_unittests

Review URL: https://chromiumcodereview.appspot.com/23464005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220664 0039d316-1c4b-4281-b951-d872f2087c98

BUG=281246
R=ygorshenin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23757003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220661 0039d316-1c4b-4281-b951-d872f2087c98

The afoermentioned bug causes some pages to wedge which causes profile generation in Telemetry to fail.
Use tab.WaitForDocumentReadyStateToBeInteractiveOrBetter() instead to attempt to mitigate this.

BUG=282100
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23478017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220660 0039d316-1c4b-4281-b951-d872f2087c98

This maintains a duplicate set of menus for standard items. This enables
keyboard shortcuts to work as expected when the Chrome menus are hidden.

This also adds tags to various items in MainMenu.xib using existing and new
entries from chrome_command_ids.h. The tags are used to look up items in
the main menu.

BUG=168080, 276052
TEST=When an app window is focused, the main menu should change to a set of
menus relevant to apps. I.e. Chrome specific menus/items should be hidden.
The item in the menus should behave as expected for the app.

Review URL: https://chromiumcodereview.appspot.com/23005021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220659 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true
R=chrisgao@chromium.org, frankf@chromium.org

Review URL: https://codereview.chromium.org/23800002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220657 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bungeman@chromium.org
BUG=266484

Review URL: https://codereview.chromium.org/23689005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=chrisgao@chromium.org

Review URL: https://codereview.chromium.org/23495016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220654 0039d316-1c4b-4281-b951-d872f2087c98

than taking it as an arg.

The next change for Show URL will result in this function needing to muck with
the toolbar model and possibly re-fetch the text afterwards, so this change
prepares for that.

BUG=248287
TEST=none
R=msw@chromium.org

Review URL: https://codereview.chromium.org/23804002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220653 0039d316-1c4b-4281-b951-d872f2087c98

BUG=b/8627864
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23458014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220652 0039d316-1c4b-4281-b951-d872f2087c98

The mini_installer test framework used the psutil module to find process IDs and paths, but this module was not available on the buildslave. Remove psutil and call Windows API directly instead.

NOTRY=True
BUG=264859
1) Uninstall Chrome (if it's installed.)
2) Put mini_installer.exe in the same folder as test_installer.py
3) Use Python 2.6.x. Make sure that psutil is not installed. Run "python test_installer.py config\config.config". The test should pass.

Review URL: https://chromiumcodereview.appspot.com/23814002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220650 0039d316-1c4b-4281-b951-d872f2087c98

If a PageAction inherits another PageAction class, then DiscoverClasses() 
might mess up the map from simple module name to class object name. See 
bug for more details.

BUG=281568

Review URL: https://chromiumcodereview.appspot.com/23602015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220649 0039d316-1c4b-4281-b951-d872f2087c98

This CL should fix this issue that we are experiencing(note it is not always reproducible):
- In a maximized window, clicking button may not take any effect due to immediate
keyboard relayout
(go to http://unixpapa.com/js/testkey.html and try hit reset button after typed
a bunch of keys)

It also workarounds the other two issues:
1. keyboard flicking when quickly switch from one input field to another field
2. In webdev javascript console, the input feild temoporary lost focus when
candidate popup window shows and it may try to hide and relayout keyboard, which
makes the console unuseable with virtual keyboard.
The root problem for the above two issues are tracked in issue 281493.

BUG=

Review URL: https://chromiumcodereview.appspot.com/22831045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220648 0039d316-1c4b-4281-b951-d872f2087c98

make sense.

The use of NUM_BIN_PRIORITIES was confusing, but actually it
looks like that was simply old code and shouldn't even exist
anymore.

Also deleting some unused variables and functions.

Review URL: https://chromiumcodereview.appspot.com/23802002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220647 0039d316-1c4b-4281-b951-d872f2087c98

Send cancel request to printer when registration is canceled.

BUG=245375

Review URL: https://chromiumcodereview.appspot.com/23780002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220646 0039d316-1c4b-4281-b951-d872f2087c98

BUG=281038

Review URL: https://chromiumcodereview.appspot.com/23514006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220645 0039d316-1c4b-4281-b951-d872f2087c98

permissions by automatically generated ones for declare_permissions.html.
Add docs for the tabs permission. Remove the unused tabCapture docs.
Fix some missed cases where we didn't change "module" terminology to "API".

R=jyasskin@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23494015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220644 0039d316-1c4b-4281-b951-d872f2087c98