- 07 Dec, 2017 40 commits
-
-
Raymes Khoury authored
This adds more tests to SearchPermissionsService to test: -The cases where the kGrantNotificationsToDSE flag is disabled -The case where the kGrantNotificationsToDSE is enabled and then changes back to disabled. This also fixes a bug where resetting DSE notifications permissions would happen even when the feature flag was disabled. Bug: 799534 Change-Id: I907f03308936a1a502fa9fba04aae80325c3a3ee Reviewed-on: https://chromium-review.googlesource.com/813140Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#522362}
-
Eve Martin-Jones authored
This change is for files in the path //third_party/WebKit/Source/core/clipboard/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Change-Id: Ie725fb237db6d86efc373e415c7dfbf4dea42a2f Reviewed-on: https://chromium-review.googlesource.com/812366Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Eve Martin-Jones <evem@chromium.org> Cr-Commit-Position: refs/heads/master@{#522361}
-
Gyuyoung Kim authored
The spec says that "When the user agent uses this handler, it must replace the first occurrence of the exact literal string "%s" in the URL argument". - Spec: https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers So, only the first %s can be changed to the given URL. For example, let's assume this scenario, 1. navigator.registerProtocolHandler("test", 'http://example.com/%s/url=%s', 'title');" 2. <a href="test:duplicated_placeholders">this</a> According to the specification, destination URL should be "http://example.com/test%3Aduplicated_placeholders/url=%s". But, current Chrome implementation replaces all placeholders with the given custom url as below, "http://example.com/test%3Aduplicated_placeholders/url=test%3Aduplicated_placeholders" Firefox also substitutes only first placeholder when url contains multiple placeholders. Bug: 791912 Change-Id: Ic3d439c68ac35d776afa6b6907ecdc0da774b08e Reviewed-on: https://chromium-review.googlesource.com/808086 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#522360}
-
Sriram authored
Upstream the below tests from media/track/ to wpt 1. track-active-cues.html 2. track-constants.html Bug: 782555 Change-Id: I587aebd9ef8bdc60cac19a4cb5dd42d69a917b2c Reviewed-on: https://chromium-review.googlesource.com/810825 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#522359}
-
rhalavati@google.com authored
We are adding network traffic annotations to sockets. Some remoting classes are refactored to transfer the annotations to the underlying sockets. Bug: 656607 Change-Id: Id2deafff189259a808896cb9b426a91fc45c54bf Reviewed-on: https://chromium-review.googlesource.com/810786Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#522358}
-
Eve Martin-Jones authored
This change is for files in the path //third_party/WebKit/Source/core/leak_detector/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Change-Id: If017db1b5666219af6f95ac38aaeced49f657f69 Reviewed-on: https://chromium-review.googlesource.com/813434Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Eve Martin-Jones <evem@chromium.org> Cr-Commit-Position: refs/heads/master@{#522357}
-
Daniele Castagna authored
This CL just adds a TODO in the overlay candidate code, where we currently reject HW overlays candidates if they have a color transform matrix, since we should be able to handle those once crbug.com/792757 is addressed. Bug: 792757 TBR: reveman Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: If0211c553d82dfca212d6e9b52e0ebfd5f861dd1 Reviewed-on: https://chromium-review.googlesource.com/813062 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#522356}
-
Makoto Shimazu authored
SWContextClient is getting complicated rather than just passing through the events, especially after adding renderer-side timers. This CL is for adding unit tests for SWContextClient. Bug: 774374 Change-Id: Iaaf3944d0a11d812c9f9f3e2f9bfe2f334fcba19 Reviewed-on: https://chromium-review.googlesource.com/799518 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#522355}
-
Toni Barzic authored
Move logic to * launch lock screen note when stylus is removed * close lock screen note when screen is forced off (e.g. due to power button press) from lock_screen_apps/state_controller to ash, into a newly added LockScreenNoteDisplayHandler. The main goal of this is to better handle lock screen app launch when stylus is ejected with display forced off. This action should perform two actions: 1. turn the display on 2. launch the lock screen note (if lock screen note action is enabled) Doing this at the same time can cause a flash of lock screen UI before the lock screen note app window is shown. With logic for launching the note moved to ash, it's possible to delay changing display state until the lock screen app window becomes visible, which should be long enough to prevent lock screen UI flash. BUG=767711 Change-Id: I7754050cb1275a6526a66843435b9f2d5837371f Reviewed-on: https://chromium-review.googlesource.com/807671 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#522354}
-
Sasha Bermeister authored
Change quota_dispatcher_host.mojom to use url.mojom.Origin instead of a url.mojom.Url. Also added TODOs in QuotaManager (and similar) to update to use a url::Origin in their implementation instead of a GURL, referencing crbug.com/598424. Bug: 781643 Change-Id: I086dc0facec82523ab058463a311831c94d4f939 Reviewed-on: https://chromium-review.googlesource.com/804906Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#522353}
-
Eve Martin-Jones authored
This change is for files in the path //third_party/WebKit/Source/core/timing/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Change-Id: I6da854a295beb39494e21604590dad978c1b4e9b Reviewed-on: https://chromium-review.googlesource.com/813436Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Eve Martin-Jones <evem@chromium.org> Cr-Commit-Position: refs/heads/master@{#522352}
-
Jinsuk Kim authored
The event flow was migrated to ViewAndroid. This CL removes the remaining handler, and moves the post-event task in ContentViewCore.onSizeChanged to ImeAdapterAndroid/PopupZoomer. Bug: 622847 Change-Id: I1814d435365a3aa0f7685b26c860cf56e2856a9a Reviewed-on: https://chromium-review.googlesource.com/784731 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#522351}
-
Tomasz Mikolajewski authored
Service should be provider type agnostic. Callers can now use Service::GetProviders() to do the same. Bug: None Test: All unit tests pass. Change-Id: I6b89ad15081bf23a260e1dd50e6391728b00843a Reviewed-on: https://chromium-review.googlesource.com/803178 Commit-Queue: Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#522350}
-
Timothy Loh authored
This patch fixes a crash in modal permission prompts on Android where the UI dismiss handler is called when the delegate has already been cleared. This happens due to a race between native C++ trying to close the prompt and the user actioning the prompt (which asynchronously calls the click/dismiss handlers). Even though we currently clear the dismiss handler in dismissFromNative, the Dialog itself may have queued calling the original handler, which doesn't work once the delegate is cleared. Bug: 791023 Change-Id: I7e520a36a33eccad2dd7ab82526e2a7bc404704f Reviewed-on: https://chromium-review.googlesource.com/810407 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#522349}
-
Takeshi Yoshino authored
Bug: 692926 Change-Id: Iacd04725bfbc2f0beff5bd87b9061d4ba369d6e2 Reviewed-on: https://chromium-review.googlesource.com/807864Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#522348}
-
Scott Graham authored
TBR=mark@chromium.org Bug: 792619 Change-Id: Ic1e807fcd70377596737ba06e797cade5c7bd59b Reviewed-on: https://chromium-review.googlesource.com/812453 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#522347}
-
Shanmuga Pandi M authored
As per spec[1], intrinsicWidth, intrinsicHeight, and intrinsicRatio should return NULL , if state is other than "loaded". [1] https://drafts.css-houdini.org/css-typed-om-1/#cssimagevalue Bug: 792328 Change-Id: I9d3c7014136f6f2a7bd6b350ff4083389436cc54 Reviewed-on: https://chromium-review.googlesource.com/810288Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#522346}
-
Ke He authored
The crash reason is |geolocation| got std::move() first before it calls the QueryNextPosition(). It is better to save the InterfacePtr of geolocation and geolocation_context as class member. BUG=791445 Change-Id: I694853a0bc37f53d879419e7b0ab2d8943e98509 Reviewed-on: https://chromium-review.googlesource.com/807759 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by:
Colin Blundell (OOO Dec 7) <blundell@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#522345}
-
Sammie Quon authored
Missed a case for part 1 (https://chromium-review.googlesource.com/c/chromium/src/+/797681). After both snap, press F5 to return to one snap + overview. Snapped windows header is not shown. This is because on entering overview mode or switching from split view states happen when overview is starting, not when it is entered (IsSelecting() returns false in OnOverviewModeStarting), so remove that check. Test: manual, ash_unittests CustomFrameViewAshTest.HeaderVisibility Bug: 789378 Change-Id: I1f1589b359983dcc6a2db65be62cd185121411c0 Reviewed-on: https://chromium-review.googlesource.com/809757Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#522344}
-
Eve Martin-Jones authored
This change is for files in the path //third_party/WebKit/Source/core/fullscreen/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Change-Id: Ie21a0b3893a158189f8ae9f7d3f628152c64bbe3 Reviewed-on: https://chromium-review.googlesource.com/813395Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Eve Martin-Jones <evem@chromium.org> Cr-Commit-Position: refs/heads/master@{#522343}
-
Thomas Guilbert authored
CastMediaRouteProvider and RemotingMediaRouteProvider have very similar code that can be generalized into a base class. This CL extracts the common logic behind observing media sinks and adds it to the new BaseMediaRouteProvider. Bug: 790766 Change-Id: I92a2fec95dc5cf32f132e295dc8e95b0604217e4 Reviewed-on: https://chromium-review.googlesource.com/784121 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Cr-Commit-Position: refs/heads/master@{#522342}
-
Sadrul Habib Chowdhury authored
mus should no longer host viz for browser_tests --mus. So it should not have --mus=viz flag set. With this change, the browser_tests no longer need the filter file. So remove it (from main and fyi waterfalls). BUG=786453, 785536 Change-Id: Ia9ecfdc8f667bb07cf53debbc98f960938f6d452 Reviewed-on: https://chromium-review.googlesource.com/812169Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#522341}
-
Alice Boxhall authored
Several places in the code I'd overlooked were referring to "paletteContainer", so I felt it was safest to just put it back the way it was. Bug: 792348, 792342 Change-Id: I144752c1436500d4167190060f675b0115ee8a14 Reviewed-on: https://chromium-review.googlesource.com/812584Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#522340}
-
Dirk Pranke authored
This CL converts the chromium waterfall config to be auto-generated using the new generate_buildbot_json framework. R=kbr@chromium.org, jbudorick@chromium.org BUG=662541 Change-Id: I56c403369b4e0811fe604930d8da97048d434eda Reviewed-on: https://chromium-review.googlesource.com/809958Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#522339}
-
Giovanni Ortuño Urquidi authored
Help measure the overhead of retrieving apps during navigations. Bug: 785661 Change-Id: I8e31ba9373744e6d68942e96f207d3eac1bb67f0 Reviewed-on: https://chromium-review.googlesource.com/809920 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#522338}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/82cfea0e3cd5..db654910e39e $ git log 82cfea0e3..db654910e --date=short --no-merges --format='%ad %ae %s' 2017-11-30 spang Fix rendering of full height UI features 2017-12-06 simonhatch Dashboard - Copy histogram level diagnostics in /add_histograms Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I3ebea557e96eba03b19f395099437efd921c0877 Reviewed-on: https://chromium-review.googlesource.com/813236 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522337}
-
dpapad authored
Bug: 792774 Change-Id: I2507ec439d43880de311edc9bc8131bc774edc3d Reviewed-on: https://chromium-review.googlesource.com/807684 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#522336}
-
Eric Stevenson authored
This CL adds support for extra post processing after package_resources is complete, including modifying the R.java files that are used. Bug: 762130 Change-Id: I25fdc9a4bd9f2a13620036cb6988dced8d2602ea Reviewed-on: https://chromium-review.googlesource.com/761676 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#522335}
-
jchen10 authored
x86 and x64 have different default alignment for 'long long' and 'double'. The browser and renderer processes of Android webview run in 64-bit and 32-bit modes respectively. So we need to deliberately arrange buffer fields to avoid misalignment. BUG=781095 Change-Id: Icb6bade57d6d977468fe9c83a77f1e56d8875f90 Reviewed-on: https://chromium-review.googlesource.com/752428 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#522334}
-
Kim Paulhamus authored
Add a test for the timeout in the authenticator impl. Necessitates refactoring //device/u2f test code into a test_support target to set up a service_manager::Connector. Bug: 785950, 785950 Change-Id: Idfd132a54909ceb8e7104e278434227ecac2c34c Reviewed-on: https://chromium-review.googlesource.com/775912 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#522333}
-
chrome-release-bot authored
TBR=amineer@chromium.org Change-Id: Ie61f3176458a5d4fd0c9daf7534ef3a0a9fc2c31 Reviewed-on: https://chromium-review.googlesource.com/813376Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#522332}
-
Eve Martin-Jones authored
This change is for files in the path //third_party/WebKit/Source/core/intersection_observer/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Change-Id: I2bb5d2856d322a761ee810b0e573a0880c0a2b25 Reviewed-on: https://chromium-review.googlesource.com/813354Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Eve Martin-Jones <evem@chromium.org> Cr-Commit-Position: refs/heads/master@{#522331}
-
John Budorick authored
Not necessary since spellcheck was componentized. Bug: 791632 Change-Id: I442a50cc15d1fc63714f65a2abbf62b8b254938c Reviewed-on: https://chromium-review.googlesource.com/808984Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#522330}
-
Kunihiko Sakamoto authored
For ResourceLoadScheduler experiment, we plan to add more aggressively targeted variants of PageLoad.Clients.MultiTabLoading.* metrics that will only be logged if there are more than X loading tabs. This will give us the distribution of number of loading tabs, and will help us determine the threshold of the targeted metrics. Bug: 792759 Change-Id: I8aefd59f52cefd4c1e449795cfdace4fc44fdf98 Reviewed-on: https://chromium-review.googlesource.com/807866 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#522329}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/43fd0d44d2a6..030017a4855c $ git log 43fd0d44d..030017a48 --date=short --no-merges --format='%ad %ae %s' 2017-12-06 kainino Mark StaticType related functions as constexpr Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I6c652e1bfd589baf3fa99824cf976994e43e0a8b Reviewed-on: https://chromium-review.googlesource.com/813176Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522328}
-
Charles Harrison authored
Some observers can have code that computes policy in an expensive way. Bug: 792524 Change-Id: I4787f295e946efe889528a0a7df19421791856f4 Reviewed-on: https://chromium-review.googlesource.com/811367 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#522327}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee13fe4b..5ce45836 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Icd31f3446c5ddde57f7719bc73bb22e13028372b Reviewed-on: https://chromium-review.googlesource.com/812215Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#522326}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/409506c4c978..5031e5f8b77f $ git log 409506c4c..5031e5f8b --date=short --no-merges --format='%ad %ae %s' 2017-12-07 angle-deps-roller Roll skia/third_party/externals/angle2/ 43fd0d44d..030017a48 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I51ca44960d6bf5517cc1e6828bae8751410031f5 Reviewed-on: https://chromium-review.googlesource.com/813194Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522325}
-
Benjamin Pastene authored
Something that significant should trigger compiles and tests. Bug: 792130 Change-Id: Ia6c467f97e54ac4b8e8b6c6bc8ab00ff4a9acd65 Reviewed-on: https://chromium-review.googlesource.com/812503Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#522324}
-
kylechar authored
This CL deletes viz::FrameSinkManagerClient. FrameSinkManagerImpl has a pointer to each CompositorFrameSinkSupport directly now since this is needed anyways. The FrameSinkManagerImpl::clients_ map is removed as a result. SinkAndSupport will always contain a CompositorFrameSinkSupport* while the CompositorFrameSinkSupport object exists. SinkAndSupport::sink will be non-null when FrameSinkManagerImpl owns the compositor frame sink. CompositorFrameSinkSupport::Init()/Create() are also no longer needed since SetBeginFrameSource() is no longer virtual. Remove Init() and make the constructor public. Create() is left since it's widely used for now but is marked deprecated. Also remove some old/wrong forward definitions and fix some style guide violations. Bug: 792192 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I14f9662c9db485ce18edf1d358493648997d3648 Reviewed-on: https://chromium-review.googlesource.com/810866Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#522323}
-