- 12 Nov, 2019 40 commits
-
-
Pavel Shmakov authored
Discussion: https://docs.google.com/document/d/1M-ocVxRpj43fGrM4mdBazEgcDa0nbWPxD_NxfsPnrkg/edit?ts=5dc96bc9 This CL implements the short-term solution, i.e. only an onRenderProcessGone callback. Change-Id: I51cf71975db4d72e940e15b5f2acca6cde3ff4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901083Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#714501}
-
Matthew Jones authored
Bug: Change-Id: If7d4dfd554bb9224f3f12266f1bfdab99040225e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910802 Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#714500}
-
Manu Cornet authored
Change-Id: I4ab18dcab81d8622a52b9b744bd7aa57ae1693da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911220Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#714499}
-
Denis Kuznetsov authored
Bug: 1023370, 852557 Change-Id: I2d859e6f38f494ad15293939d322a31cc0ac567d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911216Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#714498}
-
Mathias Carlen authored
Before this patch, three different activity types were tested in the same test. That resulted in the activities to interfere with one another. This patch splits the tests up into one test file per activity. R=szermatt@chromium.org Bug: 1018183 Change-Id: Ie09202e9ac69e96ac207ffe3f43b4e00e592d343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910088Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#714497}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e8fc00fb..5bd261c7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic37aee1120a6706c570d556eb1839c825092b5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911245Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714496}
-
kylechar authored
Ensure the GPU thread task to schedule DC overlays runs after the mailboxes have been mapped to textures. Bug: 1003040 Change-Id: I0a5a8b4ce1c24d8b64fbb600092703e5e8a2d136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907193 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714495}
-
Kai Ninomiya authored
- New styles from upstream to fix text wrapping. - Add the tests that require glslang. They still won't run - they automatically skip themselves since the glslang dependency is not available. Soon I'll replace this file with a similar auto-generated one. Bug: None Change-Id: I60c64eddce0030a41bf3bb4d97cd8fdaed4905c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906371Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#714494}
-
W. James MacLean authored
This test flakes regularly on Kitkat, less often on marshmallow. TBR=jianli@chromium.org Bug: 1022322 Change-Id: Idca960761c3a4a56fdd2027b79a53943fe07199e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911390Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#714493}
-
Tobias Sargeant authored
In the case that CrashpadHandlerMain is not an exported symbol we should fall back to using the java crashpad launcher. Also check that the trampoline binary exists. Bug: 1022837 Test: manual; install a non-trichrome webview on Q, and check Test: that a minidump is captured. Change-Id: If397fd805a25f73aa4a54e728670d1943cb188e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906350Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#714492}
-
Gauthier Ambard authored
This is needed to be able to use this file from ios/web. Bug: 901082 Change-Id: I893360bab6226212780ebf7d4eb186737936db92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911742 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#714491}
-
Josh Nohle authored
We also add the function ShouldDeprecateV1DeviceSync for future use. We adjust the DeviceSync service unit tests to check the Chrome OS feature flags. Bug: 951969, 1019206 Change-Id: I5cd8de6521131cf1cca672f4dc7b6115f93cd06a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907834Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#714490}
-
nancy authored
Design doc: go/appservice-for-per-app-time-limit-design-doc This CL implements the interface: PauseApps RecoverApps This CL also implements the App Pause Dialog. To make AppServiceProxy more clean, PauseApps's parameter "PauseData" is defined in PauseDialog, as that is used for the App Pause Dialog. The App Pause Dialog should be similar to the Uninstall Dialog. Based on the requirement, the App Pause Dialog should be implemented for the ARC running apps only. The app running checking will be added in a separate CL. BUG=1011235 Change-Id: If2811f9722ce18494418f3a1c7ff0f12c951b599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899629 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#714489}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9da287fd0264..371316798c01 git log 9da287fd0264..371316798c01 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 sugoi@google.com Blend mode fix for 565 format Created with: gclient setdep -r src/third_party/swiftshader@371316798c01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/24332884 Change-Id: I4726090c410a98d65dec6f1c5dc30f7a2a9f4dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910793Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714488}
-
Ian Kilpatrick authored
We had an issue in the existing invalidation code when an object could contain an OOF-positioned node, but wasn't a LayoutBlock. This already happens when we have a LayoutInline being a containing-block, but there are other cases where this is true. Clusterfuzz found that LayoutTableSection falls into this category. E.g. The OOF-positioned node would be inserted into the nearest containing-block (the anonymous LayoutTable in this case). When it stopped being a containing-block, the OOF-positioned node was never removed from the LayoutTable. This caused a crash when the OOF's layout was invalidated. The OOF marked itself, and the LayoutView (its new containing block) for layout. But the LayoutView didn't know it had this as an OOF-positioned child. This patch moves the current logic within LayoutBlock into LayoutBoxModelObject. Bug: 1021491, 1021676, 1022545 Change-Id: I0f0b4c8aa655fc7edca5d79379205a8d445713d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906708Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#714487}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed16d1d29e2f..a9c64739fb43 Created with: gclient setdep -r src-internal@a9c64739fb43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I9335950b8723dce0baccc2bc9bb224f280e7b265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910792Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714486}
-
Stephen Chenney authored
This patch adds UMA metrics to match the recently added information in UKM, allowing the Rendering Core team to track their contributions to First Contentful Paint. Bug: 1001199 Change-Id: I4a6a4779a4fadf8a71d9e69eaedbe826a3dbb9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901429 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#714485}
-
Liquan (Max) Gu authored
This patch adds a toolbar to the Bottom-sheet based Payment handler. The features of the toolbar includes: * origin: shows the origin of the payment app url (with the scheme) * title: shows the payment app title * progress bar: shows the load progress of the payment app * security icon: show 3 different icons based on the security level. Because of its resemblance with the ephemeral tab toolbar, we reuse the ephemeral tab toolbar's layout but implement it with different controlling logic. Note that the above features support redirect. Whenever the payment app page redirect, these features would get updated to match the current page. The progress bar updates the load progress whenever receiving web-contents' progress-updating callback. It get hidden once the progress reaches 100%; it shows up again once the progress turns below 100%. Bug: 999196 Change-Id: Ifaf9e971256ff82888176623b3a4b51749246a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901639Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#714484}
-
Andreas Haas authored
We change the type of the size field of a DOMArrayBuffer to size_t to allow bigger DOMArrayBuffers eventually. This CL introduces new getters for the size field, {ByteLengthAsSizeT} and {ByteLengthAsUnsigned}. {ByteLengthAsUnsigned} replaces the current {ByteLength} implementation and still returns an {unsigned}. There is a CHECK for potential overflows. This function is deprecated and should not be used anymore. Instead, {ByteLengthAsSizeT} should be used. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I13dea548c5eae6b46530e49ef51fbb366438e4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910091 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#714483}
-
Elly Fong-Jones authored
This one is easy: TabHoverCardBubbleView recreates its footnote view whenever the footnote view's state changes anyway, so simply don't create it in the constructor at all. Bug: 1011446 Change-Id: Ia195f28d48dd3a76897c3f466476aaf78a8c13bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910422Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#714482}
-
Joe Mason authored
R=proberge Bug: 1023545 Change-Id: Icc7f7ed30ba4ac51fbf5725e61cfafeb2aebe150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906475Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#714481}
-
Philip Rogers authored
Trivial 3D transforms are not considered direct compositing reasons when the DoNotCompositeTrivial3D experiment is active (see: CompositingReasonFinder::RequiresCompositingFor3DTransform). This has caused a performance regression on top sites (google.com and many others) where we no longer use composited scrolling. This change continues to use trivial 3D transforms as a reason for composited scrolling. Bug: 1012775 Change-Id: Ibef9b9b3de4d57afe30d0fc3dc75da29855b7deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907415Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714480}
-
Vladislav Kuzkokov authored
This list is used to decide whether we can send username and filename to a particular printer. Bug: 1022101 Change-Id: Iaa3ad19ace09105af8587801e7bfc5317d7a011e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910096 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#714479}
-
Askar Aitzhan authored
The experiment CloudPolicyOverFCM was tested on 50% Dev and Canary and the result were expected. Prior to moving to 50% Beta the experiment is added to Field Trial Testing Config. The results of experiment: * https://screenshot.googleplex.com/6ZNs6sQ7QxM Bug: 939039 Change-Id: Id8d7107a93d64a93f3b8363909fd691af517cab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906215Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Cr-Commit-Position: refs/heads/master@{#714478}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f34cdc70ca1b..37dcb894574e git log f34cdc70ca1b..37dcb894574e --date=short --no-merges --format='%ad %ae %s' 2019-11-12 johnkslang@users.noreply.github.com Merge pull request #1973 from KhronosGroup/fix-fmod-int Created with: gclient setdep -r src/third_party/glslang/src@37dcb894574e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,cnorthrop@google.com Bug: None Change-Id: I51cf1697dfe9418e362d025ba447a2158d5df73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714477}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/229035db8cc6..bd27b14638e4 git log 229035db8cc6..bd27b14638e4 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" 2019-11-12 danilchap@webrtc.org Mark scoped_refptr move and swap operations as noexcept 2019-11-12 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." 2019-11-12 mbonadei@webrtc.org Add 2 more RTC_EXPORT. 2019-11-12 yvesg@webrtc.org Fix NetworkEmulationManagerTest.ThroughputStats flakiness (again). Created with: gclient setdep -r src/third_party/webrtc@bd27b14638e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Iee5d33aa45af765b261f53a8385ad7548ce9f6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910789Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714476}
-
Charlie Hu authored
Changing the frame policy when a navigation is already in-flight must not affect the in-flight navigation because of https://html.spec.whatwg.org/multipage/iframe-embed-object.html#attr-iframe-allow The snapshot is made at the beginning of a local_frame_client navigation and used on document initialization(after commit of navigation). If the frame owner is a remote one, the old value is used. - capture frame policy at the start of navigation - local_frame_client_impl - NavigationInfo - render_frame_impl.BeginNavigationInternal - pass it from renderer process to browser process through CommonNavigationParams in navigation_params.mojom - MakeCommonNavigationParams - use value in CommonNavigationParams to init navigation_params - render_frame_impl.CommitNavigationInternal - web_navigation_params -> DocumentInit -> Document::InitializeFeaturePolicy More detailed information could be found on crbug page. A document_loader_test is added to further strengthen the test on frame policy value used. Verified that the added test would fail without the patch. Bug: 972089 Change-Id: I694aa46b6e8e04bebc86b0e7886b856a9a302905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796119Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#714475}
-
Yoshifumi Inoue authored
This patch makes |NGFragmentItem::GetWritingMode()| not to crash for |kGeneratedText| for preparation of migrating |NGFragmentItem|. Below is sample stack trace when |GetWritingMode()| called with kGeneratedText Sample file: fast/css/text-overflow-ellipsis.html - NGFragmentItem::GetWritingMode() - NGFragmentItem::IsHorizontal() - WriteTextFragment() - Write() - Write() - Write() - LayoutTreeAsText::WriteLayers() - LayoutTreeAsText::WriteLayers() - LayoutTreeAsText::WriteLayers() - ExternalRepresentation() - ExternalRepresentation() - WebFrameContentDumper::DumpLayoutTreeAsText() Bug: 982194 Change-Id: Iae8a55a3fff57a487ac9d21c47c06fd19cae2c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911345 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714474}
-
Roger Tawa authored
Added more permutations of the combination of: - has / doesn't have feature flag - has / doesn't have policy set - has / doesn't have DM token Tests for the secondary policies will be added along with those features. Bug: 1021940 Change-Id: Ic0d105d41d3f8ba3aa71a6880ce974d48dfac051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904114 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#714473}
-
Vadym Doroshenko authored
Bug: 959776 Change-Id: I1398b271633dd731a363b32b2c69a67764f0aa6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911204 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714472}
-
Mia Glaese authored
Fix bug that tab carousel is hidden any time a tab is closed. Added corresponding test. Bug: 982018 Change-Id: I59cc4709fc322e509bcb48575b10f32bcca14ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910427Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#714471}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7b689b5ced7d35d672ee08974888f6af810f5554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910790Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714470}
-
Rob Buis authored
The following mappings are performed: dir => direction mathbackground => background-color mathcolor => color mathsize => font-size See https://mathml-refresh.github.io/mathml-core/#global-attributes Note that the mapping of display, displaystyle, mathvariant and scriptlevel will be added later. Bug: 6606 Change-Id: I1b00c2981071dc1127570a5f7351f8b8e2b89357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908533 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#714469}
-
Alex Chau authored
- Also log network error - Log net::OK(0) when ResponseHead is not present Bug: 1021896 Change-Id: I0da6ccda68c5b914349cdc011752897e2e10bcd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901470 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#714468}
-
Alex Chau authored
- Disabled ClickToCall/SharedClipboard SyncTurnedOff browser test when UnidoOnSignIn is on as it no longer applies - Disabled Sharing registration when device is in local sync mode if deriving VAPID key as derived key is not availalbe in local sync mode - Add DeviceInfo to allowed type in transport mode in sync_integration_tests when UnidoOnSignIn is on Bug: 1009516 Change-Id: I59a48d6feb2aee941ae6adb867c3a72c1ce70f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905946 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#714467}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/867f8c92ed1a..b9b1bae4effb git log 867f8c92ed1a..b9b1bae4effb --date=short --no-merges --format='%ad %ae %s' 2019-11-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 3e4abc9ac382..12e54dae167c (1 commits) Created with: gclient setdep -r src/third_party/angle@b9b1bae4effb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:None Change-Id: I188d0376588fe44d4a3096953ec5b3c19bccf8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911959Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714466}
-
Thomas Tellier authored
Bug: 1010259 Change-Id: I1c05b5cee396cb3bfa9ecf91e5f15700958d73aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900000 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#714465}
-
Henrique Ferreiro authored
Move blink::WebIDBDatabaseException into //third_party/blink/public/mojom/indexeddb.mojom. Bug: 1022358 Change-Id: I77cd44bb7bad473692342d49070771632348fe30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899612Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#714464}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/29cbe0b3..e8fc00fb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9989c1ff7f0910ee3da24fce721408de11c2cb7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911244Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714463}
-
Roman Sorokin authored
Bug: 750060 Change-Id: Ie27b75f03835c7cf64cedea5b06f34a441b33216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900994Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714462}
-