GitLab

1051: make: Fix regression where bundle targets without postbuilds called postbuilds
of a different target.

BUG=none
TEST=`make chrome` on groby's mbp works again
TBR=mark

Review URL: http://codereview.chromium.org/7977040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102231 0039d316-1c4b-4281-b951-d872f2087c98

 remove all rounded corders in the pod.
 add 1x border around pod
 change background to c0c0c0.

BUG=chromium-os:20652
TEST=see bug for new ui mock


Review URL: http://codereview.chromium.org/7980029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102230 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7980049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102227 0039d316-1c4b-4281-b951-d872f2087c98

Instead, allow Native Client when Javascript is allowed.
BUG=91571
TEST=manual

Review URL: http://codereview.chromium.org/7978037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102226 0039d316-1c4b-4281-b951-d872f2087c98

RWHVV shouldn't update ime if there is no inputmethod associated with the view.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7976028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92803
TEST=


Review URL: http://codereview.chromium.org/7978013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102223 0039d316-1c4b-4281-b951-d872f2087c98

debug intermittent crash seen only there.

BUG=None
TEST=None
R=bradchen@chromium.org
Review URL: http://codereview.chromium.org/7976042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102221 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94433
TEST=manual


Review URL: http://codereview.chromium.org/7845004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102220 0039d316-1c4b-4281-b951-d872f2087c98

Make EntryKernel/Entry/BaseNode use base::Time instead of int64s.

Add sync/util/time.h, with utility functions to manage the sync proto
time format.

Store times on disk in proto format instead of the local system.
This requires a database version bump (to 77).

Update SessionChangeProcessor/SessionModelAssociator
to use base::Time, too.

Remove hackish Now() function.

Remove ZeroFields() function, and instead zero-initialize in EntryKernel::EntryKernel() directly.

BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102184

Review URL: http://codereview.chromium.org/7981006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102218 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually


Review URL: http://codereview.chromium.org/7983043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102217 0039d316-1c4b-4281-b951-d872f2087c98

If a bubble view was shown immediately after creating a browser window the bubble view would get a deactivate event causing it to close.

The problem was that when the browser window's page was commited it would switch focus to the location bar. This caused the bubble view to lose focus and close.

Fix was to have the browser winodw switch focus to the location bar only if it was the active window. Thus if a bubble view was shown it wouldn't switch focus.

This change also modifies InProcessBrowserTest::CreateBrowserForPopup() to show the browser window before navigating to a blank page. This fixes a problem where the browser window wouldn't become active.

BUG=95146
TEST=


Review URL: http://codereview.chromium.org/7960001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102216 0039d316-1c4b-4281-b951-d872f2087c98

Lots of functions have been deprecated recently.
We should update the DEPS and wait for a while before
removing them.

BUG=chromium-os:20648
TEST=build chrome

Review URL: http://codereview.chromium.org/7980030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102215 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87811
Test= plugins.PluginsTest.testDisableEnableAllPlugins

Review URL: http://codereview.chromium.org/7865002

TBR=venkataramana@chromium.org
Review URL: http://codereview.chromium.org/7981044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102214 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=bots green
Review URL: http://codereview.chromium.org/7979031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102213 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds a new virtual method NPChannelBase::GetModalDialogEvent() to
avoid the need for NPObjectProxy to cast its NPChannelBase to PluginChannel.

Refactoring only, no functional change.

BUG=96703


Review URL: http://codereview.chromium.org/7983032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102212 0039d316-1c4b-4281-b951-d872f2087c98

TBR=kalman@chromium.org
BUG=97511
TEST=none

Review URL: http://codereview.chromium.org/7977038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102210 0039d316-1c4b-4281-b951-d872f2087c98

net::NetworkChangeNotifier instead.

BUG=chromium-os:20014
TEST=make sure hosted app loading is still respecting network online state changes
Review URL: http://codereview.chromium.org/7969009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102209 0039d316-1c4b-4281-b951-d872f2087c98

While typing into the omnibox, VoiceOver will announce
"untitled window created"
This is fairly disruptive and has been commented on by users.
We should revisit how to make the underlying NSMatrix accessible, but in the meantime, set the window to NSAccessibilityUnknownRole so VoiceOver will ignore it.

Similarly, status bubbles cause VoiceOver to announce "untitled window created". The content contained therein is exposed in other ways to the user of VoiceOver.

BUG=63483
TEST=manual


Review URL: http://codereview.chromium.org/7982033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102207 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95896
TEST=Click on 'Manage Bookmarks' at top level of NTP4 bookmarks page, should invoke the Bookmarks Bar folder.
Review URL: http://codereview.chromium.org/7976009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102206 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102205 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7981034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102204 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bulach@chromium.org

Review URL: http://codereview.chromium.org/7982046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102202 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76834
TEST=manual.


Review URL: http://codereview.chromium.org/7982018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97381
TEST=Chrome not crashing


Review URL: http://codereview.chromium.org/7976022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102200 0039d316-1c4b-4281-b951-d872f2087c98

I'm going to be splitting these up a lot and there will be more
files. They need a home.

Review URL: http://codereview.chromium.org/7980055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102198 0039d316-1c4b-4281-b951-d872f2087c98

This is a D-Bus config file that will be installed on /etc/dbus-1/system.d
on Chromium OS. The original file comes from libcros.

BUG=chromium-os:18904
TEST=none

Review URL: http://codereview.chromium.org/7982020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102197 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102196 0039d316-1c4b-4281-b951-d872f2087c98

These had gotten out of sync with the comments and intended behavior when we reduced the max time per chunk to 20ms.

BUG=none
TEST=PhishingDOMFeaturExtractorTest.Continuation


Review URL: http://codereview.chromium.org/7981027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102195 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r6737: (khim) Partial rollback of r6734.
r6738: (mcgrathr) Add gyp/scons configury and buildbot option to build trusted code with Clang
r6739: (jvoung) Update llvm/llvm-gcc revs to pull in trivial merge
r6740: (mcgrathr) Roll back gtest_rev 364
r6741: (mcgrathr) Make Mac clang bot 32-bit
r6742: (kschimpf) Speed up x86-64 validator by inlining buffer segment reads. Speeds up x86-64 validator by approximately 11%.
r6743: (kschimpf) Speed up x86-64 validator by inlining heavily called routines. Speeds up

BUG=none
TEST=nacl_integration


Review URL: http://codereview.chromium.org/7977028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102194 0039d316-1c4b-4281-b951-d872f2087c98

When XmppConnection is deleted, its TaskPump member is not deleted immediately.
The destructor enqueues a task to the message loop to have it deleted later.  A
comment in ~XmppConnection that explains why it does this.

In the unit tests, the TaskPump would get leaked because the message loop would
never get a chance to run that deletion task.  This commit fixes the problem by
running all pending tasks on that message loop before we exit the test.

This commit removes the suppression for bug_80238.  Issue 80238 hasn't been
seen for a while, so it's probably safe to remove.  It's only relation to issue
79651 is that it happened in the same set of tests; the two issues probably had
different root causes.

This commit renames the suppression bug_79651, which is still necessary, but
isn't actually related to issue 79651.  When I tried to remove it, I ran into
the issue now known as issue 96904.  I've renamed the suppression to match the
issue it's actually suppressing.

Discussion of these changes can be found on the bug tracker, spread across the
pages for issues 79651, 80238 and 96904.

BUG=79651, 80238, 96904
TEST=InvalidationNotifierTest


Review URL: http://codereview.chromium.org/7919026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102193 0039d316-1c4b-4281-b951-d872f2087c98

Since it is default on now.

BUG=chromium-os:20537
TEST=Verify fix for chromium-os:20537.


Review URL: http://codereview.chromium.org/7980040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102192 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96742
TEST=See bug


Review URL: http://codereview.chromium.org/7982037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102190 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/7980018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102189 0039d316-1c4b-4281-b951-d872f2087c98

Chrome uses an explicit third_party copy of this library,
however, temporarily the nacl_integration_tests require the system
version to be installed to build sel_ldr.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2265
TEST=None
R=nfullagar@google.com
Review URL: http://codereview.chromium.org/7977035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102188 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7979033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102187 0039d316-1c4b-4281-b951-d872f2087c98

Make EntryKernel/Entry/BaseNode use base::Time instead of int64s.

Add sync/util/time.h, with utility functions to manage the sync proto
time format.

Store times on disk in proto format instead of the local system.
This requires a database version bump (to 77).

Update SessionChangeProcessor/SessionModelAssociator
to use base::Time, too.

Remove hackish Now() function.

Remove ZeroFields() function, and instead zero-initialize in EntryKernel::EntryKernel() directly.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7981006

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/7977034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102186 0039d316-1c4b-4281-b951-d872f2087c98

Make EntryKernel/Entry/BaseNode use base::Time instead of int64s.

Add sync/util/time.h, with utility functions to manage the sync proto
time format.

Store times on disk in proto format instead of the local system.
This requires a database version bump (to 77).

Update SessionChangeProcessor/SessionModelAssociator
to use base::Time, too.

Remove hackish Now() function.

Remove ZeroFields() function, and instead zero-initialize in EntryKernel::EntryKernel() directly.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7981006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102184 0039d316-1c4b-4281-b951-d872f2087c98

Instead add DemuxerStream::audio_decoder_config() to break FFmpegAudioDecoder's dependency on the AVCodecContext object maintained by FFmpegDemuxer.


Review URL: http://codereview.chromium.org/7867051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=no
TEST=no


Review URL: http://codereview.chromium.org/7982023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102182 0039d316-1c4b-4281-b951-d872f2087c98

make sure menus are shown rather then something meaningful.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7979021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102180 0039d316-1c4b-4281-b951-d872f2087c98