GitLab

Test test reads body right after receiving a response, but it leads to some
flakiness. It is not guaranteed that the response body is available at the
moment.

This change fixes the problem by reading response body after the loading
finishes.

BUG=675924
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2592663002
Cr-Commit-Position: refs/heads/master@{#439844}

The update icon in the system tray was small and blurry on 1x displays.

BUG=643401

Review-Url: https://codereview.chromium.org/2595623002
Cr-Commit-Position: refs/heads/master@{#439843}

Pass the URL instead of the VirtualURL to the native providers and the
webUI.

BUG=671964

Review-Url: https://codereview.chromium.org/2590803002
Cr-Commit-Position: refs/heads/master@{#439842}

Currently, we activate the time source as soon as one observer becomes
pending. If that observer is removed, the time source may currently do
an unneccessary tick, because we only deactivate the time source if
all observers were removed.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2591773002
Cr-Commit-Position: refs/heads/master@{#439841}

Disable WebViewClientTest testShouldOverrideUrlLoadingOnCreateWindow,
which has been flaky on L and N bot, and ServiceWorkerClientTest
testServiceWorkerClientInterceptCallback, which has been failing on N bot

BUG=659077, 675809

Review-Url: https://codereview.chromium.org/2590053002
Cr-Commit-Position: refs/heads/master@{#439840}

This CL makes use of the resetting function VariationParamsManager.
This should work now and therefore it is sufficient to hold the manager
as a simple member.

BUG=672010

Review-Url: https://codereview.chromium.org/2592663003
Cr-Commit-Position: refs/heads/master@{#439839}

Controlled by the NTPPreferAmpUrls feature, enabled by default.

BUG=668095
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2593573003
Cr-Commit-Position: refs/heads/master@{#439838}

Per the specs at go/fns-ui-spec, the "Login not secure" warning should
show up in username fields as well as password fields. Which makes sense
because usernames are sensitive information too. Thus, this CL populates
the "Login not secure" warning in the suggestions dropdown of a password
form regardless of whether the field is a password field or not.

BUG=675696
TEST=Enable #enable-http-form-warning in chrome://flags and relaunch
Chrome. Save a username/password in the Name/Password form in
http://rsolomakhin.github.io/autofill/. Focus the "Name" field and
observe a "Login not secure" warning in the autofill dropdown.

Review-Url: https://codereview.chromium.org/2585173006
Cr-Commit-Position: refs/heads/master@{#439837}

BUG=621548
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2313103002
Cr-Commit-Position: refs/heads/master@{#439836}

The LevelDB folder backing ModelTypeStore is inside Sync Data folder.
While this change is being driven by race conditions from sync trying
to delete this folder while it is being used, this setup is fundamental
flawed. The ModelTypeStores will hold model type specific information
that needs to be persistent across sign outs and disabling sync.

The approach this CL takes to fix this problem is the modify the
deletion logic to only affect the Directory (sqllite3) files. This
means that the Sync Data folder will still exist even when sync is off.

BUG=673508,673887

Review-Url: https://codereview.chromium.org/2568743004
Cr-Commit-Position: refs/heads/master@{#439835}

Android InputDevice sources are not represented by single set bits,
and so or'ing them together is not correct.

BUG=672907

Review-Url: https://codereview.chromium.org/2594733002
Cr-Commit-Position: refs/heads/master@{#439834}

MediaStreamAudioDestinationNode needs a constructor.  This was
inadvertently missed in issue 626449.

Also, modified the exception type when an invalid channel count is
specified.  All other AudioNodes throw NotSupportedError instead of
IndexSizeError.  This requires updating one test.

BUG=674508, 626449
TEST=constructor/mediastreamaudiodestination.html,
mediastreamaudiodestinationnode.html

Review-Url: https://codereview.chromium.org/2578243002
Cr-Commit-Position: refs/heads/master@{#439833}

BUG=chromium:468240

Review-Url: https://codereview.chromium.org/2592653002
Cr-Commit-Position: refs/heads/master@{#439832}

https://skia.googlesource.com/skia.git/+log/3711e1185d53..22f4a1fd4859

$ git log 3711e1185..22f4a1fd4 --date=short --no-merges --format='%ad %ae %s'
2016-12-20 robertphillips Remove getDevice_just_for_deprecated_compatibility_test()
2016-12-19 msarett Implement SkICC::WriteICC()
2016-12-19 brianosman Respect color space in GrTextureDomainEffect

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2596433002
Cr-Commit-Position: refs/heads/master@{#439831}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/54a5b164..8bf02eb7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2590233002
Cr-Commit-Position: refs/heads/master@{#439830}

BUG=671743

Review-Url: https://codereview.chromium.org/2559793002
Cr-Commit-Position: refs/heads/master@{#439829}

This patch is a preparation for a "badged icons" instead of green
checkmarks in the "persistence2" experiment.

Currently, TabbedPane.setTabIcon method accepts icon type and icon
titles. This works fine, but we'd like to pass in a more complex
objects - badged icons.

For this to work, the TabbedPane.setTabIcon has to accept general
instances of UI.Icon class.

BUG=675856
R=dgozman

Review-Url: https://codereview.chromium.org/2587293002
Cr-Commit-Position: refs/heads/master@{#439828}

When adding a bookmark with a non ASCII bookmark, a DCHECK was hit when
converting to UTF16.

BUG=675981

Review-Url: https://codereview.chromium.org/2590973002
Cr-Commit-Position: refs/heads/master@{#439827}

Change the share view animation from fade in/slide up to slide up/slide down.

BUG=672773

Review-Url: https://codereview.chromium.org/2593563002
Cr-Commit-Position: refs/heads/master@{#439826}

Using update-w3c-deps in Chromium d0059913.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7835

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2590903002
Cr-Commit-Position: refs/heads/master@{#439825}

Calling |ClearAllVariationParams| will now create a new instance of the
FieldTrialList so |SetVariationParamsWithFeatureAssociations| will
work again.

BUG=672010

Review-Url: https://codereview.chromium.org/2590883002
Cr-Commit-Position: refs/heads/master@{#439824}

BUG=675624

Review-Url: https://codereview.chromium.org/2589763002
Cr-Commit-Position: refs/heads/master@{#439823}

Test ChromeVisibilityObserverBrowserTest.VisibilityTest is flacky on Linux:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)
(32)/builds/36743/steps/browser_tests/logs/stdio

Actually problem on showing window after browser creation but it is better to
wait all async operations with RunLoop.

BUG=

Review-Url: https://codereview.chromium.org/2591783002
Cr-Commit-Position: refs/heads/master@{#439822}

Rebase protobuf to current HEAD to pull the 3 following changes:
* 4c5d3ed Fix integer overflow in FastUInt32ToBufferLeft
* 4587a3f [arm/gcc] Don't rely on KUSER_HELPERS feature for atomics
* a5a2c1d generic atomicops: Use strong compare_exchange

This change has been made following steps described in
third_party/protobuf/README.chromium file, please refer to it
for further information.

BUG=599051,673488

Review-Url: https://codereview.chromium.org/2495533002
Cr-Commit-Position: refs/heads/master@{#439821}

Rebaselines for this test should be complete.

BUG=673752
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2588033003
Cr-Commit-Position: refs/heads/master@{#439820}

These tests are flaky, and until we can figure out how to enable
retries only on this config, we should disable them.

BUG=674932
TBR=kbr@chromium.org,ynovikov@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2594713002
Cr-Commit-Position: refs/heads/master@{#439819}

BUG=582312

Review-Url: https://codereview.chromium.org/2589923002
Cr-Commit-Position: refs/heads/master@{#439818}

https://chromium.googlesource.com/angle/angle.git/+log/37ee8a6..f047097

BUG=chromium:671162

TEST=bots
NOTRY=true
TBR=geofflang@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2591793002
Cr-Commit-Position: refs/heads/master@{#439817}

The code generator wrongly uses `Nullable<Callback*>` when nullable
callback functions are used like below:

callback C = void();
interface I { void f(C? callback); }

Since C++ impl of callback functions are garbage collected types,
we can just use `Callback*`.

BUG=675859

Review-Url: https://codereview.chromium.org/2588303002
Cr-Commit-Position: refs/heads/master@{#439816}

Combine duplicated method logic. Add unittest to ensure activity stops
when webState is deallocated.

BUG=none

Review-Url: https://codereview.chromium.org/2587173002
Cr-Commit-Position: refs/heads/master@{#439815}

Its last caller was removed in r306479.

BUG=556939

Review-Url: https://codereview.chromium.org/2586413002
Cr-Commit-Position: refs/heads/master@{#439814}

I added parentheses to the frame calculation expression to work around
clang-format issues, but I added them in the wrong place and made the math
wrong.  This CL removes the parentheses and restores the original expression.

BUG=675595

Review-Url: https://codereview.chromium.org/2590223002
Cr-Commit-Position: refs/heads/master@{#439813}

Creating a wrapper might fire events synchronously which in turn can
modify the wrapper. There is, however, an invariant for interceptors
that if they modify their holder, they need to signal this. Therefore,
when we create a wrapper, always signal that the write happened.

BUG=670155
R=tkent@chromium.org,haraken@chromium.org

Review-Url: https://codereview.chromium.org/2566663002
Cr-Commit-Position: refs/heads/master@{#439812}

The HTMLMediaElement no longer adds the MediaControls to the shadow tree
in order to prepare for the class to be an interface implemented by
modules. This CL also removes a couple of reset() call.

BUG=662761
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2588823002
Cr-Commit-Position: refs/heads/master@{#439811}

Revert of Maintain HostZoom connection per-frame on browser side (patchset #4 id:100001 of https://codereview.chromium.org/2581143002/ )

Reason for revert:
Seems to cause problems on Mac:

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Mac10.10%2F28001%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout

Original issue's description:
> Maintain HostZoom connection per-frame on browser side
>
> HostZoomMapObserver is a per-WebContents class, while the HostZoom Mojo
> connection is per-frame. Before this CL, HostZoomMapObserver was
> maintaining one HostZoom connection and rebinding it every time a new
> RenderFrame was created. This meant that HostZoomMapObserver was
> continually losing connections to existing frames. This CL changes
> HostZoomMapObserver to maintain one connection per-RenderFrame in a
> map indexed by the corresponding RenderFrameHost.
>
> BUG=673065
> TEST=Visit news.ycombinator.com and increase the zoom level to 175%.
> Click the top link. Hit back: news.ycombinator.com should still be
> zoomed to 175%.
>
> Committed: https://crrev.com/8e24b7d133424fb221891601d6254b7df58188d5
> Cr-Commit-Position: refs/heads/master@{#439800}

TBR=scottmg@chromium.org,wjmaclean@chromium.org,nick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=673065

Review-Url: https://codereview.chromium.org/2595603002
Cr-Commit-Position: refs/heads/master@{#439810}

TBR=eae,kojii

Review-Url: https://codereview.chromium.org/2590213002
Cr-Commit-Position: refs/heads/master@{#439809}

BUG=648557

Review-Url: https://codereview.chromium.org/2586363002
Cr-Commit-Position: refs/heads/master@{#439808}

Remove a TODO that I left before because I confirmed that
current code is correct, and chaging it makes many unit tests
fail.

BUG=670232

Review-Url: https://codereview.chromium.org/2587323002
Cr-Commit-Position: refs/heads/master@{#439807}

Now, core/fetch has a dependency to bindings/core/, but this won't be
permitted once the directory is moved to platform/loader/fetch.

This patch moves this last unexpected dependency, and make it
finally possible to move under platform/.

BUG=655920

Review-Url: https://codereview.chromium.org/2578983002
Cr-Commit-Position: refs/heads/master@{#439806}

This were reviewed upstream in https://github.com/w3c/csswg-test/pull/1155

This should reduce the noise in https://codereview.chromium.org/2450093005, and
make it more manageable and straight-forward to review.

BUG=657748

Review-Url: https://codereview.chromium.org/2588093003
Cr-Commit-Position: refs/heads/master@{#439805}