GitLab

BUG=602666

Review-Url: https://codereview.chromium.org/2577703002
Cr-Commit-Position: refs/heads/master@{#438809}

totalRtt and currentRtt have been renamed in the spec to
totalRoundTripTime and currentRoundTripTime:
https://w3c.github.io/webrtc-stats/#since-21-sep-2016*

Both old and new names are whitelisted until
https://codereview.webrtc.org/2576383002/ has rolled into Chromium.
When the roll is done old names will be removed.

BUG=chromium:627816

Review-Url: https://codereview.chromium.org/2577923004
Cr-Commit-Position: refs/heads/master@{#438808}

BUG=609747

Review-Url: https://codereview.chromium.org/2584503002
Cr-Commit-Position: refs/heads/master@{#438807}

BUG=671080,674434
TEST=manually tested by modifying chrome.storage API to return errors and
confirming that Files app works properly with default options.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2578863003
Cr-Commit-Position: refs/heads/master@{#438806}

BUG=673711

Review-Url: https://codereview.chromium.org/2580743002
Cr-Commit-Position: refs/heads/master@{#438805}

https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer/+log/2ed967c..f2488e1

R=aizatsky@chromium.org, inferno@chromium.org, kcc@chromium.org, ochang@chromium.org
BUG=539572,674060

Review-Url: https://codereview.chromium.org/2570203003
Cr-Commit-Position: refs/heads/master@{#438804}

Enhance the chrome.app.window API for shelf integration with the possibility of
restoring showInShelf=true pinned windows.

Based on https://codereview.chromium.org/2341643002

Co-Authored-By: Valentin Ilie <valentin.ilie@intel.com>;

BUG=610299

TEST = https://codereview.chromium.org/2297633002

Review-Url: https://codereview.chromium.org/2523053004
Cr-Commit-Position: refs/heads/master@{#438803}

BUG=674468
TBR=schenney@chromium.org

Review-Url: https://codereview.chromium.org/2575383003 .
Cr-Commit-Position: refs/heads/master@{#438802}

Initial patch to remove implicit conversions.

This CL adds following utf16 conversion methods and use
them in blink_platform_impl.cc to show how it'd look like.

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

BUG=667131

Review-Url: https://codereview.chromium.org/2571863003
Cr-Commit-Position: refs/heads/master@{#438801}

generate_indented_conditional() still indented code
by 4 spaces.  This CL changes to be 2 spaces to follow
chromium like style change.

BUG=None

Review-Url: https://codereview.chromium.org/2584443003
Cr-Commit-Position: refs/heads/master@{#438800}

BUG=674466
TBR=tkent@chromium.org

Review-Url: https://codereview.chromium.org/2572413003 .
Cr-Commit-Position: refs/heads/master@{#438799}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4e3a6669..8cc65d64

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2578083002
Cr-Commit-Position: refs/heads/master@{#438798}

Made -webkit-print-color-adjust property independent. Also updated
independent-inheritance-fast-path.html to include webkitPrintColorAdjust.
Also minor cleanup of make_computed_style_base.py, including removing a
redundant if and assignment to property_name.

Tested using independent-inheritance-fast-path.html.

BUG=628043

Review-Url: https://codereview.chromium.org/2578903002
Cr-Commit-Position: refs/heads/master@{#438797}

BUG=671137

Review-Url: https://codereview.chromium.org/2572773002
Cr-Commit-Position: refs/heads/master@{#438796}

Make styled-label trimming less aggressive - now when wrapped on \n, only this \n is removed, not all whitespace sequence. This allows whitespace
"formatting" like line indentation with spaces. Also makes double newline behave like expected - insert an empty line between text before and after \n\n.
Syled label layout loop refactored to de-duplicate code.
Added tests coverage for styled label.
Fixed LegalMessageLine comment - no longer have to explain that it is based on styled_label with some caveats.

R=sky@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2348433002
Cr-Commit-Position: refs/heads/master@{#438795}

In some circumstances, the minimum font-size would be applied to the
"scaled font", messing up rendering. Because of how the font is scaled,
this would trigger much less than one might expect.
Change the useSmartMinimumForFontSize argument to the
FontSize::getComputedSizeFromSpecifiedSize function to be about entirely
ignoring the minimum font-sizes (this function only has two callsites.)
Refactor LayoutSVGInlineText::computeNewScaledFontForStyle a bit to deal
with this new flow. Also always keep the "original" font when we compute
a scale factor of 0 - it should be invisible regardless.

BUG=232332,335725,475795,626936,664961
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2575863002
Cr-Commit-Position: refs/heads/master@{#438794}

Reading list was not added to the possible selected options for sync.
This CL fixes it and add an histogram for the reading list sync option.

BUG=669393

Review-Url: https://codereview.chromium.org/2548413002
Cr-Commit-Position: refs/heads/master@{#438793}

- Remove unused using statements
- Remove unnecessary content::
- Include resource_type.h where IsResourceTypeFrame() is used
- Use IsResourceTypeFrame() where we can

R=reillyg@chromium.org,mmenke@chromium.org,mattm@chromium.org,treib@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2576663004
Cr-Commit-Position: refs/heads/master@{#438792}

This should mitigate a bug that FirstMeaningfulPaint is reported too
soon (or not reported) on some CPU-heavy pages, because network idle is
detected while CPU is busy running scripts.

BUG=659021,674228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2581633002
Cr-Commit-Position: refs/heads/master@{#438791}

Oilpan's per-thread heap mode is already shipped for workers and we no longer
have to run the tests on both BlinkGC::MainThreadHeapMode and
BlinkGC::PerThreadHeapMode.

BUG=674400

Review-Url: https://codereview.chromium.org/2578053002
Cr-Commit-Position: refs/heads/master@{#438790}

Add temporary empty targets for each of the targets that will exists
upstream one the upstreaming process is complete.

Add "all_tests" targets for each directory that will contains test
targets, and change //ios:all to depend on them instead of depending
on the individual test targets.

Move ios_chrome_unittests target definition from ios/chrome/BUILD.gn
to ios/chrome/test/BUILD.gn.

BUG=None

Review-Url: https://codereview.chromium.org/2570523002
Cr-Commit-Position: refs/heads/master@{#438789}

R=jochen@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2572513004
Cr-Commit-Position: refs/heads/master@{#438788}

Various hasPendingActivity() overrides weren't taking the state of the
ExecutionContext into account, only considering if event listeners were
registered. We're not interested in holding onto a script environment
after an execution context has been destroyed, so adjust the predicates
to return false if the ExecutionContext has been destructed.

The V8GCController wrapper visitors already check if hasPendingActivity()
implementations incorrectly return |true| when used inside of destroyed
ExecutionContexts, but that check is not handled by trace wrappers
(ActiveScriptWrappable.)

R=
BUG=

Review-Url: https://codereview.chromium.org/2571193002
Cr-Commit-Position: refs/heads/master@{#438787}

Currently we force online login for legacy supervised users when the oauth
token becomes invalid. However there is no online login for legacy supervised
users - we just print a cryptic error message, and there is no way to refresh
this oauth token, so the account is effectively locked.

BUG=chromium:659788
TEST=manual

Review-Url: https://codereview.chromium.org/2563573002
Cr-Commit-Position: refs/heads/master@{#438786}

https://crrev.com/2445223002 Removed a redundant layout test
editing/spelling/markers.html but forgot to remove its expected.txt file.
This patch does that.

TBR=yosin@chromium.org
BUG=n/a

Review-Url: https://codereview.chromium.org/2581473003
Cr-Commit-Position: refs/heads/master@{#438785}

BUG=674049

Review-Url: https://codereview.chromium.org/2580453002
Cr-Commit-Position: refs/heads/master@{#438784}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/027994b8..4e3a6669

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2575413002
Cr-Commit-Position: refs/heads/master@{#438783}

Cr-Commit-Position: refs/heads/master@{#438782}

Move the inherited property text-align and its enum, ETextAlign,
to be generated in ComputedStyleBase. Also moved getter / setter /
initial value methods to be generated in ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2577973002
Cr-Commit-Position: refs/heads/master@{#438781}

This change eliminates the property that non-singleton services are
owned by the first service that connects to them. Instead, singleton
and non-singleton services are treated identically by the Service
Manager: they go away either (1) when the service requests so or
(2) when the Service Manager itself goes away.

The motivation for this change is that (a) there are situations where
this "tree ownership" model doesn't make sense (see linked bug), and
(b) there is nothing currently in the codebase that is utilizing the
tree ownership model. If desired, the tree ownership model could be
resurrected on a per-service basis by adding a "session manager" attribute
to a service's manifest, which would denote that that service should own
all of the services that it directly or transitively connects to.

This CL also changes Service Manager's destructor to perform
two-phase shutdown on its owned Instances. This change eliminates
possible deadlock in the following situation:
- An Instance A blocks in its destructor for its Runner to complete
- That Runner blocks completion on the corresponding Service A shutting down
- Service A blocks its shutdown on some distinct Service B shutting down
- Service B is waiting to receive a connection error in order to initiate
  shutdown
- ServiceManager never deletes Instance B since it is blocked waiting for
  the destructor of Instance A to return

An example of such a situation is found in connect_test_package.cc:
ConnectTestService clears its ProvidedService instances in its OnStop() method,
while ProvidedService does not exit its destructor until it receives a
connection error. Before this CL, deadlock was not tickled because the
ProvidedServices were always killed when the first service that
connected to them was killed, which happened to be before ConnectTestService
was killed.

BUG=672863

Review-Url: https://codereview.chromium.org/2572803002
Cr-Commit-Position: refs/heads/master@{#438780}

The main change is to use base::LaunchUnitTestsSerially as a test runner
so it can parse some command-line arguments the isolate test runner
passes in.

BUG=663126
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2521793002
Cr-Commit-Position: refs/heads/master@{#438779}

JumpListIcons(Old) folders are getting unexpectively huge for some users.
This is caused by file operation failures.

After analyzing those two folders' operation metrics by landing several changes,
we find that there are a few issues that need to be fixed.

1) base::CopyDirectory() in file_util_win.cc has incorrect logic when target
dir string contains source dir string. Please see detailed comments in the code,
2) When it fails to delete folder |JumpListIconOld|, we should not move
folder |JumpListIcon| to |JumpListIconOld|, otherwise |JumpListIconOld| can
get unexpectedly huge eventually.
3) When it fails to move folder |JumpListIcon| to |JumpListIconOld|, we
should still delete |JumpListIcon| to avoid endless file accumulation in it.

To fix the first issue, IsParent() function is used in file_util_win.cc to
replace the old logic. I have tested it in a previously checked-in CL.
The gathered user data confirms its correctness. It can be found in line
370 of the old version of jumplist.cc in this CL. In that version, I copied
and changed a few file operation functions from //base for debugging and
testing purposes.

We still log one kind of user data for verification and further analysis.

This CL also reverts several changes I made for debugging purpose.

BUG=40407,179576
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2570693002
Cr-Commit-Position: refs/heads/master@{#438778}

https://pdfium.googlesource.com/pdfium.git/+log/37b12ad87319..72a22025ec44

$ git log 37b12ad87..72a22025e --date=short --no-merges --format='%ad %ae %s'
2016-12-14 tsepez Remove unused m_OtfFontData.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2575393002
Cr-Commit-Position: refs/heads/master@{#438777}

"Show Google Now cards" option should populate when it is enabled in field trial
and the default search provider is google.

BUG=614439
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2572963004
Cr-Commit-Position: refs/heads/master@{#438776}

This CL adds blendMode field to EffectPaintPropertyNode, upgrades
PaintPropertyTreeBuilder to create effect nodes if CSS mix-blend-mode is
applied to an element and ensure propery isolation on the parent, and adds
corresponding conversion in PaintArtifactCompositor.

BUG=609937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2564193002
Cr-Commit-Position: refs/heads/master@{#438775}

From video_decode_accelerator.h, it's not clear if it's valid to
call Reset before NotifyFlushDone. Currently ARC may call Reset
before NotifyFlushDone is back. We need to document this and add
a test for it.

BUG=671944
TEST=None

Review-Url: https://codereview.chromium.org/2556873003
Cr-Commit-Position: refs/heads/master@{#438774}

Fixed typo in quick view for no playback available message to have proper margin between the icon.

BUG=None
TEST=manually.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2562023002
Cr-Commit-Position: refs/heads/master@{#438773}

As a part of "Persistence" plan, the UISourceCode.checkContentUpdated
method should move away from UISourceCode.

This CL is a preparation for this. This patch kills a few clients of the
method, since they are not needed any more:
1. SourcesSearchScope shouldn't be forcing checkContentUpdated during search,
   it can simply request content
2. The UISourceCodeFrame shouldn't request content on focus - the iNotify
   reports changes while devtools are blurred.

BUG=673086
R=dgozman

Review-Url: https://codereview.chromium.org/2567283004
Cr-Commit-Position: refs/heads/master@{#438772}

As part of this, starts allocating a transform node to represent direct
compositing of will-change:transform elements and their stacking children.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2571043002
Cr-Commit-Position: refs/heads/master@{#438771}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5ba6e0d1..027994b8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2580723002
Cr-Commit-Position: refs/heads/master@{#438770}