- 03 Oct, 2019 40 commits
-
-
Fredrik Söderquist authored
This reworks the way the interval is updated when the animation target changes. The code to handle "connect" and "disconnect" from the time container is moved into new methods AddedTo/RemovedFromTimeContainer(), which does tasks that was previously sprinkled about in SetTargetElement() and InsertedInto() and SMILTimeContainer::Schedule(). The call to ResetCachedAnimationState() in SVGAnimateElement is moved to the "removal" side since we now revalidate the animation state via SVGSMILElement::DidChangeAnimationTarget(). Bug: 998526 Change-Id: Ib6e847330cebc503cbca4a7cbd308b7a7ccc733a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837832Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#702513}
-
Nicolas Boichat authored
These bases should be treated as an internal device. (Also, reorder the list to sort by VID/PID and fix Whiskers device name) Bug: b/139521914 Change-Id: I12f58d72d4e6a30c8077ec0eb577d00cd77697ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833033Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702512}
-
Hiroshige Hayashizaki authored
1. Previously, `@std/foo` bare specifiers are implemented by mapping them into `import:@std/foo`, but this caused allowing users to specify `import:@std/foo` URLs directly. This CL instead maps `@std/foo` to `std:foo`, and removes `import:` from the implementation, blocking any `import:` URLs. 2. Also, this CL centralizes the `@std/` URL processing into ParsedSpecifier::Create(), and plumbs a `support_builtin_modules` flag. The new plumbing code is needed because we no longer assumes built-in module support in import maps (Issue 1010751). Bug: 1010751 Change-Id: I49f8987867343542a4503d4e0446cfd49e0c4aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836671Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#702511}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/0cd9a67ce84f..99938eab593d git log 0cd9a67ce84f..99938eab593d --date=short --no-merges --format='%ad %ae %s' 2019-10-03 digit@google.com [vulkan]: Implement VkSemaphore using Marl primitives. 2019-10-02 capn@google.com Fix integer overflow in image size calculation 2019-10-02 capn@google.com Verify the commit message has a Bug: line 2019-10-02 chrisforbes@google.com Consider all faces in TextureCubeMap::hasNonBaseLevels() 2019-10-02 chrisforbes@google.com Fix edge cases of creating EGLImages from cubemap faces 2019-10-02 sugoi@google.com Strict weak ordering for SamplingRoutineCache::Key 2019-10-02 chrisforbes@google.com Fix eglCreateImageKHR error logic for level=0 2019-10-02 swiftshader.regress@gmail.com Regres: Update test lists @ 0cd9a67c Created with: gclient setdep -r src/third_party/swiftshader@99938eab593d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140421726,chromium:b/140421004,chromium:b/141892461,chromium:b/141916742,chromium:b/141916742,chromium:b/141916742 Change-Id: Ibe948614dc3ec2bbce3c3245602e69797df8b8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837256Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702510}
-
Nina Satragno authored
Bug: 1011029 Change-Id: I0828fd90ad18d6233a61c9e58c600485f71eef76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838353 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#702509}
-
Fabrice de Gans-Riberi authored
This is a reland of 304c2408 Original change's description: > [fuchsia] Implement per-app remote debugging in CastRunner. > > * Handle the |enable_remote_debugging| parameter in > chromium.cast.ApplicationConfig to enable per-app remote debugging > in CastRunner. > * Set the CastRunner debugging port to 9222. > * Remove a buildflag to enable remote debugging Context-wide. > * Add a test to check remote debugging is properly enabled per-App. > > Bug: 997895 > > Change-Id: I19aced4e90790e77cc3f55b1118fbf459ae19b14 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773707 > Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702264} Bug: 997895 Change-Id: Ife9ac25676dbae1866a71cf2445899973f2e9962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837487Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#702508}
-
Ian Kilpatrick authored
Today we can end up in a state where the layout result cache for a LayoutBox contains a fragment tree which doesn't match the layout tree state. This occurs when we "abort" layout, i.e. 1) during the first pass children are positioned at a particular offset 2) a parent aborts layout due to resolving a BFC offset 3) the parent hits the layout result cache which has children at a different offset Bug: 1003558 Change-Id: Iabc5dfefd74c517222ec435cea376ad000a0372f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821674Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#702507}
-
Vladimir Levin authored
This patch adds an extra parameter to internal IntersectionObserver::Create to allow for possibility of delivering notifications via PostTask. R=szager@chromium.org Change-Id: I19bb463509e266a8f9bc68c592cd32ad6380d9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836902Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#702506}
-
Juanmi Huertas authored
This reverts commit 71af7965. Reason for revert: We found a better solution than the revert so we are reverting the revert. Original change's description: > Revert "Fixing ShouldAccelerate to preserve acceleration" > > This reverts commit 0e20fdf5. > > This reverts a fix that will be reintroduced later on once we add > the WillReadFrequently to the creation of canvases. > > Bug: 1001845, 983642, 1008179 > Change-Id: I4e5aa58af69e1b202962eee37177e5cd0401c9a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829794 > Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702174} TBR=fserb@chromium.org,juanmihd@chromium.org Change-Id: Ic6c7dc0b6fa30d741f8e7de00c127673933cd7f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001845, 983642, 1008179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838372Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#702505}
-
Yulun Wu authored
Bug: 1010724 Change-Id: If783bd10bba4157bcd5c1a18337d524eb26e62d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836276 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#702504}
-
Matt Menke authored
Also fix the LoadingPredictor tests that failed when it was enabled. Bug: 963480 Change-Id: I4c8d87d0d97bfd4e8e4e639921da4cd4f908ca5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832248 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#702503}
-
Christopher Cameron authored
This is no longer needed, as we now only do mojo over mach. TBR=rsesek Bug: 942213 Change-Id: I677e1e405dbfe47ff5917743943fcdf9995a6668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837376Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#702502}
-
Bettina authored
Expand phishguard to show warnings on saved password reuse on phishing sites. Bug: 1010764 Change-Id: I7ea4f49ab6afaac8d2229a011356d77f35d10612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837092 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#702501}
-
Tim van der Lippe authored
After converting the `ui/` folder to ESM, there was a significant performance regression in terms of file size of the `resources.pak`. It turns out that we were not minifying ESM files, but we did do that before with Closure. Update the `copy_devtools_modules` to also invoke rjsmin to minify the JavaScript source code. Before: $ du -h -B K out/Default/resources.pak 12096K out/Default/resources.pak After: $ du -h -B K out/Default/resources.pak 11752K out/Default/resources.pak Before the original CL transforming `ui/` landed: $ du -h -B K out/Default/resources.pak 11860K out/Default/resources.pak This means that after converting `ui/` to ESM, we saved 90KB. We suspect this is because we are no longer transpiling to ES5, but instead serve source ES6. Bug: 1010910 Change-Id: I7dd07ff788d014e9f9a8e25e168c58c010cd00af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837814 Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#702500}
-
Hiroshige Hayashizaki authored
This CL adds ImportMaps feature separetely from BuiltInModuleInfra, to enable import maps separately from built-in modules. This CL only does very basic migration from BuiltInModulesInfra flag to ImportMaps flag. Subsequent CLs will implement more logic to disable built-in module-related things when ImportMaps && !BuiltInModulesInfra. Bug: 1010751 Change-Id: Iec722de822750b60a7dcfbf70910338bbdd4aa9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836600Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#702499}
-
Varun Khaneja authored
See discussion here: http://shortn/_slnTdcsaT9 R=bdea, dvadym Bug: 1010158 Change-Id: Ib8c881acf825078ed0471e9a838e678ecccb15c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832408 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#702498}
-
Tibor Goldschwendt authored
This is a reland of d205c616 Original change's description: > Add native resource to dummy module and test loading in smoke test > > * Adds a new PAK file with a dummy resources. > * Refactors the TestDummyModuleProvider to to synchronously load the > module PAK file when retrieving the impl. > * Adds a friend to ScopedAllowBlocking in order to be able to memory > map the module PAK file on the main thread. > > Change-Id: I0a3b949b83b37a7089aa410a691de6ae28f9a36a > Bug: 989646 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822847 > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Reviewed-by: Fred Mello <fredmello@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702423} TBR=twellington@chromium.org,cjgrant@chromium.org,dcheng@chromium.org,agrieve@chromium.org,huangs@chromium.org,fredmello@chromium.org Bug: 989646 Change-Id: Ifab13d56aead63532ab57000e7253d0ce89f75b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837485Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702497}
-
Matthew Jones authored
Failures as a result of https://chromium-review.googlesource.com/c/chromium/src/+/1833821 Couldn't revert offending patch because of a merge conflict. See bug for more details. TBR: mvanouwerkerk@chromium.org, alexchau@chromium.org Bug: 1010998 Change-Id: I007565f9bb8f769b4afa69ab6895b4cf07865027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836995Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#702496}
-
Jon Mann authored
TBR=treib@chromium.org Bug: 966270 Change-Id: I2a210207d19471f56295f2a7e967fdf8ac01214f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819496 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#702495}
-
Patrick To authored
OpenXR currently uses the XR_REFERENCE_SPACE_LOCAL space to send the transformation matrix back. This is incorrect because the head corresponds to XR_REFERENCE_SPACE_VIEW, and the orientation also needs to be added to the transformation matrix. This change queries the views based at the XR_REFERENCE_SPACE_VIEW space and returns the transformation matrix containing the position and orientation back to blink. Bug: 999573 Change-Id: I365b1346f15f4d48dfad85dc1df4d0039d9b8c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828721 Commit-Queue: Patrick To <patrto@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#702494}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/448444596bbc..687249cc9ed7 git log 448444596bbc..687249cc9ed7 --date=short --no-merges --format='%ad %ae %s' 2019-10-03 primiano@google.com GN: fix cross-compilation support 2019-10-03 fmayer@google.com Merge "Alow to set BufferExhaustedPolicy in client API." 2019-10-03 taylori@google.com Merge "perfetto-ui: Go to CPU sched slice" Created with: gclient setdep -r src/third_party/perfetto@687249cc9ed7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:141319350 Change-Id: I876bd09caa1f46e7f622d4fdcaa183ec232c7036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702493}
-
zhaoyangli authored
- Added test method setups in |-appLaunchManagerDidRelaunchApp| in |ChromeTestCase|, which will do resets and open a new tab after app is relaunched. Introduced a flag in |ChromeTestCase| to prevent these setups from called twice after one relaunch. - Added in smoke test to test if new tab is opened after relaunch. - Remove user's [ChromeEarlGrey openNewTab] call after calling |ensureAppLaunchedWithFeaturesEnabled|. Bug: 922813, 1004565 Change-Id: I525fb7492777fdd29b9491a2d6927b64fd58df7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835022 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#702492}
-
Peter Kasting authored
Bug: 1005568 Change-Id: I2843b0da4c1e343f1493f0892cad2c7ddfc5a56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836669 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#702491}
-
Tommy Steimel authored
This CL adds track kind marker styling to the Media Controls CSS that was never copied over from the legacy controls CSS. Bug: 933000 Change-Id: Ie4fc1c5a7706664a9afff841c5ccc47399dbb4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829278Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#702490}
-
Yi Gu authored
The HitTestDataChangeObserver requires a clean state of HitTestData before any change happens. Previously we didn't check whether child1's hit test data are ready or not. If its data arrive after the pointer events change, the HitTestDataChangeObserver will not work properly. Bug: 968970 Change-Id: Ib00a324ff0960c85c98c7f0800ef300cc4ebddd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837147Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702489}
-
Devlin Cronin authored
These methods (originally added in crrev.com/ef8f0ca9) were used to mark which apps had been re-ordered on the NTP. The preference is no longer checked anywhere. Remove both the setter and getter, and add the preference to the list of obsolete preferences to remove. Bug: None Change-Id: Ife36753fb52b5ede503fab02c839a3bf13fed824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836020Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702488}
-
Brandon Wylie authored
The current fakebox focus animation makes the G slightly visible to the left (in LTR mode) of the omnibox background. This insets the G a bit, which makes it animate within the omnibox background. Bug: 988883 Change-Id: I7fcd782feb9ab593b31d0c56aa4481fd9c37f025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832706Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702487}
-
Bettina authored
The code assumes that whenever the signed-in non-sync user clicks on "protect account" that they are automatically recorded by the security event recorder. However, the code needs to make sure that the account is the unconsented primary account. Thus, to prevent confusion in the metrics, only log the action when we can actually mark the account at risk. Bug: 914410 Change-Id: I52fc1c8432ab64da37a6526f2d1dcfe1713c3279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834848Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#702486}
-
Kevin Bailey authored
When keyword mode has been explicitly entered, and experimental keyword mode has been enabled, we don't want document suggestions (unless its search provider matches the keyword provider). Without this restriction, these suggestions tend to show up when we're only expecting keyword suggestions, since they rank highly. Bug: 837395, 883901 Change-Id: If821f0efa8e3ffb6b05555ec6455849dc1d7f059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825779 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#702485}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/16438a83d608..880a3f812b03 git log 16438a83d608..880a3f812b03 --date=short --no-merges --format='%ad %ae %s' 2019-10-03 ahassani@chromium.org Revert "chromeos_config: Mark lakitu paladin builders experimental" 2019-10-03 saklein@chromium.org packages service: Add builds method. 2019-10-03 saklein@chromium.org cros_install_debug_syms: fix parallel installation 2019-10-03 lamontjones@chromium.org PRESUBMIT.cfg: verify that we work with signer. Created with: gclient setdep -r src/third_party/chromite@880a3f812b03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibb4360808f68eae8fa2c49582232f8cfdb1faa59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837574Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702484}
-
Michael Thiessen authored
This function is a large, and hard to follow. I'm hoping to break out a bunch of functions that are clearer about what they're doing and make ordering clearer. In this change I do fix an exception handler to actually catch the exception it was intending to catch (and you can easily repro the crash by disabling the targeted Activity while the leaving Chrome alert dialog is up). I also make sure that when we fail to show the alert dialog for reasons other than a BadTokenException, we also propagate this back so we don't get into a state where we report an async action action is taking place when it isn't. Bug: 1006927 Change-Id: Ie09214f64ead85c31fb8e83e187878d984f2afc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835144Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#702483}
-
Steven Bennetts authored
This CL ignores Device PropertyChanged updates sent before the initial GetProperties request is received. It fixes an edge case triggering a DCHECK when the |type| property is not set yet (it is set when the initial properties are received). Bug: 1008193 Change-Id: I1a32578ba8a9f5ae7deda53c27c9c2fc8556e0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836178Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702482}
-
Xing Liu authored
This CL removed the unused delegate class for ImpressionHistoryTracker. Bug: 965133 Change-Id: I0463a99f4dc7344c66533b4881fec5fe8fa6393a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832711Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702481}
-
Lorne Mitchell authored
The resource types weren't localizable. This change fixes this by calling ls`` on each resource type in ResourceType.js. In addition, the tooltips for the record and search buttons. These were already localizable, but the module title descriptor wasn't running through ls(). Bug: 941561 Change-Id: I1d2a035bd2f763597458ab463c4343edc8a9337c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791440Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702480}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6cf9a9ef99f7..ab5d4d490562 Created with: gclient setdep -r src-internal@ab5d4d490562 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ie5212cdf6618e6d6e0b0862f48291f91ed72d0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837276Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702479}
-
Lei Zhang authored
It's unused. Change-Id: Ic108d486fac11e5d5ee7615c076d78173a4352d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835175Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#702478}
-
Matt Menke authored
A lot of these were left around after code was updated to use the network service. This CL particularly focuses on test_url_fetcher_factory.h includes. This CL also removes "using base::TimeDelta" from url_request_test_util.h, which also affects a couple files with the unnecessary includes. Bug: None Change-Id: Id3f104bf43fd935c692497dd0e00e669271323d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836512Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#702477}
-
Matt Menke authored
The unpredictable nature of when the favicon fetch occurs was causing the fetch to fail. This CL prefetches it, so it will be cached. Bug: 1006637 Change-Id: I2d16fa80b3ffe05c1cc6e21437c9a8a95dbd8bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835092 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702476}
-
Jakob Gruber authored
With the recent port of the streams API to C++ [0], the natives blob is now unused and will shortly be removed. V8 API related to the natives blob is being deprecated [1] and will be removed in the next release. This CL is the minimal change to keep up with these API deprecations. In follow-up work, all other infrastructure related to the natives blob should be removed. [0] https://crrev.com/c/1746118 [1] https://crrev.com/c/1824944 Bug: v8:7624 Change-Id: I26e409660d177035cdb5d92c317fc2e0174be2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834352Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#702475}
-
Matt Menke authored
A bunch of tests were instantiating them but not using them, so also remove the classes from those tests. TBR=lambroslambrou@chromium.org TBR=rogerm@chromium.org TBR=dvadym@chromium.org TBR=hendrich@chromium.org Bug: 1010491 Change-Id: I0528cd61f69e0010eefa45f5c65edf63a09fc6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834926 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#702474}
-