GitLab

if the options don't match.

Bug: 925297
Change-Id: Ibb92dd0eb7ccedf9f6c235439fc82a903b613854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660553
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672143}

Presently, we call .mutate() on a potentially null icon. In
these cases, we should instead clear the icon.

Bug: 966909
Change-Id: I6181c72d29ef15dfd543affcd7b8b38a664eef95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676724Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672142}

Replace it with an observer interface on GlobalErrorService.

Change-Id: Ief1d6c231684e886a17931be7355ca6a6cabda72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670054
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672141}

Refactor to |base::OnceCallback| where possible.
Explicitly use |base::RepeatingCallback| where it isn't.
Leave as is if depends on API that should be updated.

Bug: 968109
Change-Id: I21262a79e87c182ed1a2d9287f67a748a95f6ebf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662549Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672140}

Using wpt-import in Chromium 3792d868.
With Chromium commits locally applied on WPT:
9e3affdd "Ship `referer` header length limitation."
845a980a "KV Storage: add timeout=long and reenable disabled test"
73b57b36 "Add sec-metadata test when updating a service worker"
58b8718f "KV Storage: update to match IDL"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
cbiesinger@chromium.org:
  external/wpt/css/css-flexbox
drott@chromium.org:
  external/wpt/css/css-text-decor
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
kojii@chromium.org:
  external/wpt/css/css-rhythm
  external/wpt/css/css-text/line-break
  external/wpt/css/css-writing-modes
kojii@chromium.org, mstensho@chromium.org:
  external/wpt/css/CSS2
rego@igalia.com:
  external/wpt/css/css-contain
  external/wpt/css/css-grid
  external/wpt/css/css-ui

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I59c1e24113b5ee82be67b4bed81b870aef1c9ae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675689Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672139}

Creates vulkan_swift_shader_blink_web_tests

This adds a variant of blink_web_tests to the Chrome-GPU
FYI bot: "Linux FYI SkiaRenderer Vulkan (NVIDIA)"

This will allow us to get correctness coverage of
SkiaRenderer+Vulkan until we have bots setup that can run
the native Vulkan.

This change adds a new FlagExpectations file to represent
the failures occurring with Vulkan, which pass with GL.
While also updating the skia_renderer_blink_web_tests to
properly respect the SKIP expectation.

Documentation on FlagExpectations has been updated to
reflect how to mix expectations with test lists, while
actually skipping tests.

TEST=vulkan_swift_shader_blink_web_tests

Bug: 969824
Change-Id: I8dec7f9e1c921868b2216efb0bd63ea952fc6dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652791
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672138}

On IDBObjectStore and IDBIndex instances, the keyPath property says is
defined in the spec with: "if this attribute returns an object
(specifically an Array), it returns the same object instance every
time it is inspected". Web platform tests for this were missing.

Since the property is 'any' in Web IDL (since it could be a string or
Array) it can't use the [SameObject] extended attribute. And in the
Blink IDL, it can't use the [SaveSameObject] hint since that requires
[SameObject]. Instead, use the [CachedAttribute] hint and never dirty
the cache.

Bug: 977048
Change-Id: Ic4ede31a3a01e7a8a90c4f54eb8a989a673fcf22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674495
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672137}

TBR=rsleevi@chromium.org

Change-Id: I53712d04cad1fcc93e68125a0c76c9154c71c299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673537Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672136}

Change-Id: Ic629921bdc6280c19a9c2d0962bbfa37faba70fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670117
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672135}

The current tests do not evaluate the case of opening as 'peeking'
and then expanding to fullscreen to see all applications. This
can have different performance characteristics, since the application
data should be ready before the animation.

Currently the performance would be identical to normal fullscreen,
Open to be ~20 and Close to be ~90.

Bug: 961467
Test: interactive_ui_tests on nocturne
Change-Id: I002dc5ef3e4b2a57791b9da97c7fcf1e44ca323c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674194Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672134}

MakeUserNameForAccount() doesn't fail creation of user on some of the windows instances.

This fix explicitly returns a failure when we want to fail the login UI instead of depending on
"create user" to fail for "empty username" instead.

Note that currently the error_text is set as IDS_INTERNAL_ERROR_BASE. Explicit error handling
with appropriate error messages would be done in a followup change (already filed a bug for it).

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1659512/24

Bug: 976543
Change-Id: Ic4d92f5ef647d0f3cd5fd50c1f52b588c94a3afd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672234
Commit-Queue: Rakesh Soma <rakeshsoma@google.com>
Reviewed-by: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672133}

This is part of the 4.3 phase on the design document [1]. It prepares
ground for dependent mediastream classes to be Onion soup'ed.

[1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/edit

BUG=704136
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Ib56eb8a4dc4c00f653d1a6b750eb526263b68976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672800
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672132}

This CL adds a specific, individual WPT test for each type of
backdrop-filter effect.

If you find yourself here, looking for the test for blur() or
a multi-filter (combined) test, see crbug.com/978481.

Bug: 831485
Change-Id: I065fd94dbfe5ef0813ffe90f07878247147d3261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674708
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672131}

LoFi, both server and client, is now deprecated.

Bug: 944286
Change-Id: I4095aea5e5136da44eef8f641e052f8782e92d4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666306Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672130}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3df9c76a4999..1e2dfd22680d


git log 3df9c76a4999..1e2dfd22680d --date=short --no-merges --format='%ad %ae %s'
2019-06-25 ahassani@chromium.org build_lib: fix an exception catch problem


Created with:
  gclient setdep -r src/third_party/chromite@1e2dfd22680d

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I234108ab0ce7db94467844b8e4fc06c216a2bdc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676349Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672129}

This change gets rid of the small splash screen layout, which
effectively shifts the text placement a little closer to the icon when
the icon in small, and avoids having long text get cut off vertically.

This also lowers the minimum icon size to 16dp for screens smaller
than 600dp, where small icons don't look quite as bad.

Bug: 977198
Change-Id: I58ebe7c76af6dc756709a21141c5cc45843cf135
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670121
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672128}

Some compare_videos.py flags will be removed by [1]. They were already
deprecated and not used.

[1] - https://webrtc-review.googlesource.com/c/src/+/143788

Bug: None
Change-Id: Id37735b18ce5573468b8583e9f14392bc1b12128
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675671Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672127}

Change-Id: I2bfe4f20b0980dfa920586becfe9f2b9f9a97d87
Bug: 970240,934451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669231Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Auto-Submit: Allen Robinson <arobins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672126}

1. Modified BrowserAccessibilityManager and its subclasses to return nullptr if the current tree is disconnected from the top document and the focus node is retrieved
This is because from Blink, we get one focused element per renderer - one focused node per iframe.
If the current accessibility tree is disconnected from its parent tree, we have no way of knowing where the document's global focus is and might erroneously get back the locally focused node, i.e. the focused node in the current iframe.
This will cause the focus to appear to jump from the globally focused node to the locally focused one, until the trees containing each iframe are connected again on the browser side.
The user-facing bug is that focus will seem to randomly jump around the page, mostly jumping back to the top, preventing the user from reading anything.

2. Ensured that the static variable in BrowserAccessibilityManager in which the previously focused node is stored is cleared when:
A) The tree managed by the current BrowserAccessibilityManager is deleted.
B) The tree managed by the current BrowserAccessibilityManager changes its tree ID.
C) The subtree containing the previously focused node is deleted.

3. Audited all places in the code were certain focus related methods from BrowserAccessibilityManager are called, and accounted for the possibility of those methods returning nullptr.
The list of methods is as follows:
FireFocusEventsIfNeeded
FireFocusEvent
NativeViewHasFocus
GetFocusFromThisOrDescendantFrame
GetActiveDescendant
GetFocus
GetRootManager
GetDelegateFromRootManager
IsRootTree
AccessibilityIsMainFrame
CanFireEvents

4. Audited all the methods in BrowserAccessibilityManager and its subclasses that were using the BrowserAccessibilityManagerDelegate.
Some of those methods were calling methods on the delegate without first checking if it was nullptr, which could be the case in unit tests.

5. Took the opportunity to add "const" to a bunch of focus related methods, since retrieving the focus should not be modifying any state on any class instance.

6. A followup patch should modify the deserializer in AXTree to ensure that the same node ID is used when the root of the tree has been updated after some of its children got added or removed.
This will remove even more spurious focus events from being fired.

Change-Id: I4a75312632bf0b66e346fc5cae683edd9e63933a
Bug: 956748
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660717
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Auto-Submit: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672125}

Follow-up to CL:1669916

Change-Id: Ie98e1cbf0ed3cb90b41bdc682367474992bd1970
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676124
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672124}

because b/a/pylib/symbols/stack_symbolizer.py uses it: http://bit.ly/2YkZKih

Bug: 790202
Change-Id: Ie45a5de5947e5f296d42cbea0c49411be13f6702
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675341
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#672123}

Adds new opt guide proto optimization type for DeferAllScript with
whitelist checking for it from PreviewsDeciderImpl thru PreviewsHints.

Bug: 965277
Change-Id: I7be59e6eda9b64d310027ac2c3ddfb7f91ac76eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673754Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672122}

This UKM should only be recorded once per page load. Marking this event
as singular makes it easier to query in logs.

Change-Id: I72acf796d084d0fe97df8932067a30ce95dc7537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669573Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672121}

We did this by default and for flattenhtml=true, but not when setting
preprocess=true.  This seems like an oversight.

Bug: 564112
Change-Id: Id3d6907e79be51ea2ce905e563f350fd0f882164
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670353
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672120}

https://swiftshader.googlesource.com/SwiftShader.git/+log/e899321b0bf7..a25f5438fa27


git log e899321b0bf7..a25f5438fa27 --date=short --no-merges --format='%ad %ae %s'
2019-06-25 chrisforbes@google.com Use correct alignment for input attachment loads


Created with:
  gclient setdep -r src/third_party/swiftshader@a25f5438fa27

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/135954761
TBR=swiftshader-team+autoroll@google.com

Change-Id: I5493b76f7d8f16aea2303001ea435282d10ffdd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676013Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672119}

Bug: 973925
Change-Id: I7eae9ca730babc823341c766e49d242496d2c315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672204
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672118}

BUG=973822

Change-Id: I71f6494eae094646068382444eb985626efd0bbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658168
Commit-Queue: Gustavo Avena <gustavoavena@chromium.org>
Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672117}

The method GetAvatarImageURLWithOptions() is updated to support
image URLs coming in the FIFE Avatar URL format.

This should resolve issues related to color-inverted account images
on the Chrome surface.

Bug: 911332
Change-Id: I8c0a10be69bc87a40a39cf46e0428b418d97b021
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670888
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672116}

A previous fix did not fully fix the crash. https://crrev.com/c/1645479

The crash with the signature AddSameConstraints still occur so an
additional check is added directly before AddSameConstraints() is
called.

Bug: 970876
Change-Id: I9adb9437eea159896d089ce415c33688fb1dc46b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670149
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672115}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/16f6e6ab932f..b9a1021d5b7d


git log 16f6e6ab932f..b9a1021d5b7d --date=short --no-merges --format='%ad %ae %s'
2019-06-25 dneto@google.com Remove Appveyor artifacts link. (#739)


Created with:
  gclient setdep -r src/third_party/shaderc/src@b9a1021d5b7d

The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=radial-bots+chrome-roll@google.com

Change-Id: I4d1bd3021c4f0923eab1fe99cbde22804fc5571f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675743Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672114}

This CL removes all uses of the word 'modern' from the media controls
resources.

Bug: 884215
Change-Id: Ib6e28c953dd478bbc73a28697fa45a1562eb9641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674330Reviewed-by: Jazz Xu <jazzhsu@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672113}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45f99e2caaf7..70ec83098831


Created with:
  gclient setdep -r src-internal@70ec83098831

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=reillyg@google.com,yhirano@google.com,futhark@google.com

Change-Id: I2dbd047b07b5d5bd505733bcd85fe8bb258c8fef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676011Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672112}

Bug: 978436
Change-Id: Ief76cb6af4ad65fe433eb2d6d66282be313e4d87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676168
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672111}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e198ec2f..0d7d36e8

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I8c54705e1d2f3ec537d46a9c94f190a5159b0542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675251Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672110}

midl.py currently does some path munging that is better handled by midl.gni.
It has knowledge of 'third_party' and 'win_build_output' and these should be
an argument to the script provided by the build system instead of knowledge
intrinsic to midl.py.

This changes moves that logic to midl.gni. midl.gni produces the same default
path that midl.py previously generated (so net result is a no-op).
browser_switcher/bho is the only consumer that had custom logic that needed
to explicitly specify the output location. Additionally, this enables
other IDL producers to specify a non-standard place to persist the IDLs if
they so desire.

Details:
midl.py/gni facilitate IDL compilation. Nominally, one would run midl as part
of the build process and be done with it. However, to support cross-platform
compilation, IDL generation is done on Windows clients and persisted in the
source tree. This way platforms that can't run midl directly can still
produce a Windows build.

For a given IDL, in the source tree |somewhere|, the standard location for
the checked in midl outputs is third_party\win_build_output\midl\|somewhere|.
midl.py knew how to get from the IDL built outputs (in |gen|) to the standard
location. Now midl.gni has that knowledge, additionally some other location,
other than the standard location may be used, if necessary.

Bug: 976936
Change-Id: Ibd448c8d59cc59e19c26beb8235c6f581182061e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666483Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Scott Sheehan <ssheehan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#672109}

Bug: 969989, 975774

Change-Id: I10ea2dc24835b3da9d36d2045aef523ab11d10f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675672
Auto-Submit: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672108}

The passthrough command decoder does not implement the state restoration
functions because it does not track state. When a GLStateRestorer
exists, it is used for the scoped binders in ui/gl/scoped_binders.h and
leads to incorrect state being applied.

BUG=88258

Change-Id: I18937597fc02562dfaf01d67a9d4a1b8b84290a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670949Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672107}

Bug: 971868
Change-Id: Icdfba2d851058b961cec6e7546d3c6fb0123fed1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674615Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672106}

This CL moves write-related operations to NFSFileWriter. This makes
the backend and interface closer to the current shape of the spec.

Bug: 968550
Change-Id: Ia2ccd97416b478eddf210118132519eef2b16040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672026Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Auto-Submit: Olivier Yiptong <oyiptong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672105}

The two metrics are meant to monitor extension content verification
related stats:
ExtensionContentHashFetcher.CreateHashesTime
Extensions.CorruptExtensionTotalDisables
Mark these as never-expiring.

Bug: 976038, 976013
Test: None
Change-Id: I915898f9533a1e40a3576ce4924453ef9374cee8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674206Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672104}