- 21 Jun, 2018 40 commits
-
-
Morten Stenshorne authored
TBR=kojii@chromium.org Bug: 850504 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I80780e6e19db3932094085a5fdf12a0497ab2774 Reviewed-on: https://chromium-review.googlesource.com/1110364 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#569354}
-
Scott Violet authored
This makes AshService create the necessary things when ash runs out of the browser process. BUG=837686 TEST=covered by tests Change-Id: Ia7203fbde3737c8009315c19de0d3b981605eb5a Reviewed-on: https://chromium-review.googlesource.com/1109465 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569353}
-
Rayan Kanso authored
After a fetch is complete, the metadata in the ServiceWorker database is updated with the new total_downloaded value. Bug: 826257 Change-Id: I8167683cc89f0d8567ddc861e934b3a4f4a20bd7 Reviewed-on: https://chromium-review.googlesource.com/1080816Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#569352}
-
Nico Weber authored
The test lists are almost identical, except that chromium_linux_and_gl_gtests also includes network_service_gtests, site_isolation_chromium_gtests, and site_isolation_chromium_linux_gtests. This has the effect of adding various test binaries (browser_tests etc) in network_service and (not_)site_isolation mode to the memory bots. To not overload swarming, suppress these tests on the bots that are in the default cq. Effectively adds these tests - network_service_browser_tests - not_site_per_process_browser_tests - network_service_components_browsertests - site_per_process_components_browsertests - site_per_process_components_unittests - network_service_content_browsertests - site_per_process_content_browsertests - site_per_process_content_unittests - network_service_extensions_browsertests - site_per_process_extensions_browsertests - network_service_interactive_ui_tests - not_site_per_process_interactive_ui_tests - not_site_per_process_sync_integration_tests - not_site_per_process_unit_tests to these bots: - Linux CFI - Linux MSan Tests Bug: 843511 Change-Id: I8fdfff7f48301d115c7e5aec7530fe9f9ff250a5 Reviewed-on: https://chromium-review.googlesource.com/1110151 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#569351}
-
Chris Morin authored
Make the process with state TOP appear as a regular app in the task scheduler instead of as a system process. This also allows users to kill it from the task scheduler. Have the new process state TRANSIENT_BACKGROUND appear as a service. Bug: none Test: Ensure TOP app is a regular app in the task scheduler. Change-Id: I49efca2bd2848479f6b590588fd357393d8a591d Reviewed-on: https://chromium-review.googlesource.com/1097975Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Christopher Morin <cmtm@google.com> Cr-Commit-Position: refs/heads/master@{#569350}
-
Nicolas Ouellet-payeur authored
For privacy reasons, we don't want the blacklist to be persisted after the user leaves incognito mode (as this info could reveal a website that was visited in incognito). With this patch, adding a website to the blacklist makes it work for the incognito browsing session, but only saves those websites in memory. Closing the incognito discards the changes to the blacklist, and the main browsing session is not affected. Bug: 793925 Change-Id: Icdd35e86b8b807c6a639c5c6ba86786f912e1bd0 Reviewed-on: https://chromium-review.googlesource.com/1110259 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#569349}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I42d6fe9cc40b4d3f16d618caa9ae5edfdd83d94d Reviewed-on: https://chromium-review.googlesource.com/1110446 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569348}
-
Katie D authored
Bug: 853576,854901,854899,854893 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0e027023f631f61a7969e2adc04c6ef59c87b38e Reviewed-on: https://chromium-review.googlesource.com/1108379 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#569347}
-
Lukasz Anforowicz authored
This CL exclude requests made from plugins (e.g. from Flash) in the NetworkService implementation of Cross-Origin Read Blocking (CORB). Bug: 846339 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iaa191f6805250fcc6f88e5042b5d149e7cfd216c Reviewed-on: https://chromium-review.googlesource.com/1101965 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#569346}
-
Tom Anderson authored
Using -fdebug-prefix-map requires adding an absolute path on the command line. This is bad for relocatable builds, and couldn't be good for goma caching. This CL changes usage of -fdebug-prefix-map to -fdebug-compilation-dir, which we can tell the compilation dir we want to set directly (in our case, "."). The produced .o and .dwo files are identical in the build configuration that I tested. BUG=846610,439949 R=dpranke CC=tikuta Change-Id: I8cdbfea14f7330118b9f25ebfa6af5bdf447bf17 Reviewed-on: https://chromium-review.googlesource.com/1103546 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569345}
-
Marijn Kruisselbrink authored
This change makes sure that if Mojo Blob URLs and Service Worker s13n are enabled there will be no more race conditions between revoking blob URLs and creating shared workers from those URLs. Cq-Include-Trybots: luci.chromium.try:linux_mojo Bug: 852249 Change-Id: I2ad10fbc2c16abb8e4666afae6893e9faf09f285 Reviewed-on: https://chromium-review.googlesource.com/1108496 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#569344}
-
Peter Boström authored
This changes tab text color from ~GG200 and GG700 to white and GG800 which makes inactive tabs in both incognito and default theme easier to read. It's especially important for themed-frame windows though where very light grey on white provided significantly worse contrast. This also increases tab-separator opacity to better match the increased contrast. Bug: chromium:855091 Change-Id: I0ec7208d6b1158e4abbb361acd119d3a48020f10 Reviewed-on: https://chromium-review.googlesource.com/1109271 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#569343}
-
crystallambert@chromium.org authored
This update gives the debugging tutorial its own extension. Gives greater focus to extension specific tips and less instruction on using DevTools. Bug: None Change-Id: I65a51507b8d96a8dbfe3aa9faa9132fef8226e43 Reviewed-on: https://chromium-review.googlesource.com/1083843Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#569342}
-
Stephen Martinis authored
The chrome test result format needs failed tests to be marked as unexpected to be recognized as true failures. Otherwise they're thought to be acceptable failures, and don't show up as actual failures when parsed. Bug: 533481 Change-Id: Ica94a18a4503a5553ef5602627643ae526155e1a Reviewed-on: https://chromium-review.googlesource.com/1109269Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#569341}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8b23dba0e50f..6f440ed5b51f git log 8b23dba0e50f..6f440ed5b51f --date=short --no-merges --format='%ad %ae %s' 2018-06-21 mbonadei@webrtc.org Revert "Implement H264 simulcast support and generalize SimulcastEncoderAdapter use for H264 & VP8." 2018-06-21 saza@webrtc.org Add AGC1 fuzzer 2018-06-21 titovartem@webrtc.org Revert "Roll chromium_revision e1ef7d4b..b47e7752 (568794:569173)" 2018-06-21 danilchap@webrtc.org Replace rtc::Optional with absl::optional in api 2018-06-21 henrik.lundin@webrtc.org Revert "NetEq: Deprecate playout modes Fax, Off and Streaming" 2018-06-21 sergio.garcia.murillo@gmail.com Implement H264 simulcast support and generalize SimulcastEncoderAdapter use for H264 & VP8. 2018-06-21 henrik.lundin@webrtc.org NetEq: Deprecate playout modes Fax, Off and Streaming 2018-06-21 titovartem@webrtc.org Remove third party dependecies that are not more in the source code 2018-06-21 titovartem@webrtc.org Remove usage of rtc_base/checks.h in 3pp base64.cc 2018-06-21 hta@webrtc.org Add support for content-hint value "text" 2018-06-21 danilchap@webrtc.org Replace rtc::Optional with absl::optional in rtc_base 2018-06-21 yura.yaroshevich@gmail.com Fixed crash when PCF is destroyed before MediaStream in ObjC Created with: gclient setdep -r src/third_party/webrtc@6f440ed5b51f The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:852701 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iabcf02d7b06e664bc318ed997f788ed78c928745 Reviewed-on: https://chromium-review.googlesource.com/1110278Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569340}
-
Reilly Grant authored
This patch is preparation for allowing signin to work with the Network Service as in that path there will be no direct access to the net::URLRequest object. These wrapper classes expose the minimum interface needed by the signin module to modify headers. Bug: 789670 Change-Id: I06bc2d99dba2de8359ab2f93d9a220f6c6e3b502 Reviewed-on: https://chromium-review.googlesource.com/1098377 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569339}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/44fc6f687b35..53842b6cbc1f git log 44fc6f687b35..53842b6cbc1f --date=short --no-merges --format='%ad %ae %s' 2018-06-21 ckitagawa@chromium.org [Devil] Fix pylint typecheck errors 2018-06-21 perezju@chromium.org [Telemetry] Add clear_caches option to possible_browser.Create 2018-06-21 charliea@chromium.org Tell sqlite3 to use a write-ahead mode 2018-06-21 perezju@chromium.org Fix index of timeseries data frames 2018-06-21 perezju@chromium.org [Telemetry] Do not cache installed apps in AndroidPlatformBackend 2018-06-21 benjhayden@chromium.org Increase Anomaly query limit in graph_json. 2018-06-21 nednguyen@google.com Disable testWaitForJavaScriptCondition on Mac 2018-06-21 perezju@chromium.org [Telemetry] Example: restart browser during story 2018-06-21 perezju@chromium.org [Telemetry] Fix pylint unidiomatic-typecheck warnings 2018-06-21 perezju@chromium.org [soundwave] Code health in dashboard_api.py 2018-06-21 perezju@chromium.org [soundwave] Follow cursor on fetch alerts API call Created with: gclient setdep -r src/third_party/catapult@53842b6cbc1f The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:811244,chromium:711073,chromium:854744,chromium:849703,chromium:854986 TBR=sullivan@chromium.org Change-Id: I7a6383560447cee344a85996f9a7f595e0e9088c Reviewed-on: https://chromium-review.googlesource.com/1110297Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569338}
-
Marc Treib authored
This makes a few things a bit nicer: Now StartupController doesn't have to know about the set of registered data types anymore, which are really not its business. As a consequence, it's not necessary to call Reset() before using the StartupController. This also removes one of two uses of SyncPrefs from StartupController; I hope to remove the remaining one soon. Bug: 854978 Change-Id: I75c8971342554eb190287724eff2ff3238ffbff6 Reviewed-on: https://chromium-review.googlesource.com/1110220 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#569337}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 724717 Test: none Change-Id: I5ed5b564cf92b1fd95101a8614e1717c468b314a Reviewed-on: https://chromium-review.googlesource.com/1109309Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#569336}
-
Chris Lu authored
Implements TableViewTextButtonItem for the button and TableViewTextLinkItem for the footnotes. Video: https://drive.google.com/file/d/1HnfmVgm-MH3T4k5nVPzN1IpiRBfRaLIv/view?usp=sharing Bug: 85340 Change-Id: I5e79574334f4654a24f72a1635ab2cdd3bd4c31b Reviewed-on: https://chromium-review.googlesource.com/1103584 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#569335}
-
Malay Keshav authored
This patch ensures that the aria labels are updated only when the index is updated on the display size slider. Without this we may update the aria label with an index in the array that is out of bounds. This happens in certain race conditions where the index has been updated but the array has not or vice versa. Bug: 854809 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I23807fe8b0a27ead8323b7a3d484db14ce79bf7d Component: Display Size slider, display settings Reviewed-on: https://chromium-review.googlesource.com/1108933 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569334}
-
Eric Karl authored
Android OOP-D requires running a Java Choreographer based BeginFrameSource on the display compositor thread. In order to do this, this thread must have a Java looper. This CL adds a looper by converting this thread from a base::Thread to a base::android::JavaHandlerThread on Android. As we also want to be able to specify a thread priority for this thread, this patch adds thread priority support to the JavaHandlerThread class. Bug: 811967 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I12d39edd5925f33629e91ad17eaf575ed49b0296 Reviewed-on: https://chromium-review.googlesource.com/1109020Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#569333}
-
Ben Wagner authored
Skia is cleaning up a few headers. Unfortunately a few source files in Chromium relied on a few transitive includes. TBR=sadrul@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I8bb15183908958eb066fb0ff4d20026ae9f311a4 Reviewed-on: https://chromium-review.googlesource.com/1110143 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#569332}
-
Vasilii Sukhanov authored
- The code is refactored. CheckChildProcessSecurityPolicy is to be used for autofill::mojom::PasswordManagerClient too. - PasswordForm::signon_realm is now checked together with origin. Bug: 467150 Change-Id: I8e696c4c904c72621a3410a8ec8f4d00cb4d6236 Reviewed-on: https://chromium-review.googlesource.com/1109966 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#569331}
-
Johann authored
Re-land with working msan support: https://chromium-review.googlesource.com/c/chromium/src/+/1109557 https://aomedia.googlesource.com/aom.git/+log/cc92258a08d9..c5a56b99df86 $ git log cc92258a0..c5a56b99d --date=short --no-merges --format='%ad %ae %s' (...) Created with: roll-dep src/third_party/libaom/source/libaom As part of the roll we must update the colorspace signaling. Originally added to libaom in commit 9e69463febe0ee8525cb5a99ee5f9f11286581f1 Author: Andrey Norkin <anorkin@netflix.com> Date: Thu Dec 21 18:50:57 2017 -0800 CICP colorspace signaling Monochrome is signaled outside of CICP: commit f340fece2c18f068dc3c0c9219b2e5a5eee7ba79 Author: Debargha Mukherjee <debargha@google.com> Date: Wed Jan 10 18:12:22 2018 -0800 No colorspace for mono-video f/ CICP compatibility BUG=aomedia:1673 And remove references to the deadline parameter. BUG=aomedia:13 Updates bear-av1.webm and disables bear-av1.mp4 test. ffmpeg muxing of av1 in mp4 has not been upstreamed yet. The webm file was generated with the av1 tree in this update. vpxdec media/test/data/bear-vp9.webm -o bear.y4m aomenc -o bear-av1.webm -p 2 --target-bitrate=150 \ bear.y4m The I frame for the AV1 test is generated with: aomenc -o bear-av1.webm -p 2 --target-bitrate=150 \ bear.y4m --limit=1 --ivf And then a hex editor is used to remove the 32 byte file header and 12 byte frame header. BUG=chromium:783519 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0b89285155e286f921448b221a491f9ed24cfd6e NOPRESUBMIT=true (due to presubmit confusion about relative paths in DEPS) Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie74c407f903b166948dd519c47339cfd09e6751c Reviewed-on: https://chromium-review.googlesource.com/1109742Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#569330}
-
Matthew Jones authored
The contextual search manager is passed into the bottom toolbar's init function allowing us to attach an observer to it. This allows us to show and hide the bottom toolbar's android view which was previously obscuring contextual search. Bug: 854230 Change-Id: Ieefbc233bacfb90d31f0110ed3f96957b10f069a Reviewed-on: https://chromium-review.googlesource.com/1106552 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#569329}
-
lgcheng authored
EDU is reqeusting more complicated flow/strings for the UMA notification flow, in the mean time we should unblock enterprise login flow during authentication when Arc is managed enabled. Bug: 852816 Test: Manual with test enterprise account Change-Id: I7c857685ba1be55e268377b29ef7dc426109cada Reviewed-on: https://chromium-review.googlesource.com/1108497 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#569328}
-
Tarun Bansal authored
Add RESOURCE_LOADING_HINTS optimization to the list of previews. Also, check if this optimization is enabled using base::Features, and if so, perform rest of the checks (including optimization hints), and add it to the list of enabled and/or committed previews. Note that currently this only supports resource loading hints provided via optimization hints and not via real time server API. Change-Id: I3764c05d731046a262eaa14b0f33d5caf8132fb5 TBR: holte@chromium.org Bug: 854666 Reviewed-on: https://chromium-review.googlesource.com/1107158 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#569327}
-
Victor Costan authored
Change-Id: I4704f3e8d7caddf5c0dc0a281ee0787080ae1ef5 Reviewed-on: https://chromium-review.googlesource.com/1108883Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#569326}
-
Victor Costan authored
This CL replaces a push_back() call with an emplace_back and an std::move. Sadly, the current benefit is minimal, because protobuf-generated code doesn't currently implement move operations. However, this code will be referenced as a good example of LevelDB usage, so there is a clear benefit in showing modern std::vector usage. When our Protocol Buffers library moves to C++11, this code (and all code that follows this pattern) will get the code size and speed benefits. Change-Id: I7a5fbba0e8ebdbcce474558ee3b9466ab86730ff Reviewed-on: https://chromium-review.googlesource.com/1108890Reviewed-by:
Chris Mumford <cmumford@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#569325}
-
Peter Wen authored
More specific steps for building all commits from a roll locally. Bug: None Change-Id: I4d29e2810ee220d149880a792c89c91f27e1ff9b Reviewed-on: https://chromium-review.googlesource.com/1110039 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#569324}
-
Qiyu Hu authored
According to "Supplement to the Bluetooth Core Specification" (CSS 7.0, https://www.bluetooth.com/specifications/bluetooth-core-specification), Part A, 1.1, "GAP and GATT service UUIDs should not be included in a Service UUIDs AD type, for either a complete or incomplete list." present in scan result Bug: 78593133 Test: Do nRF scan and confirm that only non GATT service UUIDs are Change-Id: Ia1d069a4356b1de90c19667fa28db167a5e3a7bb Reviewed-on: https://chromium-review.googlesource.com/1108882 Commit-Queue: Qiyu Hu <qiyuh@google.com> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#569323}
-
Kyle Milka authored
Bug: 854010 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5b0d59bb3ab73a6e179a70021779af8afa31e2e2 Reviewed-on: https://chromium-review.googlesource.com/1109029Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#569322}
-
Khushal authored
Use the PaintImage::GetSupportedDecodeSize API in the SoftwareImageDecodeCache to decode directly to the scaled size, instead of decoding to the original size and scaling. R=ericrk@chromium.org Bug: 558070,761564 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia2e71961acad9f40648212f8be5fef734fea9fe3 Reviewed-on: https://chromium-review.googlesource.com/1106608Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#569321}
-
Morten Stenshorne authored
There's also LayoutNGListItem, LayoutNGTableCaption and LayoutNGTableCell. Fixes 11 tests. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id7dae1c83b35ca5d4566088acf62d9bacfbe3a8f Reviewed-on: https://chromium-review.googlesource.com/1109834Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#569320}
-
Hongchan Choi authored
This CL removes unused 'input'-related members from DefaultAudioDestinationNode. Bug: 854229 Change-Id: I8495ac736d4cb1f33c61fec243510c42a88e3fc2 Reviewed-on: https://chromium-review.googlesource.com/1110035 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#569319}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d9fb538bc08c..bcd66f54de12 git log d9fb538bc08c..bcd66f54de12 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 stephana@google.com Add pass/fail Gold summary to output Created with: gclient setdep -r src/third_party/pdfium@bcd66f54de12 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I901f8706d942aac339b883e5a869d59d6b6e41f0 Reviewed-on: https://chromium-review.googlesource.com/1110198Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569318}
-
Mikel Astiz authored
We'd like to get rid of the fake, in favor of the mock, since most tests are anyway using the fake for mocking purposes (counting function calls and verifying arguments). Bug: 791939 Change-Id: Ie48fba806604af4aa622a56dc0e76e36c943f90e Reviewed-on: https://chromium-review.googlesource.com/1109511Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#569317}
-
Rune Lillesveen authored
Traverse flat tree instead of layout tree for ancestor style. Required to update pseudo elements as part of style recalc. Bug: 836126 Change-Id: I509b89ad6907f7856022fb3b28151829b6317f49 Reviewed-on: https://chromium-review.googlesource.com/1109828 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#569316}
-
kylechar authored
The gfx::AcceleratedWidget StructTraits had it passed by reference instead of value. The underlying type is always a primitive so it should be passed by value. Update StructTraits and mojom implementations. Change the StructTraits implementation to fail deserialization for platforms that don't support sending AcceleratedWidgets over IPC. Also change StructTraits unittest not to need a test interface, directly serialize and then deserialize instead. Bug: none Change-Id: Iee82df75d248fe48f5478ca5251a08238707758e Reviewed-on: https://chromium-review.googlesource.com/1110023Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#569315}
-