- 05 Mar, 2018 40 commits
-
-
Jay Civelli authored
Adds a new API to the unzipper service that lets clients select which files should be extracted. Also adding unit-tests for the unzipper client code. Bug: 799220 Tbr: sky@chromium.org, blundell@chromium.org Change-Id: I0408baccf8a2b0e5b904e76e25d840ead469660b Reviewed-on: https://chromium-review.googlesource.com/943828 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#540975}
-
Shimi Zhang authored
Split ClassRegister out from http://crrev/c/923021. Introduces ClassRegsiter to upstream, but don't make any use of it until the corresponding downstream part is added. Bug: 805531 Change-Id: I42db76afd1a78e70208876f8a8a9120b34cf2d44 Reviewed-on: https://chromium-review.googlesource.com/949611Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#540974}
-
Joel Einbinder authored
The PopoverHelper holds a reference to an external element. The helper needs to be disposed if the element outlives should outlive the helper. Change-Id: I58fb02a929a601cadf3472db886517c553a87575 Reviewed-on: https://chromium-review.googlesource.com/949668Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#540973}
-
Qiang Xu authored
changes: Using IsActiveUserSessionStarted instead of IsUserSessionBlocked as IsUserSessionBlocked could contain not ACTIVE state during logging in, which could cause BuildWindowList crash. Bug: 805046 Test: tested on device Change-Id: I13fac4df6a0dd7e531dc30fbc91d6dd80152ee30 Reviewed-on: https://chromium-review.googlesource.com/949666Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#540972}
-
Christopher Cameron authored
If a LayerTreeHost's LocalSurfaceId has been committed to a LayerTreImpl, then never allow that LocalSurfaceId to be used with incompatible size or scale factor. This CHECK should eventually be enabled on all platforms, but for now only passes tests on non-Aura. Ideally, this CHECK should not depend on has_pushed_local_surface_id, but scale factor adjusting layout tests use transiently-invalid settings. Bug: 814690 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia610cbbb0859260e620cc79639daed9b39ba7a1b Reviewed-on: https://chromium-review.googlesource.com/947713Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#540971}
-
Saman Sami authored
The call into ClearCompositorSurface... is not necessary because the destructor of RWHVGuest will implicitly evict the surface by invalidating its frame sink id. Remove that method and its unit test and also unify RenderWidgetHostViewGuest::SubmitCompositorFrame and RenderWidgetHostViewChildFrame::SubmitCompositorFrame because there doesn't seem to be any differences between them that actually matters. Change-Id: I2cae5d3d8f5099cd224b849c3bffe71645596328 Reviewed-on: https://chromium-review.googlesource.com/949563Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#540970}
-
Hwanseung Lee authored
According to the spec[1], Element.computedStyleMap() should return the same object each time. [1]https://drafts.css-houdini.org/css-typed-om-1/#dom-element-computedstylemap Bug: 816761 Change-Id: Ice74cca345ba5b4f7136f44695a4b3f6ab605f9a Reviewed-on: https://chromium-review.googlesource.com/939123Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#540969}
-
Jao-ke Chin-Lee authored
Bug: 731556 Change-Id: I40ca8fa97262e77e715b074457ca33075a5896fe Reviewed-on: https://chromium-review.googlesource.com/949458Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#540968}
-
Raymes Khoury authored
The RenderFrameHost is needed when checking media permissions to ensure that permission has been allowed by Feature Policy. This plumbs the RFH through the many layers of code necessary so it can be used to check this. Bug: 802945 Change-Id: Ice6d3b143113f1bc41b9af445bfd4c2887d112ff Reviewed-on: https://chromium-review.googlesource.com/938862Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#540967}
-
Scott Violet authored
This reverts commit b3e42b74. Reason for revert: I just had a failure in the nacl side of things that I believe is related to this. I'm going to revert. Original change's description: > Rename buildflag_headers for consistency > > This updates content. > > Targets go from foo_features to foo_buildflags > And similarly the header now has buildflags in the name. > > BUG=814485 > TEST=covered by build > > Change-Id: I42c4e6d6fd102d923575a0a3eccf77ec3b0e3276 > Reviewed-on: https://chromium-review.googlesource.com/949091 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540919} TBR=sky@chromium.org,dcheng@chromium.org Change-Id: I9f6a9ef5b6299bf9656b24db5eed63bbfa474f49 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 814485 Reviewed-on: https://chromium-review.googlesource.com/949983Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#540966}
-
Min Qin authored
This reverts commit c128a63a. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "Move downloadResponseHandler to components/download" > > This is a reland of 824bbddf > > Original change's description: > > Move downloadResponseHandler to components/download > > > > No major change in functionality, just moving the files > > > > Bug: 803135 > > Change-Id: I93737ed4539c1b3ddc25212814ef9b9c903ac882 > > Reviewed-on: https://chromium-review.googlesource.com/944545 > > Reviewed-by: Helen Li <xunjieli@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Reviewed-by: Bo <boliu@chromium.org> > > Commit-Queue: Min Qin <qinmin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#540736} > > Bug: 803135 > Change-Id: I270c0f6edc212ffe1a2a9d06ccfbc95f1da8f3e2 > Reviewed-on: https://chromium-review.googlesource.com/949702 > Reviewed-by: Min Qin <qinmin@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540961} TBR=boliu@chromium.org,dtrainor@chromium.org,qinmin@chromium.org,xunjieli@chromium.org Change-Id: Iea107687b6008c6132ee6533fdff56e1d3db0265 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 803135 Reviewed-on: https://chromium-review.googlesource.com/950022Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540965}
-
Josh Karlin authored
For navigations which are initiated by user gesture, measure how long the user stays on the page if they press the back button. Bug: 817846 Change-Id: I1b2831b133f1856be8bf18c36d5df3d88e1610de Reviewed-on: https://chromium-review.googlesource.com/943702 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540964}
-
Jian Li authored
Also add one method to get size in addition to digest. Tests are added. Bug: 758690 Change-Id: I8e5ac40503d54e16a054f58f4e1ae03e7a3100cd Reviewed-on: https://chromium-review.googlesource.com/935446Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#540963}
-
Sahel Sharify authored
https://chromium-review.googlesource.com/695981 is a fix to drop the pending wheel end event when the RWHI gets destroyed. But there are still memory crashes that happen in RouteMouseWheelEvent after MouseWheelPhaseHandler::SendSyntheticWheelEventWithPhaseEnded(bool). This cl gets the RWHI from the view to make sure that to RWHI is valid before dispatching the pending mouse wheel event with phaseEnded. Bug: 791963 Change-Id: Ief659137b106a23596f8aa2a10dc3c2be48a3e9a Reviewed-on: https://chromium-review.googlesource.com/904547Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#540962}
-
Min Qin authored
This is a reland of 824bbddf Original change's description: > Move downloadResponseHandler to components/download > > No major change in functionality, just moving the files > > Bug: 803135 > Change-Id: I93737ed4539c1b3ddc25212814ef9b9c903ac882 > Reviewed-on: https://chromium-review.googlesource.com/944545 > Reviewed-by: Helen Li <xunjieli@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540736} Bug: 803135 Change-Id: I270c0f6edc212ffe1a2a9d06ccfbc95f1da8f3e2 Reviewed-on: https://chromium-review.googlesource.com/949702Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540961}
-
Douglas Creager authored
We now mark the reports as pending before checking whether we're allowed to deliver them to the report collectors. Since the permission check might happen on a different thread, we need to ensure that the garbage collector doesn't delete the reports on us while we're performing the permissions check. Bug: 818273, 818582 Change-Id: Iba92a58468f439589b56f1b2169c289e3473c71c Reviewed-on: https://chromium-review.googlesource.com/948983Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Douglas Creager <dcreager@google.com> Cr-Commit-Position: refs/heads/master@{#540960}
-
Kevin McNee authored
I used the DisableThreadedScrolling flag for this test to force scrolling to the main thread in order to get the test in on time for M65. I've updated the test to wait until the compositor knows to send the event to the main thread, rather than forcing it with the flag. Bug: None Change-Id: I2d35688482b63133db439f21521a0664fdf824d0 Reviewed-on: https://chromium-review.googlesource.com/949670Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#540959}
-
Lukasz Anforowicz authored
Bug: 477150, 789781, 769508, 661725 Bug: 611232, 745881, 801992 Change-Id: If90fb04e97513b99716afd844a2a77ca0905ab3d Reviewed-on: https://chromium-review.googlesource.com/942316Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#540958}
-
bsheedy authored
Regular upgrade to the most recent public release APK. Done separately from the other APK upgrades to make it easier to identify perf regressions caused by a particular APK upgrade. Change-Id: If8e2e7d6df94dd41f0b6ca5e8ace0056617a6b60 Reviewed-on: https://chromium-review.googlesource.com/943834Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#540957}
-
Greg Thompson authored
This dialog is shown to a user when a relaunch is needed for an update and the user's administrator has set the RelaunchNotification policy to 2 (required). The dialog is shown each time the UpgradeDetector moves the UpgradeNotificationAnnoyanceLevel to LOW, ELEVATED, or HIGH. On the final showing, the dialog cannot be dismissed without accepting the relaunch. BUG=511300 Change-Id: I2c6cab28b65b841cfde6754530c902d22940f99c Reviewed-on: https://chromium-review.googlesource.com/939392 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#540956}
-
Tarun Bansal authored
The two histograms were added to the WebKit code earlier, but that CL did not add them to histograms.xml. This CL adds the histogram description to the xml file. Bug: 800035 Change-Id: Ie42f4ccbdb35ea69324a8856af369f74db60fb60 Reviewed-on: https://chromium-review.googlesource.com/944247Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#540955}
-
Andrey Kosyakov authored
The formatting was different from the auto-generated one since https://chromium-review.googlesource.com/937402 Change-Id: I38dadfd93e9eba959db26e155f96b9f6fc2557cc Reviewed-on: https://chromium-review.googlesource.com/949386Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540954}
-
Xiaoqian Dai authored
It's possible that during resizing, the desired resizing bounds for the snapped window is smaller then the minimum bounds. In this case, we use window transform to apply a translation on the window to make it visaully be placed outside of the workspace area. The transform will be reset after the resizing. Bug: 725683, 817557 Change-Id: I9cf4056a30a417a2afe29d16fe6a8f80268d64b8 Reviewed-on: https://chromium-review.googlesource.com/944721 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#540953}
-
Patrick Monette authored
Let us determine if the user is able to elevate without a password. Bug: 717696 Change-Id: I8e5fa4e8de348eac32cd27a046840930d7f5dff8 Reviewed-on: https://chromium-review.googlesource.com/927356 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#540952}
-
Lukasz Anforowicz authored
Bug: 806996 Change-Id: If4cb6110727ac6eacd5652aec74052445437a654 Tbr: creis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/949777Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#540951}
-
Michael Thiessen authored
This reverts commit 0e39bd62. Original change's description: > Revert "VR: Use isInVrSession API to keep Chrome in VR until user has left VR" > > This reverts commit dc55fd14. > > Reason for revert: Suspected to have broken chrome_public_test_vr_apk on main waterfall > https://ci.chromium.org/buildbot/chromium.android/Marshmallow%20Phone%20Tester%20%28rel%29/?limit=200 > first failing build contains this cl: > https://ci.chromium.org/buildbot/chromium.android/Marshmallow%20Phone%20Tester%20%28rel%29/3088 > > Original change's description: > > VR: Use isInVrSession API to keep Chrome in VR until user has left VR > > > > This fixes the Daydream Dashboard issues so that if Chrome is simply > > stopped/started in VR without any intents, Chrome stays in VR. > > > > Also makes resuming Chrome from DD home way faster if Chrome was > > already in VR. > > > > Bug: 780887 > > Change-Id: Iab7f713bfc5b85972f908ea141e3b495297d7286 > > Reviewed-on: https://chromium-review.googlesource.com/944547 > > Reviewed-by: Yash Malik <ymalik@chromium.org> > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#540403} > > TBR=mthiesse@chromium.org,ymalik@chromium.org > > Change-Id: I7ae67f5d23d816796cc7f567792e181900b3012a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 780887 > Reviewed-on: https://chromium-review.googlesource.com/946709 > Reviewed-by: Benjamin Pastene <bpastene@chromium.org> > Commit-Queue: Benjamin Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540588} TBR=mthiesse@chromium.org,ymalik@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 780887 Change-Id: I690474b0dd7b8dff7e7a5b2dbd036b0f97eacb52 Reviewed-on: https://chromium-review.googlesource.com/949083Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#540950}
-
Aaron Leventhal authored
Deselecting the omnibox when the location bar is blurred causes confusing screen reader verbalizations when switching tabs. This behavior can be suppressed by only firing the selection event in a textfield when it is actually focused. This general fix makes sense as it would be confusing for screen reader users to hear any selection-related information for a textfield that is not currently focused. Bug: 817967 Change-Id: I945383c27f51b5bc791ab2c35327862fdac32179 Reviewed-on: https://chromium-review.googlesource.com/944014 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#540949}
-
Lukasz Anforowicz authored
Bug: 806996 Change-Id: I7270bfdd6f282fb64e54711d019dcd3e22939db1 Reviewed-on: https://chromium-review.googlesource.com/949405Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#540948}
-
Eric Roman authored
This is a speculative fix for calls to dhcpsvc!DhcpRequestParams being very slow following network changes. Bug: 770201 Change-Id: I506f44d51ee4d14625bb4d64974f6e4dd618c103 Reviewed-on: https://chromium-review.googlesource.com/946870 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#540947}
-
Danyao Wang authored
Bug: 814803 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5b3411ca1545b982120752e95f92736751337be5 Reviewed-on: https://chromium-review.googlesource.com/939524 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#540946}
-
Christopher Thompson authored
This adds three missing histograms to histograms.xml that should have been introduced in https://crrev.com/c/914468: two enums, Security.SecurityLevel.OnCommit and Security.SecurityLevel.OnComplete, and one suffixed histogram, Security.TimeOnPage. Bug: 803540 Change-Id: I608604067c422703efa130dbc16f271529d0bbf6 Reviewed-on: https://chromium-review.googlesource.com/949608 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#540945}
-
Siddhartha authored
BUG=818570 TBR=dskiba@chromium.org Change-Id: I307696cbb48b2bd6dcdd7b625409e75a49b05413 Reviewed-on: https://chromium-review.googlesource.com/949455 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#540944}
-
Christopher Thompson authored
This adds to the SiteEngagement UKM collection to track the final engagement score, rounded down to the nearest multiple of 10 to reduce the granularity of the collection. Additionally adds a new metrics utility function to perform linear bucketing (similar to the existing exponential bucketing function). Bug: 803544 Change-Id: I1c3031e94d4cce28995ab53095c6a4df3e39f65e Reviewed-on: https://chromium-review.googlesource.com/939876 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#540943}
-
Joshua Bell authored
The quota heuristics reduced the effective volume size on a per-OS before calculating the temporary pool size - e.g. 10GB for a desktop OS and 1GB for CrOS/Android/etc. These numbers are sketchy at best, and it turns out they don't affect much when the "should/must remain free" numbers are considered: e.g. on 1000GB desktop device, 10GB accommodation 900GB used - pool is 330GB (without accommodation it'd be 333GB) 995GB used - pool is 330GB (ditto) 998GB used - "should" - writing blocked 999GB used - "must" - purging starts e.g. on 64GB mobile device, 1GB accommodation 60GB used - pool is 21GB (without accommodation it would be 21.3GB) 61GB used - pool is 21GB (ditto) 62GB used - "should" - writing blocked 63GB used - "must" - purging starts In none of these cases does the OS accommodation do much beyond fractionally altering how much Chrome will store, and protection imposed by the "should/must" thresholds dominates the behavior. Even if the accommodation numbers were increased, the pool size only changes fractionally (e.g. raising mobile to 10GB just drops the pool to 18GB). Remove the OS accommodation calculation entirely. Bug: 817128 Change-Id: Iaefebb5b0f60ec221535e5c3a577a155fcb620a4 Reviewed-on: https://chromium-review.googlesource.com/940525 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#540942}
-
rbpotter authored
Add automated testing for showing the GCP certificates error. Bug: 793947 Change-Id: I78aea282ed70f94361553ce37675ece6c18c467b Reviewed-on: https://chromium-review.googlesource.com/941551 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#540941}
-
dpapad authored
Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iadec938bab9709410a2baf5c30d2cc07a6a9b145 Reviewed-on: https://chromium-review.googlesource.com/947704Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#540940}
-
https://pdfium.googlesource.com/pdfium.git/+log/8b1f7deec855..31e08d1d6db1 $ git log 8b1f7deec..31e08d1d6 --date=short --no-merges --format='%ad %ae %s' 2018-03-05 hnakashima Cleanup CFWL_ScrollBar::Timer::Run. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ifb6535edd7199e81d799b5ae9bb41bb4b95848a2 Reviewed-on: https://chromium-review.googlesource.com/949568Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540939}
-
Darren Shen authored
We currently hit a DCHECK when appending a var ref. This patch fixes the crash by rejecting it as per the spec. Spec: https://github.com/w3c/css-houdini-drafts/commit/ecfcbf9721c0d7dff7890d8e009e4e3ad9b72d10 Bug: 814606 Change-Id: I144307bf489db5e968c8e326087d13554ec3e59c Reviewed-on: https://chromium-review.googlesource.com/948142Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#540938}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5f45b4c7. With Chromium commits locally applied on WPT: 5bc12947 "Remove tests of non-defined behaviors for `line-break: loose`" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13373 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/i18n TBR=jsbell No-Export: true Change-Id: I965b8740a08c0ed02be6e1fed44ab1dfec9832f8 Reviewed-on: https://chromium-review.googlesource.com/949367 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#540937}
-
Charlie Andrews authored
This is the first part of a fix aimed to prevent us from slow flushing if the BattOr connection is already open. This used to be how it worked, but recent improvements we made to the retry protocol caused a regression in clock sync latency. TBR=nednguyen@google.com Bug: 816470 Change-Id: Ibfceb02e62c333ff3d2b32c8bd52f5a1277bbe70 Reviewed-on: https://chromium-review.googlesource.com/946515Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#540936}
-