- 19 Dec, 2019 40 commits
-
-
Andrew Luo authored
Bug: 1021665 Change-Id: I4bb27606a3e52ec08341332f1844c6b0073994b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970082 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#726242}
-
Azeem Arshad authored
This CL fixes issue with "Mobile Data" toggle animating to the on position when opening the menu instead of appearing in the on state immediately. The issue was caused because the mobile data header view always initializes with the toggle off. The correct value is updated immediately after initialization. But this code path uses the toggle's AnimateIsOn method that starts an animation. Fixed this by setting correct initial state for mobile header view. Fixed: 1020722 Change-Id: I8c17ce28b09b2506221fcbcbf472f80d44f67006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975111 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726241}
-
Jon Mann authored
This reverts commit ede86024. Reason for revert: Breaks network selection in OOBE Original change's description: > Maintain focus when items in a network-list are updated. > > Previously, focus would jump to the first element when > the underlying network list was updated. This fix > attempts to maintain focus on a particular network if it > is still present, otherwise it tries to stay on the same > index, and finally falls back to the first element. > > Fixed: 1005934 > Change-Id: I9a7e2307bc604f8ba08b659e22f80ba88ad66156 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920188 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Jon Mann <jonmann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721367} TBR=khorimoto@chromium.org,jonmann@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1031994, 1032265 Change-Id: I31a30d106b61cb917f4a489abf17097476db40e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975162 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#726240}
-
Alex Cooper authored
This change begins implementing the infrastructure for AR and VR permissions so that WebXr can switch to using Permissions instead of a custom consent flow. Note that neither permission is intended to be exposed to blink at this time, and neither permission is expected to be called, therefore all calls to these permissions are currently blocked while development is occurring. Bug: 1033592 Change-Id: Ia51f9df7f66c42d2b5fad17ef9e9206b7bedd799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965974 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#726239}
-
Demetrios Papadopoulos authored
Those resources are only used by the browser settings and seem to have been erronously added in os_settings_resources.grd. Bug: 1026455 Change-Id: I2a0d00207c0f3e11a4b8b66689bfb86010e631f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974760 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#726238}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/aa39e6f58369..5c3e409cc4f9 git log aa39e6f58369..5c3e409cc4f9 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 chonggu@google.com [Telemetry] Fix fuchsia_forwarder Created with: gclient setdep -r src/third_party/catapult@5c3e409cc4f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1014642 Tbr: sadrul@google.com Change-Id: I2cd6d71f664e299ae4b747e803a7e16b655c38cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726237}
-
John Budorick authored
both from https://ci.chromium.org/p/chromium/builders/ci/android-avd-packager/23 Bug: 922145 Change-Id: I9ffff6bcd6126b53501cf1f6cb9e71294f21b323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974396 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#726236}
-
Fredrik Söderquist authored
Less open-coding means less to cargo-cult. Change-Id: I1d1e7210e28cbb117b1bfaeb5e009f40ad0e1e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974231 Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#726235}
-
Andrew Luo authored
This will avoid wasting test re-run time on the bots. Bug: 1021665 Change-Id: I42dfcfa848e3c07c0fb5e8de4524a864e497f70d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968238Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#726234}
-
sczs authored
- Adds verifyExistenceOfBookmarkWithURL and verifyAbsenceOfBookmarkWithURL to BookmarkEarlGrey and its AppInterface. - Moves verifyOrderOfTabsWithCurrentTabIndex to bookmark_entries_egtest since its only used by this test and its not using any App code. Change-Id: I64d2191da55ff6c8e60131f8e7f56b726443ae2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974819 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#726233}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3567a9a85896..e020cf38f429 git log 3567a9a85896..e020cf38f429 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 tsepez@chromium.org Fix some whitespace in public header formatting 2019-12-18 thestig@chromium.org Do slightly fewer casts with FPDFBitmap_GetBuffer() result. 2019-12-18 tsepez@chromium.org Tidy interface comments in public/fpdf_formfill.h. Created with: gclient setdep -r src/third_party/pdfium@e020cf38f429 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I8f134974d4fb9523c014592d0da72108046b01f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975154Reviewed-by:
-
Miyoung Shin authored
This CL migrates code to the new BrowserInterfaceBroker class. This allows retrieving the remote implementation in the browser process without relying on the InterfaceProvider API. Bug: 936482, 1002647 Change-Id: I273a91f6b0dfd34e4994ef8987396295ce8436f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969127 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#726231}
-
Raymond Toy authored
NewExpectedClosure returns a base::OnceClosure now and NewExpectedBoolCB returns a base::OnceCallback. Bug: 1007799 Change-Id: Ic0fbcbd1b70c1e81920efdf095ba89d6f905c37f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972816Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#726230}
-
bttk authored
This is a reland of e401fb7e Original change's description: > Replace org.chromium.base.Promise.Function with Function > > Bug: 1034012 > Change-Id: I9dd122eca2169955f2ccf006dc039158be232d14 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965440 > Commit-Queue: bttk <bttk@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Ender <ender@google.com> > Cr-Commit-Position: refs/heads/master@{#724788} Bug: 1034012 Change-Id: I897913251141fe181992e7e9bf6723bc752a7afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967765 Auto-Submit: bttk <bttk@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#726229}
-
Yue Li authored
For testing purposes, check the ShouldArcAlwaysStart flag for the play store state. The flag will only turned on by a command line flag for testing purposes. Background: https://chrome-internal-review.googlesource.com/c/chromeos/platform/tast-tests-private/+/1948653 Bug: 982538 Test: Run existing tests Change-Id: I7c8c3c97df5b696b9fcc467e7abc7e980305f05a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962598 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#726228}
-
Gyuyoung Kim authored
The original CL missed cleaning up MediaStreamTrack::Create(). So, this CL removes the Create() and makes all callers use MakeGarbageCollected<MediaStreamTack> instead. Bug: 939691 Change-Id: I9fa14e15f57f367bad1ff62c9b8cafbc4acaa0ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971303Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#726227}
-
Yusuke Sato authored
ARCVM already does this with SchedulerConfigurationManager's observer, and this is Crostini port of the feature. BUG=1011559 TEST=try, lscpu in guest returns 2 on eve Change-Id: Ie94497ed803c2e10f17def26855107e0f1c336e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972883Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#726226}
-
Caleb Rouleau authored
It seems we are somehow hitting the overall 4000 second timeout, which prevents us from getting logs. Attempt to timeout earlier so that we get some logs. Bug: 1035590 Change-Id: I293d2772ccd2cc87b66b47c1954ecb802c8f0ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974705 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#726225}
-
Kent Tamura authored
The new behavior matches to Edge and Firefox. Bug: 908632 Change-Id: I0dbb861e93836284a0c474cc486650dab27dc7b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973333 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#726224}
-
Anand K. Mistry authored
There are two problems with trying to unmount sshfs if Crostini is not running: 1. The unmount will fail, resulting in distracting log spam 2. Unnecessary blocking of suspend, which increases time to suspend Bug: 1035686 Change-Id: I12e4724b77db55ebfa241f1fa765821861824c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974293 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
-
Zhenyao Mo authored
BUG=941163 TEST=bots R=kbr@chromium.org Change-Id: I3ea45662ac87730fb8166a59e4af76401fb6f49d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974623 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Kent Tamura authored
The new behavior matches to Edge and Firefox. Bug: 625710 Change-Id: I27de8b769712062f548eb9d2274544d1ec0ff073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973435 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/61e3d1746f00..60e4a93e3e4d git log 61e3d1746f00..60e4a93e3e4d --date=short --first-parent --format='%ad %ae %s' 2019-12-18 fmayer@google.com Merge "Move symbolizer to src/profiling/symbolizer." Created with: gclient setdep -r src/third_party/perfetto@60e4a93e3e4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I729112a7c6fcea60f66e26d79ac328d7a8ddde5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974591Reviewed-by:
-
Chase Phillips authored
Bug: 1033609 Change-Id: Ibe109738738e8610bb71024d9201627251df4eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869379 Commit-Queue: Chase Phillips <cmp@chromium.org> Auto-Submit: Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#726219}
-
Brian Sheedy authored
Switches uses of PrintResult to PerfResultReporter in the base_perftests target and whitelists it for conversion to histograms before uploading to the perf dashboard. Bug: 923564 Change-Id: I0947dd98f842b072af7f7637db2191bb4a299992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968239Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#726218}
-
Khem Raj authored
time element is deprecated on new input_event structure in kernel's input.h see [1] This starts to fail the build on libcs( musl ) which has already implemented the 64bit time_t and enabled it for 32bit arches, compiler complains that it can not file structure member called 'time' in input_event struct This patch ensures that we use portable defines in a backward compatible way [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=152194fe9c3f BUG=1033635 Change-Id: Ifd9f8aa4e8844ac9b4d3598cbe4a6474fe2726f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972680Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726217}
-
Navid Zolghadr authored
Change-Id: Ic84c334db97272e92449953113c3789f27d7c4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971658Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#726216}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/bluetooth. Bug: 1001114 Change-Id: Iddb31cbbf71637ae989ea634f78207dfd9289c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971049 Commit-Queue: Julie Kim(OoO til Jan 01) <jkim@igalia.com> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#726215}
-
Demetrios Papadopoulos authored
This page is no longer used anywhere other than Chrome OS Settings. Bug: 1026455 Change-Id: I033b7d8c1936349802a8dafb092ab74bae36d452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973354 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Fergal Daly authored
Currently on mac and win the callback is not run, leading to a situation where the browser process does not send an IPC to the renderer, leaving the renderer blocked on the dialog. This was making the bfcache tests in https://crrev.com/c/1955245 fail on mac and win. On linux, dialogs always behave if suppressed. Also fix a bug in the mac code where it attempts to store the callback inside both the helper and the ShellJavascriptDialog. Only the helper actually gets it. Bug: 1030133 Change-Id: I7fe66eb9950f9f51e9be833224a43ba1cb003a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973517 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6037820448a9..a892219ced42 git log 6037820448a9..a892219ced42 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@a892219ced42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I29270af60ee3581fc69488f4fb8f55a7617d924b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974608Reviewed-by:
-
George Steel authored
Move metrics from KeyframeEffect::Create() body to IDL [Measure] and merge the two keys into a new one with the proper name. This in preparation for changing it in the next CL. Split from crrev.com/c/1921343 Bug: 981894 Change-Id: I7f42597e507e1c4354804a907474aeb0be6bc840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966501 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#726211}
-
kylechar authored
|needs_sync_tokens| was set false as a performance optimization when the display compositor and browser UI shared a command buffer. This never happens anymore outside of tests so it can be removed. Bug: 869250 Change-Id: If963d69323cb87638ae34cca08132b49e6abdd0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973966 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
This CL implements and enables BMO-launching of the Settings system web app from AppList and Shelf on ChromeOS. Work done to reuse existing functionality: - Extract ConvertDisplayModeToAppLaunchContainer util function. - Expose CreateWebApplicationWindow and NavigateWebApplicationWindow functions out of WebAppLaunchManager. Bug: 1034386 Change-Id: Ie9301e94237c020e0746b2a0b1686a21879ed2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971040 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#726209}
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers components/safe_browsing/ and the minimal set of necessary client updates. Fixed: 1007726 Change-Id: If8dacb296ded88cf07bf55193c1458b4962b2cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974993Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#726208}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=dalecurtis@chromium.org Bug: 1023677 Change-Id: I94c1a00eb137653946a3dd26d0afb24d838caa70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957561 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#726207}
-
Nate Chapin authored
This removes the need for custom pause/unpause logic for ScriptedAnimationController in Document. Also, construct ScriptedAnimationController in the Document constructor, rather than lazily. It will get initialized on the first frame, so we're not saving much by deferring its initialization. This simplifies a bunch of logic around its handling in Document, and guarantees that its lifetime will be predictable for leak detection. TBR=creis@chromium.org Bug: 1029822 Change-Id: Ia30db6b7dac25c834152ae546364d77ff089fca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970259 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Alex Cooper authored
Refactor XRSessionOptions and XRRuntimeOptions to use an enum, XRSessionMode, where appropriate rather than a pair of bools. As the WebXr spec evolved, the mojom definitions evolved with it. Now that WebVr has been removed and the spec has been solidified, this refactors portions of the mojom to fit better and simplify the code. As a result, a blink-side enum was able to be replaced with this new mojom enum. Unfortunately, a device-side enum was not able to be removed, but it was able to be scoped to just the SessionMetricsHelper. Hopefully future cleanup will enable removal of this enum as well. A couple of changes are worth calling out specifically: Some slight behavior changes were added, which fit with the expectations of the code. Namely, some runtimes that only checked for "immersive", and not "environment_integration", now assert that the request is for "ImmersiveVr", which more closely reflects reality. XrRuntimeManager::GetRuntimeForOptions was also cleaned up from a more complicated set of if-blocks to a switch statement. Fixed: 1035205 Change-Id: I09f39d4a80f1454d5a9aa58fb785169ba5338510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973156Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#726205}
-
Lambros Lambrou authored
This CL reverts http://crrev.com/36980fe26e8d2e0ce2929e22d2e87ea3f88c02e5, to re-enable LocalHotkeyInputMonitorMac. It also adds back the dependency on google_toolbox_for_mac, needed for the code to build. Bug: 1035613 Change-Id: I6e83cc225ab3cbde9f6a1be78caf5afd6295db66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975036 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#726204}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d94b7f19dbf6..979775099f35 Created with: gclient setdep -r src-internal@979775099f35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1028270,chromium:1030991,chromium:992370 Tbr: jbudorick@google.com Change-Id: If4eecad3c93d840c65211fcc5ae93983ba92228d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974785Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726203}
-
