Commits · 8bce7075c2ef7334f3e624b41570123c4f29e6a8 · eriksson monteiro / tangled

30 Nov, 2011 40 commits

Rebase the MessageBubble on the new views bubble. · 8bce7075

msw@google.com authored Nov 30, 2011

Views screen locker password errors and the 3G promo bubble looks good; except:
I filed crosbug.com/23324 for ScreenLockerViews MouseEventRelay.

BUG=98322
TEST=MessageBubbles work as before (screen locker password errors, 3G MobileDataPromo).

Review URL: http://codereview.chromium.org/8557005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112321 0039d316-1c4b-4281-b951-d872f2087c98

8bce7075

Update .DEPS.git · d8647346

chrome-admin@google.com authored Nov 30, 2011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112320 0039d316-1c4b-4281-b951-d872f2087c98

d8647346

Revert 112305 - Pull the phone library directly. Delete old version. · 226cccfa

isherman@chromium.org authored Nov 30, 2011

TEST=unit-tests
BUG=105577
Review URL: http://codereview.chromium.org/8736001

TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/8759004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112319 0039d316-1c4b-4281-b951-d872f2087c98

226cccfa

Revert 112178 - [Sync] Make syncer commands avoid posting tasks on threads with no work to do · 1ce7c92a

akalin@chromium.org authored Nov 30, 2011

Add abstract GetGroupsToChange() method to ModelChangingSyncerCommand.
Use that to figure out which worker threads to post work on (instead of
posting on all of them).

Implement GetGroupsToChange() for each ModelChangingSyncerCommand.

Add GetEnabledGroups() and GetEnabledGroupsWithConflicts() functions to SyncSession.

Key unapplied updates index by type for ApplyUpdatesCommand.

Make the abstract methods of ModelChangingSyncerCommand protected.

BUG=97832
TEST=


Review URL: http://codereview.chromium.org/8637006

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/8758006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112318 0039d316-1c4b-4281-b951-d872f2087c98

1ce7c92a

Revert 112034 - Add win_shared and linux_shared builder into the default try bot set. · 0d27c34b

ajwong@chromium.org authored Nov 30, 2011

Component builds breakages are easy to introduce because you can accidentally add a cross-component dependency without any warning if you're doing a normal static build.

BUG=105750
TEST=none

Review URL: http://codereview.chromium.org/8726043

TBR=ajwong@chromium.org
Review URL: http://codereview.chromium.org/8762005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112317 0039d316-1c4b-4281-b951-d872f2087c98

0d27c34b

Fix testProcessCountCombination on Mac · 81698574

nirnimesh@chromium.org authored Nov 30, 2011

Exclude GPU processes from the counts since they can pop-in any time.

BUG=None
TEST=testProcessCountCombination

R=dennisjeffrey@chromium.org

Review URL: http://codereview.chromium.org/8759003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112315 0039d316-1c4b-4281-b951-d872f2087c98

81698574

add crypto module password dialog view and test. · 9253d98c

alicet@chromium.org authored Nov 30, 2011

move cryto_module_password_dialog.cc out of gtk dir into cyrpto_module_password_dialog_view.cc and crypto_module_password_dialog.cc. crypto_module_password_dialog_view.cc needs views lib, and so it is not linked into all platform.

BUG=97844
TEST=None

Review URL: http://codereview.chromium.org/8115020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112314 0039d316-1c4b-4281-b951-d872f2087c98

9253d98c

Refactor PanelManager to create PanelStrip. · af33ec48

jennb@chromium.org authored Nov 30, 2011

* Added TestPanelMouseWatcher utility to help tests simulate mouse movements.
* Separated out PanelBrowserTest.MinimizeRestore into 3 tests to make it easier to tell which part is failing when it fails.

BUG=None
TEST=Panel*Test.*Changed header guard.

Review URL: http://codereview.chromium.org/8744005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112313 0039d316-1c4b-4281-b951-d872f2087c98

af33ec48

Don't make ServiceChildProcessHost derive from ChildProcessInfo. It didn't... · ec5265f2

jam@chromium.org authored Nov 30, 2011

Don't make ServiceChildProcessHost derive from ChildProcessInfo. It didn't really need to. This is needed since code in chrome will only be able to see interfaces from content's public API.

BUG=98716
Review URL: http://codereview.chromium.org/8755002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112312 0039d316-1c4b-4281-b951-d872f2087c98

ec5265f2

Cleanup: Remove an unneeded dependency. · 9e94d245

thestig@chromium.org authored Nov 30, 2011

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8666015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112311 0039d316-1c4b-4281-b951-d872f2087c98

9e94d245

Heapchecker: Remove a suppression since the leak has been fixed. · 9227bef7

thestig@chromium.org authored Nov 30, 2011

BUG=104760
TEST=none
Review URL: http://codereview.chromium.org/8745019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112310 0039d316-1c4b-4281-b951-d872f2087c98

9227bef7

update dependencies in preparation for glue being a component · eb64f833

dpranke@chromium.org authored Nov 30, 2011

R=darin@chromium.org
BUG=98755
TEST=waterfall stays green

Review URL: http://codereview.chromium.org/8741002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112309 0039d316-1c4b-4281-b951-d872f2087c98

eb64f833

Update .DEPS.git · 9ec3e3f4

chrome-admin@google.com authored Nov 30, 2011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112308 0039d316-1c4b-4281-b951-d872f2087c98

9ec3e3f4

Move remaining about: handlers to webUI. · b3adbd04

tsepez@chromium.org authored Nov 30, 2011

browser_about_handler.cc still exists to rewrite old about: URLs, but the
actual handling now takes place under webui.  Thus BINDINGS_POLICY_WEB_UI
is applied to these as well.

BUG=104809
Review URL: http://codereview.chromium.org/8623001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112307 0039d316-1c4b-4281-b951-d872f2087c98

b3adbd04

Shim calls to NPN_MemAlloc/MemFree through PluginHost · dac8dead

dpranke@chromium.org authored Nov 30, 2011

This change is necessary so that content doesn't attempt to call NPN_*
functions directly; this will be impossible once glue is a separate
component.

R=jam@chromium.org
BUG=98755
TEST=waterfall stays green

Review URL: http://codereview.chromium.org/8741005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112306 0039d316-1c4b-4281-b951-d872f2087c98

dac8dead

Pull the phone library directly. Delete old version. · 5f6f7f25

georgey@chromium.org authored Nov 30, 2011

TEST=unit-tests
BUG=105577
Review URL: http://codereview.chromium.org/8736001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112305 0039d316-1c4b-4281-b951-d872f2087c98

5f6f7f25

Fix BubbleDelegateView call to DisableInactiveRendering. · 1e99e51e

msw@chromium.org authored Nov 30, 2011

Currently, when bubbles pop up, Chrome renders as inactive/'unfocused'.
Call DisableInactiveRendering on Widget::Show rather than Widget construction.

BUG=98312,98323
TEST=Showing bubbles doesn't make Chrome appear inactive/'unfocused'.

Review URL: http://codereview.chromium.org/8741011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112304 0039d316-1c4b-4281-b951-d872f2087c98

1e99e51e

Suppress another race in WebRTCAudioDeviceTest. · 8c012045

cbentzel@chromium.org authored Nov 30, 2011

BUG=103711
TBR=tommi@chromium.org

Review URL: http://codereview.chromium.org/8760006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112303 0039d316-1c4b-4281-b951-d872f2087c98

8c012045

Fixed a header name error in UMA statistics that record what servers accept range requests. · c7deb56c

ahendrickson@chromium.org authored Nov 30, 2011

Change the names of the statistics, so that there is no pollution of the data.

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8746020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112302 0039d316-1c4b-4281-b951-d872f2087c98

c7deb56c

Pass gamepad enable switch through to WebKit · 0205fbf5

scottmg@chromium.org authored Nov 30, 2011

BUG=79050


Review URL: http://codereview.chromium.org/8724002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112301 0039d316-1c4b-4281-b951-d872f2087c98

0205fbf5

Suppress CSSParser::parseSheet from HTMLTitleElemet::textWithDirection · 42f08438

cbentzel@chromium.org authored Nov 30, 2011

BUG=105961
TBR=mikelawther@chromium.org

Review URL: http://codereview.chromium.org/8760004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112300 0039d316-1c4b-4281-b951-d872f2087c98

42f08438

aura: Implement window-related methods in platform_util. · 9331fcee

derat@chromium.org authored Nov 30, 2011

This implements GetTopLevel(), IsWindowActive(), and
ActivateWindow().

BUG=99712
TEST=added

Review URL: http://codereview.chromium.org/8692016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112299 0039d316-1c4b-4281-b951-d872f2087c98

9331fcee

Move ui sync code to common directory, clean up TCW. · 3da95a10

avi@chromium.org authored Nov 30, 2011

BUG=105872
TEST=no functionality change

Review URL: http://codereview.chromium.org/8745024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112298 0039d316-1c4b-4281-b951-d872f2087c98

3da95a10

Fix leak in ProfileInfoCache::SetGAIAPictureOfProfileAtIndex · 1302dcf9

sail@chromium.org authored Nov 30, 2011

The problem was that some memory allocated by the file thread wasn't being cleaned up. Fix was to stop the file thread and then process all the pending messages on the UI thread.

BUG=105864
TEST=

Review URL: http://codereview.chromium.org/8745010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112297 0039d316-1c4b-4281-b951-d872f2087c98

1302dcf9

Expand android tests. · faaa5a2a

jrg@google.com authored Nov 30, 2011

Add net_unittests to baseline build/run; add some test disabling.
Add experimental build phase to bot script.

BUG=None
TEST=

Review URL: http://codereview.chromium.org/8746003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112296 0039d316-1c4b-4281-b951-d872f2087c98

faaa5a2a

Fix content_shell. We really need an automated test soon :) · fe2e0acc

jam@chromium.org authored Nov 30, 2011

Review URL: http://codereview.chromium.org/8742029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112295 0039d316-1c4b-4281-b951-d872f2087c98

fe2e0acc

Disable the test that hangs batch script execution. · 83c318ac

venkataramana@google.com authored Nov 30, 2011

BUG=105948
TEST=NONE
Review URL: http://codereview.chromium.org/8742032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112293 0039d316-1c4b-4281-b951-d872f2087c98

83c318ac

Add new internet cafe brand code · 7f5c6083

sail@chromium.org authored Nov 30, 2011

BUG=
TEST=


Review URL: http://codereview.chromium.org/8745023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112292 0039d316-1c4b-4281-b951-d872f2087c98

7f5c6083

Chromium style clang fixes for OVERRIDE in compositor_unittests · a803592b

dhollowa@chromium.org authored Nov 30, 2011

Fixes clang plugin complaint about missing override:
./ui/gfx/compositor/compositor_cc.h:35:11: error: [chromium-style] Overriding method must be marked with OVERRIDE.
  virtual void* GetDisplay();
          ^
Also, adds |SetCurrent| call to properly track context in |GLContextNSView::MakeCurrent|.

BUG=104390
TEST=Compiles on Mac/clang.  compositor_unittests pass.
R=piman@chromium.org, kbr@chromium.org


Review URL: http://codereview.chromium.org/8748018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112291 0039d316-1c4b-4281-b951-d872f2087c98

a803592b

Fixup ordering of new thread init parts · 2167cd62

stevenjb@chromium.org authored Nov 30, 2011

This fixes some ordering from http://codereview.chromium.org/8477004

Change-Id: Icf945d0ebfbb766f7f9315a39f5469dee03873e1

BUG=98716, 104578, 105435
TEST=Run tests on all platforms


Review URL: http://codereview.chromium.org/8755001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112290 0039d316-1c4b-4281-b951-d872f2087c98

2167cd62

Implement Drain() on HttpPipelinedStream. · e2bec397

simonjam@chromium.org authored Nov 30, 2011

BUG=102385
TEST=net_unittests


Review URL: http://codereview.chromium.org/8591037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112289 0039d316-1c4b-4281-b951-d872f2087c98

e2bec397

Move extension delegate calls to a new ExtensionTabHelperDelegate interface. · 1739e57d

avi@chromium.org authored Nov 30, 2011

BUG=105872
TEST=no functionality change

Review URL: http://codereview.chromium.org/8741025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112288 0039d316-1c4b-4281-b951-d872f2087c98

1739e57d

revert remoting part of 112252 · ca16cd0c

garykac@chromium.org authored Nov 30, 2011

BUG=105934
TEST=make

Review URL: http://codereview.chromium.org/8749018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112287 0039d316-1c4b-4281-b951-d872f2087c98

ca16cd0c

Aura: Fix popup window frames appearing blue · bf603ea4

jamescook@chromium.org authored Nov 30, 2011

Added desaturated gray IDR_FRAME, IDR_FRAME_INACTIVE, and IDR_FRAME_APP_PANEL for Aura.

BUG=105883
TEST=visual

Review URL: http://codereview.chromium.org/8748014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112285 0039d316-1c4b-4281-b951-d872f2087c98

bf603ea4

Fix build · 7a60deec

abarth@chromium.org authored Nov 30, 2011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112284 0039d316-1c4b-4281-b951-d872f2087c98

7a60deec

Fix web extent in default search app. · 62bb1961

rogerta@chromium.org authored Nov 30, 2011

BUG=103278
TEST=See comment #4 in bug for repro steps.
Review URL: http://codereview.chromium.org/8747014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112283 0039d316-1c4b-4281-b951-d872f2087c98

62bb1961

manifest_version should be a base CRX key · 154361df

abarth@chromium.org authored Nov 30, 2011

Without this patch, the manifest_version attribute is rejected for hosted apps.

TEST=TaskManagerBrowserTest.NoticeHostedAppTabs (once a later patch lands)
Review URL: http://codereview.chromium.org/8748020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112282 0039d316-1c4b-4281-b951-d872f2087c98

154361df

Always use JavaScript as opposed to Javascript in UI strings · 6a7633cc

steveblock@chromium.org authored Nov 30, 2011

BUG=105871


Review URL: http://codereview.chromium.org/8742019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112281 0039d316-1c4b-4281-b951-d872f2087c98

6a7633cc

Remove a couple of unused Autofill strings · 53a2e0e7

isherman@chromium.org authored Nov 30, 2011

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8745006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112280 0039d316-1c4b-4281-b951-d872f2087c98

53a2e0e7

base::Bind: Implement a 1-arity CancelableCallback and use this to implement · d4d57df4

jhawkins@chromium.org authored Nov 30, 2011

net::CancelableCompletionClosure.

BUG=none
TEST=none

R=ajwong@chromium.org

Review URL: http://codereview.chromium.org/8662047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112279 0039d316-1c4b-4281-b951-d872f2087c98

d4d57df4