- 15 Aug, 2019 40 commits
-
-
Mike Frysinger authored
The WrapOutputStream logic as written only works for Python 2. Python 3.7 added a dedicated API for this, but older Python 3 versions require a bit of effort. It's all a bit hairy, but there aren't any other options here. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I980fe4e92af7b5c0a44f25737ac267bb90d207d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755385Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#687293}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f714c29b97d0..74bf49a9abc9 git log f714c29b97d0..74bf49a9abc9 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 khokhlov@google.com Merge "Trace processor: Export legacy ftrace and json trace events to JSON" Created with: gclient setdep -r src/third_party/perfetto@74bf49a9abc9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Iad99ba8bbd2a6a9ee1af9fc163ea693237388b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755558Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687292}
-
Mike Frysinger authored
The Python folks decided to break re.sub behavior and have it randomly replace empty matches with non-empty strings. For example: >>> re.sub(r'(.*)', r'foo', 'asd') 'foofoo' To avoid this crazy pants behavior, we could make the regex match the entire string (by adding ^ and $ anchors), but this bit of code doesn't really need a regex at all. We're simply inserting the string "2x" before the last "/" in the filename. Rewrite the code to do a little ad-hoc string splitting instead as this is a bit easier to read. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I7aa005d685bb1019c464af1c1f12ce2701431ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755391Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#687291}
-
Mike Frysinger authored
We rely on the unicode(node) result for testing & display of the node state, but this doesn't work in Python 3 where str==unicode. Rename the exsting __unicode__ to __str__ and add a backwards compatible alias for Python 2. Now str(node) works in both. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I9cb3027d3f013e53c0a6bfc23705ea7a30e88ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755393Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#687290}
-
Julien Racle authored
If you include both base/win/async_operation.h and base/win/vector.h then a few aliases (like Complex, Abi) will collide. This CL proposes using dedicated type names to prevent collision to happen. BUG=728870 Change-Id: Ib7757ecd0793a25de18818f1156920973e8ef8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755748 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#687289}
-
Avery Musbach authored
Before the present CL, the caption buttons of a browser window would be hidden most of the time, but not at the moment when a browser window is created in tablet mode. Workflows such as entering and exiting overview would then cause the browser window caption buttons to be hidden because they were supposed to be hidden all along. As of the present CL, the caption buttons really will be hidden in the first place. The present CL adds a very flaky unit test. Without the present CL, the related test TabletModeBrowserCaptionButtonVisibility is already a little bit flaky, meaning that the present CL is not really introducing a new problem. The present CL just adds to the priority of addressing the preexisting test flake issue. See Issue 993974. Test: browser_tests HomeLauncherBrowserNonClientFrameViewAshTest.CaptionButtonVisibilityForBrowserLaunchedInTabletMode Bug: 993594, 993974 Change-Id: I63442abd452eba4ea6b35ad67273dec000ea1c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754239Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#687288}
-
Hirokazu Honda authored
AMD GPU driver shows the whole black frame if the surface size is coded size specified in the bitstream. This bug turns out when Android begins to inform the adjusted size (crrev.com/c/1694962 & crrev.com/c/1722468). This CL is a workaround for this driver bug. VaapiVDA ignores the frame size adjusted by a client and use coded size embedded in codec bitstream. Bug: b:139460315, b:139325471 Test: android.media.cts.EncodeDecodeTest on grunt and atlas Change-Id: Ic9b2d69b2ceb669e1e8660edc2df3f3f0fc20b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755434 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#687287}
-
Gabriel Charette authored
This is a reland of 1219f372 It was initially reverted per conflict with skyostil@'s crrev.com/686824 landing simultaneously. I fixed that in the reland that landed in crrev.com/687250 but crrev.com/686824 was reverted simultaneously making the first patch the one needed again... So I'm relanding the first CL as-is. Original change's description: > [base] Additional no-compile tests for traits_bag.h > > This assertion was tested in task_traits_unittest.nc already but it > should also be tested generically alongside the generic code. > > Change-Id: I77ea066a2a82c63f6ad8c692a23b93f74913fe1d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753655 > Auto-Submit: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686836} Change-Id: I39da37fc659a1bdf7476f772d816e43a3ef10df4 TBR=fdoray@chromium.org Change-Id: I39da37fc659a1bdf7476f772d816e43a3ef10df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756151Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#687286}
-
Yi Xu authored
remove (Canvas|OffscreenCanvas).TextMetrics.MeasureText metrics. Since measuring text is dependent on the length of the text, the measurement times are not comparable. Bug: 982019 TBR=rkaplow@chromium.org Change-Id: Iaddc190ba5d71a5aacdbe48ddff8427cbb616bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753588 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#687285}
-
Evan Stade authored
Recent changes have removed its usage throughout the codebase. Bug: 268984 Change-Id: Id6b211af5e99d8774f68db7235196f869ca782b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753548Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#687284}
-
Egor Pasko authored
Fix symlink creation for cases when the binary does not have build-id. When --symbols-dir is a relative path, the symlink under discussion would look like this: 'path/to/libfoo.so/000000000000000000000000000000000' -> (pointing to) 'path/to/libfoo.so/<HASH>' It works for absolute paths, but not for relative ones like 'path/to'. It will work for both absolute and relative paths if the link itself is relative and points to -> '<HASH>'. Fortunately it is easy to do. Done. Bug: None Change-Id: Ic764f0380063e2f2e15cf484afd5468dcca8f51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745986Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#687283}
-
Ryan Powell authored
This CL creates the MultiSourceMemoryPressureMonitor, MemoryPressureVoteAggregator, and MemoryPressureVoter classes described here: https://docs.google.com/document/d/1W3FPDyjIAKBcFGNYsHA3EKR1FHrJlbBaqT4_RUnxzq0/edit#. The aggregator class collects votes from voter instances via the OnVote method. A MemoryPressureVoteAggregator object will be owned by the MultiSourceMemoryPressureMonitor class, which will be merged with the MemoryPressureMonitor class after subsequent CL's which will migrate the OS-specific MemoryPressureMonitors to own a Voter and use that Voter to inform the Monitor of their votes. Bug: 980965 Change-Id: Ib84aadca9a4cf74b3c1f8a42787d63a96f5dfd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719109 Commit-Queue: Ryan Powell <ryanpow@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#687282}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/201cdbb64614..096b09187476 git log 201cdbb64614..096b09187476 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 bsalomon@google.com Make GrBlend.h private 2019-08-15 brianosman@google.com Add SkImage::reinterpretColorSpace 2019-08-15 egdaniel@google.com Remove remaining functions in GrGLCaps that use GrPixelConfig. 2019-08-15 michaelludwig@google.com Move the source image into Context Created with: gclient setdep -r src/third_party/skia@096b09187476 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: chromium:795132 chromium:985500 Change-Id: If39f8a34c9c0653236b6494284635a9c7d8d90a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755553Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687281}
-
Robert Ma authored
No-Try because the test hasn't arrived yet. TBR=lpz No-Try: True Bug: 994214 Change-Id: I522b21423261f1f9d3cdccad6c3a40edc78b9185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755973Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#687280}
-
Fred Mello authored
Bug: 949729 Change-Id: I8ebb40af59aea33f27e0a38e7ac6e617af099b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751963 Commit-Queue: Fred Mello <fredmello@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#687279}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/75b6f212c853..ae0f75063c10 git log 75b6f212c853..ae0f75063c10 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 chrisforbes@google.com Add libyarn static library to Android build Created with: gclient setdep -r src/third_party/swiftshader@ae0f75063c10 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139010488 Change-Id: I030e013b5fbd1123ec51b22de2e03d08d03931d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755556Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687278}
-
Justin Cohen authored
This reverts commit 0e2df95c. Reason for revert: Needs a bot upgrade instead (crbug.com/994039) Original change's description: > [ios] Fix host os targeting on chromium.clang/ios bots. > > Xcode 11 requires 10.14 > > Change-Id: Ib0e59878ee4bae8e76d73cd881dc58781becad95 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754323 > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686923} TBR=justincohen@chromium.org,jbudorick@chromium.org,hypan@google.com Change-Id: Ia12d64719ef0b1f964c4631dff2f4e738d45b4b6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756152Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#687277}
-
Alison Maher authored
This change updates the selection and search text/background colors in forced colors mode to HighlightText and Highlight. Bug: 970285 Change-Id: I170fdce8be02e31c26273e4eab5390427e672065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735471Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#687276}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5a3cb6082190..cb5f1034aafc Created with: gclient setdep -r src-internal@cb5f1034aafc The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I3cacd75b614402e63881fe02e370f9e0d9f4b95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755550Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687275}
-
Yusuke Sato authored
Currently, Chrome sends ARCVM's *guest* PIDs to debugd to adjust oom scores which doesn't make sense at all and may even have a serious side effect. Important host-side processes unrelated to ARC might be killed because of the bad oom scores adjustment. This CL temporarily disables the feature until we come up with a proper oom handling design for ARCVM. BUG=b:135633925 TEST=launch ARCVM, run 'grep 'WARNING debugd' /var/log/messages'. verify there's no warning from debugd. Change-Id: I541f7b0fe34fd80e82726ec30b32a63574e8d0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754783Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#687274}
-
Ayu Ishii authored
This change adds SMSReceiverStart to UKM use counters to record usage of the API and see how it is being used to help with improvements. More on metrics for SMS Receiver API here [1]. [1] http://doc/1dB5UM9x8Ap2-bs6Xn0KnbC_B1KNLIUv4W05MunuXYh0#heading=h.kwlb7w9qxxpc Bug: 976332 Change-Id: I10d6150b6fd2dc8e434a2486da18db134b3f39d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745608Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#687273}
-
Matt Falkenhagen authored
This makes the wrapper's internal methods also core thread-aware rather than assuming IO thread, following up to the public method changes from https://chromium-review.googlesource.com/c/chromium/src/+/1753843. After this CL, the plan is to locally change the thread to UI and see what breaks, and start landing CLs for the individual callsites to make them core thread-aware. Bug: 824858 Change-Id: I9c351fa77d83cee9ef60d6fa2afee2fc35570c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753847 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#687272}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/73af388b695c..7053241136b9 git log 73af388b695c..7053241136b9 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 khokhlov@google.com [Telemetry] Set intermediate_dir independent of output_dir Created with: gclient setdep -r src/third_party/catapult@7053241136b9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:981349 Change-Id: I3c157bb0874b68b65d0e510679e230a1146d5cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755554Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687271}
-
chrome://flags/enterpriseYann Dago authored
Light theme: http://screen/XMbqH13O2hu Dark theme: http://screen/AyXbKiGV8LZ Bug: 982371 Change-Id: I7b3d9ae278b32aa3f145fd68e05109424c82f227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724691 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#687270}
-
Gabriel Charette authored
TBR for missed doc update post rename in crrev.com/685964 TBR=skyostil@chromium.org Bug: 992483 Change-Id: Ie6c98ebc6d5e4ae1911e12f44c37a6fd49a797fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756163Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#687269}
-
Peter Kotwicz authored
This CL replaces CustomTabIntentDataProvider#removeTransparencyFromColor() with ColorUtils#getOpaqueColor() BUG=993651 Change-Id: Iff213215a83d0d7c270713ead16902828c1aef0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755185Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#687268}
-
Sean Harrison authored
and add some additional comments. Bug: 960513 Change-Id: I064a68d5baddff0c4b91582403615ba1043ceadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731136Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#687267}
-
Gabriel Marin authored
BUG=989976,b:131626644 Change-Id: Id64b1525946dcedbfd064a305d9ff37c45a3cf7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754158Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#687266}
-
Michael van Ouwerkerk authored
Screenshot links: * https://storage.cloud.google.com/chromium-translation-screenshots/db20d59a367785851159036132b461e7025c6fc8 * https://storage.cloud.google.com/chromium-translation-screenshots/cfc10fd03d677cb87c705fbfe45c7e312a618f14 Bug: 992345 Change-Id: Ida28748db6927e0b50930163877a915bfcd4c4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754011Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#687265}
-
Xida Chen authored
Right now the wpt/css/support/interpolation-testcommon.js is very specific to interpolations using CSS animations. As a result, it is used by a few tests only. This CL rewrites the file. To be more specific, most of the code comes from web_tests/animations/interpolation/resources/interpolation-test.js, which runs the tests with several interpolation methods: 1. cssAnimationsInterpolation 2. cssTransitionsInterpolation 3. cssTransitionAllInterpolation 4. webAnimationsInterpolation With this general test file, a lot of existing interpolation test can use this. Furthermore, the intention is to move non-wpt interpolation and composition tests to wpt using this file. Bug: 900581 Change-Id: I1058c556932d28709bacdb08a4591c958aead937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752103 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#687264}
-
Morten Stenshorne authored
Skipping this part isn't necessarily the right thing to do, but not protecting against it might cause infinite loops (no known test case at this point, but I'm planning on some changes that would cause it without this CL). Since nested column balancing isn't really properly supported anyway, disable this piece of the machinery for nested column balancing (i.e. a balanced multicol inside another balanced multicol). This will result in multicol containers too short to fit the content in some cases (but only if there is nested balancing). For now, the new flag added to NGConstraintSpace is only used for this, but it should also be useful for other purposes, such as only enabling code that does column-balancing stuff (such as space shortage calculation) when there's actually column balancing going on. Bug: 829028 Change-Id: Ibda95072b01e5b36c831e9d33a0f85b2accf7f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755984Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#687263}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/08233ee4998e..f411acf552ca git log 08233ee4998e..f411acf552ca --date=short --no-merges --format='%ad %ae %s' 2019-08-15 bratell@opera.com Make it possible to build a Windows SDK package without arm libs Created with: gclient setdep -r src/third_party/depot_tools@f411acf552ca The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: I3952a3fb646e81fc0a49a49160a03b0deca87299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755551Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687262}
-
Chris Hamilton authored
This migrates the last legacy GraphImplObserver client. BUG=910288 Change-Id: I49a146cd482ce5459678c7c43c4072988503546d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752629Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#687261}
-
John Budorick authored
This reverts commit b36e6e49. Reason for revert: causing CQ/CI compile failures again, e.g. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Builder/117358 Original change's description: > Reland "[base] Additional no-compile tests for traits_bag.h" > > This reverts commit 1d132585. > > Reason for reland: build failure is because this CL landed at the same > time as crrev.com/686824 which changed the semantics for HasTrait() > > Change-Id: I97c7cc0b41de444c31cd64017f0a3ab9e9be4093 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754095 > Commit-Queue: François Doray <fdoray@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687250} TBR=gab@chromium.org,fdoray@chromium.org,alancutter@google.com,mlamouri@chromium.org,nektar@chromium.org,maxmorin@google.com,findit-for-me@appspot.gserviceaccount.com Change-Id: Ib19084326e48618e304b2ac0a9548a831da4407f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756207Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#687260}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: Id47749adbf464389521b32ec8f92a69bde1e84b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756183 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#687259}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLMapElement> and DynamicTo<HTMLMapElement> as new downcast helper. 2. Use IsA<HTMLMapElement>(element) in place of IsHTMLMapElement(element). Bug: 891908 Change-Id: I59c06892f8ea7fcac84c532f1f4f6eb8b87a24d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755431Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#687258}
-
Saman Sami authored
When we don't have a current context, g_current_gl_context is not null. Instead, it's an instance of NoContextGLApi. In ExternalVkImageBacking ::Destroy, don't check that g_current_gl_context is null. Always call MakeCurrent. Bug: 939442 Change-Id: Icc4cc15daec78f32697d56cc102718cf5b0a229b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754708Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#687257}
-
Mike Frysinger authored
Currently if a node parsing logic fails in an unexpected way, we just show the exception name. This isn't super useful by itself as it lacks specific context, so include the exception value too. In the case of missing files, this will be the filename that the code was unable to locate. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: Id9b9fd3370c648099ded6bafa816323bdf0de96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755392Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#687256}
-
Mike Frysinger authored
We're running an integer through oct() to get a string of the octal number, which we then pass to int() to parse as a decimal number so we can finally pass to %d to get a padded string. 195 -> '0303' -> 303 -> '303' This relies on the exact output format of oct() which breaks when using Python 3 -- it outputs '0o303' which int() rejects. We can simplify this greatly by just switching from %d to %o and letting Python do the translation for us. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I9c379d0962819e69eed2890bc2369784c0a95ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755384Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#687255}
-
Lily Chen authored
Bug: 990439 Change-Id: Ibf7f5a23486f3d55d728c02c5d03bc34b1a4cfa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753590Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#687254}
-