- 16 Sep, 2016 40 commits
-
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/e14e226ba738..f93d71122e4f $ git log e14e226ba..f93d71122 --date=short --no-merges --format='%ad %ae %s' 2016-09-16 bungeman SkFontData to use smart pointers. 2016-09-16 robertphillips Add staging for removal of SkRRectsGaussianEdgeShader::Make (for Android) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347853002 TBR=bsalomon@google.com CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=djsollen@google.com Review-Url: https://codereview.chromium.org/2344943003 Cr-Commit-Position: refs/heads/master@{#419166}
-
chaopeng authored
Ignore other warnings when detected semi-colons in viewport tag. BUG=139428 Review-Url: https://codereview.chromium.org/2312303002 Cr-Commit-Position: refs/heads/master@{#419165}
-
harukam authored
BUG=none Review-Url: https://codereview.chromium.org/2342203003 Cr-Commit-Position: refs/heads/master@{#419164}
-
iclelland authored
BUG=647311 TBR=kenrb@chromium.org Review-Url: https://codereview.chromium.org/2342853003 Cr-Commit-Position: refs/heads/master@{#419163}
-
jri authored
BUG=646145 Review-Url: https://codereview.chromium.org/2344053003 Cr-Commit-Position: refs/heads/master@{#419162}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/6c4ad3383 BUG=601247 TBR=kdsilva@google.com Review URL: https://codereview.chromium.org/2349723002 . Cr-Commit-Position: refs/heads/master@{#419161}
-
eyaich authored
BUG=chromium:633253 Review-Url: https://codereview.chromium.org/2344163002 Cr-Commit-Position: refs/heads/master@{#419160}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/262052c9261a..e14e226ba738 $ git log 262052c92..e14e226ba --date=short --no-merges --format='%ad %ae %s' 2016-09-16 mtklein Tweak valgrind suppressions for intentional leaks. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=djsollen@google.com Review-Url: https://codereview.chromium.org/2347083003 Cr-Commit-Position: refs/heads/master@{#419159}
-
svillar authored
The code which computes the intrinsic logical width of the grid container and the rows sizes with indefinite height is exactly the same but operating in different axis. Refactored so that we don't have to write the initialization and tear down code twice. Review-Url: https://codereview.chromium.org/2347613003 Cr-Commit-Position: refs/heads/master@{#419158}
-
harukam authored
BUG=474318 TEST=manuallry tested Review-Url: https://codereview.chromium.org/2347063003 Cr-Commit-Position: refs/heads/master@{#419157}
-
agrieve authored
Ninja follows a symlink when stat'ing, so you can't use a symlink as an output and have dirty checking work properly. https://github.com/ninja-build/ninja/issues/1186 BUG=646165 Review-Url: https://codereview.chromium.org/2348793002 Cr-Commit-Position: refs/heads/master@{#419156}
-
ellyjones authored
Otherwise, moving the right edge of the window moves the switcher. Oops. This CL also refactors cocoa_l10n_util::ExperimentalMacRTLIsEnabled() to include a test for base::i18n::IsRTL(), since every callsite needed to check both. BUG=642732 Review-Url: https://codereview.chromium.org/2346783002 Cr-Commit-Position: refs/heads/master@{#419155}
-
svillar authored
Grid items have now a fixed height so that the grid could be seen when opening the test with a browser. This artificially improves the runs/s of the test because a fixed height is much cheaper to compute than an auto height, but we do not plan to change it so the test will still be sensitive to layout regressions. Review-Url: https://codereview.chromium.org/2345963002 Cr-Commit-Position: refs/heads/master@{#419154}
-
kdsilva authored
BUG=601247 Review-Url: https://codereview.chromium.org/2337013005 Cr-Commit-Position: refs/heads/master@{#419153}
-
fdoray authored
Now that SchedulerSequencedTaskRunner::RunsTasksOnCurrentThread() returns true iff the current task is part of the SchedulerSequencedTaskRunner's sequence, the TODO in SequencedWorkerPool::Inner::IsRunningSequenceOnCurrentThread() does not apply anymore. BUG=622400 Review-Url: https://codereview.chromium.org/2343803004 Cr-Commit-Position: refs/heads/master@{#419152}
-
harukam authored
BUG=554440 TEST=browser_tests --gtest_filter=GalleryBrowserTestInGuestMode.ResizeImageOnDownloads Review-Url: https://codereview.chromium.org/2299493002 Cr-Commit-Position: refs/heads/master@{#419151}
-
paulmeyer authored
I noticed that FrameTreeNodes that contain inner WebContentses have RenderFrameHosts that are marked "live" (for the purposes of RenderFrameHost::IsRenderFrameHostLive()) even though they do not have any associated RenderFrames. This patch fixes that. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2346673002 Cr-Commit-Position: refs/heads/master@{#419150}
-
gab authored
BUG=646443 Review-Url: https://codereview.chromium.org/2339253004 Cr-Commit-Position: refs/heads/master@{#419149}
-
foolip authored
WebIDL does not allow this: https://heycam.github.io/webidl/#prod-ExtendedAttributeList This was discovered by markdittmer@ when testing webidl2.js. The changes were made by running this Python script on all IDL files: with open(sys.argv[1], 'r+') as f: text = f.read().replace('[\n] ', '') f.seek(0) f.write(text) f.truncate() This also runs all IDL files through git stripspace, as a first step to ensure that the Python script wouldn't miss a case due to trailing whitespace. (The cases with comments inside were fixed manually.) R=rbyers@chromium.org,markdittmer@chromium.org Review-Url: https://codereview.chromium.org/2347803002 Cr-Commit-Position: refs/heads/master@{#419148}
-
jkrcal authored
With the current default value fetching_requires_signin=true, users get suboptimal UX after fresh install / after clearing app data. Because of bug 632199, the server-side variation parameters are not applied in the first run and sign-in is required. This is inconsistent with the second run of Chrome, where the server sets fetching_requires_signin:=false and no sign-in is required any more. BUG=646759 Review-Url: https://codereview.chromium.org/2343583002 Cr-Commit-Position: refs/heads/master@{#419147}
-
amalika authored
We had a boolean that replicated the meaning of m_headerType so all instance of the former were changed in favor of using isReportOnly class method. R=mkwst@chromium.org Review-Url: https://codereview.chromium.org/2340983004 Cr-Commit-Position: refs/heads/master@{#419146}
-
bruthig authored
Added a centralized style provider that can be re-used across all system tray rows eventually. This CL currently applies the font style to the TrayItemMore types only. BUG=637846 Review-Url: https://codereview.chromium.org/2244003002 Cr-Commit-Position: refs/heads/master@{#419145}
-
shaochuan authored
1. Move cacheHitHistogram count out of if statement to include memory cache hits, whose |m_loadStartTime| is 0. 2. Remove redundant checks in if statement. After previous refactoring, recordRemoteFont() is now only called once from notifyFinished(), and |font| here is always available and loaded. 3. Use DataSource to determine cases to record load time (data URL loads have non-zero |m_loadStartTime| but should complete immediately). Review-Url: https://codereview.chromium.org/2342273003 Cr-Commit-Position: refs/heads/master@{#419144}
-
maksim.sisov authored
This cl splits the big CL with changes to net/ folder and has changes only to net/url_request *fetcher_core files according to the changes to URLRequest API. What the big cl does: It modifies net/ clients that use URLRequest API as long as URLRequest::Read returns int net errors and URLRequest::Delegate and NetworkDelegate methods (for example, OnResponseStarted or OnCompleted) have int net_error in the arguments now. The reason behind splitting the CL into small one is that an android bot started to be unstable and unittests became flaky. It was not possible to locate the problem and the decision was to split the CL and upload small parts with a 6+ hours interval in order to make it possible to locate the problematic code. The big CL is located here - https://codereview.chromium.org/2265873002/ BUG=423484 Committed: https://crrev.com/a74d3cbc572fa1c85cc2c0434a9f8e2f9cba0cd9 Review-Url: https://codereview.chromium.org/2331853002 Cr-Original-Commit-Position: refs/heads/master@{#418014} Cr-Commit-Position: refs/heads/master@{#419143}
-
finnur authored
BUG=634039, 614277 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2338283002 Cr-Commit-Position: refs/heads/master@{#419142}
-
jkrcal authored
Currently, we instantiate the service in BrowsingDataRemover even when it does not exist, yet. This means that we instantiate it on non-android platforms, in unit-tests, etc. This CL changes the logic so that the service is accessed only if it has been created previously. This way, the BrowsingDataRemover respects the start-up logic that decides whether to create the service or not. BUG=647222 Review-Url: https://codereview.chromium.org/2342673004 Cr-Commit-Position: refs/heads/master@{#419141}
-
blundell authored
To start the servicification of //content's time zone monitoring code, this CL Mojoifies the ViewMsg_TimezoneChange message sent from the browser to the renderer. To do so, we introduce the TimeZoneMonitor Mojo interface (living in //device, where the implementation will move to), and change content::TimeZoneMonitor to implement the interface. Rather than notifying all RenderProcessHosts on a time zone change, content::TimeZoneMonitor maintains connections to the clients (RenderThreadImpl in this case) and notifies them directly on a time zone change. This CL uses the polling pattern described here: https://groups.google.com/a/chromium.org/forum/#!topic/mojo-dev/pSNDDN3gpFo for consistency with the way that the geolocation and battery monitor interfaces work (in practice, it's unlikely that time zone change updates would flood the client, of course). Followup will decouple content::TimeZoneMonitor from //content and move it to // device. BUG=612341 TEST=http://crbug.com/288697#c12: load the page, change the system time zone, and then click "recheck" to ensure that the renderer picks up the new time zone. Don't reload the page, which is likely to give you a new renderer process, use the "recheck" link on the page. Review-Url: https://codereview.chromium.org/2304073003 Cr-Commit-Position: refs/heads/master@{#419140}
-
kraynov authored
Added support for script protobuf compiler plugins. Removed |json_converter| option workaround. BUG=637292 Review-Url: https://codereview.chromium.org/2343833002 Cr-Commit-Position: refs/heads/master@{#419139}
-
tobiasjs authored
Because the compositor shares a context with the video resource updater, the copy target doesn't require a sync token. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2341743004 Cr-Commit-Position: refs/heads/master@{#419138}
-
peconn authored
- Add the tab strip height factor into the transition equation to make sure the transition is anchored to the top of the tab. - Override ntp_search_box_transition_length to make the transition take longer on tablets. BUG=625145 Review-Url: https://codereview.chromium.org/2345673002 Cr-Commit-Position: refs/heads/master@{#419137}
-
guidou authored
Linux and Windows were already reporting audio output device changes as DEVTYPE_AUDIO_CAPTURE. This CL basically renames DEVTYPE_AUDIO_CAPTURE to DEVTYPE_AUDIO and makes the CrOS device monitor to report audio-output device changes in addition to audio-capture devices. The only platform that needs further work is Mac, which currently does not report device changes for output-only devices such as USB speakers. BUG=587396 Review-Url: https://codereview.chromium.org/2326623003 Cr-Commit-Position: refs/heads/master@{#419136}
-
xiaochengh authored
BUG=647219 Review-Url: https://codereview.chromium.org/2345693005 Cr-Commit-Position: refs/heads/master@{#419135}
-
henrika authored
Revert of Removed duplicated JS hasVideoInputDeviceOnSystem() test helper (patchset #4 id:200001 of https://codereview.chromium.org/2310683003/ ) Reason for revert: Speculative revert from WebRTC-in-Chrome sheriff since it seems like this CL breaks content_browser tests on Windows 7. See https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/29582/steps/content_browsertests/logs/stdio for more details. Original issue's description: > Removed duplicated JS hasVideoInputDeviceOnSystem() test helper > > BUG=509735 > > Committed: https://crrev.com/8870e560931560b4dae5a1d2c87c5629b1e3c44e > Cr-Commit-Position: refs/heads/master@{#419008} TBR=mcasas@chromium.org,sky@chromium.org,jam@chromium.org,tommi@chromium.org,lunalu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=509735 Review-Url: https://codereview.chromium.org/2347473004 Cr-Commit-Position: refs/heads/master@{#419134}
-
shanmuga.m authored
SVG Image's width and height attributes will use intrinsic size, if css style size is 'auto' Spec: https://svgwg.org/svg2-draft/embedded.html#Placement https://svgwg.org/svg2-draft/geometry.html#Sizing BUG=493681 Review-Url: https://codereview.chromium.org/2230963002 Cr-Commit-Position: refs/heads/master@{#419133}
-
sakal authored
Enable HW encoding on Android. This code has been in the code base for a very long time but it was never enabled. This CL fixes a small bug in it and enables it. BUG=445320, 638664 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2288103003 Cr-Commit-Position: refs/heads/master@{#419132}
-
yosin authored
This patch converts "editing/pasteboard/displaced-{,generic-}placeholder.html" to use w3c test harness to simplify test script, and consolidates into "editing/inserting/insert_and_placeholder.html" since these test scripts verifies "insertHTML" command with similar test sample, for improving code health. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2341953005 Cr-Commit-Position: refs/heads/master@{#419131}
-
hiroshige authored
To make clear that the SharedBuffer() returned by resourceBuffer() is not modified outside Resource class. BUG= Review-Url: https://codereview.chromium.org/2220543002 Cr-Commit-Position: refs/heads/master@{#419130}
-
sakal authored
The new API is implemented in this CL: https://codereview.webrtc.org/2337883003/ BUG=webrtc:6329 Review-Url: https://codereview.chromium.org/2337913002 Cr-Commit-Position: refs/heads/master@{#419129}
-
yamaguchi authored
Existing code will not build when building chromeos_unittests target following the simple chrome build instruction http://www.chromium.org/chromium-os/how-tos-and-troubleshooting/building-chromium-browser with BOARD=x86-generic, for example. TEST=chromeos_unittest built successfully following the instruction above, and the test passed. Review-Url: https://codereview.chromium.org/2344893002 Cr-Commit-Position: refs/heads/master@{#419128}
-
tyoshino authored
Tries to make the code a little more readable to help debugging the associated bug. For the OK result, BoundNetLog::EndEventWithNetErrorCode() was called after BoundNetLog::EndEvent() in WebSocketTransportClientSocketPool::RequestSocket(). Fixed this to call only EndEvent(). Removed pre-condition checks before ActivateStalledRequest() which are already performed by its while loop. Added DCHECK_NE(error, OK) to FlushWithError() to make sure OK is never received from that path. Reordered some lines. R=yhirano@chromium.org,mmenke@chromium.org BUG=642363 Review-Url: https://codereview.chromium.org/2328453002 Cr-Commit-Position: refs/heads/master@{#419127}
-