GitLab

dbus_unittests relies on the presence of /usr/bin/dbus-launch, which is provided
by the dbus-x11 package.  The absence of this package is currently causing
dbus_unittests to fail on the Linux Xenial bot.

BUG=789768
R=dpranke
NOTRY=true

Change-Id: Ic844648f3651e518e276c1fb764849b09145b34b
Reviewed-on: https://chromium-review.googlesource.com/924693
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537483}

Change-Id: Ia357ad7fcc51722ad6e2106d74bfaac569e94f13
Reviewed-on: https://chromium-review.googlesource.com/924652
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Buck Krasic <ckrasic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537482}

Really fixes the Android test failure this time, by delaying the DCHECK on
process type until after we've considered whether the OS is supported by the
profiler. This has been validated by running the test on Android hardware. The
suspected issue is that Android test is not setting the process type command
line switch, which is being DCHECKed in the profiler code.

This is a reland of 106dd071.

Original change's description:
> Second reland of "Encapsulate Chrome thread profiling setup into a single class"
>
> Fixes Android test failure by avoiding implicit creation of the render
> thread. Also moves the decision on whether to profile extension processes into
> the StackSamplingConfiguration, and cleans up comments.
>
> This is a reland of f8ad6e3e.
>
> Original change's description:
> > Reland "Encapsulate Chrome thread profiling setup into a single class"
> >
> > This is a reland of aa63fc1d.
> >
> > Original change's description:
> > > Encapsulate Chrome thread profiling setup into a single class
> > >
> > > Creates a simple abstraction around the fairly complex profiling setup.
> > > This CL switches over the GPU and renderer process usage to this class.
> > > The browser process usage will be converted to use this class after it
> > > is extended to support periodic profiling (in a follow-on CL).
> > >
> > > Bug: 808588
> > > Change-Id: I6195571bf3ddd08291f288f475569bd9a88795ef
> > > Reviewed-on: https://chromium-review.googlesource.com/905451
> > > Reviewed-by: Scott Violet <sky@chromium.org>
> > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> > > Commit-Queue: Mike Wittman <wittman@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#535125}
> >
> > TBR=sky
> >
> > Bug: 808588
> > Change-Id: I34f1910116c4e7a500e353c27b85bf7534be43c7
> > Reviewed-on: https://chromium-review.googlesource.com/907508
> > Reviewed-by: Mike Wittman <wittman@chromium.org>
> > Commit-Queue: Mike Wittman <wittman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#535170}
>
> Bug: 808588
> Change-Id: Id34e6a3e57c144697413ecced43146bf3e6521e9
> Reviewed-on: https://chromium-review.googlesource.com/917197
> Commit-Queue: Mike Wittman <wittman@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537023}

Bug: 808588
Change-Id: Id93da3a3699b364e3d592823d4326b903b0c5a40
Reviewed-on: https://chromium-review.googlesource.com/923217Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537481}

This was added to support closing the app list bubble on Windows.
At the time, Windows bubbles were constructed of two nested HWNDs.
The app list bubble no longer exists and bubbles are now one HWND.

Bug: 189112
Test: No Min/Max/Restore/Close windows system command behavior changes.
Change-Id: I0a3ead068a54cb7c2a3ba44c4b7af7e38bcba2a7
Reviewed-on: https://chromium-review.googlesource.com/924315Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537480}

_AddNmAliases() updates raw_symbols by adding symbols that have the
same address as existing ones, but with different names. For example,
let raw_symbols be:
  [A1, X, B1, B2, B3, Y, C1, C2],
and suppose X can be replaced with [X1, X2, X3] and Y with [Y1, Y2].
The old code modifies raw_symbols in place by adding gaps first:
  [A1, X, B1, B2, B3, Y, C1, C2, ?, ?, ?],
then move elements to gaps (! are overwritable, including Y):
  [A1, X, B1, B2, B3, !, !, !, ?,  C1 ,C2],
then writes the new symbols in reverse order:
  [A1, X, B1, B2, B3, !, !, Y2, Y1, C1 ,C2].
Repeating (X writable):
  [A1, !, !, !, B1, B2, B3, Y2, Y1, C1 ,C2],
  [A1, X3, X2, X1, B1, B2, B3, Y2, Y1, C1 ,C2].

The code works but is rather complex, and it reverses the order of
new symbols inserted. This CL simplifies the code by allocating a new
array, and insert new symbols in order (of whatever |names_by_address|
returns). The obtained result for the example would now be:
  [A1, X1, X2, X3, B1, B2, B3, Y1, Y2, C1 ,C2].

Note the change of new elements' order. As a result, this CL affects
patch content, and requires change in test data. The computation time
of _AddMnAliases() is negligible (~0.1s).

Change-Id: I5bfb7cceb9e1ebbdf493cea55c92144581721b40
Reviewed-on: https://chromium-review.googlesource.com/922986Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537479}

Issue 61674 and 515257 shows web developer want to call js scroll to
prevent browser scroll restoration. Currently Chrome don't support this.
This patch is to Measure how many pages try to do that.

Bug: 515257, 61674
Change-Id: I7773c1db6f85d1da0f196a2e43fce5faba35e5a9
Reviewed-on: https://chromium-review.googlesource.com/889184Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537478}

Bug: 812947
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If2a653a7784b464d44bbde72d42df0ca719c2e90
Reviewed-on: https://chromium-review.googlesource.com/923580Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537477}

The PrefetchedPagesTracker is used to see if suggestions have corresponding
offline pages, in which case they may be given longer lifetime before expiration.
The check is done after remote provider does a "Fetch", which brings new suggestions
and starts suggestions integration. The whole thing is asynchronous and can trigger
load of offline pages database right after the fetch rather than at the moment of
creation, as it does it currently.

Loading Offline Pages database on Chrome startup becomes too expensive as number
of offline pages grows so it needs to become more on demand.

TBR: vitaliii@chromium.org
Bug: 793109
Change-Id: I919c5c777e8363c194c49cce1fd86076b87ead4d
Reviewed-on: https://chromium-review.googlesource.com/906103Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Patrick Noland <pnoland@google.com>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537476}

This avoids code having to hold on to a raw pointer only. At the same time, it's safe to pass a
pointer to the SharedURLLoaderFactory to other code which doesn't know about it and only expects
a URLLoaderFactory*.

Change StoragePartition::GetURLLoaderFactoryForBrowserProcess to return a SharedURLLoaderFactory as
an example. This avoids consumers, which may be in components and don't know about
StoragePartition, from holding on to the raw pointer past the lifetime of profile. The returned
implementation always calls back to StoragePartition, which allows it to work across restarts of
the network services.

A future change will modify URLLoaderFactoryGetter (used on IO thread). Keeping it separate because
this change is already large.

Bug: 773295
Change-Id: I885a0c3771d78d9daa16c767c7e7dc085cdbfb55
Reviewed-on: https://chromium-review.googlesource.com/924173
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537475}

Also changes the refactors the creation of the ShareParams instance for
the offline page to accept a callback for the send the result and run
the needed IO operation in a background task (avoiding strict-mode
violations).

Bug: 758690
Change-Id: I57cd200961b851dc384ee11ca118a791244a3d7c
Reviewed-on: https://chromium-review.googlesource.com/923361
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537474}

The old keychain wrapper doesn't handle multiple keychain entries and
can't deal with the new keychain schema.

This CL implements a new keychain wrapper for committing
(Key, Account, Security Value) entry and doing
(Key, Account)->Security Value lookup.

BUG=811380

Change-Id: Id2ea073fb5b171fa105a7379a29f7884a0a2f57d
Reviewed-on: https://chromium-review.googlesource.com/917523
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537473}

re-land d70e8035 which broke the mac compile
(message_center_unittests are apparently not built on mac on the CQ)

TBR=rdevlin.cronin@chromium.org

Bug: 578868
Change-Id: I9e07913e4145034a97744c6ad67cf5c59ae961fa
Reviewed-on: https://chromium-review.googlesource.com/923571Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537472}

This test is failing with a pending WebRTC change. It will be
re-enabled and fixed once that change rolls in.

Bug: 813215
Change-Id: I448ba431da7d00b2b04fab2c471d301ecf18310c
Reviewed-on: https://chromium-review.googlesource.com/924610Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537471}

On Cocoa and mobile platforms we would ask the user if they want to
enable "Always Translate" on the initial prompt after they accepted the
translation enough times. This patch adds that capability, in the form
of a checkbox on the translate bubble, to Views platforms.

Bug: 808754
Change-Id: I70149c0e077d70d64a6b6e26f5599a6c39cefda4
Reviewed-on: https://chromium-review.googlesource.com/917641
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537470}

This extracts DevToolsNetworkInterceptor as an interface between
NetworkHandler and the implementation of network request interceptor.
The only current implementation is DevToolsURLRequestInterceptor, but
the URLLoader-based implementation will share the interface.

Bug: 812464
Change-Id: I3c3c00fce2bae7e9278b05eb688f3dda1e8b10c3
Reviewed-on: https://chromium-review.googlesource.com/920795
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537469}

BUG=810917

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I76d2bbae723009eabb528d6ff50f3aa98a739e4f
Reviewed-on: https://chromium-review.googlesource.com/924452Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537468}

The test case passes in SPv175 (enabled by default), fails otherwise.

Bug: 809102
Change-Id: Ic83e3ad785f1b10fb8c359fddb61c5672a6f8e33
Reviewed-on: https://chromium-review.googlesource.com/924622Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537467}

Cause ... why bother keeping two different limits? It can only create
bugs. And does.

Bug: 807833
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I0bd136cbfe844a8ce1729c51991f360fca0fe7d5
Reviewed-on: https://chromium-review.googlesource.com/919493Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537466}

On Android, we can expose EXTRA_DATA_TEXT_CHARACTER_LOCATION_KEY
on accessible nodes in order to allow services like Select To Speak
to get the bounding box of individual characters or character
ranges.

When we implemented support for this, we exposed it on almost any
element, but this leads to Select To Speak not being able to
distinguish between real text, and things like images with no
visible text that it might be able to OCR.

Fix this by exposing this character location key only on nodes
that are static text or have a static text descendant.

Add a test that covers some common cases.

BUG=812772

Change-Id: I48941edfaa7522fdd36a5bd7fc88a0a4054713f3
Reviewed-on: https://chromium-review.googlesource.com/922688
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537465}

Merge internal change: 186016017

Change-Id: I0b1aa566e794c6360877eb9f3c05dcdcf3247c9a
Reviewed-on: https://chromium-review.googlesource.com/924443Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537464}

When we remove a page from download home, we also should tell the
Android Download manager that the offline page is no longer
available so it can get properly cleaned up.

Bug: 758690
Change-Id: Ifd492c4c505e3b0eab36fabf044612e23fb128da
Reviewed-on: https://chromium-review.googlesource.com/912766Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537463}

A BlobDataHandle could not have a content_type set, but that should be
treated no different from an empty string, so serialize it as such.
Otherwise this will trigger validation failures causing weird behavior
when for example a blob without a content type is posted on a
MessagePort.

Bug: 813146
Change-Id: I0a20a6b91391e9aa490a337b93c74f9ab4316e31
Reviewed-on: https://chromium-review.googlesource.com/924338
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537462}

Spellcheck was mojofied in crrev.com/c/846370, but relevant files
are left without being renamed, so that we don't break git revision
log. This patch finishes the renaming.

Bug: 714480
Change-Id: If6df9357871a4a2e353f3ab336878d3be891c596
Reviewed-on: https://chromium-review.googlesource.com/898529Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537461}

https://boringssl.googlesource.com/boringssl/+log/67968895b3b8cace34ea6dbdf65ac922667959ac..085955c56744a9cc82f98ed850deca2165252d2c

BUG=none

Change-Id: I0f487c4379cc2afe960f958ba137373c89eb1011
Reviewed-on: https://chromium-review.googlesource.com/924344
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537460}

- Define GetCdmProxyContext() interface and the default implementation.
- Define CdmProxyContext interface.
- The interface will be used to get data from CdmProxy implementation
  required for decrypting/decoding.

Bug: 799310
Change-Id: I1f1bdd7036ebbd2598371b249a7e85e1fe90e7f2
Reviewed-on: https://chromium-review.googlesource.com/915215
Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537459}

The bug was the VrShellGl::OnVSync is called every frame (by the Android
Choreographer), and we would restart the timer from the beginning. As a result
it would never actually fire.

In this CL, we only schedule the timeout if there's a state change from when
we start sending VSyncs to the WebVR page again. Note that we only ever stop
sending VSync for DLAs so that we can show the splash screen for a minimum
duration, so what this effectively means is not scheduling timers in OnVSync
for non-DLA WebVR presentations.

Bug: 812292
Change-Id: I06c58b8902704f5d3033ded4ad7839f077e71052
Reviewed-on: https://chromium-review.googlesource.com/923547Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537458}

This cl handles the ui::VKEY_BACK. If it is already empty search box and
typing ui::VKEY_BACK will exit search mode in Keyboard Shortcut
Viewer (KSV).

Bug: 768932
Test: Tested on device.
Change-Id: I5cee02a97959784163e65e300b5113f2a3409513
Reviewed-on: https://chromium-review.googlesource.com/923090
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537457}

Kochi Mincho is old and is not available on newer linux distros.  IPA Mincho is
a suitable replacement.  However, the IPA font metrics are slightly different
than Kochi.  There were some test expectations that certain font metrics (like
baseline) be different from Arial, but they're conincidentally not for IPA.  I
also swapped out Arial for Verdana so that the metrics would still be different.

BUG=812911
R=derat
TBR=asvitkine

Change-Id: Ida904c06ad8aa962ac850ff47cda1170103638fa
Reviewed-on: https://chromium-review.googlesource.com/923551Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537456}

This reverts commit b5d6f42d.

Reason for reland: The revert didn't fix the failing tests

Original change's description:
> Revert "[jumbo] avoid helper function collisions in VisibleUnits*Test.cpp"
> 
> This reverts commit 53413b13.
> 
> Reason for revert: (sheriff) Attempt at addressing failure at:
> https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/66387
> 
> Original change's description:
> > [jumbo] avoid helper function collisions in VisibleUnits*Test.cpp
> > 
> > This fixes jumbo builds after https://chromium-review.googlesource.com/923604
> > 
> > Change-Id: Ib7030da7e0a6acfdad8200564f9375ba218e8ca6
> > Reviewed-on: https://chromium-review.googlesource.com/923723
> > Reviewed-by: Fredrik Söderquist <fs@opera.com>
> > Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
> > Cr-Commit-Position: refs/heads/master@{#537278}
> 
> TBR=yosin@chromium.org,fs@opera.com,mostynb@vewd.com
> 
> Change-Id: I5b31694096f982e50954ee959b7e5c58d04a77f9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/923374
> Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537400}

TBR=yosin@chromium.org,fs@opera.com,dschuyler@chromium.org,mostynb@vewd.com

Change-Id: I922f59a9b1cd3fe66e277a05118685ed008ad88b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/924591Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537455}

SlimmingPaintV175 enables raster invalidation and paint chunks based
on paint properties. See crbug.com/771643.

Bug: 771643
Change-Id: I5fdbcabc7ca0f2fa8e69ae0fbf5a0077bba46cfe
Reviewed-on: https://chromium-review.googlesource.com/923572Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537454}

The UseCounter being on the partial interface wasn't actually counting
anything. Move to the attribute instead.

Confirmed in V8CSSPartial generated code that this is now doing the
right thing.

Change-Id: Iab0f50535f7a06e4c2ff1172b7c80133554f9ae7
Reviewed-on: https://chromium-review.googlesource.com/923542Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537453}

Since 8a14e909 we dispatch device change notifications when palm suppression
state changes. This is causing context menus to be dismissed erroneously on stylus
lift. It's unclear why this is happening and should be fixed, but for now just
revert to the old behavior.

This is a partial revert of 8a14e909.

Bug: 810599

Change-Id: Ida6b01f225e35cc7e04b603055a69a25c3f0163d
Reviewed-on: https://chromium-review.googlesource.com/923214
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537452}

It looks like we have plenty of capacity.

R=jbudorick@chromium.org
BUG=694033

Change-Id: I36c232b1a3fd3a91a501144630bf6ff7ec73a9dc
Reviewed-on: https://chromium-review.googlesource.com/920657Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537451}

Additionally, this CL updates CRWGenericContentView's contentSize
adjustment logic to ensure that scrolling doesn't get disabled.

Bug: 807957
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idf48f9b79966520f31477b0a58415eb286f037ae
Reviewed-on: https://chromium-review.googlesource.com/917642Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537450}

This reverts commit 4de65ba0.

Reason for revert: Causing 'gn gen' on Mac builder to fail:
https://ci.chromium.org/buildbot/chromium/Mac/38303

Original change's description:
> Mac SelectFileDialog TLC
> 
> - Resurrects shell_dialogs_unittests on Mac
> - Fixes 2 tests that had regressed since the gn transition.
> - Tweaks the code to be more robust around complex object lifetimes.
> - Adds test SelectFileDialogMacTest.Lifetime
> 
> Bug: 788271
> Change-Id: Ice43179a1da3b7bbcd44fb9b0efdf6d84e4d2f5b
> Reviewed-on: https://chromium-review.googlesource.com/920961
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Trent Apted <tapted@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537419}

TBR=avi@chromium.org,tapted@chromium.org,rsesek@chromium.org

Change-Id: I24a41bcb566a2bff3e58b5babce7ec77b43d0b63
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 788271
Reviewed-on: https://chromium-review.googlesource.com/924483Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537449}

https://chromium.googlesource.com/angle/angle.git/+log/17448956b720..0cbfa5866f43

$ git log 17448956b..0cbfa5866 --date=short --no-merges --format='%ad %ae %s'
2018-02-15 jmadill Vulkan: Implement basic Renderbuffer attachments.
2018-02-16 oetuaho Simplify built-in function node initialization

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: I2fe98dedbab2dbb2bf2071f970de3257c8a99165
Reviewed-on: https://chromium-review.googlesource.com/924467
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#537448}

Bug: 804499
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I066fc6b53f8f2775f559f8dd75ab63d629b74e9d
Reviewed-on: https://chromium-review.googlesource.com/924381
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537447}

Touching VERSION elicits a regeneration of all mojom message IDs on
platforms where message ID scrambling is enabled.

Before this CL, that regeneration step induces a rebuild of over
13000 targets when building chrome, as all mojom headers are
regenerated, and dependencies on mojom headers abound.

After this CL, the regeneration step only forces a rebuild of
a new per-mojom header dedicated exclusively to message ID
definitions, affecting only the corresponding mojom.cc files
and reducing the rebuild cost to about 2700 targets.

This also introduces a new GN arg |enable_mojom_message_id_scrambling|
which defaults to |true|, enabling the current scrambling behavior on
all supported platforms. If set to |false|, message IDs will never
be scrambled and changes to VERSION won't affect mojom in any way.

Bug: 808162
Change-Id: I8c4e4fa1dcc8d1d4349febee7dea6cce824ca0a6
Reviewed-on: https://chromium-review.googlesource.com/900528Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537446}

This logic happens behind the flag --cc-check-damage-early.

If any of the last 3 frames had no damage, we enable the damage check in
WillBeginImplFrame from crrev.com/c/767851. This is described further here:
https://docs.google.com/document/d/1Onv9teMJMyT63-8NywNQfaYY2PRTujvqI9Xa9jGcXvY

Bug: 687695
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ie77abd0f587dc9815012bde87d5d0354a2f9cbbf
Reviewed-on: https://chromium-review.googlesource.com/854991Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537445}

These patches are taken out of googletest update
https://crrev.com/c/900544. That CL has been reverted, and fixing the
revert cause may take a while. Landing these patches now, separately,
will reduce the size of the next googletest update CL, and might reduce
code churn, if the googletest update CL needs to be reverted.

Bug: 813219
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I19022e107f459e1dce91921336346c610ec51409
Reviewed-on: https://chromium-review.googlesource.com/924444
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537444}