- 07 Jun, 2018 40 commits
-
-
Amy Qiu authored
Move image_decoding_cases into rendering folder and modify to inherit from RenderingStory class Bug: 849392 Change-Id: I56b02c60c1f674f7c48b8bf378b8bc92f68f4205 Reviewed-on: https://chromium-review.googlesource.com/1089290 Commit-Queue: Amy Qiu <amyqiu@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#565377}
-
Kevin Marshall authored
fidl_library.gni will be used for targets defined outside "third_party", so promoting the GN template to a higher level makes sense. The relocation was verified using "gn gen --check". TBR=sergeyu@chromium.org Change-Id: Ib632e466185f77f7b4f5bc43b13439bdd28faf3c Reviewed-on: https://chromium-review.googlesource.com/1091157Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#565376}
-
Bailey Berro authored
This change creates the NetBiosClientInterface. This interface will allow us to create a FakeNetBiosClient that can be injected into the NetBiosHostLocator class for testing. Bug: chromium:757625 Change-Id: Iadf5965ce43a504f5babe2220944d91b48b9d537 Reviewed-on: https://chromium-review.googlesource.com/1081299 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#565375}
-
liberato@chromium.org authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/1da9c3346d87..f7d78b109d17 $ git log 1da9c3346..f7d78b109 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 liberato Updated chromium/patches/README 2018-05-31 michael avcodec/vp3: Fix end of bitstream check in unpack_superblocks() 2018-06-05 liberato Automatically build chrome patches with find_patches.py 2018-05-31 modmaker Fix heap buffer overflow. 2018-06-01 liberato Add check_merge.py 2018-05-24 liberato Add null check for encryption info. 2018-05-21 liberato Configs for merge-m68a 2018-05-15 michael avformat/mov: Only fail for STCO/STSC contradictions if both exist 2018-05-15 michael avformat/mov: Break out early if chunk_count is 0 in mov_build_index() 2018-05-20 jerome.borsboom avcodec/vc1: FIELDTX is only present in interlaced frame I/BI pictures (...) Created with: roll-dep src/third_party/ffmpeg BUG=832852 Change-Id: If5ffa2bfedd2bdd9a43ac338455af9993d634b93 Reviewed-on: https://chromium-review.googlesource.com/1087767Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#565374}
-
Tom Anderson authored
Now that the app shell is being built on the bots, it shouldn't give verbose logging output during the build. This CL is a partial merge of [1], which fixed the issue for the Linux Chrome packages. [1] https://chromium.googlesource.com/chromium/src/+/8e3b5543f0dfc6585ad06aa2c2235a3a813438cd BUG=None R=michaelpg Change-Id: Id97fe1b3e6694a15e36f324d954a9fa7e2b61e7b Reviewed-on: https://chromium-review.googlesource.com/1091295Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#565373}
-
Ryan Landay authored
We previously had a behavior in the new Android horizontal tab switcher where opening the tab switcher would show the previous tab instead of the current one. I previously landed a CL to remove this behavior, but swiping down from the toolbar is still showing the previous tab. It turns out there's a totally separate piece of pre-existing logic that, together with the scroll snapping, is actually causing swiping down from the toolbar to still go to the previous tab. We of course did not notice this prior to removing the "show previous tab" behavior. This CL fixes this pre-existing logic to not show the previous tab. Bug: 849480,831359 Change-Id: I0b89f87e536c5d4938638fbd6ac7fabde568e772 Reviewed-on: https://chromium-review.googlesource.com/1091230Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#565372}
-
Wez authored
These tests mix use of QuitCurrent*Deprecated() with use of the current RunLoop::Quit*Closure() model. Migrate them off the deprecated API so that we can enforce quit-by-closure-only wherever QuitClosure is used. Bug: 844016 Change-Id: I5c8b2557d361ea9ade9f5da0440bac7f7878440e Reviewed-on: https://chromium-review.googlesource.com/1090214Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#565371}
-
Jun Choi authored
Add function to convert byte array spans into stringpiece representations in fido_parsing_utils. Change-Id: I8a5aca9c980cee994aeb6b46fd2cfd7f5417998c Reviewed-on: https://chromium-review.googlesource.com/1087816 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#565370}
-
Wez authored
content:Shell used QuitCurrent*Deprecated(), while many of the //content browser-tests use the modern RunLoop::Quit*Closure() mechanism. Migrate content::Shell off the deprecated API, so that we can enforce quit-by-closure-only wherever QuitClosure is used. TBR: kinuko Bug: 844016 Change-Id: I661c3ed1c799680dea9760d3fb43d78aa8039897 Reviewed-on: https://chromium-review.googlesource.com/1090219Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#565369}
-
Antonio Gomes authored
We are in the process of migrating ContentHashFetcher from URLRequestFetcher to SimpleURLLoader (see bug 844926). For this, we need to stop storing URLRequestContextGetter raw pointers in ContentHash::FetchParam. Instead it will store a std::unique_ptr<network::SharedURLLoaderFactoryInfo> instance, which is non-copyable. This is a preparation CL that adapts ContentHash::FetchParam to hold non-copyable members. For this, it removes both copy-ctor and the assignment overload (=), and uses std::move to pass FetchParam instances around. BUG=844926 Change-Id: I417543ddd377eef39146fcce69c325a35c499f6c Reviewed-on: https://chromium-review.googlesource.com/1089273 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565368}
-
Jeremy Roman authored
Bug: 843124 Change-Id: I56b9beb4e16e74361cf291998fc78ec232c6fc0c Reviewed-on: https://chromium-review.googlesource.com/1089587 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#565367}
-
Peter E Conn authored
Bug: 813104 Change-Id: I0139374f0f05c2a685d413e8c9d4bfcd5204cd67 Reviewed-on: https://chromium-review.googlesource.com/1088702 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#565366}
-
Marijn Kruisselbrink authored
Also rename from LevelDBWrapper to StorageArea to better reflect what the interface is used for. Bug: 781870, 809771 Change-Id: I712fee920d95f5e18dc6bfa74d1277c8aed4bd19 Reviewed-on: https://chromium-review.googlesource.com/1087495Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
James Wallace-Lee authored
SynchronousCompositorProxy only uses mojo and no longer uses the old IPC. Mojo is now the default implementation rather than a subclass of SynchronousCompositorProxyMojo. Bug: 687695 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ieddf50f1441648ba1a88197b690b321ff6f83ba1 Reviewed-on: https://chromium-review.googlesource.com/1062956Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#565364}
-
Vadym Doroshenko authored
Bug: 831123 Change-Id: Ic6e39ee80a0db626b04b163314ed9589997fa268 Reviewed-on: https://chromium-review.googlesource.com/1090928Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#565363}
-
Ben Pastene authored
This reverts commit 43bebb1d. Reason for revert: suspected to have broken analyze on android CQ bot https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel?limit=200 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-kitkat-arm-rel/6471 ERROR at //components/browser_sync/profile_sync_test_util.cc:27:11: Include not allowed. #include "services/network/test/test_url_loader_factory.h" Original change's description: > Migate SyncStoppedReporter to SimpleURLLoader > > Bug: 844966 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I3c198d95735770668eed4a1342a3979224239529 > Reviewed-on: https://chromium-review.googlesource.com/1089132 > Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565321} TBR=sky@chromium.org,mmenke@chromium.org,pilgrim@chromium.org,mastiz@chromium.org Change-Id: Iaf73cd80c169fc9451d82c42f807685258d3b09f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844966 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1091306Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#565362}
-
Kevin McNee authored
This reverts commit c7c852a5. Reason for revert: This did not revert cleanly. generate_build_files is failing e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-gcc-rel/12779 Original change's description: > Revert "S13n: Port components/image_fetcher to SimpleURLLoader." > > This reverts commit d6f27e51. > > Reason for revert: image_fetcher is used from more than UI thread, > and SharedURLLoaderFactory isn't cross-thread. > > Note that this isn't a 100% mechanical revert since it needed a merge > with some ImageDataFetcher cleanups; I also kept in some iOS glue bits > that are used in a pending CL and aren't directly related to the substance > of the revert. > > Bug: 850089 > > Original change's description: > > S13n: Port components/image_fetcher to SimpleURLLoader. > > > > URLFetcher will stop working in the browser process with advent > > of Network Service, and SimpleURLLoader is the replacement API > > for most clients. > > > > Bug: 843205 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet > > Change-Id: I23f22f2b00e4ece0ca85d0bad95909cd15309eb6 > > Reviewed-on: https://chromium-review.googlesource.com/1060254 > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#564526} > > TBR=rogerta@chromium.org,jam@chromium.org,mathp@chromium.org,eugenebut@chromium.org,gambard@chromium.org,morlovich@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 843205 > Change-Id: Ifeb0c24a9e83bf271be3f10cb32f6d81ea0d0832 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/1090930 > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565348} TBR=rogerta@chromium.org,jam@chromium.org,mathp@chromium.org,eugenebut@chromium.org,gambard@chromium.org,morlovich@chromium.org Change-Id: Iee4b628c585b7f3f4509f4dc0c691a012d31c874 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850089, 843205 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1091305Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#565361}
-
Nico Weber authored
It already runs on the regular linux main waterfall and memory bots. TBR=hans Bug: 843511 Change-Id: I3f5f97694291f4143614fb2b72344dda31cf1556 Reviewed-on: https://chromium-review.googlesource.com/1091141Reviewed-by:
-
Toni Barzic authored
BUG=NONE Change-Id: I6130bcff05d90ad35b3106eeee6d8973c58b8c11 Reviewed-on: https://chromium-review.googlesource.com/1090311Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#565359}
-
Florin Malita authored
https://github.com/w3c/csswg-drafts/issues/2714 clarified that serialization should always use the expanded form. Bug: 850537 Change-Id: I77e60df149fb490b0c2c1db78f020a7246ea7b5c Reviewed-on: https://chromium-review.googlesource.com/1090820Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#565358}
-
Ben Pastene authored
We collect logs from the VM after tests. The problem is, if the test hangs indefinitely, we won't get a chance to grab the logs before swarming kills us when we reach the timeout. Swarming sends a SIGTERM, waits for grace_period, then SIGKILLs the task if it's still running. This CL will catch the SIGTERM and kill what should be the frozen test process. This will let cros_run_vm_test pull the logs before we get SIGKILLed. Bug: 848402 Change-Id: I48be1de865e3b287584978b5461f15e2bae49dfd Reviewed-on: https://chromium-review.googlesource.com/1087800 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#565357}
-
Jonathon Kereliuk authored
This CL renames the send_command_and_get_result endpoint to /goog/cdp/execute which follows the extension specification format and is a more appropriate API name. Note we still support the old name. Bug: chromedriver:2307 Change-Id: Ia7a389781eb92a2cf9bd6244e766e6c32e9b5ab9 Reviewed-on: https://chromium-review.googlesource.com/1091216Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#565356}
-
Matt Wolenetz authored
Since these two flags should map 1:1 to each other, this change removes the former in favor of the latter, which is reachable from SourceBufferState even before OnSourceInitDone has occurred. It also notes a pre-existing spec incompliance with newly filed crbug 850316. BUG=607372,850316 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I83d10db6b7c367615f5b968447dbdb415aee5cb7 Reviewed-on: https://chromium-review.googlesource.com/1089494Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#565355}
-
Aga Wronska authored
Bug: 827376 Test: Run WizardControllerDemoSetupTest Change-Id: I84525ecf4b370fac104aba99e8da04eaf32342de Reviewed-on: https://chromium-review.googlesource.com/1088127Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#565354}
-
vitaliii authored
Connect ConsentSyncBridge to ConsentAuditor behind a feature on all platforms except iOS. ConsentAuditor does not use the bridge at all yet. This CL is a part of a series to split user consents from user events into a separate datatype. Bug: 840357 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id23914d4afcf105f21dab856208d98979aa82209 Reviewed-on: https://chromium-review.googlesource.com/1084475 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Benoit Zanotti <bzanotti@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#565353}
-
Tessa Nijssen authored
Toolkit-views menus positioned with POSITION_BEST_FIT are be positioned to the side of the anchor when the menu height is greater than ~50% of the screen. Currently in this situation, the "actual" position of the menu is incorrectly recorded as POSITION_BELOW_BOUNDS. If a menu delegate invokes MenuChildrenChanged() and recalculates the menu bounds, this can cause the menu to reposition itself under the anchor rather than remaining to the side. To fix, record the "actual" position as POSITION_BEST_FIT in this situation. Bug: 840919 Change-Id: I4102e014c058b2f89d5bc38b7b4371c010367119 Reviewed-on: https://chromium-review.googlesource.com/1087516 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#565352}
-
Dmitry Gozman authored
Added a helper to ChromeDevToolsManagerDelegate and DevToolsWindow to check whether inspection is allowed. This helper is used to: - not open DevToolsWindow; - not show "Inspect Element" context menu item; - disable DevTools-related browser commands; - not show inspectable views on chrome://extensions; - not show extensions on chrome://inspect. RenderFrameDevToolsAgentHost also disallows attaching a debugging session when embedder says so to prevent exposure over protocol or remote debugging. Bug: 838146 Test: browser_tests --gtest_filter=DevToolsSanity*Policy* Change-Id: I59f255cc89919f2568170f4854955ba95eadae7f Reviewed-on: https://chromium-review.googlesource.com/1069411Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#565351}
-
Christopher Thompson authored
This lets the #ExperimentalUi flag control showing only the lock icon for SECURE (non-EV) sites. Change-Id: I8e807ada60c2e8ccbd9fb560f2148e87f863d74c Reviewed-on: https://chromium-review.googlesource.com/1080238 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#565350}
-
Elly Fong-Jones authored
These tests are hitting some corner case of MacViews fullscreen. TBR=sky@chromium.org Bug: 850594 Change-Id: I7ee54c3d1076ef29007c89ff573013a0514ace1a Reviewed-on: https://chromium-review.googlesource.com/1091136Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#565349}
-
Maks Orlovich authored
This reverts commit d6f27e51. Reason for revert: image_fetcher is used from more than UI thread, and SharedURLLoaderFactory isn't cross-thread. Note that this isn't a 100% mechanical revert since it needed a merge with some ImageDataFetcher cleanups; I also kept in some iOS glue bits that are used in a pending CL and aren't directly related to the substance of the revert. Bug: 850089 Original change's description: > S13n: Port components/image_fetcher to SimpleURLLoader. > > URLFetcher will stop working in the browser process with advent > of Network Service, and SimpleURLLoader is the replacement API > for most clients. > > Bug: 843205 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I23f22f2b00e4ece0ca85d0bad95909cd15309eb6 > Reviewed-on: https://chromium-review.googlesource.com/1060254 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564526} TBR=rogerta@chromium.org,jam@chromium.org,mathp@chromium.org,eugenebut@chromium.org,gambard@chromium.org,morlovich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 843205 Change-Id: Ifeb0c24a9e83bf271be3f10cb32f6d81ea0d0832 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1090930 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#565348}
-
Iker Jamardo authored
Adds a new XRSessionRequest structure to be passed when the RequestSession call is made to be able to pass information like user gesture. The RequestSession now requests camera permission in ARCoreDevice. The code to ask for camera permission has been copied and adapted from src/chrome/browser/media/webrtc/media_stream_devices_controller.cc and a re-check for the Android OS level camera permission is still needed. Bug: 835037, 845160, 775372 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Iecabc3927beb6106a1ada5289f3af3ecffd48ed8 Reviewed-on: https://chromium-review.googlesource.com/1055677 Commit-Queue: Iker Jamardo <ijamardo@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#565347}
-
Xida Chen authored
It is not obvious why we need to account for effective_zoom_ for the shadows in the CSS Paint API, but not for line width. This CL adds some comments to ensure the knowledge won't be lost. Bug: None Change-Id: Ibc5086449a929af0d7877874aaec482a2487ab92 Reviewed-on: https://chromium-review.googlesource.com/1090791 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#565346}
-
glevin authored
As per crbug.com/788014 Comment 1 (and previous dlgs): - Change button text "OK" -> "Continue" - Remove X (Close) button from upper right Bug: 788014 Test: Cast to a screen while multi-logged in. Try switching profiles. Try to spot the Harmony. Change-Id: Icdb122f100d6f0b00129da7534150b7314a17686 Reviewed-on: https://chromium-review.googlesource.com/1065021Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
-
sebsg authored
Some forms have multiple sequential fields predicted as being the whole street address. We should rationalize those to a set of address lines 1, 2 and possibly 3 depending on the situation. Bug: 835975 Change-Id: I75b2fa891a9ca3006066df6ba418f3475ffe01b8 Reviewed-on: https://chromium-review.googlesource.com/1089804 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#565344}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/18562b8..faef514 git log 18562b8..faef514 --date=short --no-merges --format='%ad %ae %s' 2018-06-07 kjlubick@google.com More libfuzzer cleanups from GPU switchover 2018-06-07 caryclark@skia.org generate SkColor include 2018-06-07 mtklein@chromium.org clean up some unused parts of SkArenaAlloc 2018-06-07 jvanverth@google.com Add test of tiny text with perspective. Created with: gclient setdep -r src/third_party/skia@faef514 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Iccd1d42777c1d4040b520f6e8fc0451b86ba72a4 Reviewed-on: https://chromium-review.googlesource.com/1090762Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565343}
-
Nico Weber authored
Enables these tests on the linux memory bots: filesystem_service_unittests leveldb_service_unittests traffic_annotation_auditor_unittests They already run on the regular main waterfall linux bots and on the clang tot bots. Bug: 843511 Change-Id: Ie0f1b5ea6433c2f21f87df993ac205f4553ced89 Reviewed-on: https://chromium-review.googlesource.com/1091070 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565342}
-
Varun Khaneja authored
The tests check whether we can parse the file properly, identify if the .rar file contains other archives, or executables, etc. Bug: 750327 Change-Id: I71f75521a186115d8ba2c7f2983dfb4abdbbbe1a Reviewed-on: https://chromium-review.googlesource.com/1089853Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#565341}
-
Nico Weber authored
They run on the main waterfall, so they should run on the clang/tot bots as well. Bug: 843511 Change-Id: I6fe7256c741d224c090fb38074fe98ff07353149 Reviewed-on: https://chromium-review.googlesource.com/1091071 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
glevin authored
Note that there are 3 app dialogs here generated by the same code: one for uninstalling, one for USB list permission, and one for USB access permission. As per crbug.com/788010 Comment 1 (and previous dlgs): - Allow text to run to right edge of dialog (minus margin) - Remove X (Close) button from upper right - Width = 448px Bug: 788010 Test: Try to uninstall an ARC++ app, or use one to access USB devices. OMG Harmony! Change-Id: I6ffe099ba9f4fe3fae7cd3b6f203873000dd62e8 Reviewed-on: https://chromium-review.googlesource.com/1066450 Commit-Queue: Greg Levin <glevin@chromium.org> Reviewed-by:
-
James Cook authored
They seem to pass now in mash_browser_tests (--enable-features=Mash) Bug: 723880 Change-Id: If1695c2b175dd72188c32233ae016aeef1d9636a Reviewed-on: https://chromium-review.googlesource.com/1091115Reviewed-by:
-
