Commits · 8c012045f498cc81304e7006324a1596979cc82b · eriksson monteiro / tangled

30 Nov, 2011 40 commits

Suppress another race in WebRTCAudioDeviceTest. · 8c012045

cbentzel@chromium.org authored Nov 30, 2011

BUG=103711
TBR=tommi@chromium.org

Review URL: http://codereview.chromium.org/8760006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112303 0039d316-1c4b-4281-b951-d872f2087c98

8c012045

Fixed a header name error in UMA statistics that record what servers accept range requests. · c7deb56c

ahendrickson@chromium.org authored Nov 30, 2011

Change the names of the statistics, so that there is no pollution of the data.

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8746020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112302 0039d316-1c4b-4281-b951-d872f2087c98

c7deb56c

Pass gamepad enable switch through to WebKit · 0205fbf5

scottmg@chromium.org authored Nov 30, 2011

BUG=79050


Review URL: http://codereview.chromium.org/8724002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112301 0039d316-1c4b-4281-b951-d872f2087c98

0205fbf5

Suppress CSSParser::parseSheet from HTMLTitleElemet::textWithDirection · 42f08438

cbentzel@chromium.org authored Nov 30, 2011

BUG=105961
TBR=mikelawther@chromium.org

Review URL: http://codereview.chromium.org/8760004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112300 0039d316-1c4b-4281-b951-d872f2087c98

42f08438

aura: Implement window-related methods in platform_util. · 9331fcee

derat@chromium.org authored Nov 30, 2011

This implements GetTopLevel(), IsWindowActive(), and
ActivateWindow().

BUG=99712
TEST=added

Review URL: http://codereview.chromium.org/8692016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112299 0039d316-1c4b-4281-b951-d872f2087c98

9331fcee

Move ui sync code to common directory, clean up TCW. · 3da95a10

avi@chromium.org authored Nov 30, 2011

BUG=105872
TEST=no functionality change

Review URL: http://codereview.chromium.org/8745024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112298 0039d316-1c4b-4281-b951-d872f2087c98

3da95a10

Fix leak in ProfileInfoCache::SetGAIAPictureOfProfileAtIndex · 1302dcf9

sail@chromium.org authored Nov 30, 2011

The problem was that some memory allocated by the file thread wasn't being cleaned up. Fix was to stop the file thread and then process all the pending messages on the UI thread.

BUG=105864
TEST=

Review URL: http://codereview.chromium.org/8745010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112297 0039d316-1c4b-4281-b951-d872f2087c98

1302dcf9

Expand android tests. · faaa5a2a

jrg@google.com authored Nov 30, 2011

Add net_unittests to baseline build/run; add some test disabling.
Add experimental build phase to bot script.

BUG=None
TEST=

Review URL: http://codereview.chromium.org/8746003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112296 0039d316-1c4b-4281-b951-d872f2087c98

faaa5a2a

Fix content_shell. We really need an automated test soon :) · fe2e0acc

jam@chromium.org authored Nov 30, 2011

Review URL: http://codereview.chromium.org/8742029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112295 0039d316-1c4b-4281-b951-d872f2087c98

fe2e0acc

Disable the test that hangs batch script execution. · 83c318ac

venkataramana@google.com authored Nov 30, 2011

BUG=105948
TEST=NONE
Review URL: http://codereview.chromium.org/8742032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112293 0039d316-1c4b-4281-b951-d872f2087c98

83c318ac

Add new internet cafe brand code · 7f5c6083

sail@chromium.org authored Nov 30, 2011

BUG=
TEST=


Review URL: http://codereview.chromium.org/8745023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112292 0039d316-1c4b-4281-b951-d872f2087c98

7f5c6083

Chromium style clang fixes for OVERRIDE in compositor_unittests · a803592b

dhollowa@chromium.org authored Nov 30, 2011

Fixes clang plugin complaint about missing override:
./ui/gfx/compositor/compositor_cc.h:35:11: error: [chromium-style] Overriding method must be marked with OVERRIDE.
  virtual void* GetDisplay();
          ^
Also, adds |SetCurrent| call to properly track context in |GLContextNSView::MakeCurrent|.

BUG=104390
TEST=Compiles on Mac/clang.  compositor_unittests pass.
R=piman@chromium.org, kbr@chromium.org


Review URL: http://codereview.chromium.org/8748018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112291 0039d316-1c4b-4281-b951-d872f2087c98

a803592b

Fixup ordering of new thread init parts · 2167cd62

stevenjb@chromium.org authored Nov 30, 2011

This fixes some ordering from http://codereview.chromium.org/8477004

Change-Id: Icf945d0ebfbb766f7f9315a39f5469dee03873e1

BUG=98716, 104578, 105435
TEST=Run tests on all platforms


Review URL: http://codereview.chromium.org/8755001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112290 0039d316-1c4b-4281-b951-d872f2087c98

2167cd62

Implement Drain() on HttpPipelinedStream. · e2bec397

simonjam@chromium.org authored Nov 30, 2011

BUG=102385
TEST=net_unittests


Review URL: http://codereview.chromium.org/8591037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112289 0039d316-1c4b-4281-b951-d872f2087c98

e2bec397

Move extension delegate calls to a new ExtensionTabHelperDelegate interface. · 1739e57d

avi@chromium.org authored Nov 30, 2011

BUG=105872
TEST=no functionality change

Review URL: http://codereview.chromium.org/8741025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112288 0039d316-1c4b-4281-b951-d872f2087c98

1739e57d

revert remoting part of 112252 · ca16cd0c

garykac@chromium.org authored Nov 30, 2011

BUG=105934
TEST=make

Review URL: http://codereview.chromium.org/8749018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112287 0039d316-1c4b-4281-b951-d872f2087c98

ca16cd0c

Aura: Fix popup window frames appearing blue · bf603ea4

jamescook@chromium.org authored Nov 30, 2011

Added desaturated gray IDR_FRAME, IDR_FRAME_INACTIVE, and IDR_FRAME_APP_PANEL for Aura.

BUG=105883
TEST=visual

Review URL: http://codereview.chromium.org/8748014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112285 0039d316-1c4b-4281-b951-d872f2087c98

bf603ea4

Fix build · 7a60deec

abarth@chromium.org authored Nov 30, 2011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112284 0039d316-1c4b-4281-b951-d872f2087c98

7a60deec

Fix web extent in default search app. · 62bb1961

rogerta@chromium.org authored Nov 30, 2011

BUG=103278
TEST=See comment #4 in bug for repro steps.
Review URL: http://codereview.chromium.org/8747014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112283 0039d316-1c4b-4281-b951-d872f2087c98

62bb1961

manifest_version should be a base CRX key · 154361df

abarth@chromium.org authored Nov 30, 2011

Without this patch, the manifest_version attribute is rejected for hosted apps.

TEST=TaskManagerBrowserTest.NoticeHostedAppTabs (once a later patch lands)
Review URL: http://codereview.chromium.org/8748020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112282 0039d316-1c4b-4281-b951-d872f2087c98

154361df

Always use JavaScript as opposed to Javascript in UI strings · 6a7633cc

steveblock@chromium.org authored Nov 30, 2011

BUG=105871


Review URL: http://codereview.chromium.org/8742019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112281 0039d316-1c4b-4281-b951-d872f2087c98

6a7633cc

Remove a couple of unused Autofill strings · 53a2e0e7

isherman@chromium.org authored Nov 30, 2011

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8745006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112280 0039d316-1c4b-4281-b951-d872f2087c98

53a2e0e7

base::Bind: Implement a 1-arity CancelableCallback and use this to implement · d4d57df4

jhawkins@chromium.org authored Nov 30, 2011

net::CancelableCompletionClosure.

BUG=none
TEST=none

R=ajwong@chromium.org

Review URL: http://codereview.chromium.org/8662047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112279 0039d316-1c4b-4281-b951-d872f2087c98

d4d57df4

Remove unused BrowserBubble remnants. · 43cb919a

msw@chromium.org authored Nov 30, 2011

The only use of BrowserBubble was deprecated in crrev.com/111886.
ExtensionPopup now uses the new views bubble; this code is dead.

BUG=97248,98323
TEST=ExtensionPopup bubbles work as before.

Review URL: http://codereview.chromium.org/8673009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112278 0039d316-1c4b-4281-b951-d872f2087c98

43cb919a

Suppressions for v8StringToWebCore*String on Mac memcheck. · b948c26a

cbentzel@chromium.org authored Nov 30, 2011

BUG=105938
TBR=timurrrr@chromium.org

Review URL: http://codereview.chromium.org/8752003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112276 0039d316-1c4b-4281-b951-d872f2087c98

b948c26a

Whitespace style fix (that I previously overlooked). · d0abde53

viettrungluu@chromium.org authored Nov 30, 2011

TBR=dmichael


Review URL: http://codereview.chromium.org/8749010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112275 0039d316-1c4b-4281-b951-d872f2087c98

d0abde53

Resubmit CL with memory leaks patched. See 8429004. · 03c3921d

chocobo@chromium.org authored Nov 30, 2011

BUG=chromium-os:19399
TEST=manual + try linux_chromeos_valgrind
Review URL: http://codereview.chromium.org/8734013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112274 0039d316-1c4b-4281-b951-d872f2087c98

03c3921d

Move another bunch of extension API tests to manifest_version 2. · c00ea08a

abarth@chromium.org authored Nov 30, 2011

These extensions are loaded as unpacked extensions, so they need to be updated
to version 2 before we can change every unpacked extension to use version 2.

BUG=62897
Review URL: http://codereview.chromium.org/8725019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112273 0039d316-1c4b-4281-b951-d872f2087c98

c00ea08a

Fix typo in poor man's trybot. · 404999c2

joi@chromium.org authored Nov 30, 2011

TBR=grt@chromium.org
BUG=none

Review URL: http://codereview.chromium.org/8754002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112272 0039d316-1c4b-4281-b951-d872f2087c98

404999c2

SSL Host info: Make sure that we can update certificate chains in · 6a019de2

rvargas@chromium.org authored Nov 30, 2011

the cache.

BUG=102554
TEST=net_unittests

Review URL: http://codereview.chromium.org/8670009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112271 0039d316-1c4b-4281-b951-d872f2087c98

6a019de2

Converted remaining non-factory NewRunnable* calls to use base::Bind · 3913ee11

rickcam@chromium.org authored Nov 30, 2011

BUG=105561
TEST=unit_tests


Review URL: http://codereview.chromium.org/8726001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112270 0039d316-1c4b-4281-b951-d872f2087c98

3913ee11

Move a bunch of extension API tests to manifest_version 2. · 605c56ee

abarth@chromium.org authored Nov 30, 2011

These extensions are loaded as unpacked extensions, so they need to be updated
to version 2 before we can change every unpacked extension to use version 2.

BUG=62897
Review URL: http://codereview.chromium.org/8729014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112269 0039d316-1c4b-4281-b951-d872f2087c98

605c56ee

Added OWNERS file for ui/gfx/surface/ . · df9caa63

kbr@chromium.org authored Nov 30, 2011

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8741024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112268 0039d316-1c4b-4281-b951-d872f2087c98

df9caa63

Another suppression for inlineFlowBox/inlineTextBox. · a0570c09

cbentzel@chromium.org authored Nov 30, 2011

BUG=101755
TBR=yurys@chromium.org

Review URL: http://codereview.chromium.org/8743018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112267 0039d316-1c4b-4281-b951-d872f2087c98

a0570c09

Fix the components build on Linux. · 8fe69369

tony@chromium.org authored Nov 30, 2011

We were including the wrong GLES2/gl2.h file.  This was previously fixed
in http://codereview.chromium.org/8540032 , but we regressed it
http://codereview.chromium.org/8423038/ .

It looks like we were getting the copy in third_party/angle/include.

BUG=None


Review URL: http://codereview.chromium.org/8735003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112266 0039d316-1c4b-4281-b951-d872f2087c98

8fe69369

Prepare for didUpdateLayout moving to WebViewClient. · 169d428d

levin@chromium.org authored Nov 30, 2011


Review URL: http://codereview.chromium.org/8742007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112265 0039d316-1c4b-4281-b951-d872f2087c98

169d428d

Relands the following. First attempt was reverted because it broke · 3bcc6f70

sky@chromium.org authored Nov 30, 2011

clang bot (too much inlined). TBR since this just moves some code to
the .cc file.

Makes TestWebGraphicsContext3D::initialize create a stub context and
surface. This is needed otherwise we crash when code tries to access
the current context. Also makes GLContextStub::MakeCurrent set itself
as the current context.

BUG=104360
TEST=none
R=kbr@chromium.org,piman@chromium.org
TBR=kbr@chromium.org,piman@chromium.org


Review URL: http://codereview.chromium.org/8742022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112264 0039d316-1c4b-4281-b951-d872f2087c98

3bcc6f70

Make some organization in RenderWidgetHost clearer. · e672003f

levin@chromium.org authored Nov 30, 2011

Also, this reduces duplication in comments and fixes them to refer to
RenderViewHost.

Review URL: http://codereview.chromium.org/8745009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112263 0039d316-1c4b-4281-b951-d872f2087c98

e672003f

Add TSAN StatisticsRecorder::StatisticsRecorder suppression. · 9ea6f075

cbentzel@chromium.org authored Nov 30, 2011

BUG=104776
TBR=jar@chromium.org

Review URL: http://codereview.chromium.org/8749011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112262 0039d316-1c4b-4281-b951-d872f2087c98

9ea6f075

Rebase ConfirmBubble on the new views bubble. · 10d6852e

msw@chromium.org authored Nov 30, 2011

Win SpellingBubble is accessible via textfield context menu:
"Spell-checker options"->"Ask Google..."

BUG=98323,99130
TEST=ConfirmBubble (SpellingBubble) works as before.

Review URL: http://codereview.chromium.org/8746001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112261 0039d316-1c4b-4281-b951-d872f2087c98

10d6852e