- 10 May, 2019 40 commits
-
-
Etienne Bergeron authored
This CL is changing the FontFallback signature to take an StringPiece instead of a raw pointer and a length. The CL doesn't include behavior changes. R=asvitkine@chromium.org Bug: 944227 Change-Id: I1302e5dd94ce9cf111ac8fb70b55f32d11aafbe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594344 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#658582}
-
Stephen McGruer authored
Bug: None Change-Id: Ia6991745a9d02b07811cd2901958b63a4176039b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565206 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#658581}
-
Michael Lippautz authored
This reverts commit 7a19b1f0. Reason for revert: Temporarily revert fix to get more information on the crasher. Original change's description: > heap: Stricter checks for backing modifications > > Backings were allowed to be modified (shrinking, freeing) when > incremental marking was running and the backing was not marked yet. This > can be problematic when write barriers on nested containers fire > eagerly, registering slots. > > Bug: 918064 > Change-Id: Id6fa8ed5b3c3c2bdc04ed8f812f1b883d4e0d362 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602498 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658101} TBR=haraken@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 918064 Change-Id: I01677e8d48a35e1c95fabe7133297c569eadee02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605910Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#658580}
-
Majid Valipour authored
Restrict localTime type so that NaN is considered invalid which brings us in line with web-animation. Our implementation was previously incorrect as it would accept NaN and then convert it into an unexpected base::TimeDelta. This patch restricts accepted input by switching EffectProxy.localTime from 'unrestricted double?' -> 'double?' and brings us in line with ComputedEffectTiming.localTime as defined in Web-Animation. [1,2] As a side effect the attribute no longer accepts 'undefined'. Per webidl 'double?' is a nullable type which accepts a valid double, or null. So anywhere we are setting local time to 'undefined' we should use 'null' instead. Other changes: - WorkletAnimation blink/cc are updated to never send NaN - Update tests to not expect NaN and remove relevant checks - Add DCHECKS in Animator to ensure local and current times are never NaN - Update expectations to reflect now working tests [1] https://drafts.csswg.org/web-animations-1/#dom-computedeffecttiming-localtime [2] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/animation/computed_effect_timing.idl?l=10 Bug: 937456 Change-Id: I9a72e4023608980c8a64743bc6737202e4f70538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1443864Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#658579}
-
John Budorick authored
Bug: 961548 Change-Id: I7638bd524d1802bdc9bc02ddd7437a9d395e2240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604184Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#658578}
-
Geoff Lang authored
ANGLE is moving to support the more standard behaviour of returning a context version that is backwards compatible with the requested version but this new behaviour conflicts with what Chrome expects with the passthrough command decoder. BUG=angleproject:3425 Change-Id: I107b194fe2e3ad8e1707ab55155d6d74ee0b4735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602813Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#658577}
-
Ross McIlroy authored
They don't work now that we have switched to running Monochrome6432 on the Pixel2 bots. BUG=934251 TBR=crouleau@chromium.org Change-Id: Ice482985391a9552ba80de7ee555a9a582029a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605909 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#658576}
-
Takashi Toyoshima authored
This patch adds metrics to measure characteristics listed below: - cache key size - cache value size - entry counts per each origin set Bug: 961602 Change-Id: Ib2bff9f55c69c034840536b287f0ce18595dfebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605820 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
David Roger authored
It is suspected that IsNewProfile is not really reliable. This CL switches to WasCreatedByVersionOrLater instead. As a side effect, TestingProfiles are now automatically migrated to Dice. Tests that really need a pre-dice profile can now use the new BuildPreDiceProfile() function. Bug: 959188 Change-Id: I42e74ba20287caa47752eb4cf46636a912d93f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594720 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#658574}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4c03bf558364..e7737dde3a32 git log 4c03bf558364..e7737dde3a32 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 perezju@chromium.org Revert "Telemetry: stop supporting browserless benchmarks in story runner" 2019-05-10 khokhlov@google.com Telemetry: stop supporting browserless benchmarks in story runner Created with: gclient setdep -r src/third_party/catapult@e7737dde3a32 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:840428,chromium:840428 TBR=skyostil@google.com Change-Id: I0a53ddf6fb261c70899f19050ae2eddf41b21705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658573}
-
Rayan Kanso authored
Remove manual history/privacy checks by delgating the recording decision to UkmBackgroundRecorderService. Bug: 952870 Change-Id: I2bea7bbbee6a43c21959b7c60c9640d4a8ed4e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601042Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#658572}
-
Joe DeBlasio authored
This CL passes along the initiating origin of a request down into DownloadInfo and related objects. The current download objects store substantial context related to where a download comes from, but not enough to reliably determine requesting origin. This functionality will be used in a subsequent CL to block some forms downloads as mixed content. Bug: 960819 Change-Id: Ifa2537141bb71c37665608e992ee91cd665c41ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596178Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#658571}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f68074fda388..a0dc004642e1 Created with: gclient setdep -r src-internal@a0dc004642e1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I7ec73587c3839f8339a4e268ed37bcb2fdec62a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605317Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658570}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4687bddcea20..6eeaf927e381 git log 4687bddcea20..6eeaf927e381 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 bsalomon@google.com Promote circle clipping to full float Created with: gclient setdep -r src/third_party/skia@6eeaf927e381 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/123437630 TBR=robertphillips@google.com Change-Id: I824a21c46fe2c346bff6c310115ed9087dca87f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605215Reviewed-by:
-
Olivier Robin authored
Do not wait for the Breakpad thread when setting a value. The Breakpad thread can be busy for quite a long time (seconds) waiting for it will freeze the UI thread. The get functions are still blocking but are only used in tests. Bug: 960378 Change-Id: Ia9d58087baaecfe5e42f798cfbb8c37bb4859c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605409Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658568}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I41fb031fbda6d96b30dfc84e50dc3e01a19b2da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605316Reviewed-by:
-
Elly Fong-Jones authored
This change: 1) Removes top-sites-from-site-engagement 2) Removes the backing TopSitesFromSiteEngagement feature 3) Removes the only codepath that used that feature 4) Removes the then-unused SiteEngagementTopSitesProvider 5) Removes the TopSitesProvider interface itself, which now has only one implementation (DefaultTopSitesProvider) 6) Removes DefaultTopSitesProvider and folds its implementation into TopSitesImpl 7) Removes all relevant test code Bug: None Change-Id: I633de67c38d86e7dcfccaa30badcdabaf9c2ee3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603475Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#658566}
-
Etienne Bergeron authored
This CL is changing the image used as result. The win7 image was taken with aliasing off. The bots has aliasing on by default and was turned off by incorrect code in chrome. see: https://chromium-review.googlesource.com/c/chromium/src/+/1570527 The bots got fixed and the code causing flakiness is getting removed. The expected results should be the image with aliasing activated. NOTE TO SHERRIFS: If LayoutProviderTest.ExplicitTypographyLineHeight, please disable the test and assign the bug to me. I think I've found any cause of flakiness. If not, I'll dig more. Bug: 955128 Change-Id: I753df3dc217a7aa030b4490297a4ee54344a5a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597277Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Bug: None Change-Id: I405d5ce9f7c6400b1aac3f8496273d9f4d9b8b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605787 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#658564}
-
Yuwei Huang authored
This CL integrates the iOS client with the new directory service. It also deletes the HostListFetcher and makes HostListService store and return the protobuf HostInfo. Bug: 954594 Change-Id: Ia47d91ba5e7bc2d0fdbdb441c95694e75deab6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602075 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#658563}
-
Charlie Harrison authored
Bug: 961285 Change-Id: I7d07d5313c39c782eb531b2f02fc0400dd6b08fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601944Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#658562}
-
Robert Kaplow authored
Simplify the logic by just enabling and removing the variations param (which was never enabled). Bug: 869123 Change-Id: Ic98b681e53ca3a4179d4f5a6f2948520f3c9ff6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600451Reviewed-by:
-
Tanja Gornak authored
Change-Id: If05f20ee2299704349e70ef13bd1ccec0463cd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599450 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 28b2e498. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." a554ea37 "Reland "[EventTiming] Round instead of ceil the |duration|"" a06bcc90 "WebXR: Rename requestSession parameter variables to match use" eeafcaee "[sms] Introduce testing infrastructure and handle some corner cases." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" faed29aa "[EventTiming] Remove unneeded prefix from WPT tests" 9d5bc5ec "Portals: Add support for frame-src CSP directive." d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ib53f3af4acc9e988a4be602af90eb38600e26680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605841Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658559}
-
Morten Stenshorne authored
TBR=kojii@chromium.org Change-Id: I6e9f774fc957ba80180d5b7dfc3aab51ab016468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604273Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#658558}
-
Vadym Doroshenko authored
When the old parser is completely off, this function returns false always. Bug: 831123 Change-Id: I2719532919d6438e62cb70959c64e736fef6c4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605417Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#658557}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5c293b71dc3e..04b8ec6ff397 git log 5c293b71dc3e..04b8ec6ff397 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 fmayer@google.com Merge "Use PERFETTO_DFATAL_OR_ELOG to get errors from release builds." Created with: gclient setdep -r src/third_party/perfetto@04b8ec6ff397 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib9c15cb418f82dfe4ada7be8c66404fb3b77492b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605314Reviewed-by:
-
Ella Ge authored
The test is all passed and no timeout on mac, see flakness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=fast%2Fevents%2Frecorded-keydown-event.html Bug: 872705 Change-Id: Ie221d20aec6dc4d5817cc7d250e85ca57fa4ea69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603503Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#658555}
-
Nicolas Ouellet-payeur authored
Change-Id: Ic9b114b0c77ddf827c064bbf60bd6624ef7aeadf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600628Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#658554}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fb8c856afa8f..8da35a60ab3c git log fb8c856afa8f..8da35a60ab3c --date=short --no-merges --format='%ad %ae %s' 2019-05-10 hta@webrtc.org Deprecate owned naked pointers to cricket::SessionDescription 2019-05-10 nisse@webrtc.org Simplify WindowsCommandLineArguments, and move to example code. Created with: gclient setdep -r src/third_party/webrtc@8da35a60ab3c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3da9d4fce5aeeed90d4b52aae060c9f1508be4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605217Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2dd4ab3a4acb..6e384fef6c0f git log 2dd4ab3a4acb..6e384fef6c0f --date=short --no-merges --format='%ad %ae %s' 2019-05-10 cepheus@frii.com Build: Fix 3 warnings. 2019-05-10 johnkslang@users.noreply.github.com Merge pull request #1761 from KhronosGroup/SPIR-V_1.4 Created with: gclient setdep -r src/third_party/glslang/src@6e384fef6c0f The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I66867f9bf9f437a237dbee31161e589c61a5c670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605218Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2d5ee4f98a92..802c51c55135 git log 2d5ee4f98a92..802c51c55135 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 nya@chromium.org Revert "BuildStore: remove the transitioning variable" Created with: gclient setdep -r src/third_party/chromite@802c51c55135 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I56eb56d244b64a56c4b6512230129a55a090cd02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605216Reviewed-by:
-
Henrik Grunell authored
- Before changing the IO buffer size on the AudioUnit, see if the device still is present. - Initialize min and max variables for buffer size range. - Check return value when getting buffer size range; return at failure. Bug: 960736 Change-Id: Iddf1d1736c801c46b690e6fe4a570b62f304830c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602493 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#658550}
-
Nicolas Ouellet-payeur authored
It's a text input field. When the user enters a URL in that field, a JSON object is displayed, explaining the decision + reason LBS would make for that URL. https://i.imgur.com/geKj4Gh.png Bug: 959379 Change-Id: Ia79577f6135f9203832123b13a4f77f1b4b4f31b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601645Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#658549}
-
Robert Ogden authored
Only non-ALLOWED values are logged. Bug: 955472 Change-Id: I7480df4ce7597319fc6cbd18bc23da8e7c46625f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597688Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#658548}
-
kylechar authored
OverlaySurfaceCandidate::operator< calls gfx::ToNearestRect() on |display_rect|. This is only valid if |display_rect| is an integer rect stored in a RectF. DrmOverlayManager::CanHandleCandidate() already rejects candidates with non-integer display_rects. The rejected candidate is still added to a cache, which will do comparisons and hit a DCHECK. We add it to the cache because we can have one rejected candidate and one non-rejected candidate in the input. Instead of putting the real OverlaySurfaceCandidate value for the rejected candidate, replace it with a default constructed OverlaySurfaceCandidate. Include a comment and test that covers this because it's subtle. Bug: 959689 Change-Id: I7313db49107708843d2b3f345197f183cccf97db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602447Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#658547}
-
Jérôme Lebel authored
Changing titles to have title case, and adding dot to subtitles. https://drive.google.com/open?id=15CrMALU9oMXmQ6IeAckm__VDxAYx85hC https://drive.google.com/open?id=1jcOBC2uRkdhaoGyf1blc12paoFogHydD Bug: 961271 Change-Id: I5ad6d0d2455aa6e9599d60189e801486538561fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602714Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/62d6b621decf..f68074fda388 Created with: gclient setdep -r src-internal@f68074fda388 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I9678f970333684414c03f0b3ca1da40f2129cdbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605213Reviewed-by:
-
David Jean authored
Since history always has normal browser state, even in incognito, pass down a new load strategy forcing incognito from main_controller. Catch a load in current tab for the other mode and forward to other service. Fix crash with calling pre-render before checking if we have a web state. Bug: 960728, 960732, 947005 Change-Id: I591e60ea7bf1e08ac27d6b63b8ba60fffa03e938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599466 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
-
Ilya Nikolaevskiy authored
Bug: chromium:930186 Change-Id: I7921ae4ce5d787e45e350db6a1a83b59201c024f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594714Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#658543}
-
