- 20 Feb, 2018 26 commits
-
-
Megumi Hattori authored
This reverts commit b5cae0bd. Reason for revert: Settings button and close button on MessageCenterView are missing. Original change's description: > Implement scroll shadow on MessageCenterView. > > When MessageCenterView can be scrolled, the 2dp scroll shadow is > displayed at the bottom. > > The shadow is displayed over notifications on MessageCenterView. > > If MessageCenterView is all scrolled, the shadow is hidden. > > BUG=779880 > > Change-Id: I48fdb3e97c57075114ba4210cea40039c295a6d7 > Reviewed-on: https://chromium-review.googlesource.com/923244 > Commit-Queue: Megumi Hattori <megumihattori@google.com> > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537711} TBR=yoshiki@chromium.org,tetsui@chromium.org,maajid@chromium.org,megumihattori@google.com Change-Id: Ib697e58df63ccda943eb4caf920620787bf31577 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 779880 Reviewed-on: https://chromium-review.googlesource.com/925926Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#537718}
-
Darren Shen authored
This patch adds the clear() method to inline & declared StylePropertyMap Spec: https://drafts.css-houdini.org/css-typed-om-1/#dom-stylepropertymap-clear Bug: 813653 Change-Id: Ib56f60fa59dc8d241e7fb1a7695fce2bea094026 Reviewed-on: https://chromium-review.googlesource.com/925761 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#537717}
-
Yoshifumi Inoue authored
This patch gets rid of extra namespace for jumbo build from "VisibleUnitsWordTest.cpp" to simplify source code for improving code health. [1] http://crrev.com/c/923723 [jumbo] avoid helper function collisions in VisibleUnits*Test.cpp Change-Id: I35e5f45f458e370000aeaf8f161e26c76f7f5152 Reviewed-on: https://chromium-review.googlesource.com/925922Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537716}
-
Koji Ishii authored
Following bot results are included. 3839 3841 3843 3845 3846 50 lines were removed and 51 lines were deflaked by consecutive results since 3770. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I73fdf6b07145a907d4025838718f30cc3eadf045 Reviewed-on: https://chromium-review.googlesource.com/923666 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#537715}
-
Yuki Shiino authored
The current implementation is running ResizeObserver's callback functions even when they're NOT wrapper-traced. This patch makes it sure that the observed Element is performing wrapper-tracing otherwise ResizeObserver does not invoke an untraced callback function. The attached test case causes crash with the current implementation, but not with this patch. Bug: 809784 Change-Id: If2e66d388ab4f4410ca8c472176fbdee5a957f08 Reviewed-on: https://chromium-review.googlesource.com/924104Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#537714}
-
Kinuko Yasuda authored
Example failures: https://ci.chromium.org/buildbot/chromium.mac/Mac10.10%20Tests/29357 https://ci.chromium.org/buildbot/chromium.mac/Mac10.11%20Tests/23562 https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/10337 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win7/60528 TBR=hiroshige@chromium.org Bug: 813704 Change-Id: I2632b5acd189b9a203700c8b5b1f57fc449aba93 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/925870Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#537713}
-
Kinuko Yasuda authored
TBR=klausw@chromium.org NOTRY=true Bug: 813697 Change-Id: Ibef66c36488eb83052c0b8da91e232c9be832020 Reviewed-on: https://chromium-review.googlesource.com/925867Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#537712}
-
Megumi Hattori authored
When MessageCenterView can be scrolled, the 2dp scroll shadow is displayed at the bottom. The shadow is displayed over notifications on MessageCenterView. If MessageCenterView is all scrolled, the shadow is hidden. BUG=779880 Change-Id: I48fdb3e97c57075114ba4210cea40039c295a6d7 Reviewed-on: https://chromium-review.googlesource.com/923244 Commit-Queue: Megumi Hattori <megumihattori@google.com> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#537711}
-
Naina Raisinghani authored
This patch allows CSSTransformValues items to be mutated/appended. Spec issue here: https://github.com/w3c/css-houdini-drafts/issues/690 Bug: 545318 Change-Id: I841704e1f2ec8db0f27ae254a0949d4f9b46c8f7 Reviewed-on: https://chromium-review.googlesource.com/925882Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#537710}
-
Amirhossein Simjour authored
PermissionDialogController uses PermissionAppModalDialogView if the flag is enabled. Since the goal is to remove the current implementation based on AlertDialogs, I didn't introduce common interface between PermissionAppModalDialogView and PermissionDialogView. BUG=811134 Change-Id: Ia3f5e072eccf4b25800ae430b8af10d263344409 Reviewed-on: https://chromium-review.googlesource.com/916551 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#537709}
-
Matt Falkenhagen authored
I believe this code is never reached since Mojo Blobs is now enabled by default. R=kinuko Change-Id: I31ff07484290ab932a3569c9e10e00316a5bafd0 Reviewed-on: https://chromium-review.googlesource.com/925863Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#537708}
-
https://webrtc.googlesource.com/src.git/+log/2b6f13508ec1..500874effdad $ git log 2b6f13508..500874eff --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I518c2f64cbf962dcdf4bbedab6d0ee2dfb06c682 Reviewed-on: https://chromium-review.googlesource.com/925687Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537707}
-
Matt Falkenhagen authored
Back in issue 413094, we decided to skip service worker for fetches from Pepper plugins with "private permission" for security purposes. The motivation was that Pepper plugins without "private permission" could be assumed to enfore the same-origin policy. However, the spec has since mandated skipping service workers for the request for the plugin itself, i.e., the target URL of an EMBED or OBJECT element. This patch makes two changes: 1) Requests *for* the target URL of EMBED or OBJECT element that load a Pepper plugin skip service workers. This aligns with recent patches to skip all EMBED or OBJECT element requests: r537245 skipped them for embedded HTML content, and r537386 skipped them for MIME handler plugins. The code change is in ppb_nacl_private_impl.cc::CreateWebURLRequest. This stops the requests for the manifest and pexe from being intercepted by the service worker. 2) Requests *from* any Pepper plugin skip service workers. Previously, we only skipped if the plugin had private permission, now we skip regardless of permission. The code change is in url_request_info_util.cc::CreateWebURLRequest. One thing I'm not so sure about is PepperPluginInstanceImpl::Navigate which apparently does a navigation in a frame. This is also changed to to skip service workers (by changing the utility function CreateWebURLRequest), but it's unclear whether that's needed. You might ask why we don't change the service worker interception code to just skip plugins, instead of changing the plugin callsites. This is because at the SW interception site, we don't know whether the request came from a plugin or not: for the manifest request, the RequestContextType is "INTERNAL", and the ResourceType is "SUBRESOURCE". It's also worth nothing that NetworkService/S13nServiceWorker already skip the service worker for all these requests, since we don't hook in at the URLRequestJob level anymore. In NS/S13nSW, we likely won't need to set skip service worker at these callsites. R=kinuko TBR=bradnelson Bug: 771933,413094 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I09db0eda46f2e7d9372495a6205f5cb0026de6c7 Reviewed-on: https://chromium-review.googlesource.com/923663 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#537706}
-
Alice Boxhall authored
Idle tasks are too difficult to use in layout tests, and are also not implemented anywhere other than Chrome. Bug: 792783 Change-Id: I802c2a9cdd292138ff68fefd3f69b71e0f6e2e98 Reviewed-on: https://chromium-review.googlesource.com/923469 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537705}
-
Megumi Hattori authored
When a gear icon for the inline settings is clicked, the animation should be drwan from the point where the mouse is cliked. However, if notifications are shown on MessageCenterView, the animation is not drawn from the correct point. This CL Fixes the stating point for drawing animation. BUG=813465 Change-Id: Ic903b86abfd31f0da80b931f5f68234c47c7ac33 Reviewed-on: https://chromium-review.googlesource.com/923689Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Megumi Hattori <megumihattori@google.com> Cr-Commit-Position: refs/heads/master@{#537704}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 780785, 786332 Change-Id: I78cb3555cdf9e77c65db286fd37c887d6ac30d56 Reviewed-on: https://chromium-review.googlesource.com/923626Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#537703}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: Ia2d707ef8de3a9addcbec2d3da9f7214225e9f78 Reviewed-on: https://chromium-review.googlesource.com/923252Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#537702}
-
Matt Falkenhagen authored
This function is unused. Change-Id: I80dbe6731de3b4909c72dad51702343d8855082a TBR: shimazu Reviewed-on: https://chromium-review.googlesource.com/925881Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#537701}
-
David Vallet authored
Bug:813671 Change-Id: Iedea149d4bddc06b3bc45d5b4e3dce7f10819b6e Reviewed-on: https://chromium-review.googlesource.com/923662 Commit-Queue: David Vallet <dvallet@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#537700}
-
Kouhei Ueno authored
Before this CL, CBORReader::Read() rejected CBOR-encoded data with extra bytes at the end, and reported CBORReader::DecoderError::EXTRANEOUS_DATA. This CL introduces alternative CBORReader::Read() which allows extraneous data following CBOR-encoded data. Callers can tell the size of the CBOR-encoded data via |num_consumed_bytes|. Bug: 803774 Change-Id: I154534f5049e94f3d20e67c4889e711332b1726f Reviewed-on: https://chromium-review.googlesource.com/920802 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#537699}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/326ee962..5f4eca57 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4261503ec7c08087fb98ad7a20c8fda7a7a41a07 Reviewed-on: https://chromium-review.googlesource.com/925621Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#537698}
-
Naina Raisinghani authored
This is as there is a bug on the spec highlighting the lack of usefulness of the function: https://github.com/w3c/css-houdini-drafts/issues/656 Bug: 812912 Change-Id: If0b47a4bfa268f55f63e5c80168971164dc63199 Reviewed-on: https://chromium-review.googlesource.com/923501 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#537697}
-
Yoshifumi Inoue authored
This patch simplifies parameters of |TypingCommand::DeleteSelectionIfRange()| because all call sites pass same arguments to reduce source code size for improving code health. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/crrev.com/c/925125 Introduce DeleteSelectionOptions for DeleteSelectionCommand construction Change-Id: I77228da041f77e9864a25542082ea9827fb3b631 Reviewed-on: https://chromium-review.googlesource.com/923614 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#537696}
-
Makoto Shimazu authored
check-webkit-style internally skips LayoutTests except for TestExpectations. This CL is for skipping that before running check-webkit-style. Bug: none Change-Id: Id6636d8e56c346d61e102643840baee17ecb6f9c Reviewed-on: https://chromium-review.googlesource.com/923870Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#537695}
-
Kent Tamura authored
Makes importNode() code match to the DOM specification. This CL has no behavior changes Bug: 812089 Change-Id: I9aa7bf1401ba2e5b4342547e49ea7b567616801c Reviewed-on: https://chromium-review.googlesource.com/923230Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#537694}
-
https://skia.googlesource.com/skia.git/+log/cad0acf4db5b..62ce2ca06978 $ git log cad0acf4d..62ce2ca06 --date=short --no-merges --format='%ad %ae %s' 2018-02-19 reed Simplify decal for gradients 2018-02-19 reed hide virtual and rename to onMakeComposed 2018-02-19 fmalita SlideDir focus w/ animation Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I4babcdf1aa6bff2a843bc51bacc3ef42fb0ee88c Reviewed-on: https://chromium-review.googlesource.com/925544Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537693}
-
- 19 Feb, 2018 14 commits
-
-
Morten Stenshorne authored
The new multicol tests fail because NG has no support for nested multicol yet. There's also a new position:sticky test that fails. TBR=kojii@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If48e42a5551939f7a4dde943142f332e979af13c Reviewed-on: https://chromium-review.googlesource.com/925661 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#537692}
-
Darren Shen authored
This patch allows CSSUnparsedValue items to be mutated/appended. See https://github.com/w3c/css-houdini-drafts/issues/664 Bug: 812919 Change-Id: I3e3c1d91fa9bfaa3a1a4adde45202c36c9bdb37f Reviewed-on: https://chromium-review.googlesource.com/923670Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#537691}
-
Darren Shen authored
We were crashing because converting CSSPerspective(-1px) to a CSSValue returns nullptr. The correct behaviour should be to convert it as CSSPerspective(calc(-1px)). Bug: 812620 Change-Id: I5ee70d4fb5eed064bcdad67391c3eb84531144d6 Reviewed-on: https://chromium-review.googlesource.com/924742 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#537690}
-
Kenichi Ishibashi authored
Before this CL we didn't stop appending data for mulitpart images even after there was an decode error. This doesn't align the assumption the base class has. The base class, Resource, doesn't expect calling AppendData() when there was an error. We should cancel the parser when there is a decode error so that we don't append data after the error. Bug: 813485 Change-Id: I40112e11bf1d7d1c84e2794c81bbaf178207496f Reviewed-on: https://chromium-review.googlesource.com/923668Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#537689}
-
Daniel Cheng authored
Add basic documentation in the headers, so some of the invariants and basic usage are more obvious without having to refer to a separate Markdown document. Change-Id: Ic14350c8745ba95c05f62be17760fb02c6f7bfef Reviewed-on: https://chromium-review.googlesource.com/924744Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#537688}
-
Tsuyoshi Horo authored
Bug: 803774 Change-Id: Ied7ac32ab21cf17c889980ab593e70ee85ef871c Reviewed-on: https://chromium-review.googlesource.com/923924Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#537687}
-
Scott Graham authored
Flaked on ARM64 at https://build.chromium.org/p/chromium.fyi/builders/Fuchsia%20ARM64/builds/6051, Blamelist includes https://chromium-review.googlesource.com/c/chromium/src/+/924001 which looks like it could be related, but also looks similar to general TaskScheduler timing flake, so disabling. TBR: wez@chromium.org Bug: 813651 Change-Id: Ic67fb40d5efe5cd614d6413e180311f372ae7269 Reviewed-on: https://chromium-review.googlesource.com/925546Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537686}
-
Darren Shen authored
Currently, when we set width to something like -1, we would get an invalid value for width. According to the spec [1], we should be wrapping the invalid value in a calc. This patch wraps invalid values in calc, and changes the test harness to allow us to test this. Bug: 545318 Change-Id: I71769e1bc69164c9b7dcf0d2c54ca06b623b5d9e Reviewed-on: https://chromium-review.googlesource.com/923603 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#537685}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1880a2eb..326ee962 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6770fb499f93225d26a14c8cb8d2b103ee3d7240 Reviewed-on: https://chromium-review.googlesource.com/925343Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#537684}
-
Xi Cheng authored
Bug: 734095 Change-Id: I13ad555008c546e71bf510acd4923a188277ad76 Reviewed-on: https://chromium-review.googlesource.com/923165Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#537683}
-
https://pdfium.googlesource.com/pdfium.git/+log/c8785f736df5..e53460ff2697 $ git log c8785f736..e53460ff2 --date=short --no-merges --format='%ad %ae %s' 2018-02-19 dsinclair Remove extraneous HasError checks 2018-02-19 dsinclair FormCalc Assignment is not a SimpleExpression 2018-02-19 dsinclair Cleanup FormCalc inheritance 2018-02-19 dsinclair Remove base class ToJavaScript methods in FormCalc 2018-02-19 dsinclair Cleanup JS generation in formcalc. 2018-02-19 dsinclair Inline FormCalc method names 2018-02-19 dsinclair Inline some formcalc identifiers 2018-02-19 dsinclair Merge FormCalc to JavaScript methods Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic05e46f04d53b572379784cc2b160e1e5da9aa12 Reviewed-on: https://chromium-review.googlesource.com/925455Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537682}
-
Alexander Khaustov authored
This is a reland of 88a96c6e. Original change's description: > remove ThreadLocalStorage::StaticSlot > > in favor of the pattern with > NoDestructor<ThreadLocalStorage::Slot> as discussed on PS1 @ > https://chromium-review.googlesource.com/c/chromium/src/+/881017/1 > > StaticSlot has been subject to a possible initialization race: > CHECK_NE(slot_, kInvalidSlotValue) in StaticSlot::Initialize > could fail if another thread initialized it to kInvalidSlotValue > > Change-Id: Iefaa1dde6f85842d20561851a9a26ad5f3a20973 > Reviewed-on: https://chromium-review.googlesource.com/881017 > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Miriam Gershenson <mgersh@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537009} TBR=gab@chromium.org (already reviewed by others in original CL) Change-Id: I5675a9fe38d09486489155f897d602c87e008bb4 Reviewed-on: https://chromium-review.googlesource.com/924001 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#537681}
-
Nathan Parker authored
Bug: 808721 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0bb1055e363340ab58db1d557f2e9c46dc5a33d8 Reviewed-on: https://chromium-review.googlesource.com/912388 Commit-Queue: Nathan Parker <nparker@chromium.org> Reviewed-by:
Jialiu Lin (OOO Feb 14-19) <jialiul@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#537680}
-
vasilii authored
The new button appears when a password field is focused or when other password suggestions are displayed. The latter may happen when a username field is focused. Click on the button opens the list of passwords. User can find the relevant one there and copy it. Bug: 782287 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I199851bd28c76ac4b626f8a1ff81a86e8479a51e Reviewed-on: https://chromium-review.googlesource.com/816479 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#537679}
-