1. 21 Jul, 2016 40 commits
    • dpranke's avatar
      Flip remaining Mac tryserver perf builders to GN. · 8c1c6681
      dpranke authored
      This affects the folllowing builders on the tryserver.chromium.perf
      waterfall:
        - mac_10_10_perf_bisect
        - mac_10_11_perf_bisect
        - mac_fyi_perf_bisect
        - mac_hdd_perf_bisect
        - mac_perf_bisect_builder
        - mac_retina_perf_bisect
        - mac_retina_perf_cq
      
      R=rsesek@chromium.org
      BUG=618468
      
      Review-Url: https://codereview.chromium.org/2164963004
      Cr-Commit-Position: refs/heads/master@{#406947}
      8c1c6681
    • schenney's avatar
      Fix the positioning of backgrounds positioned right and bottom · 098ef3d2
      schenney authored
      A recent change unnecessarily pixel snapped the destination rect
      for background image painting before computing values determined by
      that rectangle. This caused situations where subsequent sub-pixel
      snapping pushes right and bottom positioned 1-pixel images outside
      the dest rect when it is intersected with the paint rect.
      
      The fix is to revert the line that early-snaps the dest rect.
      
      New test added to cover this case. One other test that had got slightly
      worse with the previous change gets better again with this change.
      
      R=pdr@chromium.org
      BUG=629075
      
      Review-Url: https://codereview.chromium.org/2167323002
      Cr-Commit-Position: refs/heads/master@{#406946}
      098ef3d2
    • twellington's avatar
      Recreate tab switcher stacks/lists when tabs are merged · cd0688e8
      twellington authored
      If tabs from two instances of are merged while either the StackLayout
      or OverviewListLayout is active, recreate the view so that the merged
      tabs show up in the layout.
      
      BUG=602498
      
      Review-Url: https://codereview.chromium.org/2162243002
      Cr-Commit-Position: refs/heads/master@{#406945}
      cd0688e8
    • grt's avatar
      Update support link in EULA dialog to the new p-link. · 13244eb9
      grt authored
      BUG=629558
      R=rpop@chromium.org
      
      Review-Url: https://codereview.chromium.org/2163913002
      Cr-Commit-Position: refs/heads/master@{#406944}
      13244eb9
    • tzik's avatar
      Remove obsolete gtest configurations · 5e583c4c
      tzik authored
      BUG=630299
      
      Review-Url: https://codereview.chromium.org/2168973002
      Cr-Commit-Position: refs/heads/master@{#406943}
      5e583c4c
    • watk's avatar
      Use the MediaCodec flush workaround in more cases · 5f69cdd9
      watk authored
      Courtesy of exoplayer, now we use the flush workaround in more cases
      than before.
      
      BUG=606110
      
      Review-Url: https://codereview.chromium.org/1918623002
      Cr-Commit-Position: refs/heads/master@{#406942}
      5f69cdd9
    • wfh's avatar
      Add some missing CrashExitCodes for child processes. · f7640b9c
      wfh authored
      Also, rename 536870904 to "Out of Memory" since this isn't a real
      Windows exception code.
      
      BUG=614440
      
      Review-Url: https://codereview.chromium.org/2170923002
      Cr-Commit-Position: refs/heads/master@{#406941}
      f7640b9c
    • ortuno's avatar
      bluetooth: Basic Web Bluetooth Fuzzer · 381085b7
      ortuno authored
      Adds basic structure of the fuzzer, a base template and some tests.
      
      The fuzzer in this file uses two variations of calls to requestDevice to
      generate a random sequence of calls. It then replaces instances of
      'TRANSFORM_REQUEST_DEVICE_OPTIONS' with object with a single filter with a
      single random service.
      
      BUG=570049
      
      Review-Url: https://codereview.chromium.org/2166463002
      Cr-Commit-Position: refs/heads/master@{#406940}
      381085b7
    • dpranke's avatar
      Update the MB builder mapping w/ a few changes. · cc19e4cf
      dpranke authored
      A couple of builders have been removed, and one has been added
      but it doesn't do compiles.
      
      TBR=brettw@chromium.org
      BUG=
      
      Review-Url: https://codereview.chromium.org/2167033002
      Cr-Commit-Position: refs/heads/master@{#406939}
      cc19e4cf
    • lushnikov's avatar
      Revert of DevTools: keep widgets in widget hierarchy upon hide, split... · 8a870698
      lushnikov authored
      Revert of DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide. (patchset #3 id:40001 of https://codereview.chromium.org/2157363006/ )
      
      Reason for revert:
      REverting as this broke devtools on Tip-of-tree
      
      [17701:17701:0721/140403:ERROR:CONSOLE(266)] "Uncaught (in promise) NotFoundError: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.", source: chrome-devtools://devtools/bundled/ui/Widget.js (266)
      
      TBR=pfeldman, dgozman
      
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      
      Review-Url: https://codereview.chromium.org/2170063002
      Cr-Commit-Position: refs/heads/master@{#406938}
      8a870698
    • ekaramad's avatar
      Tracking text selection on the browser side in OOPIF. · 6f1786b8
      ekaramad authored
      This CL adds the required logic to track the text selection information
      at the browser side. The text selection information is now stored in the
      WebContent's TextInputManager (outermost WebContents). All
      RenderWidgetHostViews as well as RenderWidgetHostViewAura
      (TextInputClient) will retrieve the information for a specific view or
      the active view from TextInputManager.
      
      BUG=578168, 602723
      CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
      
      Review-Url: https://codereview.chromium.org/2130133004
      Cr-Commit-Position: refs/heads/master@{#406937}
      6f1786b8
    • msramek's avatar
      Explicitly specify the vertical scrollbar in the MD settings CDB dialog · 564cf64f
      msramek authored
      Otherwise, a misplaced scrollbar appears (presumably on some related element
      from inside cr-dialog's shadow DOM).
      
      On the way, also relax the condition for the "< 714px height" screens to
      any media devices - there is no reason not to apply the same in print etc.
      
      BUG=625585
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
      
      Review-Url: https://codereview.chromium.org/2140613002
      Cr-Commit-Position: refs/heads/master@{#406936}
      564cf64f
    • catapult-deps-roller's avatar
      Roll src/third_party/catapult/ cb90e4130..a558b9bf0 (1 commit). · 6284aa1f
      catapult-deps-roller authored
      https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/cb90e4130adf..a558b9bf0e65
      
      $ git log cb90e4130..a558b9bf0 --date=short --no-merges --format='%ad %ae %s'
      
      TBR=catapult-sheriff@chromium.org
      
      Review-Url: https://codereview.chromium.org/2164883005
      Cr-Commit-Position: refs/heads/master@{#406935}
      6284aa1f
    • dcastagna's avatar
      ozone: Let BGRA fullscreen overlays replace primary plane. · a3a1976d
      dcastagna authored
      Ozone HardwareDisplayPlaneManager has an internal optimization where
      if an overlay completely covers the primary plane and it doesn't have an
      alpha channel it is used to replace the primary plane.
      
      Chrome promotes to overlays only RGBA buffers that don't use blending.
      
      This CL relaxes the costraint that the buffer has to XBGR to use this
      optimization.
      
      BUG=b/29430506
      
      Review-Url: https://codereview.chromium.org/2169733002
      Cr-Commit-Position: refs/heads/master@{#406934}
      a3a1976d
    • qyearsley's avatar
      Reland of actor the buildbot module in webkitpy. (patchset #1 id:1 of... · c0fee27d
      qyearsley authored
      Reland of actor the buildbot module in webkitpy. (patchset #1 id:1 of https://codereview.chromium.org/2165983003/ )
      
      Reason for revert:
      Creating a re-land CL to fix the issue encountered in https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/396281 and then re-land.
      
      As of the time when this reland patch is created, I still haven't found the cause of the problem.
      
      Original issue's description:
      > Revert of Refactor the buildbot module in webkitpy. (patchset #3 id:40001 of https://codereview.chromium.org/2152663003/ )
      >
      > Reason for revert:
      > On 2016/07/20 at 17:51:31, vadimsh wrote:
      > > Probably broke rebaseline-o-matic: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/396281
      >
      > Original issue's description:
      > > Refactor the buildbot module in webkitpy.
      > >
      > > This CL refactors BuildBot so that:
      > >  - There is now a results_url method in the BuildBot class (moved from AbstractRebaseliningCommand)
      > >  - Redundant functions are removed
      > >  - The Builder and Build classes are removed
      > >  - Buildbot-related functions in webkitpy.common.config.urls are moved into BuildBot
      > >  - Unit test and mock version are updated
      > >
      > > The purpose of this is to simplify the code; this is a follow-up to http://crrev.com/2112133002 which removed some unused functionality.
      > >
      > > Committed: https://crrev.com/66b942da80d7af5806f50630e55a9800102f43e1
      > > Cr-Commit-Position: refs/heads/master@{#406599}
      >
      > TBR=wkorman@chromium.org,dcampb@google.com,dpranke@chromium.org,vadimsh@chromium.org
      > # Skipping CQ checks because original CL landed less than 1 days ago.
      > NOPRESUBMIT=true
      > NOTREECHECKS=true
      > NOTRY=true
      >
      > Committed: https://crrev.com/b7c2c15eac19863207b008eaaa7916b726ef8d6c
      > Cr-Commit-Position: refs/heads/master@{#406614}
      
      TBR=wkorman@chromium.org,dcampb@google.com,dpranke@chromium.org,vadimsh@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      
      Review-Url: https://codereview.chromium.org/2164153002
      Cr-Commit-Position: refs/heads/master@{#406933}
      c0fee27d
    • dbeam's avatar
      Revert of 📰 Adjust the card display depending on the screen width. (patchset... · 91c4694e
      dbeam authored
      Revert of 📰 Adjust the card display depending on the screen width. (patchset #8 id:140001 of https://codereview.chromium.org/2149333003/ )
      
      Reason for revert:
      Broke Android compile:
      
      util.build_utils.CalledProcessError: Command failed: ( cd /mnt/data/b/c/b/Android_Arm64_Builder__dbg_/src/out/Debug; javac -g -encoding UTF-8 -classpath lib.java/chrome/android/chrome_java.interface.jar:lib.java/base/base_java.interface.jar:lib.java/base/base_java_test_support.interface.jar:lib.java/base/base_junit_test_support.interface.jar:lib.java/components/bookmarks/common/android/bookmarks_java.interface.jar:lib.java/components/invalidation/impl/java.interface.jar:lib.java/components/web_restrictions/web_restrictions_java.interface.jar:lib.java/content/public/android/content_java.interface.jar:lib.java/net/android/net_java.interface.jar:lib.java/sync/sync_java_test_support.interface.jar:lib.java/sync/android/sync_java.interface.jar:lib.java/third_party/WebKit/public/blink_headers_java.interface.jar:lib.java/third_party/android_tools/android_support_v7_mediarouter_java__jar_1.interface.jar:lib.java/third_party/android_tools/android_support_v7_mediarouter_java__jar_2.interface.jar:lib.java/third_party/android_tools/android_support_v7_recyclerview_java__jar_1.interface.jar:lib.java/third_party/cacheinvalidation/cacheinvalidation_javalib.interface.jar:lib.java/third_party/junit/hamcrest.interface.jar:lib.java/ui/android/ui_java.interface.jar:lib.java/third_party/android_tools/google_play_services_default_java.interface.jar:lib.java/testing/android/junit/junit_test_support.interface.jar:lib.java/third_party/junit/junit.interface.jar:lib.java/third_party/mockito/mockito_java.interface.jar:lib.java/third_party/robolectric/android-all-4.3_r2-robolectric-0.interface.jar:lib.java/third_party/robolectric/robolectric_java.interface.jar -sourcepath '' -Xlint:unchecked -Xlint:deprecation -d /tmp/tmphznxR6/classes ../../chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackupAgentTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackgroundServiceWaiterTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/ShortcutHelperTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/SSLClientCertificateRequestTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionControllerTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/cookies/CanonicalCookieTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtilsTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencerTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/gcore/GoogleApiClientHelperTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteControllerTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/media/remote/MediaUrlResolverTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/media/remote/RemoteVideoInfoTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterRouteTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterSinkObservationTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterTestBase.java ../../chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/CastMessageHandlerTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/DiscoveryCallbackTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/JSONTestUtils.java ../../chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/MediaSourceTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/TestUtils.java ../../chrome/android/junit/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/ntp/NativePageFactoryTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/ntp/TitleUtilTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/ClientIdTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/ShadowGcmNetworkManager.java ../../chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/StubBackgroundSchedulerProcessor.java ../../chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/TaskExtrasPackerTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/omaha/ResponseParserTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/omaha/VersionNumberTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillContactTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/snackbar/SnackbarCollectionUnitTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderUnitTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/tabstate/TabStateUnitTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/util/NonThreadSafeTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java ../../chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java /tmp/tmphznxR6/java/android/support/v7/recyclerview/R.java /tmp/tmphznxR6/java/android/support/v7/appcompat/R.java /tmp/tmphznxR6/java/android/support/v7/mediarouter/R.java /tmp/tmphznxR6/java/android/support/design/R.java /tmp/tmphznxR6/java/com/google/android/gms/R.java /tmp/tmphznxR6/java/org/chromium/ui/R.java /tmp/tmphznxR6/java/org/chromium/content/R.java /tmp/tmphznxR6/java/org/chromium/components/web_contents_delegate_android/R.java /tmp/tmphznxR6/java/org/chromium/chrome/R.java /tmp/tmphznxR6/java/org/chromium/third_party/android/R.java /tmp/tmphznxR6/java/org/chromium/third_party/android/media/R.java )
      ../../chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:162: error: constructor NewTabPageAdapter in class NewTabPageAdapter cannot be applied to given types;
              NewTabPageAdapter ntpa = new NewTabPageAdapter(mNewTabPageManager, null, mSnippetsBridge);
                                       ^
        required: NewTabPageManager,NewTabPageLayout,SnippetsBridge,UiConfig
        found: NewTabPageManager,<null>,SnippetsBridge
        reason: actual and formal argument lists differ in length
      
      https://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds/70053/steps/compile/logs/stdio
      
      Original issue's description:
      > [NTP Snippets] Adjust the card display depending on the screen width.
      >
      > Changes the lines to go from always 2 to at most 2 by default, so that
      > we don't show empty lines on very large screens.
      > For smaller screens, the title can go up to 4 lines, and we then hide
      > the description.
      > On bigger screens, we add space on the side of the cards
      >
      > Measures used:
      > < 360dp: Narrow -> 4 lines title
      > >= 360dp: Regular -> 2 + 2 lines
      > >= 600dp: Wide -> 2 + 2 lines, 48dp gutters around the cards
      >
      > Preview: https://goo.gl/photos/prJ42tvP4jzwiCn3A
      > BUG=625628, 624333
      >
      > Committed: https://crrev.com/7c430bb62b6269b9f1bce082083e00324a26daee
      > Cr-Commit-Position: refs/heads/master@{#406923}
      
      TBR=bauerb@chromium.org,mvanouwerkerk@chromium.org,peconn@chromium.org,dgn@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=625628, 624333
      
      Review-Url: https://codereview.chromium.org/2167973004
      Cr-Commit-Position: refs/heads/master@{#406932}
      91c4694e
    • achuith's avatar
      Revert of Shrink gn's chrome.dll - now smaller than gyp's (patchset #1 id:1 of... · 5f1f5e67
      achuith authored
      Revert of Shrink gn's chrome.dll - now smaller than gyp's (patchset #1 id:1 of https://codereview.chromium.org/2163933003/ )
      
      Reason for revert:
      Request revert by author
      
      Original issue's description:
      > Shrink gn's chrome.dll - now smaller than gyp's
      >
      > More work to shrink gn's chrome.dll
      >
      > The three largest globals that were present in gn's chrome.dll but not in gyp's chrome.dll were eliminated by using /verbose linker output to track the object files that pulled them in and then conditionally changing source_set targets to static_library targets. Specifically:
      >
      > unigram_table, in compact_enc_det.obj
      > - Referenced by TextResourceDecoder.obj from //third_party/WebKit/Source/core:html - some other source_set targets in this file were also modified
      >
      > gpu::ApplyFramebufferAttachmentCMAAINTELResourceManager::cmaa_frag_s1_ and cmaa_frag_s2_, in gles2_cmd_apply_framebuffer_attachment_cmaa_intel.obj from //gpu/command_buffer/service:service_sources
      > - Referenced by gpu_command_buffer_stub.obj from //gpu/ipc/service:ipc_service_sources
      > - Referenced by gpu_video_decode_accelerator.obj from //media/gpu/ipc/service:service
      > - Referenced by gpu_child_thread.obj from //content/gpu:gpu_sources
      > - Referenced by gpu_video_decode_accelerator_factory.obj from //content/public/gpu:gpu_sources
      >
      > As of R406709 this shrinks gn's 32-bit official chrome.dll file size from 38,907,904 bytes to 37,571,584 bytes - an unexpected 1,336,320 byte savings, mostly from the .text section. There is also ~67,000 bytes of memory-only savings in the zero-init part of the .data section.
      >
      > At the same revision gyp's 32-bit official chrome.dll file size is 37,843,456 bytes - 271,872 bytes *larger* than the gn version.
      >
      > There are still globals that are present in gn's chrome.dll but not gyp's chrome.dll, so the optimization technique can still be applied some more, but the priority is much lower now that gn is winning.
      >
      > This is a follow-on to crrev.com/2163823002.
      >
      > BUG=624274
      > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      >
      > Committed: https://crrev.com/e792bd734f3535995d3d34dba43259965b65c51e
      > Cr-Commit-Position: refs/heads/master@{#406912}
      
      TBR=brettw@chromium.org,brucedawson@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=624274
      
      Review-Url: https://codereview.chromium.org/2173453004
      Cr-Commit-Position: refs/heads/master@{#406931}
      5f1f5e67
    • xunjieli's avatar
      Fix CronetHttpURLConnectionTest#testServerHangsUp flake · 3627ffdc
      xunjieli authored
      This CL makes the server to keep sending data, so when we
      shut down the server, we are sure that it is still sending
      (no eof has been sent).
      
      BUG=629591
      
      Committed: https://crrev.com/056cabaa7714222bd67ecea221b7b3d4103752ee
      Review-Url: https://codereview.chromium.org/2164863002
      Cr-Original-Commit-Position: refs/heads/master@{#406833}
      Cr-Commit-Position: refs/heads/master@{#406930}
      3627ffdc
    • ryansturm's avatar
      Removing unused DRP histograms. · b74e7a4d
      ryansturm authored
      The following histograms are being marked as obsolete and the
      instrumentation is being removed:
      PLT.NT_Request*, PLT.NT_Redirect*, PLT.NT_Response*, PLT.NT_DelayBefore*
      
      BUG=629389,629390
      
      Review-Url: https://codereview.chromium.org/2160983004
      Cr-Commit-Position: refs/heads/master@{#406929}
      b74e7a4d
    • skia-deps-roller's avatar
      Roll src/third_party/skia/ b5dc4051f..81681949d (3 commits). · eb9058b4
      skia-deps-roller authored
      https://chromium.googlesource.com/skia.git/+log/b5dc4051f722..81681949d363
      
      $ git log b5dc4051f..81681949d --date=short --no-merges --format='%ad %ae %s'
      2016-07-21 caryclark allow curves on side of lines to be very small
      2016-07-21 borenet Add "skp" asset
      2016-07-21 vjiaoblack Creating framework for drawShadowedPicture GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003
      
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
      TBR=jcgregorio@google.com
      
      Review-Url: https://codereview.chromium.org/2168653006
      Cr-Commit-Position: refs/heads/master@{#406928}
      eb9058b4
    • ajuma's avatar
      cc: Move filters to the effect tree · cb2b7443
      ajuma authored
      This removes filters from LayerImpl, and adds them to the
      effect tree and to LayerImplTestProperties.
      
      BUG=622410
      CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
      
      Review-Url: https://codereview.chromium.org/2110683004
      Cr-Commit-Position: refs/heads/master@{#406927}
      cb2b7443
    • rajendrant's avatar
      Make ExternalDataUseReporter independent of other data use classes · 55ffa569
      rajendrant authored
      Removes DataUseTabModel and ExternalDataUseObserverBridge dependency on
      ExternalDataUseReporter by passing necessary callbacks.
      
      BUG=570884
      
      Review-Url: https://codereview.chromium.org/2165123002
      Cr-Commit-Position: refs/heads/master@{#406926}
      55ffa569
    • Xianzhu Wang's avatar
      Try to fix crash because of InlineBox deletion in a cached subsequence · f6c6259f
      Xianzhu Wang authored
      Don't know why the crashes occurred on bots. Couldn't reproduce the
      crashes reported by clusterfuzz locally. Based on the stack, the crash
      are because of deletion of an InlineBox in a cached subsequence.
      
      This partly reverts https://codereview.chromium.org/2160983007/.
      
      BUG=619630,628117
      R=chrishtr@chromium.org
      
      Review URL: https://codereview.chromium.org/2170583003 .
      
      Cr-Commit-Position: refs/heads/master@{#406925}
      f6c6259f
    • junov's avatar
      Fix gpu mipmap support on ChromeOS · 0c614148
      junov authored
      Fix gl version info check used to control texture internal
      format substitutions so that it does the right thing on
      ChromeOS.  Without this substitution we'd hit a Mesa bug
      that prevents mipmapping from working when the internal
      format is GL_BGRA
      
      BUG=540761
      CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
      
      Review-Url: https://codereview.chromium.org/2164723003
      Cr-Commit-Position: refs/heads/master@{#406924}
      0c614148
    • dgn's avatar
      [NTP Snippets] Adjust the card display depending on the screen width. · 7c430bb6
      dgn authored
      Changes the lines to go from always 2 to at most 2 by default, so that
      we don't show empty lines on very large screens.
      For smaller screens, the title can go up to 4 lines, and we then hide
      the description.
      On bigger screens, we add space on the side of the cards
      
      Measures used:
      < 360dp: Narrow -> 4 lines title
      >= 360dp: Regular -> 2 + 2 lines
      >= 600dp: Wide -> 2 + 2 lines, 48dp gutters around the cards
      
      Preview: https://goo.gl/photos/prJ42tvP4jzwiCn3A
      BUG=625628, 624333
      
      Review-Url: https://codereview.chromium.org/2149333003
      Cr-Commit-Position: refs/heads/master@{#406923}
      7c430bb6
    • kylechar's avatar
      Add new Ozone surface API. · b598dffa
      kylechar authored
      This CL adds the new API for how ozone platforms will create GLSurfaces.
      Now that //ui/ozone can depend on //ui/gl, the platform can create a
      GLSurface directly. SurfaceFactoryOzone has methods added for creating
      regular, surfaceless and offscreen surfaces. It also has a temporary
      method that will allow us to switch platforms over one by one.
      
      Small build file change to remove an unnecessary dep on //ui/base from
      //ui/gl. Since it was in public_deps, a few downstream changes to
      targets that depend on //ui/gl are needed as well.
      
      This is the start of step 3 in the associated bug.
      
      BUG=611142
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      
      Review-Url: https://codereview.chromium.org/2122243002
      Cr-Commit-Position: refs/heads/master@{#406922}
      b598dffa
    • erikchen's avatar
      Fix GetPlatformImageColor on macOS Sierra. · e1b5537d
      erikchen authored
      This test method was assuming that the output from NSReadPixel was in
      deviceRGBColorSpace, which is not necessarily true in macOS Sierra.
      
      BUG=629706
      
      Review-Url: https://codereview.chromium.org/2169633004
      Cr-Commit-Position: refs/heads/master@{#406921}
      e1b5537d
    • avi's avatar
      Rename the chrome/browser/ui/app_modal directory to be javascript_dialogs. · 175a82c7
      avi authored
      It will be the future home of the JavaScript dialog tab helper code, which will not be app-modal, so the name is no longer appropriate for use.
      
      In addition, I'm the owner of the existing dialog code (components/app_modal) so I'm going to claim ownership of the new code.
      
      BUG=629964
      TEST=none
      
      Review-Url: https://codereview.chromium.org/2169593003
      Cr-Commit-Position: refs/heads/master@{#406920}
      175a82c7
    • jbauman's avatar
      Correctly handle VPX videos in SMPTE.170 colorspace. · 2cd2671b
      jbauman authored
      These were being defaulted to BT.709, but the colorspace is actually
      identical to BT.601. See http://avisynth.nl/index.php/Colorimetry
      
      BUG=621325
      
      Review-Url: https://codereview.chromium.org/2165043003
      Cr-Commit-Position: refs/heads/master@{#406919}
      2cd2671b
    • kylechar's avatar
      Delete Ozone egltest platform. · 3f2b8008
      kylechar authored
      The Ozone X11 platform implements a more complete X11 backend for Ozone
      and egltest is unused at this point. Delete the egltest code and all the
      accompanying parts of GYP and GN build files.
      
      BUG=none
      
      Review-Url: https://codereview.chromium.org/2167243002
      Cr-Commit-Position: refs/heads/master@{#406918}
      3f2b8008
    • dpranke's avatar
      Flip many of the remaining Mac GYP builders to GN. · d3b350b3
      dpranke authored
      This flips most (but not all) of the remaining Mac GYP builders
      to GN:
      
      - chromium.fyi
        - Chromium Mac 10.10 MacViews
        - Chromium Mac 10.11
        - Chromium Mac 10.11 Force Mac Toolchain
        - Chromium Mac 10.9 Goma Canary
        - Chromium Mac 10.9 Goma Canary (clobber)
        - Chromium Mac 10.9 Goma Canary (dbg)
        - Chromium Mac 10.9 Goma Canary (dbg)(clobber)
        - ClangToTMac
        - ClangToTMac (dbg)
      - tryserver.chromium.mac:
        - mac_chromium_10.10_macviews
      
      There are still some GYP builders on chromium.perf and chromium.lkgr,
      but this CL is big enough as-is.
      
      R=rsesek@chromium.org
      BUG=618468
      
      Review-Url: https://codereview.chromium.org/2169683002
      Cr-Commit-Position: refs/heads/master@{#406917}
      d3b350b3
    • sunnyps's avatar
      Default enable main frame before activation and remove finch experiment. · 45041a7e
      sunnyps authored
      The finch experiment hasn't revealed any regressions other than in page
      load times which has been deemed a blink scheduler issue (see
      crbug.com/614482).
      
      R=piman@chromium.org,rkaplow@chromium.org
      BUG=612596
      
      Review-Url: https://codereview.chromium.org/2159103008
      Cr-Commit-Position: refs/heads/master@{#406916}
      45041a7e
    • dbeam's avatar
      MD Settings: drop duplicative cursor: pointer; styles · c4c39197
      dbeam authored
      They're already being applied by the [actionable] attribute from
      settings-shared.
      
      R=tommycli@chromium.org
      BUG=none
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
      
      Review-Url: https://codereview.chromium.org/2168633003
      Cr-Commit-Position: refs/heads/master@{#406915}
      c4c39197
    • xidachen's avatar
      Fix integer over flow issue in HTMLCanvasElement::canCreateImageBuffer · 29622ffb
      xidachen authored
      Right now in this method, it does a size.width() * size.height(), and
      that could cause integer overflow.
      
      This CL fix that by using CheckedNumeric<int>.
      
      BUG=630024
      
      Review-Url: https://codereview.chromium.org/2170693003
      Cr-Commit-Position: refs/heads/master@{#406914}
      29622ffb
    • wangxianzhu's avatar
      Better performance for -LayoutUnit · 224e6490
      wangxianzhu authored
      BUG=629932
      
      Review-Url: https://codereview.chromium.org/2171813002
      Cr-Commit-Position: refs/heads/master@{#406913}
      224e6490
    • brucedawson's avatar
      Shrink gn's chrome.dll - now smaller than gyp's · e792bd73
      brucedawson authored
      More work to shrink gn's chrome.dll
      
      The three largest globals that were present in gn's chrome.dll but not in gyp's chrome.dll were eliminated by using /verbose linker output to track the object files that pulled them in and then conditionally changing source_set targets to static_library targets. Specifically:
      
      unigram_table, in compact_enc_det.obj
      - Referenced by TextResourceDecoder.obj from //third_party/WebKit/Source/core:html - some other source_set targets in this file were also modified
      
      gpu::ApplyFramebufferAttachmentCMAAINTELResourceManager::cmaa_frag_s1_ and cmaa_frag_s2_, in gles2_cmd_apply_framebuffer_attachment_cmaa_intel.obj from //gpu/command_buffer/service:service_sources
      - Referenced by gpu_command_buffer_stub.obj from //gpu/ipc/service:ipc_service_sources
      - Referenced by gpu_video_decode_accelerator.obj from //media/gpu/ipc/service:service
      - Referenced by gpu_child_thread.obj from //content/gpu:gpu_sources
      - Referenced by gpu_video_decode_accelerator_factory.obj from //content/public/gpu:gpu_sources
      
      As of R406709 this shrinks gn's 32-bit official chrome.dll file size from 38,907,904 bytes to 37,571,584 bytes - an unexpected 1,336,320 byte savings, mostly from the .text section. There is also ~67,000 bytes of memory-only savings in the zero-init part of the .data section.
      
      At the same revision gyp's 32-bit official chrome.dll file size is 37,843,456 bytes - 271,872 bytes *larger* than the gn version.
      
      There are still globals that are present in gn's chrome.dll but not gyp's chrome.dll, so the optimization technique can still be applied some more, but the priority is much lower now that gn is winning.
      
      This is a follow-on to crrev.com/2163823002.
      
      BUG=624274
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      
      Review-Url: https://codereview.chromium.org/2163933003
      Cr-Commit-Position: refs/heads/master@{#406912}
      e792bd73
    • wkorman's avatar
      Clean up in-flow position offset for LayoutInline mapping to visual rect. · a0be1c38
      wkorman authored
      Review-Url: https://codereview.chromium.org/2165913005
      Cr-Commit-Position: refs/heads/master@{#406911}
      a0be1c38
    • tsniatowski's avatar
      Use absolute namespace references in //base/logging.h macros · 612550fd
      tsniatowski authored
      Macros can be used in various namespace contexts, and macros that expand
      to "logging::Something" can end up choosing some_namespace::logging
      if used in a context wher ethere exists a nested namespace logging with
      a conflicting name like LogMessage. It's fixable by using "::logging::"
      instead of "logging::" in the macros.
      
      No examples of such issues in chrome, but this can help downstream and
      seems a good thing to do consistently.
      
      BUG=
      
      Review-Url: https://codereview.chromium.org/2045203004
      Cr-Commit-Position: refs/heads/master@{#406910}
      612550fd
    • tzik's avatar
      Remove unused include_dir in //ui/event/BUILD.gn · 10dbcfdf
      tzik authored
      An include_dir setup for gmock in //ui/event/BUILD.gn is unused, and
      that prevents to add another include dir to gmock dependencies.
      This CL removes it for the preparation.
      
      BUG=630299
      
      Review-Url: https://codereview.chromium.org/2171793002
      Cr-Commit-Position: refs/heads/master@{#406909}
      10dbcfdf
    • tommycli's avatar
      WebViewPlugin: Post geometry-update actions to a task to run async. · d16e9164
      tommycli authored
      WebViewPlugin resizes itself and actually may load a new plugin in
      response to a geometry update.
      
      Geometry updates are triggered during layout, and Blink assumes these
      things can't happen during layout.
      
      Therefore, post these actions to a task to run asynchronously. This is
      the same approach that PepperPluginInstanceImpl takes.
      
      BUG=628629
      
      Review-Url: https://codereview.chromium.org/2164753003
      Cr-Commit-Position: refs/heads/master@{#406908}
      d16e9164