- 07 May, 2020 40 commits
-
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. All calls to this function in chrome/browser/ui which are clearly only happening for incognito or guest browser are updated. This CL does not make any behavioral changes. Bug: 1060940 Change-Id: I39fcb02d986dbd973c3a49922bc24b774981e3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187372 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#766352}
-
Guido Urdaneta authored
Check that the value for this property is not null before trying to use its value. Bug: 1031921 Change-Id: I164ad850775df07fa5b993d7db51e671fc5bfa36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185491 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#766351}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1079135 Change-Id: I5c880c3645c938d87fe5c1a0db4f04bec6c1c6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186878 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#766350}
-
Yoshifumi Inoue authored
This patch changes "5190926.html" to utilize |selection_test()| and renames to "insert_list_with_underline.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I41ebbf60f50fa84a23526995624fc0db198506b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186618 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ba415029243a..8dd25597363a git log ba415029243a..8dd25597363a --date=short --first-parent --format='%ad %ae %s' 2020-05-07 dberris@chromium.org Pinpoint: Fix URL when displaying errors 2020-05-07 dberris@chromium.org Dashboard: Defer work to the background Created with: gclient setdep -r src/third_party/catapult@8dd25597363a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1079166 Tbr: wenbinzhang@google.com Change-Id: I66ec62528e13fdbe7d1a4f0f318cc586bfdc7769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187364Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766348}
-
Denis Kuznetsov authored
Also updated offline-gaia screen so that is correctly handles subsequent loads with different parameters. Bug: 1073095 Change-Id: Ia75246be91197ac4bb7804f52bae44c48c839e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183932 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#766347}
-
Makoto Shimazu authored
We are going to resume this project. Let's extend the expiry date for the experiment. Bug: 824858 Change-Id: I14a0b20af553f6f1cbc3c0d90d2de6bbb98aa802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186787Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#766346}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/88d04cb51acf..e3d1de7c5281 git log 88d04cb51acf..e3d1de7c5281 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 daed369cfdb6..101da7573691 (16 commits) 2020-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3e771a1c..207cebd2 (418 commits) 2020-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader baa10d7b1dee..08afdde7726c (4 commits) 2020-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/dawn 0abddd21c9ad..e8bf706d161d (6 commits) Created with: gclient setdep -r src/third_party/skia@e3d1de7c5281 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I6a5f30e55d4aef112c6234e0c0272e774e73a54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186540Reviewed-by:
-
dpapad authored
Specifically: - CookieDataSummaryItem was partially incorrect, and also resided in a UI element, instead of residing in local_data_browser_proxy.js, where the data it describes actually comes from. - LocalDataItem was entirely incorrect - Deleted CookieDataSummaryItem, and fixed LocalDataItem to be the correct one (matching what actually is passed back from C++) These were discovered in the process of adding JS type checking for all_sites_test.js Bug: 1000989 Change-Id: I2e39b447f8de1cc5fb60cbf02af23839f25bd211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185576 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#766344}
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/u-v5J.....MeLYn... Created with: gclient setdep -r src/third_party/aemu-linux-x64@MeLYn... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: Id7793cb82a687138ae5e5c5f18544508862827db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187362Reviewed-by:
-
Tiancong Wang authored
In crrev.com/c/2173581, we increased the amount to make sure all the Chrome OS CQ builders can pass. However after we remove the workaround in the wrapper, Chrome builders start to fail, so we need to increase the token yet again, because at this point it's hard to tell which file causes the problem. BUG=chromium:1079053 TBR=thakis@chromium.org TEST=None Change-Id: Ie8a5b577fa930a2df287fa36c501f7ce5b6debee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186356 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Auto-Submit: Tiancong Wang <tcwang@google.com> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#766342}
-
Kent Tamura authored
When an OPTION element is added to an OPTGROUP element, HTMLOptGroupElement::ChildrenChanged() is responsible to notify it to the OPTGROUP's owner SELECT element. The function checks existence of the owner SELECT first, but it failed because of the wrong implementation of HTMLOptGroupElement::OwnerSelectElement(). This CL fixes OwnerSelectElement(). Bug: 1077556 Change-Id: If1bd4dbd022954c6caa55a8e44d3a31e2994b55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186786 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "5142012-1.html" to utilize |selection_test()| and renames to "unlink_with_div.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I43838e8541fa06c4abebbe7771ac4ffe759dcfad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186835 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#766340}
-
Alice Wang authored
This CL replaces SigninTestUtil by AccountManagerTestRule to mock the signin environment in HistoryActivityScrollingTest. The latter is simpler and less flaky. Bug: 1078342 Change-Id: I4343369b9423fb8ad71e835f10388dd17d250e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184910 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#766339}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8789cfc7a5bc..459d7cc439a1 Created with: gclient setdep -r src-internal@459d7cc439a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC noel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: noel@google.com Change-Id: I48ea9b29a9b63897a651db8a4280ce51fdfd4ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186542Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766338}
-
Clemens Arbesser authored
For now, this is simply a smoke test that opens the edit dialog for a server card and verifies that this does not break the client. b/155624806 tracks progress for adding a more elaborate test, this CL is merely to get the effort started. Bug: b/155624806 Bug: b/153498495 Change-Id: I02cdef5115d011748410b72de38913c2cb262ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179883Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#766337}
-
Sujie Zhu authored
We update GetCreditCardObfuscatedNumber to GetCreditCardIdentifierString which uses CardIdentifierStringForAutofillDisplay() and is only used in iOS settings page. The GetCreditCardIdentifierString will return 'Nickname - ****2345' if nickname is enabled and available; otherwise, fall back to current pattern 'IssuerNetwork - ****2345'. Note that we have verified that long nicknames will be auto-wrapped into multiple lines. And we won't update the 'Edit Credit Card' page, we still display full card number for local card, network+last four for server card. Here is the local test video (googlers only): https://drive.google.com/file/d/1maQqdy0XTj_pd1O_JTKsLRJ2BJhoY2a7/view?usp=sharing Bug: 1059087 Change-Id: I68e56dc7d94c04fedb9087bcd199aa79e396c141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184747 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#766336}
-
Eugene But authored
Make all variables in crw_web_controller_unittest.mm follow C++ Style Guide inside C++ code. Bug: None Change-Id: Ic5a1d3978ab63edb2f52904369e7eb56f64072b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184742 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/101da7573691..e7d27705e160 git log 101da7573691..e7d27705e160 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 jiajie.hu@intel.com Fix corruption when changing the base level of a framebuffer texture attachment Created with: gclient setdep -r src/third_party/angle@e7d27705e160 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Ic18130d47043c874c26d77e0bb332c248497ac4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186545Reviewed-by:
-
Frank Liberato authored
player. This CL moves the id into the shared log record, so that all cloned logs share the same id. Without this, cloned logs will create a new player in chrome://media-internals . MediaLog: :Clone() should produce a log that refers to the original Change-Id: I1f7fd6a269f9d00de24489fa4d4ccd8c794faa13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185805 Commit-Queue: Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#766333}
-
Michele Mancina authored
Bug: b/154790255 Change-Id: I7c463c9266dbc6b57baf658c821d86a1d09c8b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179525 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Marian Fechete authored
This CL adds custom onboarding strings for a few new intents. Bug: b/155874756 Change-Id: I8398f7887d3524fb3dccd0c2d4fe71f241286e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185129Reviewed-by:
-
Pâris Meuleman authored
This adds the parsing of the report-to parameter in the cross-origin-opener-policy header as well as the parsing of the cross-origin-opener-policy-report-only header. To that end this changes the mojom structure representing the COOP value. These changes are fairly similar to what was implemented by yhirano@ on embedder policy, first in https://crrev.com/c/2060090. The same logic applies regarding the introduced typemaping. Bug: 1076456 Change-Id: Iaa331b4a177265e585b8d16da359bbd072aef09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172695 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#766330}
-
Xiaocheng Hu authored
The function is marked as a const function, but actually modifies |family_index_| via a non-const reference, which doesn't make sense. This patch simplifies the code to improve readability. Bug: 441925 Change-Id: I2df29b512c3b6173115ad8ca30016ccfacf97d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183173 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Shik Chen authored
This CL enables the special wasm-eval CSP for web workers in Chrome apps and extensions, which was missed from https://crrev.com/c/761244. Without this, when trying to loading a worker from Chrome App, there would be a confusing error message: > The source list for Content Security Policy directive 'script-src' > contains an invalid source: ''wasm-eval''. It will be ignored. Some discussions about this problem on the web: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-os-dev/OEUDlqmUyDg https://stackoverflow.com/questions/53059125/script-src-contains-an-invalid-source-wasm-eval-while-using-web-worker Bug: chromium:1070929, chromium:1058325, chromium:940811, v8:7041 Test: Open the built-in camera app on Chrome OS and check there is no error message in console. Change-Id: If22b5fd0a5ae5d08a5628a8180e57b475044fd02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152339Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#766328}
-
Yoshifumi Inoue authored
This patch changes "4916541.html" to utilize |selection_test()| and renames to "indent_preserves_selection.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ia4924cefd6bfd93f9c83954a425cdafb15db3dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186788 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ce41a3520a40..ba415029243a git log ce41a3520a40..ba415029243a --date=short --first-parent --format='%ad %ae %s' 2020-05-07 mukai@chromium.org Revert "Do not update chrome_dev.conf on cros_browser backend" 2020-05-07 dberris@chromium.org Dashboard: Support partial success 2020-05-07 dberris@chromium.org Dashboard: Support empty benchmark owners 2020-05-06 rmhasan@google.com typ: Prevent duplicate reasons from being added to expectation 2020-05-06 mukai@google.com Do not update chrome_dev.conf on cros_browser backend Created with: gclient setdep -r src/third_party/catapult@ba415029243a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050754,chromium:1050760,chromium:1078418,chromium:1078832,chromium:1078838 Tbr: rmhasan@google.com Change-Id: I9aeb78b0860744fec50d8d6e416e479ac5ba1408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186547Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "5369009.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I90854ff5112367bc7c479e1029addd56d8a16740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186617 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "4631972.html" to utilize |selection_test()| and renames to "insert_iframe.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Idb18353d6aada5cd8324d39ca29eb5c4eb497d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186832 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4daf9ae6dfb7..28ae7c5809b2 git log 4daf9ae6dfb7..28ae7c5809b2 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 szuend@chromium.org [deps] Roll chromium changes into DevTools Created with: gclient setdep -r src/third_party/devtools-frontend/src@28ae7c5809b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ieba4357b745df8ae4c0b602f13d24da7244dad2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186546Reviewed-by:
-
Marc Treib authored
For successful form submissions, it records where the filled password came from: The profile store, the account store, both, or neither. Bug: 1063852 Change-Id: I03555c309f99e126831b7564bec522d1aa6d8fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165894 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#766322}
-
Yoshifumi Inoue authored
This patch changes "leave-requested-block.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I44d05c7c1dd9c33206a61f774de9726731ad4a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186877 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ic7f0d09214a3b9df1064b333a464ea95f3df105e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169449Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#766320}
-
Roman Sorokin authored
to reduce flakiness of tests. The button is used in tests to interact with real Gaia. Gaia makes this button enable/disable hidden/visible during the signin flow. That might lead to clicks missing and tests failing. This CL adds waiting logic in javascript. It waits for the button being visible and enabled. Also it should remove cros tests dependency on the button name. Bug: 1077836 Test: tast run unicorn.Login Change-Id: I67e9c4ed8a392b05202ddb4a406232d1a8c49f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185090 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#766319}
-
François Beaufort authored
This CL makes sure user is prompted with camera PTZ access if any of the constrained values for pan, tilt, and zoom are present in getUserMedia options. This CL does not check yet for hardware support. This will come in a follow-up CL, as well as applying constraints after getUserMedia succeeds. The camera PTZ permission request is grouped with camera and microphone permission requests. Screenshots: https://i.imgur.com/J9rrWS5.png https://i.imgur.com/aGSUZVY.png Explainer: https://github.com/w3c/mediacapture-image/blob/master/ptz-explainer.md Test: https://ptz.glitch.me/ Change-Id: Ia940cd62952d828598203506ea73992ac1e87e73 Bug: 934063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127109 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#766318}
-
Rahul Arakeri authored
This CL enables ElasticOverscrollController for the root scroller on Windows to be instantiated. Turning on elastic overscrolling works for PTP but not for touch scrolling, as it does not have the necessary inertial_phase information that InputScrollElasticityController relies on. This CL adds that information for touch scroll events. Bug: 1058071 Change-Id: Ibcb1a373def9564a7b0ea81f62493d455055a8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183709 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#766317}
-
Mike Dougherty authored
TBR=gambard@chromium.org Bug: 1079165 Change-Id: I307de9b7df38f7b1af99639546df6b686cde5f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186359Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
Julian Watson authored
This will allow for mocking of PluginVmManager in tests. Tbring the owners of the following files as the changes are very mechanical: ★ ./chrome/browser/chromeos/policy/lock_to_single_user_manager.cc: ★ ./chrome/browser/task_manager/providers/vm/plugin_vm_process_task.cc: ★ ./chrome/browser/ui/app_list/app_service/app_service_context_menu.cc: ★ ./chrome/browser/ui/ash/launcher/app_service/app_service_shelf_context_menu.cc (2 files): ★ ./chrome/browser/ui/webui/settings/chromeos/plugin_vm_handler.cc: TBR=anqing@chromium.org TBR=afakhry@chromium.org TBR=nancylingwang@chromium.org TBR=jamescook@chromium.org Bug: 1049453 Change-Id: I0c73bc8d2b6b0f4e4de2870c3b7cdba17808d686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186616 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#766315}
-
Yoshifumi Inoue authored
This patch changes "paragraph-separator-in-table-[12].html" to utilize |selection_test()| and unifies into "paragraph_separator_in_table.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Iabe097cddaf3843c6192935b5a43d60cda81957d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186876 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Michael Lippautz authored
The fix in https://crrev.com/de39db161c8f0e032094c3458d399191f116a4c2 had the right idea but missed out on removing the parts that clear the references too eagerly. This patch keeps the same fix but ensures that the old code is removed. I manually verified that this fixes a CF issue (1079033) that still reproduces on master. Bug: chromium:1078751, chromium:1079033 Change-Id: Iaddbbb17b360304c6c9b59399bc6e4e219833c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187269Reviewed-by:
-
