GitLab

Review URL: https://codereview.chromium.org/935333004

Cr-Commit-Position: refs/heads/master@{#317040}

Cr-Commit-Position: refs/heads/master@{#317039}

SkImageGenerator is in the process of adding an enum return value to
onGetPixels. For staging, it has been replaced with onGetPixelsEnum.
(See https://codereview.chromium.org/919693002/)

Implement the new API. A follow up change will rename onGetPixelsEnum
to onGetPixels.

No need to check for null pixels; onGetPixels is only called by
getPixels which has already done the check.

R=reed@google.com,fmalita@chromium.org

BUG=skia:3257

Review URL: https://codereview.chromium.org/934263002

Cr-Commit-Position: refs/heads/master@{#317038}

password_manager_util_mac uses hardcoded "com.google.Chrome", since rest of the
code is pretty generic we would like to use this file directly in Opera, however
we want to use something like com.operasoftware.Opera, since that information is
can already be retrieved from [base::mac::MainBundle() bundleIdentifier] we can
just use it and append ".show-passwords".

BUG=447344

Review URL: https://codereview.chromium.org/817333002

Cr-Commit-Position: refs/heads/master@{#317037}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a1303a8..de34936

TBR=kbr@chromium.org,yosin@chromium.org

Review URL: https://codereview.chromium.org/943523002

Cr-Commit-Position: refs/heads/master@{#317036}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c119981..cd87c51

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/939993002

Cr-Commit-Position: refs/heads/master@{#317035}

Build bot recipes have been upgraded to explicitly request the provisioning
options they need.

At this point it should be safe to remove the code that guessed the required
configuration from the bot name.

BUG=450984

Review URL: https://codereview.chromium.org/926333004

Cr-Commit-Position: refs/heads/master@{#317034}

BUG=459326
TEST=open a folder which contains transparent image and confirm that generic thumbnail is not visible behind thumbnail.

Review URL: https://codereview.chromium.org/935333003

Cr-Commit-Position: refs/heads/master@{#317033}

BUG=459165
TEST=Trigger renaming on list and grid view, and check the icons.

Review URL: https://codereview.chromium.org/937143002

Cr-Commit-Position: refs/heads/master@{#317032}

This is a cleanup and should change no functionality. See the issue for detail.

BUG=442214
TEST=browser_test passes
R=fukino@chromium.org

Review URL: https://codereview.chromium.org/921043004

Cr-Commit-Position: refs/heads/master@{#317031}

BUG=402344
TEST=compared with the design spec manually.

Review URL: https://codereview.chromium.org/937083002

Cr-Commit-Position: refs/heads/master@{#317030}

- Update filetype icons.
- Use PNG images as icons in directory tree, instead of SVG images.

BUG=402344,455158
TEST=manually checked.

Review URL: https://codereview.chromium.org/939013002

Cr-Commit-Position: refs/heads/master@{#317029}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fa54650..a1303a8

TBR=kbr@chromium.org,yosin@chromium.org

Review URL: https://codereview.chromium.org/914733009

Cr-Commit-Position: refs/heads/master@{#317028}

Android binaries were relying on -Wl,--exclude-libs=ALL to prevent
unnecessary symbols from being exported in the final shared libraries
built in Chromium, however several changes were submitted that actually
disabled this linker flag in virtually all binaries, and thus it was not
really being used and many symbols were exported by mistake.

Remove --exclude-libs=ALL entirely from the Android build, as well as
all the places which were previously having to unset it, and instead
exclude the specific libraries which incorporate visible symbols that we
don't want: the NDK libraries which we statically link into the binary,
and a number of components of chromium which contain assembly code which
has not yet been fixed to set symbol visibilities correctly.

This reduces the number of exported symbols in the shared libraries to
only the ones we intended to export, which saves ~120KB binary size.

The GN build does not build the same set of things as static libraries,
so the list is slightly different there and several more symbols are
left in the final binaries which shouldn't be there, but are not pulled
in via a static library and so no --exclude-libs flag will ever fix it;
the symbol visibilities will need to be fixed at source.

BUG=448386
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/806533003

Cr-Commit-Position: refs/heads/master@{#317027}

Existing code has assumed a trace function call delegating to a base class has
the same name as the name of the function where the trace call is written (e.g.
Base::trace(visitor) in Derived::trace(), and Base::traceAfterDispatch(visitor)
in Derived::traceAfterDispatch()).

After the introduction of traceImpl(), however, this is no longer true. This
patch fixes this issue.

BUG=none
R=kouhei@chromium.org
CC=zerny@chromium.org, oilpan-reviews@chromium.org

Review URL: https://codereview.chromium.org/935253002

Cr-Commit-Position: refs/heads/master@{#317026}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/209cf09a..b696572d

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/923983003

Cr-Commit-Position: refs/heads/master@{#317025}

BUG=452613,456193

Review URL: https://codereview.chromium.org/920853004

Cr-Commit-Position: refs/heads/master@{#317024}

This is because the hotword stream requires that it be closed and
re-opened after triggering and currently, the only way to do this is to
shutdown the detector since its stream cannot be replaced.

BUG=403138

Review URL: https://codereview.chromium.org/940833002

Cr-Commit-Position: refs/heads/master@{#317023}

BUG=400674
TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/924733003

Cr-Commit-Position: refs/heads/master@{#317022}

Directory rescan sometimes uses up IO and blocks other IOs which are necessary
for updating the top-left breadcrumb. While this CL does not solve the real
cause of the issue, this CL mitigates the problem by dispatching event earlier.

BUG=459864
TEST=manually tested as described in the issue

Review URL: https://codereview.chromium.org/943473002

Cr-Commit-Position: refs/heads/master@{#317021}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/37a8479..fa54650

TBR=kbr@chromium.org,yosin@chromium.org

Review URL: https://codereview.chromium.org/938963003

Cr-Commit-Position: refs/heads/master@{#317020}

BUG=410766
TEST=None

Review URL: https://codereview.chromium.org/936243004

Cr-Commit-Position: refs/heads/master@{#317019}

BUG=459872

Review URL: https://codereview.chromium.org/935143005

Cr-Commit-Position: refs/heads/master@{#317018}

When the affiliated invalidation service provider, it should:
1) unregister itself as an observer of various objects
2) tell consumers to stop using the current invalidation service
3) destroy the device-global invalidation service, if any

Steps 2 and 3 were swapped. This meant that if the device-global
invalidation service happened to be in use, it would be destroyed
without giving consumers a chance to remove their handlers from it.

BUG=455504
TEST=None

Review URL: https://codereview.chromium.org/942463002

Cr-Commit-Position: refs/heads/master@{#317017}

This is because on Windows, we close some handles opened by Windows DLLs to prevent them from leaking into sandboxed processes, and this can cause INVALID_HANDLE_EXCEPTION to be raised if "bad handle detection" gflag is enabled, as it currently is by default on Windows 10.

Only replace File and Event handles at the moment, as File handles are the ones causing the issues on Windows 10.

BUG=452613
TEST=sbox_integration_tests
TEST=Run Chrome on Windows 10 with crash reporting enabled, and check there are no crashes listed in chrome://crashes

Review URL: https://codereview.chromium.org/919893002

Cr-Commit-Position: refs/heads/master@{#317016}

Audio player refers 'media.title' and 'media.artist' properties that are fetched
by ContentMetadataProvider. Because these properties are not related with
thumbnail, the CL moves ContentMetadataProvider to FileSystemMetadata for
preparing to use new metadata class in Audio player.

BUG=410766
TEST=FileManagerJsTest.FileSystemMetadata

Review URL: https://codereview.chromium.org/932343003

Cr-Commit-Position: refs/heads/master@{#317015}

BUG=none
TEST=none
R=rogerta@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/898003002

Cr-Commit-Position: refs/heads/master@{#317014}

The world isn't quite ready for them....

BUG=459504
TBR=benwells@chromium.org,thestig@chromium.org
Original patch from benwells; reviewed in http://crrev.com/938603002

Review URL: https://codereview.chromium.org/937843004

Cr-Commit-Position: refs/heads/master@{#317013}

If an extension printer does not declare support for PDF in its
capabilities, convert print data to PWG raster before dispatching
print request to the extension.

BUG=408772

Review URL: https://codereview.chromium.org/919213002

Cr-Commit-Position: refs/heads/master@{#317012}

Extensions with background pages (e.g. Google Cast) currently have a
shorter code path when showing an extension popup that can cause the
renderer to ask for screen metrics before the hosting NSView is added to
the view hierarchy. Since the NSWindow is nil in this case, screen
metrics for the primary screen are used, and they may be the incorrect
screen for the popup.

On non-Mac, toolkit-views platforms get around this problem by deferring
creation until View::ViewHierarchyChanged is triggered. However, there
is no NSView apart from the render view on the extension-side on Mac, so
to do the same we'd either need to add one (and keep it sized
appropriately), or modify the WebContents view itself to override
[NSView viewDid/WillMoveToSuperview] and feed it through to embedders.

Instead, this CL tweaks the ExtensionPopupController initialization to
always create the popup NSWindow (initially hidden), before creating the
ExtensionViewHost.

BUG=324748, 305620
TEST=On a retina mac, plug in a (non-retina) external monitor, move
Chrome there, and open the Chromecast dialog. It should look "nice" (not
as nice as the retina screen, but consistent with other text in Chrome).
See http://crbug.com/324748#c41

Review URL: https://codereview.chromium.org/653843002

Cr-Commit-Position: refs/heads/master@{#317011}

It may not be readily apparent how to the fix the error otherwise.

BUG=457097

Review URL: https://codereview.chromium.org/939883002

Cr-Commit-Position: refs/heads/master@{#317010}

Some users of the checkbox reported not expecting the SW to pause on startup.

BUG=455708

Review URL: https://codereview.chromium.org/939763003

Cr-Commit-Position: refs/heads/master@{#317009}

Add a test which covers the case of exporting all the keys
and installing them back to fully bootstrap another cryptographer.

Review URL: https://codereview.chromium.org/896313002

Cr-Commit-Position: refs/heads/master@{#317008}

BUG=459326
TEST=Manually tested as described in the issue.

Review URL: https://codereview.chromium.org/913203007

Cr-Commit-Position: refs/heads/master@{#317007}

This CL makes the app list search results use the short names of apps
to be consistent with the name shown in the apps grid view.

BUG=456961

Review URL: https://codereview.chromium.org/918443002

Cr-Commit-Position: refs/heads/master@{#317006}

BUG=459556
TBR=jyasskin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/932253005

Cr-Commit-Position: refs/heads/master@{#317005}

Cr-Commit-Position: refs/heads/master@{#317004}

Placeholder strings should be sentence case (even when use_titlecase is
enabled). This fixes the search box placeholder text which was missing
"or type URL" in titlecase environments (because I forgot to update that
version of the string).

Also fixed some minor comma placement in some "Ok Google" strings.

BUG=459537
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/919323003

Cr-Commit-Position: refs/heads/master@{#317003}

BUG=None
TEST=None
TBR=smckay@chromium.org

Review URL: https://codereview.chromium.org/937093002

Cr-Commit-Position: refs/heads/master@{#317002}

While looking through the code, found some places where we are using pointers
even though their values can be null. This patch adds null checks so as not to
have any crashes due to pointer value being null.

Review URL: https://codereview.chromium.org/924843002

Cr-Commit-Position: refs/heads/master@{#317001}