GitLab

We have several independent places where we decided how extension icon
is represented. We have separate logic for the shelf, recent view, app
list and app info icons. Icon look depends on type of app and some
external conditions. This leads to situation that extension App icon
looks differently in different places. Yet another problem is non-stable
applying Chrome badging in case corresponded ARC app is installed or
uninstalled.

Solution is to provide centrilized place where app icon is processed
and all consumers should use. ChromeAppIcon is introduced that applies all necessary effects based on current environment and app type. ChromeAppIconService is introduced to refer all created icons,
monitor environment changes and updating the icon. Resulting icon
image is sent to consumer via ChromeAppIconDelegate interface.

BUG=712729
BUG=703366
BUG=b/37418449
Test=Manually on device. Existing tests passed.

TBR=yoshiki@chromium.org

Review-Url: https://codereview.chromium.org/2819413003
Cr-Commit-Position: refs/heads/master@{#471035}

Bug: 721157
Change-Id: I180cb4df0839deb0fb23e0ff962b172bd2517f5e
Reviewed-on: https://chromium-review.googlesource.com/502628Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471034}

Revert of Update ozone/drm proxy_helpers.h to support move-only types. (patchset #1 id:1 of https://codereview.chromium.org/2873963004/ )

Reason for revert:
ozone_unittests has been failing continuously since this landed:

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/46812

[ RUN      ] ProxyHelpersTest.PostTask
../../ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc:69: Failure
Value of: main_checker_.CalledOnValidThread()
  Actual: true
Expected: false
../../ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc:50: Failure
Value of: main_checker_.CalledOnValidThread()
  Actual: true
Expected: false
../../ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc:75: Failure
Value of: drm_checker_.CalledOnValidThread()
  Actual: true
Expected: false

Original issue's description:
> Update ozone/drm proxy_helpers.h to support move-only types.
>
> As a helpful prerequisite for the use of mojo IPC in ozone/drm,
> support move only types in proxy_helpers.h callback sequences.
>
> BUG=620927
>
> Review-Url: https://codereview.chromium.org/2873963004
> Cr-Commit-Position: refs/heads/master@{#470715}
> Committed: https://chromium.googlesource.com/chromium/src/+/a82a006f8420ecc7c75deab4f1e9d23c43616e1f

TBR=dnicoara@chromium.org,rjkroege@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=620927

Review-Url: https://codereview.chromium.org/2873153005
Cr-Commit-Position: refs/heads/master@{#471033}

BUG=721475

TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2874293002
Cr-Commit-Position: refs/heads/master@{#471032}

BUG=673362

Review-Url: https://codereview.chromium.org/2878563002
Cr-Commit-Position: refs/heads/master@{#471031}

This allows users to turn client-side LoFi on android.

BUG=720920

Review-Url: https://codereview.chromium.org/2870263004
Cr-Commit-Position: refs/heads/master@{#471030}

This CL modify the FrameLoadType of frames such that the
ReloadBypassingCache load type gets propagated to every subframe during
a reload.

It fixes ReloadCacheControlBrowserTest.BypassingReload test with
PlzNavigate. Every ReloadCacheControlbroserTest are passing now.

BUG=671545
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel

Review-Url: https://codereview.chromium.org/2863683003
Cr-Commit-Position: refs/heads/master@{#471029}

This tries to mimic the current commandline opion of
./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run
test case in WebKit/PerformanceTests/.. directory using the command:

./tools/perf/run_benchmark blink_perf --test-path=<path to test cases>

For examples, after this CL, users can invoke:
* './tools/perf/run_benchmark blink_perf --test-path=third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html'
command to run only color-changes-measure-frame-time.html test.

* './tools/perf/run_benchmark blink_perf --test-path=TestData/'
command to run all the tests in WebKit/PerformanceTests/TestData/ directory.

This is a lot more convenient for users who are wanting to add new test cases in
directories that aren't already covered by existing blink_perf.* benchmarks.

This benchmark is added to tools/perf/contrib/ directory because it isn't meant
to be scheduled on the perf waterfall.

BUG=720772

Review-Url: https://codereview.chromium.org/2874653002
Cr-Commit-Position: refs/heads/master@{#471028}

This was part of an aborted refactor, which was abandoned due to memory coordinator work (which has deprecated the memory pressure subsystem).
When memory coordinator is finished all uses of memory pressure will be migrated to it.

BUG=
TBR=sdefresne@chromium.org, halliwell@chromium.org

Review-Url: https://codereview.chromium.org/2874553004
Cr-Commit-Position: refs/heads/master@{#471027}

BUG=

Review-Url: https://codereview.chromium.org/2877723003
Cr-Commit-Position: refs/heads/master@{#471026}

Nothing seems to reference this.

Review-Url: https://codereview.chromium.org/2877503003
Cr-Commit-Position: refs/heads/master@{#471025}

https://skia.googlesource.com/skia.git/+log/a9d9ab368318..eb7a693e0f6d

$ git log a9d9ab368..eb7a693e0 --date=short --no-merges --format='%ad %ae %s'
2017-05-11 msarett Move SK_API from namespace to function
2017-05-11 mtklein remove TODO in SkGradientShader.cpp
2017-05-11 bsalomon Workaround for Intel 6xxx clear to opaque black bug
2017-05-11 stephana Enable debug output on iOS
2017-05-11 jvanverth Fix transparent ambient shadows
2017-05-11 jvanverth Fix transparent ambient for perspective shadows
2017-05-11 msarett Add SkJpegEncoder and SkWebpEncoder to public API

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I940fc0e66a4ade56bedfa65aeb8d3d9ed16fbe86
Reviewed-on: https://chromium-review.googlesource.com/502612Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471024}

Add gn args and BUILDFLAGS for OfflinePages, instead on relying on is_android and is_official_build.
This will reliably remove the manual test harness code from the builds tested on waterfall.
Also it's in preparation for potential move of OfflinePages to other platforms (like ChromeOS).

BUG=NONE

Review-Url: https://codereview.chromium.org/2875853003
Cr-Commit-Position: refs/heads/master@{#471023}

Still causing crashes, so disable.

I have a fix in the works but it will take a bit more time so disabling in the meanwhile.

TBR=bmcquade
NOTRY=true

BUG=721369

Review-Url: https://codereview.chromium.org/2876693005
Cr-Commit-Position: refs/heads/master@{#471022}

The old Audit implementation is not used anywhere anymore except in
two tests that tested the old implmentation.  Remove these tests as
well.

BUG=704967
TEST=none

Review-Url: https://codereview.chromium.org/2872703004
Cr-Commit-Position: refs/heads/master@{#471021}

Changes:
On kevin, audio input source dropdown list displays both "Mic" and "Built-in mic". This is not expected.
For new devices, like kevin, internal-mic/mic and internal-speaker/headphone may not share the same device index, meanwhile, headphone and line-out may share the same device index. This cl is to fix this by creating virtual device name only when two audio nodes sharing the same device index.
Currently will cover three cases:
(1) Show "Built-in mic" when internal-mic and mic share dev_index, otherwise show "Mic" and "Internal mic" separately.
(2) Show "Built-in speaker" when internal-speaker and headphone share dev_index, otherwise show "Speaker" and "Headphone" separately.
(3) Show "Headphone/Line Out" when headphone and line-out share dev_index, otherwise show "Headphone" and "Line Out" separately.

TBR=dgreid@chromium.org
BUG=718220
TEST=tested on kevin and veyron_minnie, the label name works properly on https://webrtc.github.io/samples/src/content/devices/input-output/.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2869933002
Cr-Commit-Position: refs/heads/master@{#471020}

This CL refactors input paths to more closely align the content input and skia input paths.
We also now lock input to the scroll/click target.
This CL also adds a button with hover/down states.

TODO: Actually look at the passed in coordinates to see if the hover/down states should be applied.
Review-Url: https://codereview.chromium.org/2878543002
Cr-Commit-Position: refs/heads/master@{#471019}

BUG=721126

Review-Url: https://codereview.chromium.org/2876663002
Cr-Commit-Position: refs/heads/master@{#471018}

TBR=wylieb@chromium.org

Change-Id: I719a2978aa48618a79d256c82afff3139f95f249
Reviewed-on: https://chromium-review.googlesource.com/461273
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471017}

- Increased the mouse threshold to hide the toolbar
-The toolbar will now hide when the mouse is over 50px below it

- In FullscreenMenubarTracker, the toolbar layout and menubarFraction
 needs to be updated before the tracker attempt to animate the toolbar
 out.

BUG=692275

Review-Url: https://codereview.chromium.org/2875673004
Cr-Commit-Position: refs/heads/master@{#471016}

This CL enables the experiment by default.

BUG=684761

Review-Url: https://codereview.chromium.org/2873243004
Cr-Commit-Position: refs/heads/master@{#471015}

This mode is controlled via variations server. In this mode, cards a loaded, perhaps from some mock location, but the results are not shown (i.e. the view size is set to 0) to the user.

Bug=712331

Review-Url: https://codereview.chromium.org/2878503004
Cr-Commit-Position: refs/heads/master@{#471014}

The ID is generated in the downstream code based on the results
of the build configuration.

BUG=713952

Review-Url: https://codereview.chromium.org/2872453005
Cr-Commit-Position: refs/heads/master@{#471013}

This patch modifies how idle time spell checker decides checking range in
hot mode.

Before:
- If the total text length in the editable is at most 1024, check everything
- Otherwise, check a chunk of text of length 1024, expanded to sentence
  boundaries, centered at the reference position

After:
- If the total text length in the editable is at most 128, check everything
- Otherwise, if the reference position is in a paragraph of length at most
  1024, check the paragraph
- Otherwise, check a chunk of text of length 1024, expanded to sentence
  boundaries, centered at the reference position

BUG=517298

Review-Url: https://codereview.chromium.org/2867393003
Cr-Commit-Position: refs/heads/master@{#471012}

https://boringssl.googlesource.com/boringssl/+log/ddfcc6a60bec2040b4c3668d76c0f2455ecb5594..1e5cb820de99c754b57ab4321e1456ac6bdc1a78

BUG=none

Review-Url: https://codereview.chromium.org/2869243005
Cr-Commit-Position: refs/heads/master@{#471011}

Invert the command line guard flag, so that the apps on the login screen
are enabled by default now, but can be disabled using the
--disable-login-screen-apps flag. (The flag will be removed after some
time once this change is tested and verified.)

Also open up the corresponding policy DeviceLoginScreenAppInstallList,
with updating its supported range to M60+.

The policy description is extended to mention the security and privacy
constraints that are imposed on it.

BUG=576464

Review-Url: https://codereview.chromium.org/2801113002
Cr-Commit-Position: refs/heads/master@{#471010}

This indicates that "PageLoad" event conceptually only happens once per source.

BUG=

Review-Url: https://codereview.chromium.org/2870033002
Cr-Commit-Position: refs/heads/master@{#471009}

BUG=668549

Review-Url: https://codereview.chromium.org/2836333003
Cr-Commit-Position: refs/heads/master@{#471008}

BUG=711155

Review-Url: https://codereview.chromium.org/2870313002
Cr-Commit-Position: refs/heads/master@{#471007}

scrolling.

When wheel scroll latching is enabled, GSB occurs only once in the
beginning of a scroll sequence. So, it is possible to need to switch
to the main thread scroll handling in the middle of a scroll scroll
sequence (e.g. due to a change in main thread scrolling reasons).
To have a complete scroll sequence on main thread side and do the scroll
chain computation only while handling GSB, this cl sends a GSB to the main thread before sending the GSU that is not handled in the impl thread
side.

BUG=526463
TEST=AnimateInput/InputHandlerProxyTest.GestureScrollHandlingSwitchedToMainThread/*

Review-Url: https://codereview.chromium.org/2854683002
Cr-Commit-Position: refs/heads/master@{#471006}

* clean up and generalize PageLoadMetricsWaiter
* where possible, switch tests from calling NavigateToUntrackedUrl() to using PageLoadMetricsWaiter
* add support for monitoring both main and child frame updates
* fix broken DocumentWriteAsync test

BUG=720534

Review-Url: https://codereview.chromium.org/2868213003
Cr-Commit-Position: refs/heads/master@{#471005}

An interrupted download will automatically resume after network reconnection.
However, if the interruption is caused by switching active networks,
no reconnection event will happen.
For example, download may get interrupted if it is started on LTE and then OS decides to switch to WIFI.
In this case, we should immediately resume the download rather than waiting for reconnection.

BUG=707753

Review-Url: https://codereview.chromium.org/2864533004
Cr-Commit-Position: refs/heads/master@{#471004}

To unblock cq. See crbug for more details.

BUG=720511
TBR=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2874213003 .
Cr-Commit-Position: refs/heads/master@{#471003}

This is a mechanical change.

The component updater classes have dependencies on OutOfProcessPatcher.
Before this change, a client that needed to use the ComponentUnpacker
had to include component_patcher_operation.h.

With this change, the clients of ComponentUnpacker only need to include
component_unpacker.h

BUG=719751

Review-Url: https://codereview.chromium.org/2873513002
Cr-Commit-Position: refs/heads/master@{#471002}

BUG=717620
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2869303004
Cr-Commit-Position: refs/heads/master@{#471001}

Clean up expired verdicts when PasswordProtectionService is being destructed (typically, that's during browser shutdown).

BUG=719002

Review-Url: https://codereview.chromium.org/2870193002
Cr-Commit-Position: refs/heads/master@{#471000}

This directory is for creating a new blink_perf benchmark that allows users
to run arbitrary blink_perf test paths through Telemetry

BUG=chromium:720772

Review-Url: https://codereview.chromium.org/2875783002
Cr-Commit-Position: refs/heads/master@{#470999}

https://skia.googlesource.com/skia.git/+log/05fd8cf08970..a9d9ab368318

$ git log 05fd8cf08..a9d9ab368 --date=short --no-merges --format='%ad %ae %s'
2017-05-11 caryclark fix SkASSERT for Visual Studio
2017-05-10 mtklein Add a way to force raster pipeline blitter.
2017-05-11 egdaniel Add some swizzle checks to vulkan backend
2017-05-10 fmalita A8 fast path for raster clip masks
2017-05-10 recipe-roller Roll recipe dependencies (nontrivial).
2017-05-10 reed remove SK_SUPPORT_DEPRECATED_CLIPOPS from g3
2017-05-09 scroggo Remove comments referencing locked pixels
2017-05-10 mtklein Make SkCreateRasterPipelineBlitter() not fail.
2017-05-10 ethannicholas sksl support for static ifs & switches
2017-05-10 jvanverth Unify ShadowUtils interface
2017-05-10 mtklein use SkColorSpaceXformer in SkShader appendStages() fallback
2017-05-10 mtklein clean up SkShader friends
2017-05-10 reed add flag to hide deprecated clipops
2017-05-10 bungeman Fix alpha coverage for lerp_565 stage.
2017-05-09 stephana Experimental Go bindings for Skia

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: Idbb034ae7593dde5cd921a99ff22504addb8cfee
Reviewed-on: https://chromium-review.googlesource.com/502735Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#470998}

1. FrameView::SetTracksPaintInvalidations() may be called before
   FrameView::PrePaint(), so we need to create paint_controller_ if it
   is null, and check null paint_artifact_compositor_.

2. Previously when an old chunk is deleted, we still kept the tracked
   raster invalidations. When a new chunk was created at the same
   address, the new chunk inherited the old trackings.

BUG=644358
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
R=chrishtr@chromium.org

Review-Url: https://codereview.chromium.org/2874553002 .
Cr-Commit-Position: refs/heads/master@{#470997}

The sets of SurfaceIds will almost always be 0-3 elements and change
infrequently. Using flat_set should be faster and use less memory than
unordered_set.

Bug: none

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5576601ded162c741d758481e785fb7fba3c0205
Reviewed-on: https://chromium-review.googlesource.com/503188
Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#470996}