- 07 Aug, 2020 40 commits
-
-
Mugdha Lakhani authored
Bug: 1106948 Change-Id: I87b1f29822abe681ab75b703d36c3c7da70c25f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343346 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#795995}
-
Kevin Marshall authored
Promotes ScriptId to a template parameter, so that the script injector can be used for multiple purposes on a given platform. Specifically, it will allow the use of uint64 script IDs on FrameImpl, and base::StringPiece in bindings tests. Migrate OnLoadScriptInjectorHost implementation from .cc to .h. Bug: 1104369 Change-Id: Idfacd460d8d12038cfc2c00896e538ee87c55a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341837 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#795994}
-
Dan Harrington authored
histogram ContentSuggestions.Feed.VisitDuration Also fix 'open in new tab' so that it opens in the background instead of the foreground. Bug: 1044139, 1113773 Change-Id: Ib746afa1b94f47aa04c996e74a214cafa0d8abc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336816 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#795993}
-
Juliet Levesque authored
Reverse the order of logs appearing on the logging tab so newest logs appear on top, as well as change the color of verbose logging to gray, as seen here: https://screenshot.googleplex.com/rAtwCW4rJbN. Bug: 1093634 Change-Id: I88b3ed8abefec7d5512a261db41f6d464ef23947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336311Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/master@{#795992}
-
Dominique Fauteux-Chapleau authored
Corresponds to cl/322580232 Bug: 1106431 Change-Id: I68c3dc8318c051fa84a5285294f796ac92171303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317571Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#795991}
-
Julian Pastarmov authored
The code used to read the version string as provided by the uname command but the native host reads the string from the /etc/os-release file. This CL unifies the API implementation with the native host but preserves the uname approach as a fallback in case the file is not present or does not follow the expected format. BUG=1114196 TEST=unit_tests:EnterpriseReportingPrivateGetDeviceInfoTest.GetDeviceInfo Change-Id: Ie07314ef4cdbdbbbc8b1abf0784b8e54d454217a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339631Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#795990}
-
Liquan (Max) Gu authored
Change: * PaymentRequestImpl#getClient adds null check for ComponentPaymentRequest. Bug: 1114133 Change-Id: Id994b6a4d20d24f54a088a6b08b46cca330f538d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341219Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795989}
-
Sven Zheng authored
Update latest file on gcs. Bug: 1109287 Change-Id: Ibcd6540a5ebfd838e2f31bf4e71fb56b516d083e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342636Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#795988}
-
behdad authored
ReadyToActivateToActivationDuration2 metrics are covered by the EndCommitToActivation of the CompositorLatency metrics, so the methods used for reporting them is removed from compositor timing history. Bug: 1037244,1089454 Change-Id: I2e197bf34d777b051f60fa16059b13d642135762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341664Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#795987}
-
adamta authored
Adds new item in the Discover feed header top-level menu for 'Manage Activity', which leads to a web page. Also slightly refactors how menu items that lead to web pages are handled. Only shows this item and 'Manage Interests' if the user is authenticated. Bug: 1085419 Change-Id: I66be67659ccbc04121f0eb02657a7e20cfe66e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341805 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#795986}
-
Andy Lu authored
With Xcode 12.3 beta and iOS14, there was an issue with Open URLs in Chrome In Incognito Siri shortcut during cold start. For example, open a few NTP tabs in Incognito and then kill the application. Then when triggering the shortcut, the URLs are not loaded. It seems like the order of the restoration functions during cold start changed, so that what worked before no longer works. To solve this issue, a function similar to how Open URL in Chrome is handled in ContinueUserActivity is written and is modified to handle multiple URLs. This way, the tabs are opened directly after ContinueUserActivity is invoked and no longer depend on the restoration functions during cold start. Bug:1113529 Change-Id: Ie6a8c91cad307bb5e510d300695a4490116a7491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336185Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#795985}
-
Julian Pastarmov authored
The secure connect API for Mac OS is not trying to clear a potentially existing but corrupted secret before recreating it. BUG=none Change-Id: I80ecb09aba0b633df093a305f76b457740db77d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339532Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#795984}
-
Rohit Rao authored
A new method was added but never called in ASAN builds, causing an unused function warning. BUG=None Change-Id: Ibca08fb8ab291790fcb58f617844bc6a0730c8fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341807Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#795983}
-
Justin Cohen authored
XCUIElement queries used in ARQuickLook are broken on Xcode 12 beta 4 when running on the iOS 12 simulator. Disable until Xcode is fixed. Bug: 1114202 Change-Id: Ib16458ee93e6821b5520cbd791e3ba8e6beccfe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341220 Auto-Submit: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#795982}
-
Muyao Xu authored
This CL adds a mojo::Remote<mojom::Logger> in CastAppDiscoveryService to log unavailable (app_id, sink_id) pairs and socket not found errors. Bug: 687380, b/154273698 Change-Id: Ib50c74cd9a0e66c9c05b3f36fdf653e2565d8048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332329Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/master@{#795981}
-
Rohit Rao authored
M84 is crashing because OmahaService::Stop() is somehow called before the OmahaService singleton is created. This causes Stop() to try and create a new service object during shutdown, which crashes. This CL sidesteps the crash by making it safe to create a new OmahaService object, even at shutdown. The unsafe portions of the constructor were already in StartInternal(), which now needs to be explicitly invoked by OmahaService::Start(). BUG=1105799 Change-Id: Idd9531ab0ac79e4520deaa2145e9d3efc20bb01d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339719Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#795980}
-
Ben Kelly authored
Past metrics show that the main cause of failure for base::CreateDirectory in IndexedDB is the device being out of space. This CL plumbs the error code through so we can properly report this as a QuotaExceeded exception. An alternative would be to retry the operation, but if the disk is truly full then its likely any further operations will run into disk exhaustion anyway. For now lets just report the problem as accurately as we can. Bug: 1113829 Change-Id: Idc66d2f43b474e1a97229e0057031ba12c96d677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343305Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#795979}
-
Alex Newcomer authored
The histogram is Clipboard.Read/Write, not Clipboard.Format.Read/Write. Bug: 1113963 Change-Id: Ica50afa9a751e32e5510f02899d79bb61f30c182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340881 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795978}
-
Yunke Zhou authored
Allow browse as guest button to be shown in user creation screen in oobe. Hide browse as guest button in user creation screen during add person flow. Bug: 1101318 Change-Id: I235cbf486f11f3b0275adec3f44cdb9c31adb945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341640 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795977}
-
Robert Sesek authored
This is a new file on macOS 11 Big Sur. Bug: 1113952 Change-Id: I8280ef793f6da3fe6e85ba9d23a7d5e8188f2371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342573Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#795976}
-
Andrew Grieve authored
Hoping that this will aid in debugging out of memory failures. Bug: 1113246 Change-Id: Ibf2baf859598a2af2d08d911c82d3c65f2249d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328190 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#795975}
-
Thomas Lukaszewicz authored
The dependent CL adds an entrypoint for Tab Search in the tab strip. As a result the current toolbar button entrypoint is no longer necessary. Bug: 1099917 Change-Id: I68a0fdbb4bf1bbc08e65f048c132593fa5229d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341942Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#795974}
-
Lambros Lambrou authored
This CL prevents WebRTC clients from changing the VP9 lossless-color property via a VideoControl message. This is because WebRTC handles that setting via the SDP codec parameter "profile-id=1", which means an SDP offer/answer exchange is needed to properly control this setting. Non-WebRTC clients are not affected and they can still toggle lossless-color via a VideoControl message. This CL also adds logging to the VP9 encoder so we can verify what settings are being applied at the codec level. This also fixes a bug where the SDP parameter for lossless-color was not being respected. Bug: 1113499 Change-Id: I15ca83b0fcc157a3b63d3a3ca3509039ed47b24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342126 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#795973}
-
Roman Sorokin authored
Bug: none Change-Id: Ie5f17bbbbbfed17fc0dc97d98ee0f4c0d41ccd30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343037 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795972}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/69a10924bc97..fb4355fa6266 2020-08-07 bingler@chromium.org Add Schemeful Same-Site exclusion messages to front end 2020-08-07 patrick.brosset@microsoft.com Grid: Fix line name label positioning regression If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1054036,chromium:1100385 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1e5a5b5cfc9a32c406a88be79291b6d6cfcc255d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343061Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795971}
-
Alex Chau authored
- NearbyConnection is owned by NearbyConnectionsManager, and is destroyed when it's disconnected by either end from various methods - NearbyConnection offers a disconnection listener to listen for destruction - NearbyServiceManagerImpl expects to overwrite NearbyConnection's disconnection listener time to time, but NearbyConnectionImpl currently allows multiple listeners, causing NearbyServiceManagerImpl's disconnection handler to be called multiple times - Changed NearbyConnectionImpl's disconnection listener back to a single member that can be overwritten - Made IncomingFramesReader owned by IncomingShareTargetInfo so it'll be cleaned up in UnregisterShareTarget Bug: 1076008 Change-Id: I16effec3526e0e55a958a96bc3893f5d619e5a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339982Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#795970}
-
Thomas Lukaszewicz authored
This change adds an experimental entry-point for the tab search feature in the tab strip. Currently this tab search button instance has been implemented as another instance of the NewTabButton class, positioned directly next to the existing new tab button. The addition of this feature is gated by both the ENABLE_TAB_SEARCH build flag and the kTabSearch UI feature flag. Outside of changes gated by the build and feature flags, this CL wraps the existing new tab button in a |new_tab_button_wrapper_|. This wrapper allows the addition of the tab search button without introducing significant changes to existing logic that deals with the new tab button (ie animation, hit testing, padding etc). This wrapper is not expected to change the current behavior of the new tab button. There is follow up work to fix issues such as visual style and creating a base class inherited by both the actual new tab button and tab search button. Bug: 1099917 Change-Id: I63cd0804603a8d25efd4416e4f3ea4307ff6535c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333341 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#795969}
-
James Cook authored
I anticipate needing it for notifications for lacros. See go/lacros and go/lacros-notifications. Also, clean up BUILD.gn slightly -- enable_native_notifications is always true on Chrome OS. Bug: 1113889 Change-Id: I6c3bc7f81f81157568f8c1b2969f98a82a037b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339450 Commit-Queue: Jun Mukai <mukai@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#795968}
-
Ken MacKay authored
If the mixer didn't have rendering delay available when the start threshold was exceeded, the "ready to play" signal would never be sent. Fix by ignoring rendering delay status. Bug: internal b/158038278 Change-Id: I196be77210ea879ae673b704499f1c683ade8dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342305Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#795967}
-
Maxim Kolosovskiy authored
This CL changes the API of PasswordScriptsFetcher to fit the current design of Password Check on Android. Bug: 1086114, 1092444 Change-Id: I4f617ec239fea9ef778874c94a2cdb442c242eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343080 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#795966}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/889f00501aaa..fb57bbd19358 2020-08-07 vapier@chromium.org licensing: trim no-source-code exception 2020-08-07 vapier@chromium.org gerrit: deps: hack up --raw output to avoid confusion 2020-08-06 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-06 denik@google.com chromite: Create chromiumos-sdk-next builder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I11ca80d5a8ebc8efaa1992141d96071c9042b864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343058Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795965}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5184219b6ff4..f7721fb24619 2020-08-07 jonaso@webrtc.org Add interface for os/firmware to affect ICE selection. 2020-08-07 razvans@google.com Added field trials to disable video resizing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9086641eb876fc06bb6bd82b20454d9a7b9aa048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343056Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795964}
-
James Long authored
Two presets have been added, based off some combinations of settings found to be useful. More granular customization has been moved to an expandable "advanced settings" panel. Bug: 1112940 Change-Id: I3aae3635642a8cc74526ec4e1e8c0b6bfc898cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337413Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: James Long <yjlong@google.com> Cr-Commit-Position: refs/heads/master@{#795963}
-
Eleonora Rocchi authored
PasswordCheckBridge. This CL adds an empty method to the bridge to retrieve the timestamp of the last completed password check. It also adds the logic to call this method from PasswordCheckMediator. Bug: 1109691, 1092444 Change-Id: Ibaa0993e11271b4ae0ee8287a86a51e7023f3bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343268 Commit-Queue: Eleonora Rocchi <erocchi@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#795962}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/56f14dabfe99..0c0349252934 2020-08-07 aninditaghosh@google.com Handle multiple batches when converting to pandas. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2f6fe332f0e668c261279f07f8acc805f4420dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343057Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795961}
-
Antonio Gomes authored
Drive by. Include isn't needed anymore. R=thestig@chromium.org Bug: 578890 Change-Id: I10763400301d6058a66bd280f01d4a2df059c6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342571 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#795960}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ife83c4878a62a1ceb78513b65b40f3742e48db14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343062Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795959}
-
Ioana Pandele authored
Bug: 1114136 Change-Id: Ie3f43b835d89908ef35541df879e17e14974ce87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343106 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#795958}
-
Vasilii Sukhanov authored
Android. Tbr: aboxhall@chromium.org Bug: 1114193 Change-Id: I657de46a8dc7c240cf97a4ac1fb39f6a1807d637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339973Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#795957}
-
Kevin Ellis authored
The updated tests run a fair number of interpolations and push the boundary of what should be characterized as a long test. Flakes are typically clustered and the result of variability in speed of the testing infrastructure and not indicative of true changes in performance. Bug: 1093451, 1092177, 1092141 Change-Id: Ia438ae758470e3e7eb695e59e1698734e6526c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341804Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#795956}
-