- 22 Oct, 2018 40 commits
-
-
Daniel Bratell authored
pepper/fullscreen_container.h sometimes appeared twice in the sources list. This confused some other tools so it seems like a good idea to only have it there once. Change-Id: I02d88c68c6581eadb171ca5a5d72f75281c52717 Reviewed-on: https://chromium-review.googlesource.com/c/1293455Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#601550}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b4db19b7ab88..a20a50c6f2c7 git log b4db19b7ab88..a20a50c6f2c7 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 treehugger-gerrit@google.com Merge "Add d8 binaries" Created with: gclient setdep -r src/third_party/perfetto@a20a50c6f2c7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7e8ac329b5248cf8facde6e8dc8e144930dc48f4 Reviewed-on: https://chromium-review.googlesource.com/c/1293470Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601549}
-
Nico Weber authored
Looks like this snuck in while the static initialization scripts got moved around and we didn't notice the regression. Bug: 94925 Change-Id: I35b597cc4cd6b4607306ab242f8594f3eba3d0c0 Reviewed-on: https://chromium-review.googlesource.com/c/1293550Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601548}
-
Christian Biesinger authored
The functions are all trivial R=mstensho@chromium.org Change-Id: Ica0db0344ff13d03a363d7f58e19389fa1ea08d5 Reviewed-on: https://chromium-review.googlesource.com/c/1292888 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#601547}
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I4e5a2b7b4f43653867afb3509c08b09e6b04306b Reviewed-on: https://chromium-review.googlesource.com/c/1293105Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#601546}
-
Michael Lippautz authored
Bug: 843903 Change-Id: I95a0caae7f528be908caff24515971b29b4f645f Reviewed-on: https://chromium-review.googlesource.com/c/1292564Reviewed-by:
-
Michael Lippautz authored
Some tests rely on properly collecting objects on tear down. E.g. mock objects are expected to die after a test finishes. Bug: 843903 Change-Id: Ica1daee98be3625e4f2202fe0a73b290b5130ce9 Reviewed-on: https://chromium-review.googlesource.com/c/1293489Reviewed-by:
-
Christian Biesinger authored
Second part of crrev.com/c/1293449, as requested in crrev.com/c/1289720 R=mstensho@chromium.org Change-Id: I2535614b236ec4fef12b80c395431bc4d281e22a Reviewed-on: https://chromium-review.googlesource.com/c/1293454Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/23153d4a809c..d7fce6c098ea git log 23153d4a809c..d7fce6c098ea --date=short --no-merges --format='%ad %ae %s' 2018-10-22 perezju@chromium.org [pinpoint_cli] Allow multiple jobs per configuration Created with: gclient setdep -r src/third_party/catapult@d7fce6c098ea The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:894773 TBR=sullivan@chromium.org Change-Id: Ic1724665b00c2fc45d7988bd3aadf6aa92d47b2c Reviewed-on: https://chromium-review.googlesource.com/c/1293248Reviewed-by:
-
Rayan Kanso authored
Calling `match` was causing crashes in debug mode due to accessing base::Optional<>::value without initialization. Calling match with an unmatched request was crashing due to hitting a DCHECK. This returns undefined now as per the spec. Bug: 896768 Change-Id: I5d82e68ddca157a240ceaaec8990d2553366fbbb Reviewed-on: https://chromium-review.googlesource.com/c/1289269 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#601541}
-
Christian Biesinger authored
This was made possible by crrev.com/c/1283482, which avoids the performance and correctness issues this previously caused. This relands crrev.com/c/1246730 / crrev.com/c/1252682. The ChromeOS UI breakage was fixed by crrev.com/c/1281726 and crrev.com/c/1282462 IF THIS BREAKS ANY FURTHER CHROME UI: Please don't revert this patch; instead, add min-height: 0 to any inner nested flexboxes that may be affected by this patch. This is an important change for web interop with the other browsers. Bug: 596743 Change-Id: I9afe54dce82d41da452d1fdca8150ca22ebb6f9c Reviewed-on: https://chromium-review.googlesource.com/c/1269235 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff08d94ee125..5762a656ef75 Created with: gclient setdep -r src-internal@5762a656ef75 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If2348390983f886f9dc894160a1a03e9ffe6d97a Reviewed-on: https://chromium-review.googlesource.com/c/1293246Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601539}
-
Findit authored
This reverts commit 10f4b936. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 601492 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzEwZjRiOTM2MzVlMTJmOWZhMGNiYTE2NDFhMTA5MzhjYTM4ZWQ0NDgM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/9190 Sample Failed Step: capture_unittests Original change's description: > Enable camera blob stream when needed > > Since blob stream needs higher resolution, it causes higher cpu loading > to require higher resolution and resize to smaller resolution. > In hangout app, we don't need blob stream. Enabling blob stream when > needed can save a lot of cpu usage. > > BUG=b:114676133 > TEST=manually test in apprtc and CCA. make sure picture taking still > works in CCA. > > Change-Id: I9144461bc76627903d0b3b359ce9cf962ff3628c > Reviewed-on: https://chromium-review.googlesource.com/c/1261242 > Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> > Reviewed-by: Ricky Liang <jcliang@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601492} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=b:114676133 Change-Id: If173ffe9259f7eca849b184806bd56e2a9fbaac4 Reviewed-on: https://chromium-review.googlesource.com/c/1292256 Cr-Commit-Position: refs/heads/master@{#601538}
-
Jérôme Lebel authored
"Google activity controls", "Encryption", and "Manage synced data..." is enabled when the user is authenticated and disabled otherwise. Screenshot shared with Chromium accounts: + Signed out: https://drive.google.com/open?id=19lXF2SdgpLdHUlTZ4WpxipDBdQNCshbU + Signed in with consent accepted: https://drive.google.com/open?id=1SV3HhbG3hAbre5mSe06Dhjda4dJC4cck + Signed in with consent not accepted: https://drive.google.com/open?id=1r5umMw6vf8yzh8X7V8V6LzRJVJLq8Rxs Bug: 883101 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3e2180c83f42adccb2717f2fdb96efa254751bbc Reviewed-on: https://chromium-review.googlesource.com/c/1290937 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#601537}
-
Sami Kyostila authored
Now that site isolation is enabled on desktop platforms, we can safely increase timer resolution back to the previous 5µs value. Clock edge jittering is still enabled however. Bug: 798795, 422000 Change-Id: I23f29a40a8615354674f33bae7339d348773dd00 Reviewed-on: https://chromium-review.googlesource.com/c/1290916Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c67f445aea5f..b4db19b7ab88 git log c67f445aea5f..b4db19b7ab88 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 hjd@google.com Merge "trace_processor: Add smoke tests for json importer" Created with: gclient setdep -r src/third_party/perfetto@b4db19b7ab88 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I684aebd9a75d5e3feeb8dde2e8ce77677e93f386 Reviewed-on: https://chromium-review.googlesource.com/c/1293245Reviewed-by:
-
Anders Hartvoll Ruud authored
This CL adds new runtime flags which makes it possible to ship without support for <image>, <transform-function> and <transform-list>. Also replace comment near CSSPaintAPIArguments with 'depends_on'. (Added before I knew 'depends_on' existed). R=chrishtr@chromium.org Bug: 641877 Change-Id: Ic50bdaffc84a7037c23841c9eb53eb9b331ad680 Reviewed-on: https://chromium-review.googlesource.com/c/1273061Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#601534}
-
Camillo Bruni authored
Bug: 813165 Change-Id: I30bfe1aed9cac58e8c413e39c4d4082cb61bfff3 Reviewed-on: https://chromium-review.googlesource.com/c/1292882Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#601533}
-
Christian Biesinger authored
To match the naming of the fragment classes. Split out from crrev.com/c/1292429; as requested in crrev.com/c/1289720 R=mstensho@chromium.org Change-Id: I25a38e6b78f1677661203f62685c604f9d971f01 Reviewed-on: https://chromium-review.googlesource.com/c/1293449Reviewed-by:
-
Michael van Ouwerkerk authored
Revert "Reland (with fix) "Automatically pick a target directory which exists for run_web_tests.py script"" This reverts commit 0d994d59. Reason for revert: bot failure crbug.com/897673 TEST RESULTS WERE INVALID - webkit_layout_tests failing on chromium.android/KitKat Phone Tester (dbg) Original change's description: > Reland (with fix) "Automatically pick a target directory which exists for run_web_tests.py script" > > This is a reland of 5f74e543. > > The original reland is in patch set 1, fixes are in subsequent patchset. > > The fix implements: > If --release or --debug is specified and there are both more than one target dirs, > it would try to choose the dir that match the configuration on args.gn > > Original change's description: > >Automatically pick a target directory which exists for run_web_tests.py script > > > > This also updates how we compute the default for 'configuration'. First, we try to look for the > > configuration definition (args.gn) & use that value. If that doesn't succeed, we guess the > > value of configuration using the target value. > > > > Reviewers: the main change is in third_party/blink/tools/blinkpy/web_tests/port/base.py, the rest are followed by. > > > > > > Bug: 893618 > > Change-Id: I578c977bcaccd6294596f8cf7079748809698db6 > > Reviewed-on: https://chromium-review.googlesource.com/c/1281043 > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Reviewed-by: Robert Ma <robertma@chromium.org> > > Commit-Queue: Ned Nguyen <nednguyen@google.com> > > Cr-Commit-Position: refs/heads/master@{#600760} > > Bug: 893618 > Change-Id: I386b8261fc4abddd51a5b4f290c5eb3ac6ce5361 > Reviewed-on: https://chromium-review.googlesource.com/c/1289308 > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601271} TBR=dpranke@chromium.org,nednguyen@google.com,robertma@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 893618,897673 Change-Id: Ib095b320122267c9e1d352d6c5b3e0fc358ce4c7 Reviewed-on: https://chromium-review.googlesource.com/c/1293453Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601531}
-
Ramin Halavati authored
When more than one incognito windows are open, adds the number of open incognito windows to the incognito icon on the toolbar. The change is behind kEnableIncognitoWindowCounter flag and is off by default. Bug: 896235 Change-Id: I52c08700bd0ff75f355104738b7e49f9f8076a15 Reviewed-on: https://chromium-review.googlesource.com/c/1290938 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#601530}
-
Valeriya Sinevich authored
Set refresh tokens in error on Desktop, remove cached access tokens on mobile. Bug: 872724 Change-Id: I4267bfb2e70219b9f8f9adfa604dc6f6a01333f7 Reviewed-on: https://chromium-review.googlesource.com/c/1273136 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#601529}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/648d28ad6257..9acf1c1f5497 git log 648d28ad6257..9acf1c1f5497 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 mbonadei@webrtc.org Reland "Make sure Chromium will pick the correct field_trial/metric impl." Created with: gclient setdep -r src/third_party/webrtc@9acf1c1f5497 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia7431474c7f21794d22016a6696c68058c966b66 Reviewed-on: https://chromium-review.googlesource.com/c/1293243Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b248a7f6..78128866 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifacd4fc738b753a43e08bf3371278db38b678197 Reviewed-on: https://chromium-review.googlesource.com/c/1292251Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601527}
-
yoshiki iguchi authored
This CL updates the logic of handling click events and passes all the events to Chrome side at first. The chrome side may defer or cancel the user action and pass back the action to Android side. This CL also contains the mojo changes which is related with the lock screen notification and not directy related with defering. ARC-side: ag/4764629 Chromium-side: crrev.com/c/1174143 Bug: b/79951342 Test: Manual Change-Id: I42f9953029867d8e46124ba087a4f84a49fae99d Reviewed-on: https://chromium-review.googlesource.com/c/1174143 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#601526}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b20529ac11a6..23153d4a809c git log b20529ac11a6..23153d4a809c --date=short --no-merges --format='%ad %ae %s' 2018-10-22 perezju@chromium.org [pinpoint_cli] Fix get-csv for windows platforms Created with: gclient setdep -r src/third_party/catapult@23153d4a809c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I3a0aabff11d0730d81723a7394ff83d6722d8ae5 Reviewed-on: https://chromium-review.googlesource.com/c/1293244Reviewed-by:
-
Mythri Alle authored
Add support that lets embedder specify if code caching is enabled and if enabled the disk size that can be used by the cache. By default code caching is disabled. This cl also adds implementation for chrome that enables code caching. Bug: chromium:867552 Change-Id: I6edb4c0c4f3830d44731225ec91c5e95005be9da Reviewed-on: https://chromium-review.googlesource.com/c/1213093 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#601524}
-
Hans Wennborg authored
After compiler-rt r344751, CMAKE_CXX_FLAGS doesn't get passed to all objects. TBR=thakis Bug: 897627 Change-Id: Iea0eda192c6da8d6d662732e7ad456e0ba3c0b46 Reviewed-on: https://chromium-review.googlesource.com/c/1292883Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#601523}
-
Benoit Lize authored
A ParkableString underlying String may be atomic. In this case, as long as it it alive, there is a raw pointer reference to it in a per-thread table. This can lead to a use-after-poison as the string gets poisoned whereas it is still in the table. This is due to not freeing string_ in ParkableStringImpl. To fix that, don't poison AtomicStrings (which are not the majority of ParkableString). This is a false positive as when real parking happens the underlying string would be freed, hence removed from the AtomicStringTable. Bug: 883344,877044 Change-Id: I685260eafe31da4cafed150b74870a08aa61ed40 Reviewed-on: https://chromium-review.googlesource.com/c/1228057Reviewed-by:
-
Yuta Kitamura authored
This CL melds WebThreadBase's implementation into Thread, and removes WebThreadBase. Now WebThreadImpl* classes directly inherit from Thread. This is part of WebThread refactoring effort. The new implementation uses WTF::HashMap instead of std::map to store the mapping of TaskObservers. TaskObserverAdapters are stored in std::unique_ptr, so we don't need manual new/delete calls. Eventually, we will migrate to base::MessageLoop::TaskObserver instead of Blink's custom TaskObserver, which would eliminate this mapping object. Thread::IsCurrentThread() is now implemented in terms of its thread- local storage for Blink threads, just because we already have that knowledge ourselves. Also, {Add,Remove}Task{,Time}Observer() are simplified. Now the internal versions of those functions are removed, and TaskObserver functions are now non-virtual. Bug: 826203 Change-Id: I5aa56c152543af8f0e0270db86aa0f51d619b4d5 Reviewed-on: https://chromium-review.googlesource.com/c/1283015 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 894796 Change-Id: I368723376887cf830655cc20879c520a8ca9fdc8 Reviewed-on: https://chromium-review.googlesource.com/c/1292884Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601520}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ia80de6b1a257e88fb0cc4805a97e32bf8a9c096f Reviewed-on: https://chromium-review.googlesource.com/c/1293329 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#601519}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/20a8c2a7ccc6..ff08d94ee125 Created with: gclient setdep -r src-internal@ff08d94ee125 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ide3b2c8cd6b9f7e28bc94c3c5a2b46e7f443500c Reviewed-on: https://chromium-review.googlesource.com/c/1293241Reviewed-by:
-
Yves Gerey authored
We were relying on brittle transitive #include. Bug: webrtc:8311 Change-Id: I1749d9159c4fbff6658f19fefa84f46b0acabf5c Reviewed-on: https://chromium-review.googlesource.com/c/1290935 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#601517}
-
Mario Sanchez Prada authored
This will remove a dependency from OAuth2TokenService::Consumer, that will pave the way for further migrations to the IdentityManager. Bug: 809440 Change-Id: I81d77da696078cdc48eee63c466a815fd68062c5 Reviewed-on: https://chromium-review.googlesource.com/c/1288535Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#601516}
-
Nikita Podguzov authored
This is a reland of 43116fdd Original change's description: > Disable editing managed network config fields. > > * Disable network configuration field if the field is enforced by policy. > * Add policy network indicator if the field is controlled by policy. > > Bug: 877424 > Change-Id: Icfdb6d7fb3deb09696b6d2edce27d3c9851043a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1251447 > Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600735} Bug: 877424 Change-Id: I48473017b8656504de789f2cad9d0fabd89fcec7 Reviewed-on: https://chromium-review.googlesource.com/c/1290914Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#601515}
-
Florian Uunk authored
We have this check in ModelAssociationManager::Stop, so it makes sense to add it to ModelAssociationManager::StopDatatype too. Bug: 894852 Change-Id: If5f472ea74cba7bbe60f796b1255c8e54d65a069 Reviewed-on: https://chromium-review.googlesource.com/c/1290149 Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#601514}
-
Peter E Conn authored
Bug: 888945 Change-Id: I2c2c803bbd51014cc70933fde8cef45e14ddb28b Reviewed-on: https://chromium-review.googlesource.com/c/1290915 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b026043a43f9..b20529ac11a6 git log b026043a43f9..b20529ac11a6 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 perezju@chromium.org [soundwave] Fix encoding when building RequestError message 2018-10-22 perezju@chromium.org [pinpoint_cli] Fix bug when iterating over output isolates Created with: gclient setdep -r src/third_party/catapult@b20529ac11a6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:897178,chromium:897052 TBR=sullivan@chromium.org Change-Id: I5ca0605b6d78dc87a31ef59c2d0257bf9bffe390 Reviewed-on: https://chromium-review.googlesource.com/c/1293242Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I63e4fd34b8bde448da84a6b2f578dc00a69cf33a Reviewed-on: https://chromium-review.googlesource.com/c/1293067Reviewed-by:
-
