- 14 Nov, 2011 40 commits
-
-
sadrul@chromium.org authored
The ownership of NWView/NWViews should not be affected by whether there is a parent widget or not. So use the default ownership. BUG=104152 TEST=manually Review URL: http://codereview.chromium.org/8564021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109969 0039d316-1c4b-4281-b951-d872f2087c98
-
jamiewalch@google.com authored
BUG=None TEST=Manual Review URL: http://codereview.chromium.org/8511077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109968 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
Remove a DCHECK on stopping_ from StartRequestHelper. Since StartRequestHelper is now called on a background thread, it does not make sense to DCHECK on a piece of state set on the main thread; stopping_ may well be set by the time the StartRequestHelper task is run. On teardown, we do block until pending background requests are handled, so it looks safe to remove the DCHECK. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/8564026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109967 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
. Avoid trying to layout the desktop when its size is set to 0x0 when minimized on Windows. . Don't show the "Default Browser" UI in Aura either. . Don't flash the active window inactive briefly when clicking on launcher items. BUG=none TEST=none Review URL: http://codereview.chromium.org/8565015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109966 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
Completes the GetWindowRect/GetRootWindowRect/GetScreenInfo changes I thought I had finished with my last CL. . Disable a check in BrowserMessageFilter that these messages are not handled on the UI thread, for Aura. In Aura, these messages need to be handled on the UI thread (since aura::Windows are not threadsafe). We do not have the NPAPI plugin constraints regular windows has, so this check is not important. . Properly handle these messages in RWH, by sprinkling in some more defined(USE_AURA) to go with the defined(OS_POSIX). . Properly define RenderWidgetHostView::GetDefaultScreenInfo() (it was being done as an override to a static?.. oops). . Get rid of the USE_AURA NOTIMPLEMENTED() definition of the above in render_widget_host_view.cc, replacing with an impl in rwhva.cc. Also moves the _mac and _touch variants to their own .mm/.cc files. . Gets rid of WillWmDestroy for Aura. It's normal-windows-only. BUG=none TEST=none Review URL: http://codereview.chromium.org/8566011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109965 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
[I've removed the code, via a separate CL, that DCHECK() earlier today] This will automatically catch thread names in several of the child processes we are after, and it also catches the name for a webkcore thread. r=rtenneti Review URL: http://codereview.chromium.org/8558003 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/8564014 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/8565030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109962 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/8538001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109961 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
WM_DEVICECHANGE is sent when there's been a change to devices or the computer; specifically when a USB device is connected or disconnected. This is intended for use in support of Gamepads for more performant polling and connect/disconnect testing. Currently only on Windows, though seems reasonable to add for other platforms in the future. BUG=79050 Review URL: http://codereview.chromium.org/8523021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109960 0039d316-1c4b-4281-b951-d872f2087c98
-
robert.nagy@gmail.com authored
BUG= TEST= Review URL: http://codereview.chromium.org/8560001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109959 0039d316-1c4b-4281-b951-d872f2087c98
-
noelallen@google.com authored
Clean up pychecker warnings. Move common code from idl_c_header (header generator) to idl_c_proto, the 'C' code style prototyping helper. BUG= http://code.google.com/p/chromium/issues/detail?id=91607 TEST= cd src/ppapi/generators && ./generator.py Review URL: http://codereview.chromium.org/8538029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109958 0039d316-1c4b-4281-b951-d872f2087c98
-
kerz@chromium.org authored
http://build.chromium.org/f/chromium/perf/mac-release-10.6/dom_perf/report.html?history=150&rev=109945 Rebaseline to expand the range a bit. BUG=NONE TBR=cmp@chromium.org Review URL: http://codereview.chromium.org/8533020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109955 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
This should allow ATL to work in all build configurations by dynamically creating a CComModule only if needed. BUG=102736 TEST=None Review URL: http://codereview.chromium.org/8467002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109953 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
Fix potential app list crash similar to NTP crash bug http://crbug.com/104059. BUG=none. TEST=After drag-n-drop is supported in aura, drag an app in app list window should not crash. Review URL: http://codereview.chromium.org/8555015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109952 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/8491036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109951 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
Also fix a typo in a DEPS comment. BUG=none TEST=ran "git status" TBR=zmo Review URL: http://codereview.chromium.org/8528039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109950 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109949 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
BUG=99901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109948 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
The master lock is very rarely used, so we can afford to use a lazy instance of this lock. r=rtenneti BUG=104167 Review URL: http://codereview.chromium.org/8567007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109947 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitbm@chromium.org authored
Review URL: http://codereview.chromium.org/8565020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109945 0039d316-1c4b-4281-b951-d872f2087c98
-
altimofeev@chromium.org authored
BUG=chromium-os:22862 TEST=manual Review URL: http://codereview.chromium.org/8564008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109944 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@google.com authored
Review URL: http://codereview.chromium.org/8510036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109943 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
BUG=None TEST=Resize window showing accelerated content, observe no stretching while resizing. Review URL: http://codereview.chromium.org/8536005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109942 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
BUG=chromium-os:16556 TEST=chrome builds. Review URL: http://codereview.chromium.org/8555014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109941 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109940 0039d316-1c4b-4281-b951-d872f2087c98
-
hans@chromium.org authored
BUG=none Review URL: http://codereview.chromium.org/8564013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109939 0039d316-1c4b-4281-b951-d872f2087c98
-
dbeam@chromium.org authored
R=csilv@chromium.org BUG=104059 TEST=Re-order apps, Chrome doesn't crash when a CHECK() fails. Review URL: http://codereview.chromium.org/8533014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109938 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=103688 TEST=manual Review URL: http://codereview.chromium.org/8549001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109937 0039d316-1c4b-4281-b951-d872f2087c98
-
jennb@chromium.org authored
BUG=102733 TEST=PanelBrowserViewTest.MinimizeAndRestoreOn*TaskBar Review URL: http://codereview.chromium.org/8538032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109936 0039d316-1c4b-4281-b951-d872f2087c98
-
scheib@chromium.org authored
BUG=102032 TEST=Enter Full screen, tab full screen, and mouse lock; verify that displayed exit text is a link and not plain text. Manual test in ppapi/examples/mouse_lock Review URL: http://codereview.chromium.org/8427022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109935 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
raising the z-index on focus makes the outline have 4 sides instead of just 3 BUG=none TEST=manual Review URL: http://codereview.chromium.org/8537034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109934 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
BUG=54005 TEST=build and run the examples on Mac (try both debug and release build) Review URL: http://codereview.chromium.org/8551001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109933 0039d316-1c4b-4281-b951-d872f2087c98
-
msb@chromium.org authored
Fixes the use_wayland build which was broken by this commit: http://codereview.chromium.org/8113028 Similar to win, we create a wayland namespace inside base and define WaylandEvent there. Historical note: Wayland does not have a "native" event structure. Instead, the client is made aware of events via a callback executed in the context of display_run(): http://git.chromium.org/gitweb/?p=chromiumos/third_party/wayland-demos.git;a=blob;f=clients/window.c So we create WaylandEvent structure which takes the parameters from the callback and wraps them into a structure. For details, see: src/ui/wayland/events/wayland_event.h BUG=chromium:102903 TEST=Compiles but doesn't yet link with this change plus a series of others I'm working on. R=msw@chromium.org,oshima@chromium.org,mark@chromium.org Review URL: http://codereview.chromium.org/8378005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109932 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
The os_bsd variable is only available on FreeBSD and OpenBSD. Later on others like NetBSD and DragonflyBSD can be added. This variable was introduced in order to have shorter conditions in the gyp files. BUG= TEST=compile Patch by Robert Nagy <robert.nagy@gmail.com> Review URL: http://codereview.chromium.org/8567001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109929 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
Reparenting the bookmark bar on each tab change whether it needs it or not costs about 15ms. This usually is enough savings to get one more frame out of the new tab animation early on. Also, it's the Browser object's responsibility to update our toolbar; remove a duplicate call that already happened before the BrowserWindowGtk::ActiveTabChanged() Observer method was called. BUG=83106 TEST=Everything works about the bookmarks bar when changing tabs Review URL: http://codereview.chromium.org/8537022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109928 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109927 0039d316-1c4b-4281-b951-d872f2087c98
-
epoger@chromium.org authored
Control group (whitespace trybots) is http://codereview.chromium.org/8533009 Review URL: http://codereview.chromium.org/8565010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109926 0039d316-1c4b-4281-b951-d872f2087c98
-
kerz@chromium.org authored
linux-release-lowmem's machine was replaced, and some baseline ranges were too tight to pick up the usual deviations. page_cycler_database PERF_IMPROVE: delete-transactions/t, pseudo-random-transactions/t: http://build.chromium.org/f/chromium/perf/linux-release-lowmem/database/report.html?history=150&rev=109902 http://build.chromium.org/f/chromium/perf/linux-release-lowmem/database/report.html?history=150&rev=109902&graph=pseudo-random-transactions dom_perf PERF_REGRESS: Total/score: http://build.chromium.org/f/chromium/perf/linux-release-lowmem/dom_perf/report.html?history=150&rev=109902 page_cycler_bloat-http PERF_REGRESS: times/t: http://build.chromium.org/f/chromium/perf/linux-release-lowmem/bloat-http/report.html?history=150&rev=109902 xp-release-dual-core was not rebaselined fully after the v8 revert doing so now to get the improved tests back into range. page_cycler_moz PERF_REGRESS: vm_peak_r/vm_pk_r, PERF_IMPROVE: total_byte_r/IO_r: http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=150&rev=109902 page_cycler_intl1 PERF_IMPROVE: times/t: http://build.chromium.org/f/chromium/perf/xp-release-dual-core/intl1/report.html?history=150&rev=109902 page_cycler_intl2 PERF_IMPROVE: times/t: http://build.chromium.org/f/chromium/perf/xp-release-dual-core/intl2/report.html?history=150&rev=109902 BUG=NONE TBR=cmp@chromium.org Review URL: http://codereview.chromium.org/8528033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109925 0039d316-1c4b-4281-b951-d872f2087c98
-
kevers@chromium.org authored
BUG=chromium:100392,chromium:102139. TEST= Review URL: http://codereview.chromium.org/8539022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109924 0039d316-1c4b-4281-b951-d872f2087c98
-
semenzato@chromium.org authored
as a side effect. BUG=chrome-os-partner:4692 TEST=none Review URL: http://codereview.chromium.org/8508028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109922 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
TEST=unit_tests --gtest_filter=BookmarkEditorGtkTest* R=sky@chromium.org Review URL: http://codereview.chromium.org/8510051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109920 0039d316-1c4b-4281-b951-d872f2087c98
-