- 09 Jan, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/797d74a266bb..12f8d69f1288 git log 797d74a266bb..12f8d69f1288 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@12f8d69f1288 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Id353d9adffbf9e54e2cee6cce71f410ea4f9a731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993571Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729927}
-
Natalie Chouinard authored
Ignore existing presubmit errors in preference_spinner_*.xml NOPRESUBMIT=true Bug: 1035928 Change-Id: I3c25864ff3e3e82ecc6bffbbd30a945df6539f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992815Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#729926}
-
Mike Reed authored
See https://skia-review.googlesource.com/c/skia/+/263349 Change-Id: I04ee11072dd33ed5076a6b53ab580b4d5ed6b2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993626Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#729925}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac0b770408f5..141fae8b9f4d Created with: gclient setdep -r src-internal@141fae8b9f4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I490db605ecb95bfe91f611a94a04d6dbe6459b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993880Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729924}
-
Gabriel Charette authored
Getting rid of .Lukewarm suffix as it was only useful to diagnose what happens when it's not warm/cold. The main histogram already gives that and Startup.Temperature can be used for diagnosis. This CL will add 25-30% more users to the "warm" bucket and drop 5-15% from the "cold" bucket. .WarmStartup and .ColdStartup metrics are expected to shift as a result. Detailed analysis @ https://docs.google.com/document/d/1haXFN1cQ6XE-NfhKgww-rOP-Wi-gK6AczP3gT4M5_kI R=chrisha@chromium.org Bug: 969961, 1037318 Change-Id: I7c73806c0dc24d3c95d131bc1fa3098d8c57e5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991941Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#729923}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5c35f2fb1bc2..3b19b2734385 git log 5c35f2fb1bc2..3b19b2734385 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 jsphchn@google.com Make the sdk:audio_session_objc target public. 2020-01-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision efba8d29..b57c714b (729663:729764) 2020-01-09 aalaniz@twilio.com Update Android camera switch API to allow specifying a name 2020-01-09 phoglund@webrtc.org Extract plottable counter from perf results logger. 2020-01-09 henrika@webrtc.org Avoids crash in ADM for Android 2020-01-09 jonaso@webrtc.org Reland "Add field trial to base stable target rate on loss based target rate" Created with: gclient setdep -r src/third_party/webrtc@3b19b2734385 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I01b4a6f8f04f559e8c67572fddd292ebf9cae87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993883Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729922}
-
Jon Mann authored
When separating ssid from security type in a serialized network identifier, we were previously using an underscore. Since this is an allowed character in SSIDs, it's safer to use something more unique. Bug: 966270 Change-Id: I3aac88bd3fc0cfa6058b021892a697e09b271cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992585Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#729921}
-
Kevin Marshall authored
Enables HEADLESS operation on screen-less devices, using a switch published via the system's config store. Reading/parsing logic is promoted to a common library, "config_reader.h", and ContextProvider is modified to use it. Bug: 1025045 Change-Id: Iad72297cf0e2a2d30e2650563c23d58204ad7eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989998 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729920}
-
Elly Fong-Jones authored
Bug: 1011446 Change-Id: I35b19fa40c105738b286e5bf669049643b45681a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993900 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#729919}
-
Ryan Sturm authored
Bug: 1036489 Change-Id: I64bea0d19217483cb040a0bc0ba2697809a96ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993800Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#729918}
-
Rune Lillesveen authored
This feature has been enabled since M-76. Bug: 889087 Change-Id: I54fbf2851fe7da7c442f6abb05010405f7f27fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992321Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#729917}
-
Demetrios Papadopoulos authored
This test, previously named OmniboxViewTestWithoutSplitSettings.EditSearchEngines, was deleted at r727291. The test seems relevant regardless of whether the OS/Browser settings are split though. Restoring it since it still seems useful, without the now obsolete "WithoutSplitSettings" suffix. Fixed: 994927 Change-Id: I87bbbdc312a1a22b21fd2391c8c8f112302a5ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993941Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#729916}
-
Evan Stade authored
This removes the cached find-in-page value for a profile when that profile's history data is cleared. Like most data that is deleted along with DATA_TYPE_HISTORY, the time range is ignored; any time range will cause the last find-in-page value to be deleted. The original motivation for this change was to delete some Chrome dependencies from //chrome/browser/ui/find_bar/, in preparation for componentization, because it's an alternate way of achieving the behavior that is being deleted there (wrt clearing FIP for guest profiles). However it is also a behavioral improvement in that it makes Clear Browsing Data more comprehensive. Bug: 1038415, 889642 Change-Id: I429470c4f215e6a2ace29e42c2e8795a2e70daa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986909Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#729915}
-
Allen Bauer authored
Reland "Removed BrowserView::ViewHierarchChanged, moved most code to constructor and widget-specfic code to AddedToWidget." This is a reland of f3616c26 Original change's description: > Removed BrowserView::ViewHierarchChanged, moved most code to constructor and widget-specfic code to AddedToWidget. > > Bug: 245409 > Change-Id: I1e606548df4361199862c561ad86f4d40cbaa7df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979098 > Commit-Queue: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728998} Bug: 245409 Change-Id: Id5317849e130ec8715200f0947bc01f2bc932842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991945 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#729914}
-
Michael Thiessen authored
Uses the JNI generator to generate test methods for native java unittests that simply call java test methods. Bug: 783819 Change-Id: I2ff4d87a1aa053847077bd3f418123be49174375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992247 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#729913}
-
Brian Sheedy authored
Re-enables auto swarming containment on Win 10 x64 Debug (NVIDIA). Disabling it did not have any impact on flakiness. TBR=ynovikov@chromium.org Bug: 1030849 Change-Id: If13321ff6c21e5cc8162d7244b0ce43137aa08e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993118Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#729912}
-
Aran Gilman authored
Change-Id: Idcc65495d9c8fe635114f2958ec875919352a730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992588Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#729911}
-
Scott Violet authored
-webkit-box always starts horizontal layout from an x position of 0. rtl is handled by starting at 0 and iterating in reverse. https://chromium-review.googlesource.com/c/chromium/src/+/1876073 got close to this by making the width_for_rtl come from the hypothetical size. Unfortunately that doesn't deal with flex. This patch changes how coordinates are calculated when flipped to better give behavior expected of -webkit-box, and it also changes when start/end are flipped. I've add more test cases with a bunch of variations to ensure all cases are handled. This also changes the expectations of paint/invalidation/overflow/float-overflow-right.html. The expectations now match that before the patch at https://chromium-review.googlesource.com/c/chromium/src/+/1876073 BUG=1034461 1037764 TEST=external/wpt/compat/webkit-box-rtl-flex.html external/wpt/compat/webkit-box-horizontal-rtl-variants.html external/wpt/compat/webkit-box-horizontal-reverse-variants.html Change-Id: Ib32dcfef7c147d2e90b754d35f974ebe9c6092b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989930 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#729910}
-
John Lee authored
This CL simply sets up a TabGroupElement that takes in slotted content of TabElements. This is just the first CL to setup the base of the front-end work for tab groups. Bug: 1027373 Change-Id: Ic7248505c6ee7cfeaac92810e9e054f83c840c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992803 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#729909}
-
Theresa Wellington authored
When opening the ExploreSitesPage from the Start surface, ChromeActivity#getActiveTab returns null if there are no tabs open, causing an NPE. Update the ExploreSitesPage constructor to take a TabImpl rather than retrieving from ChromeActivity. BUG=1040377 Change-Id: I4d46df53dd2881fb3754a5eeb5fbadfcc6ac367e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993489 Auto-Submit: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#729908}
-
Peter Kotwicz authored
This CL: - Makes WebappActivity use CustomTabToolbarColorController - Teaches CustomTabToolbarColorController about webapp minimal UI - Adds logic to use default status bar color when the web page is a preview and the CCT is NOT in TWA mode. - Shares logic between CustomTabStatusBarColorProvider and CustomTabToolbarColorController. BUG=997796 TEST=WebappNavigationTest Change-Id: I34172a0167a3cea340b2a17641daa33af0b09295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989137 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#729907}
-
Oystein Eftevaag authored
NOTRY=true TBR=crouleau@chromium.org Bug: 1039801 Change-Id: I1d69246f996f9582fde794d4aec53d7f1590ed82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993668Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#729906}
-
Steve Anton authored
We need to monitor these histograms to determine an appropriate time to deprecate Plan B. It's unlikely that Plan B will be deprecated in 2020 so we'll need to continue collecting these metrics. Bug: 1037402, 1037401 Change-Id: Icb4a83d85355cea94bcf4fcc666e04711895ade8 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981836 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#729905}
-
Thomas Lukaszewicz authored
Fixed CustomTabBarView to set and update its colors only once attached to a widget, preventing the fallback to the default NativeTheme. Updated CustomTabBarView to respond to theme changes. Removed the dependency on GetThemeProviderForProfile from CustomTabBarView and from LocationBarView. Bug: None Change-Id: If505b0bede8f112329dcef5f2a7aab9e67dcfd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989085 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#729904}
-
danakj authored
Currently the main frame RenderWidget is never deleted but instead marked undead when the main frame is detached and replaced with a remote proxy. Then it is revived when a local main frame is created again. This changes the code to instead delete the main frame's RenderWidget instead of marking it undead. In order to do this there are a couple of fixes to go with it: 1) The browser needs to tell RenderWidgetHostImpl that the RenderWidget associated with it is gone, so that it can reset state to match the new RenderWidget later. 2) The WebViewFrameWidget needs to delete the animation timeline along with the RenderWidget. If the WebViewImpl isn't closing then it would end up being responsible for this task but the RenderWidget is already gone. Bug: 419087 Change-Id: Ibd08e7b03dd884821b38dc5d0efb5d016fb1d6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988781 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#729903}
-
Mohamed Amir Yosef authored
Change-Id: I021cd952d7a2917a8fb7203cabdac612251193df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963804 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#729902}
-
Avi Drissman authored
The “new updater” project was half-completed when it was abandoned in favor of a different approach. The different approach has been serving us well, so remove all the code for the “new updater” project. This effectively reverts: 21f3fb21 4a634b73 c0ec38a1 ce903eec 22f97baf 35b27074 1f478d5a 4a324668 f316ef44 8bcf1fdb bc95a5bb 753cb9df Bug: 960814, 1025805 Change-Id: I9f3e2b2d75d42f2ad49666dce4e0316f8a934e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991705Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#729901}
-
sebsg authored
Revert "Re-enable EngineRequestsNoBlockingTest on Win8 by initializing TaskEnvironment with COM disabled" This reverts commit 2dd4658f. Reason for revert: Causing the TaskEnvironmentTest.DefaultCOMEnvironment base_unittests to fail on Win7 starting at this build: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/98745 Original change's description: > Re-enable EngineRequestsNoBlockingTest on Win8 by initializing TaskEnvironment with COM disabled > > R=fdoray > > Bug: 947576 > Change-Id: I1f901367e6fcc5243f34f50e5704b68727a40731 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990135 > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729802} TBR=fdoray@chromium.org,joenotcharles@chromium.org Change-Id: Ie19f651e25680bc523ca8c8e37e39d11937fedc1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 947576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993841Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729900}
-
Peter Boström authored
Moves duplicated logic into views::test::WaitForAnimatingLayoutManager. Also adds a views::test::GetAnimatingLayoutManager convenience method. Bug: chromium:1039852 Change-Id: I285b4a717c556fc1b329259c0ce6142b271dcb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993565 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#729899}
-
Dan Beam authored
Discussion: https://groups.google.com/a/chromium.org/d/msg/chromium-dev/RqOdTlxuGVg/M7I0CTryDQAJ Bug: None Change-Id: I43cb19e50bf9addc530d728f4f002afa16bd6f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993388 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#729898}
-
sebsg authored
This reverts commit f3a7d44e. Reason for revert: Failing again after this landed https://ci.chromium.org/p/chromium/builders/ci/Mac%20Retina%20Debug%20%28AMD%29/59027 more details at crbug.com/1040202 Bug: 1040202 Original change's description: > Reland "Remove Pixel_CSSFilterEffects_NoOverlays failure expectation" > > This reverts commit b4099b2c. > > Reason for revert: new image has been triaged in Skia Gold. > > Original change's description: > > Revert "Remove Pixel_CSSFilterEffects_NoOverlays failure expectation" > > > > This reverts commit 7076daa4. > > > > Reason for revert: The test started failing again after this CL was landed. More details on crbug.com/1040202 > > > > Original change's description: > > > Remove Pixel_CSSFilterEffects_NoOverlays failure expectation > > > > > > Test was producing a minor image diff, has been triaged. > > > > > > Bug: 1040202 > > > Change-Id: Iae6dd08ea4b97d7f4975971b8abbb948d97867d5 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992564 > > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > > Commit-Queue: Brandon Jones <bajones@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#729597} > > > > TBR=kbr@chromium.org,bajones@chromium.org > > > > Change-Id: Id637b25550ce9f423e448d0b332c0dbbf34b9eb9 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1040202 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992367 > > Reviewed-by: sebsg <sebsg@chromium.org> > > Commit-Queue: sebsg <sebsg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#729736} > > TBR=kbr@chromium.org,bajones@chromium.org,sebsg@chromium.org > > Change-Id: Ief8494871a1a32571d7526ac313f7cbbc0d78d69 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1040202 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993113 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729838} TBR=kbr@chromium.org,bajones@chromium.org,sebsg@chromium.org Change-Id: Ibc4b81aa09eccbe93f04573dbbef675b173dfc32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994002Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729897}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bf8bd8052673..27db24581e9e git log bf8bd8052673..27db24581e9e --date=short --first-parent --format='%ad %ae %s' 2020-01-09 jdarpinian@chromium.org Optimize disabling ARB_texture_rectangle Created with: gclient setdep -r src/third_party/angle@27db24581e9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Ia9bf57138feb33c677141374c90b404f329cb375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993395Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729896}
-
Michael Spang authored
This is equivalent to the upstream "-s" option. It just prepends a string to path lookups in case paths are from a remote device for which we have a local symbols tree. Bug: 1040148 Change-Id: Icfa3232b9aa8fefa7274f26fdb0c123ceeb3f96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992008Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#729895}
-
Tommy Steimel authored
This CL switches the kaleidoscope browsertest to JavaScript Bug: 1026732 Change-Id: I35463113733460f24ebd1025420c94e9d8443825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993629Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#729894}
-
Fernando Serboncini authored
Change-Id: Ie841d2cf24be16f9a744b0a76bd35130a9d8ef10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993401 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#729893}
-
Greg Thompson authored
BUG=1037237 R=proberge@chromium.org Change-Id: I1af2a700fe4d3922f9a16e3068b8b73f09980a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986075 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#729892}
-
Yao Xiao authored
Bug: 1037382 Change-Id: I3ce638552ab44050af8bdd3083a42a5879c0c537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991748 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#729891}
-
Matt Reynolds authored
This CL modifies the return value from navigator.hid.requestDevice to return an array of HIDDevice objects instead of a single HIDDevice. If the device chooser is canceled without making a selection, the promise is resolved with an empty array instead of rejecting with a DOM exception. The HID device chooser has also been modified such that each item in the chooser represents a single physical device. If multiple logical HID interfaces are exposed by the same physical device, granting permission to access the single physical device grants permission to access any logical HID interfaces hosted by the device that satisfy the chooser filters. BUG=1036439 Change-Id: Ib67b71bcee32e261d3c9425cfc8bd7173f4ebb8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966496Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#729890}
-
Oystein Eftevaag authored
This reverts commit c6d81bfc. Reason for revert: Broken again. Original change's description: > Revert "Disable v8.browsing_mobile/browse:news:nytimes:2019 on android go & nexus 5" > > This reverts commit 5be23f11. > > Reason for revert: The CL that caused problems has been reverted. > > Original change's description: > > Disable v8.browsing_mobile/browse:news:nytimes:2019 on android go & nexus 5 > > > > NOTRY=true > > TBR=crouleau@chromium.org > > CC=mythria@chromium.org,ulan@chromium.org > > BUG=1039295 > > > > Change-Id: I418cf1c1be64257871972520008cf61749fa6032 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988546 > > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#728565} > > TBR=crouleau@chromium.org,nuskos@chromium.org > > Change-Id: Iaee18d7609fd7a54b480ab59b3dd1a3313be9be5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1039295 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985956 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728875} TBR=rmcilroy@chromium.org,crouleau@chromium.org,nuskos@chromium.org NOTRY=true Bug: 1039295 Change-Id: Iaf40d9ec4acef0aeb9ec0e809c707c8e070766aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994020Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#729889}
-
Patrick Monette authored
This CL adds an overload to WebContentsImpl::FromRenderFrameHostID() and to RenderFrameHost::FromID() that takes in a GlobalFrameRoutingId instead of taking in a pair of ints. This makes those functions easier to use when the caller already has a GlobalFrameRoutingId instance. Change-Id: I1fd7acf816d5f48b792f69d21007a302317f5cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988729 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#729888}
-