GitLab

This reverts commit fdef07af.

Reason for revert: Breaks browser_tests on the chromium.webrtc bots on Linux, Win7, and Mac. Gathering of ICE candidates fails with this error log:
[7466:7466:0713/070330.078566:INFO:CONSOLE(13)] "Returning Test failed: Error: Received invalid ICE candidate list from peer: []
    at failTest (http://127.0.0.1:52364/webrtc/test_functions.js:46:15)
    at receiveIceCandidates (http://127.0.0.1:52364/webrtc/peerconnection.js:371:11)
    at <anonymous>:1:51 to test.", source: http://127.0.0.1:52364/webrtc/test_functions.js (13)
../../chrome/browser/media/webrtc/webrtc_browsertest_base.cc:412: Failure
      Expected: "ok-received-candidates"
To be equal to: ExecuteJavascript( base::StringPrintf("receiveIceCandidates('%s')", ice_candidates.c_str()), to_tab)
      Which is: "Test failed: Error: Received invalid ICE candidate list from peer: []\n    at failTest (http://127.0.0.1:52364/webrtc/test_functions.js:46:15)\n    at receiveIceCandidates (http://127.0.0.1:52364/webrtc/peerconnection.js:371:11)\n    at <anonymous>:1:51"
With diff:
@@ -1,1 +1,4 @@
-ok-received-candidates
+Test failed: Error: Received invalid ICE candidate list from peer: []
+    at failTest (http://127.0.0.1:52364/webrtc/test_functions.js:46:15)
+    at receiveIceCandidates (http://127.0.0.1:52364/webrtc/peerconnection.js:371:11)
+    at <anonymous>:1:51

Link to bots:
https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester
https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester

Original change's description:
> [scheduler] Reenable timer throttling for background renderers.
> 
> Use renderer scheduler policy to throttle background timer queues
> when the renderer is backgrounded.
> 
> R=​alexclarke@chromium.org
> 
> Change-Id: Iff6f4b80883f1030b14e9f67345a7df9dd018a63
> Reviewed-on: https://chromium-review.googlesource.com/567932
> Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> Commit-Queue: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485947}

TBR=alexclarke@chromium.org,altimin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

NOTRY=TRUE

Change-Id: Iaf76027f0bc8894f8a8812c0843b27d26192a44a
Reviewed-on: https://chromium-review.googlesource.com/570404
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Magnus Jedvert <magjed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486459}

Interactions media queries were returning wrong values on laptops with
touch screens which are neither convertible, neither detachable.
The reason is that GetSystemMetrics(SM_CONVERTIBLESLATEMODE) returns
always 0 on these machines which is buggy as they are not in a
slate/tablet mode.

One solution would be to check the presence of ConvertibleSlateMode
key in the registry (that key is used to know when the
laptop is flipped or detached) but it doesn't seem to be consistent
across hardware (my desktop PC doesn't have that key but the hardware
listed in the bug below has it).

The last possible alternative is to query the hardware about screen
rotation. If the screen rotation is supported then it's most likely
a tablet/detachable/convertible, if not then it's a desktop PC, a
non touch laptop or a classic touch laptop. If the screen rotation
is not supported, if the laptop doesn't have a screen rotation sensor
or if the laptop is in laptop mode then it's not a tablet.

BUG=739430, 442418

Change-Id: I1aad26d7d833a425981bf0d46a7dae9878f19cd1
Reviewed-on: https://chromium-review.googlesource.com/566567Reviewed-by: Ananta Iyengar <ananta@chromium.org>
Reviewed-by: Carlos Pizano <cpu@chromium.org>
Commit-Queue: Alexis Menard <alexis.menard@intel.com>
Cr-Commit-Position: refs/heads/master@{#486458}

TBR=yszshen@chromium.org
NOTRY=true

Change-Id: Ia01b7d9027419eb2c055bf2eaaba9fa87834e35b
Reviewed-on: https://chromium-review.googlesource.com/570839Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486457}

This reverts commit 9d704fa8.

Reason for revert: FYI Buildbot ClangToTLinuxASan fails. We want to find out if this CL caused the failure.

Original change's description:
> [Zucchini] Introduce buffer_source and buffer_sink.
> 
> Cursors with convenient read and write methods to ease manipulation of
> raw data.
> 
> Bug: 729154
> Change-Id: I8a7303964b02b9df7ef033de8756b09716a91eae
> Reviewed-on: https://chromium-review.googlesource.com/560657
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Reviewed-by: Samuel Huang <huangs@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486238}

TBR=huangs@chromium.org,erikchen@chromium.org,etiennep@chromium.org

Change-Id: I15d90734a0e8b4791d51ee0b8bc04a4ce4116a45
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 729154
Reviewed-on: https://chromium-review.googlesource.com/570502Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486456}

This reverts commit f3a69e04.

Reason for revert: ios-device and ios-device-xcode-clang broken

Original change's description:
> Add optimized arm implementations to base/numerics
> 
> BUG=672489
> 
> Change-Id: I7bb13d0ae3850f3334978bd8d483550ea2f3e3fd
> Reviewed-on: https://chromium-review.googlesource.com/567436
> Commit-Queue: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486438}

TBR=jschuh@chromium.org,eae@chromium.org

Change-Id: I2555ad7458b1379675e2c9fd4385d4bdaef0212c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 672489
Reviewed-on: https://chromium-review.googlesource.com/570898Reviewed-by: Justin Schuh <jschuh@chromium.org>
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486455}

This reverts commit 66dbfe27.

Reason for revert: ios-device and ios-device-xcode-clang broken

Original change's description:
> Fix ios builders after refs/heads/master@{#486438}
> 
> TBR=eae@chromium.org
> NOPRESUBMIT=true
> NOTRY=true
> NO_DEPENDENCY_CHECKS=true
> 
> Change-Id: I61a733adb8570b6246da5b3d0dd34780c81d4dce
> Reviewed-on: https://chromium-review.googlesource.com/570838
> Reviewed-by: Justin Schuh <jschuh@chromium.org>
> Commit-Queue: Justin Schuh <jschuh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486452}

TBR=jschuh@chromium.org,eae@chromium.org

Change-Id: I8b3d22b84096b92d7800cb42ae230d1a6307fcf0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/570878Reviewed-by: Justin Schuh <jschuh@chromium.org>
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486454}

This CL replaces use of i18n-content/values with $i18n{} in the internal
appcache page. This page was and is only partially localized.

TBR=michaeln@chromium.org

Bug: 677338
Change-Id: I3113d51ab80381291807f298e3885d9128464144
Reviewed-on: https://chromium-review.googlesource.com/569314
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486453}

TBR=eae@chromium.org
NOPRESUBMIT=true
NOTRY=true
NO_DEPENDENCY_CHECKS=true

Change-Id: I61a733adb8570b6246da5b3d0dd34780c81d4dce
Reviewed-on: https://chromium-review.googlesource.com/570838Reviewed-by: Justin Schuh <jschuh@chromium.org>
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486452}

Stability, usability improvements for Fuchsia test runner.
* Fix test flakiness that seemed to be related to qemu sharing the
  stdin stream with Python. The OS would then tear down the scripts
  prematurely causing Python to panic.
  Specifying a subprocess PIPE for stdin fixes that.
* Disable the QEMU interactive monitor. It was overriding the user's
  terminal settings and blocking important keypresses like ^C, making
  it difficult to terminate tests early.

R: wez@chromium.org,thakis@chromium.org
BUG: 741194,740201
Change-Id: Ibda6ac59d44b07c1b75902a7dc13db086841baa0
Reviewed-on: https://chromium-review.googlesource.com/568739
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486451}

iOS previously did not consult the embedder for its list of secure
schemes, meaning that chrome:// urls were not treated as secure. This
change enables the Web Client to declare a list of application-specific
secure schemes, and adds the chrome:// scheme to that list.

Bug: 739480
Change-Id: Ia794aef6d9b34229755f9c7aad0cbc93158a659e
Reviewed-on: https://chromium-review.googlesource.com/568624
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486450}

This is a reland of 2096391c
Original change's description:
> Reimplement base::WaitableEvent with a kqueue on Mac.
> 
> For a single WaitableEvent, a custom EVFILT_USER kevent is used to wait and
> signal. This replaces the default POSIX implementation that uses a
> pthread_cond_t and a boolean flag.
> 
> To implement WaitMany, a new kqueue is created to wait on all the individual
> WaitableEvent's kqueue descriptor. This replaces a complex locking algorithm
> used in the default POSIX implementation.
> 
> For the asynchronous WaitableEventWatcher, a TYPE_READ dispatch_source_t is
> used to watch the WaitableEvent's kqueue. This replaces the POSIX
> implementation of a reference-counted list of async watchers guarded by a lock.
> 
> Microbenchmarks show that the kqueue implementation is significantly faster in
> most cases. The one potential drawback is hitting the low RLIMIT_NOFILE on
> macOS, since each WaitableEvent and WaitableEventWatcher requires a new
> descriptor.
> 
> Bug: 681167
> Change-Id: I135012fdd25e547ffb911fc7adc97c203df38241
> Reviewed-on: https://chromium-review.googlesource.com/553497
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485788}

Bug: 681167
Change-Id: I1b0296022f7bd1a31b074fbbb551bccc3b28d05b
Reviewed-on: https://chromium-review.googlesource.com/568642Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486449}

This CL adds extra_attributes property to create_bundle target so that
these values can be specified in BUILD files instead of hard coded in
GN.

Bug: 740800, 709289
Change-Id: I1c0393e11405527bda5cf70fb8b653fc76454b97
Reviewed-on: https://chromium-review.googlesource.com/566390
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486448}

TBR: scheib@chromium.org

Change-Id: I51eb3a98ad2d8c2d4b1417f8396220b9f46070c9
Reviewed-on: https://chromium-review.googlesource.com/570185Reviewed-by: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486447}

TBR=zmo@chromium.org
NOTRY=true

BUG=668223

Change-Id: Ib4e0e2993c285b7edfa9e443d63fdefdcd28986d
Reviewed-on: https://chromium-review.googlesource.com/570668Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486446}

Using MessageLoop across the death test fork does not work well on Mac. The
threadsafe death test style solves this issue.

Bug: 741256
Bug: 681167
Change-Id: I301981a704c284d4264642d4a553d3cc2570e0fa
Reviewed-on: https://chromium-review.googlesource.com/568800Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486445}

Bug: 740141
Change-Id: I2f82a5e8af3d79aeb0f7fd82a4c2a43ccccbcb49
Reviewed-on: https://chromium-review.googlesource.com/568842Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486444}

https://chromium-review.googlesource.com/c/562178/ reintroduced a check
that was previously used by GbmSurfaceless to test if we were pageflipping
on a non primary drm device.

The check relied on testing if the drm device of the enqueued buffers
was primary, in case the queue was empty, it'd return false.

Unfortunatly, since the logic of GbmSurfaceless changed, the queue of
buffers is now always empty where we're testing if it's an external
device.

This CL changes the logic, setting a flag is_on_external_drm_device_
every time a buffer is enqueued.

Bug: 721463
Test: Ran on samus with mimo attached.
Change-Id: I44bfa14e48251c5afa6ff635a6c3f54a0d274d98
Reviewed-on: https://chromium-review.googlesource.com/569406Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486443}

Uses Cast's DRM instead of Android's on Android audio-only builds.

BUG=internal 62721854
TEST=Cast Spotify to cast shell

Change-Id: I441357b30693e93ec2578c7066205831980d188a
Reviewed-on: https://chromium-review.googlesource.com/568247Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Thoren Paulson <thoren@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486442}

BUG=721395
R=mmenke@chromium.org

Change-Id: I608c01810d2ccf47366614ea35bdf28e819d920f
Reviewed-on: https://chromium-review.googlesource.com/568688Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486441}

Previoiusly we were just checking fragment.BlockSize() which was error
prone as:
<div style="height: 0px;">text</div>
... would have been considered an empty block.

Now the check uses the presence of the BfcOffset on the child's layout
result. If it isn't present, the child must be empty.

BUG=635619

Review-Url: https://codereview.chromium.org/2982643002
Cr-Commit-Position: refs/heads/master@{#486440}

- Use mx_status_get_string() to stringify result codes, for easier
  debugging.
- Use DCHECK_OP() variants where appropriate.
- Use NOTREACHED() in default case of watch-mode switch statement,
  rather than DCHECKing the same thing before the switch.

Change-Id: Ifac8720341137881d4ce6416ac4c7e5142c822a5
Reviewed-on: https://chromium-review.googlesource.com/569040Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486439}

BUG=672489

Change-Id: I7bb13d0ae3850f3334978bd8d483550ea2f3e3fd
Reviewed-on: https://chromium-review.googlesource.com/567436
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486438}

After ac68cf90fa046d3e9c1418aee7cd14b8ec38210 there is no code left that
still uses blink::Stream, so remove the class and its IPCs.

Bug: 690795
Change-Id: I1a60a65b232bed39aa1d16896ba611d484324c8e
Reviewed-on: https://chromium-review.googlesource.com/568689Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486437}

changes:
The general SearchResultTileItemView layout and UI should be controlled by
EnableFullscreenAppList flag. Those Play Store related views are enabled by
EnablePlayStoreAppSearch, like rating_, rating_star_, price_, badge_. By
checking if they are nullptr, that is equivalently checking
EnablePlayStoreAppSearch flag.

Bug: 741073
TEST: tested without EnablePlayStoreAppSearch flag, it behaves correctly now.
Change-Id: I6ae4313698e428760fec024c487590672bda40aa
Reviewed-on: https://chromium-review.googlesource.com/567488Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486436}

Have Android also trigger virtual keyboard on mouse up.

Bug: 730038
Change-Id: Ife9979b96f7e21577ed94af65323d4ac45513c88
Reviewed-on: https://chromium-review.googlesource.com/566279
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486435}

Bug: 737231
Change-Id: Id6f45920f7dae7e185da6b663f3bc0cfb8073cc3
Reviewed-on: https://chromium-review.googlesource.com/568856
Commit-Queue: Brad Lassey <lassey@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486434}

BUG=724616

Review-Url: https://codereview.chromium.org/2944633002
Cr-Commit-Position: refs/heads/master@{#486433}

Showing cursor and highlighted span at the same time is a bit awkward.
We can hide the cursor whenever we show the autocomplete text using
View#setCursorVisible().

Whenever span is shown, cursor should be hidden, and vice versa.
Therefore, I chose to expand the current SpanController to control
cursor as well.

The testing is a bit tricky because of excessive calls to
setCursorVisible() - so I ended up just checking the current state.

BUG=539536

Change-Id: I8333586d3209f6bb95055ed943ab5c9593741821
Reviewed-on: https://chromium-review.googlesource.com/569145Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486432}

Follow-up to https://chromium-review.googlesource.com/567267

Change-Id: I8813d776d73cc4459f5bcce6a93532f2ea9b427a
Reviewed-on: https://chromium-review.googlesource.com/570003Reviewed-by: Mike Reed <reed@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486431}

This patch adds visible property, and uses it in WebContentsCoordinationUnit.
This property is useful for metrics which need to determine whether the
corresponding tab is foreground or not.

Change-Id: I99520710a8887ea3f5aa3d3c9a56b2d6f446ac53

BUG=737817

Change-Id: I99520710a8887ea3f5aa3d3c9a56b2d6f446ac53
Reviewed-on: https://chromium-review.googlesource.com/568365
Commit-Queue: Duc Bui <ducbui@google.com>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486430}

Reland after fix "Change NetworkSessionConfigurator to process multiple versions from quic_version field"

This is a reland of 4721652f after fix the crashing issues.

Original change's description:
> Change NetworkSessionConfigurator to process multiple versions from quic_version field
> 
> Bug: 689762
> Change-Id: Ic0de2dacd01158d85318794d05f8f763659d9228
> Reviewed-on: https://chromium-review.googlesource.com/565784
> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485678}

Bug: 689762
Change-Id: I1f1c92458263d3a9f013b9e0c51154186caabd17
Reviewed-on: https://chromium-review.googlesource.com/568641Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486429}

As well, we adjust the height should the popups content change.

Bug: 375637
Test: visual
Change-Id: Ia8f77516dda4dc6dd33d196c3238926dba56a53c
Reviewed-on: https://chromium-review.googlesource.com/569312Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486428}

These files use base::MakeUnique without including ptr_util.h themselves.
ptr_util.h is indirectly included through either cc/resources/single_release_callback.h
or cc/resources/single_release_callback_impl.h, but these inclusion is
being removed.

Change-Id: I966933932273d1940e5d78957083bb13950febe7
Reviewed-on: https://chromium-review.googlesource.com/569945Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486427}

A bot with the same configuration will soon live on chromium.memory,
so we should make sure we don't break it.

Bug: 732652
Change-Id: I7ded28d433691306666912d12eb6f2212a803c65
Reviewed-on: https://chromium-review.googlesource.com/569604Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486426}

We need to properly clear CompositionRangeUpdateObserver used in the test body
and do not rely on tear down process. There seems to be a bug in the internals
of TextInputManagerTester where the internal observer is not properly removed
from TextInputManager's observer list.

Synthetic local testing shows that if we repeatedly pump
RenderWidget::UpdateCompositionInfo(true), the test crashes in non-OOPIF mode. The
reasons seems to be that TextInputManagerTester::observer_ is not removed from
TextInputManager's observer list and a late arriving IPC for IME composition range
during shutdown causes the test process to crash (UaF).

BUG=736752, 602723

Change-Id: Iebf1f20dccddae63ad587ec6f03bf6951b89c5ee
Reviewed-on: https://chromium-review.googlesource.com/545223Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486425}

Bug: 
Change-Id: I8cef060ee121c90f5ad405dd55a5ddb79676d9f2
Reviewed-on: https://chromium-review.googlesource.com/569990Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486424}

Using wpt-import in Chromium 142a048e.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/310

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
glebl@chromium.org:
  external/wpt/css/CSS2/positioning
hta@chromium.org:
  external/wpt/webrtc
igrigorik@chromium.org, panicker@chromium.org:
  external/wpt/performance-timeline
kojii@chromium.org:
  external/wpt/css/CSS2

TBR: qyearsley@chromium.org
No-Export: true
Change-Id: I652ded994e7de04204d163a5ee2ebd77bf25dc6c
Reviewed-on: https://chromium-review.googlesource.com/569984
Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486423}

Without the invalidate() call, the view would only update 400ms later,
when the progress indicator becomes visible.

Bug: 741800
Change-Id: I949e423187b2b0e68eb807c44a8d3b78043ed016
Reviewed-on: https://chromium-review.googlesource.com/570037Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486422}

Remove the deprecated function that uses default InitParams. Add the
params in the remaining callsites and set |single_process| correctly for
tests. The only exception is in aura::Env::Init() where we don't know
if it is a test.

Bug: 620934,700142
Change-Id: I5e0d61578a423dd42eca38d21ccd1568b9ce5a8b
Reviewed-on: https://chromium-review.googlesource.com/568361Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486421}

The CL [ios showcase] Integrated TextBadgeView with Showcase 
(patchset #4 id:80001 of https://codereview.chromium.org/2967113003/)
broke ios_showcase_egtests suite for iPad. The revert can be found
here: https://codereview.chromium.org/2978533002/.

This CL is a reland of the first, and fixes the egtest issue by
ensuring that EarlGrey only selects sufficiently visible elements.

Bug: 740133
Change-Id: Ie30b78e85d965bd2ff48d27fef4eb7f824d56d98
Reviewed-on: https://chromium-review.googlesource.com/567129
Commit-Queue: Helen Yang <helenlyang@google.com>
Reviewed-by: Ed Chin <edchin@chromium.org>
Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486420}