- 23 Apr, 2020 40 commits
-
-
Renjie Tang authored
This doesn't change behavior for Chrome on all platforms. But Cronet embedders might switch from quic-disabled to quic-enabled. I will send out a notice once this CL is approved. Change-Id: I62b4b77ec0bd00adf09e64a1193d0e4e6434dcff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024077Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#761997}
-
Mohamed Amir Yosef authored
crrev.com/c/1491623 removed the "REPLACE" part from the update statement, but left the comment. This CL is only removing the comment. Change-Id: I5100c960a303b9ce89bb2c1512ccd7d3392cb125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162770 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#761996}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e110a44628b1..1fb4a05e9e21 git log e110a44628b1..1fb4a05e9e21 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 ilnik@webrtc.org Reland "Launch external ref control for vp9 encoder" Created with: gclient setdep -r src/third_party/webrtc@1fb4a05e9e21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1027108 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id49b13fd71a12d1638d220b08582c90bf71a36a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163055Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761995}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e58df20c54a4..6fc0066aad67 git log e58df20c54a4..6fc0066aad67 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 jmadill@chromium.org Vulkan: Add a sampler cache. Created with: gclient setdep -r src/third_party/angle@6fc0066aad67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I445d6b9e315100ae844ac96d1e613266feca1cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163053Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761994}
-
zhaoyangli authored
When TESTS_DID_NOT_START or BUILD_INTERRUPTED happened in the an attempt and some tests didn't run due to these statuses, the tests will be retried in next attempt if there is one attempt in our test runner. These cancellations are listed as failed tests in the attempt result and will be finally copied into standard test result json, even though all affected tests succeed in following attempts. This will cause a failure in Chromium recipe. See the bug for details. Since this change, we don't mark these in test results. Tests affected by these statuses are already marked as timeout in standard test results so this won't let go any failures. Bug: 1073491 Change-Id: Id031d3fa1b7ed61bf61db2887ed8037df4244d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161930Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#761993}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/28447fd262e4..5d77448b5f68 git log 28447fd262e4..5d77448b5f68 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 alexrudenko@chromium.org Migrate Common.Color to generate whitespace color notation by default Created with: gclient setdep -r src/third_party/devtools-frontend/src@5d77448b5f68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaeddb733570acae564c3aa525aed7d02333a8447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163047Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761992}
-
Chris Thompson authored
Bug: 1037264 Change-Id: Ief9f89814fbc71a1571628648089e33c5b9fe5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159421Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#761991}
-
sczs authored
This reverts commit 920d8f93. Reason for revert: Initial CL for Reland Original change's description: > Revert "Enables kInfobarUIRebootOnlyiOS13 by default" > > This reverts commit b7db0ccb. > > Reason for revert: This causes code to dereference nullptr on iOS 12, thus causing consistent crashed. > > Original change's description: > > Enables kInfobarUIRebootOnlyiOS13 by default > > > > This is now needed in order to enable this locally and not via a finch > > config which might not land before the re-sping gets to users. > > > > Bug: 1071853 > > Change-Id: I71b42ca95e54197ddf76b4301616be36c37ad1ca > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157505 > > Commit-Queue: Sergio Collazos <sczs@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#760756} > > TBR=eugenebut@chromium.org,sczs@chromium.org > > Change-Id: I534ea0a7d177a3a5452d91ea4bf945375cd2f606 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1071853, 1073091 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159469 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760984} Bug: 1071853, 1073091 Change-Id: I387c0801d9d40001587565be42c1e1055f27d0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159251Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#761990}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/34c40d668082..7fc367463824 git log 34c40d668082..7fc367463824 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 hjd@google.com Merge "trace_processor: Fix broken commit" Created with: gclient setdep -r src/third_party/perfetto@7fc367463824 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7bc69005e7b1c8a0fc08d2a9845a145d09b794c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163049Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761989}
-
Wez authored
Isolate web_engine child processes (e.g. Renderers) to each run in a separate job, to provide stronger isolation (e.g. they cannot discover one another via PID). Bug: 1053543 Change-Id: I45457f2fb034fd0c050cf12e11ab068618e8e37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161038 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#761988}
-
Wan-Teh Chang authored
Move PopulateResourceRequestBody() into the unnamed namespace because it is only used in request_conversion.cc. Change-Id: Ie23db3dceaa51e802cfa6f33553c4e059380edb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161875Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#761987}
-
Matt Mueller authored
SecureDnsInterceptor was added in 88b36dab to ensure that unittests of certificate network fetches had secure DNS disabled, but it was only added to HTTPSOCSPTest (which is the base class for SpawnedTestServer based tests), but not to HTTPSCertNetFetchingTest (which is the base class for EmbeddedTestServer based tests). Bug: 846909 Change-Id: I1ea0af37227ee5804f55a78478ad2354211bcb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161938Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#761986}
-
Sven Zheng authored
This reverts commit ad88c6d1. Reason for revert: Still fails on bot. This is weird. I've used mb tool to launch the job and it can pass on bot. Tried several times. But on CI bot it still fails. Original change's description: > Re-enable TwoClientDictionarySyncTest.Sanity_E2ETest test > > Tested the test can pass on bot. > > Bug: 1068415 > Change-Id: I3a94ededc3969f3cdef01865ced46c2ad4d0e300 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157783 > Reviewed-by: Ian Struiksma <ianstruiksma@google.com> > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#761327} TBR=svenzheng@chromium.org,ianstruiksma@google.com # Not skipping CQ checks because original CL landed > 1 day ago. TBR: ianstruiksma@chromium.org Bug: 1068415 Change-Id: I317e83cad99f0573b4e1abe1e6b74a6092eebf16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163249 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#761985}
-
Eric Roman authored
Change-Id: Ie62002a6a2f1e16a19ea58230b4b951b439eb65d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161969 Commit-Queue: Matt Mueller <mattm@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#761984}
-
Rijubrata Bhaumik authored
Riju is spec editor for ImageCapture and is leading efforts to add new features both in the spec and in chrome. Bug: None. Change-Id: I9c0ac3496d2d867d2c9223842dac2fce63659690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160972 Auto-Submit: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#761983}
-
Jeffrey Cohen authored
Bug: 1072141 Change-Id: Ic8fea35fa0acd9bbcf8379c47ac5a8f30c3fd912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157891Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#761982}
-
Stephen McGruer authored
These are all symptomatic of crbug.com/1047818, but to stop the pain for sheriffs lets mark them timeout=long for now. Bug: 1068574, 1065250, 1070562, 1073055 Change-Id: I76e29d3037bd0c98c96bf21a7427d7981b91def4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161728 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#761981}
-
Devlin Cronin authored
Bug: 1037089 Change-Id: I38051cd634c1fba954b20f8f40ebe28242e4022f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161699Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#761980}
-
Javier Ernesto Flores Robles authored
This is a reland of b5244048 The conflicting import has been removed. Original change's description: > [iOS][Credential-Provider] Move account validator to common 1/3 > > Moves files to common to be used in Chrome. > > Bug: 1066803 > Change-Id: I6f3ec5e7916a94cdf37d20be3138e8e99ebb2257 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157215 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: David Jean <djean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#761452} Bug: 1066803 Change-Id: Ie8658dfbc3323708330844e82e12b5fe0c42606c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161033Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#761979}
-
Chris Harrelson authored
This reverts commit 2b5c4137. The fix is to wait one more frame. This makes the test pass reliably on debug builds. Bug: 977658 Change-Id: Ie8a70e6043e92267f99022cdc78b7ca687370cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161454Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#761978}
-
danakj authored
The calls to RenderWidget can be done directly in TestRunnerBindings if we give it the RenderFrame they are bound to. This also makes them work in frames other than the main frame. The reset code for device scale and colorspace is removed and simplified, as between tests we SynchronizeVisualProperties() on the main frame's widget and that will reset its state. R=avi@chromium.org Bug: 866140, 1069111 Change-Id: Id3f247a39abdd45cf1b9c523c2724dec395fc697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159621 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#761977}
-
Sebastien Lalancette authored
Merged the previous CL too quickly. Bug: 1064990 Change-Id: Icb98433f1ab7daebc7cd5ef4190e1610b05a519d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163145 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#761976}
-
Leonid Baraz authored
Bug: b:153361703 Change-Id: I5c19a27fc74055b1659acc8ec8f07c460bd69fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158870Reviewed-by:
Anqing Zhao <anqing@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#761975}
-
Olga Gerchikov authored
Implemented web-animations-1 spec changes introduces in [1]. - Update play and pause procedures to initialize start time of scroll animations to zero. - Updated calculate play state procedure to return "running" state for animations that has start time resolved. - Added/modified tests reflecting spec changes. [1] https://github.com/w3c/csswg-drafts/pull/4842 Bug: 1070637 Change-Id: Ic83995899b2f3f8d8f985f84b8a2b438bbad7c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150687 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#761974}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cefc2d9a4582..5fc5c8128ce0 git log cefc2d9a4582..5fc5c8128ce0 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 egdaniel@google.com Add GrD3DPipelineStateBuilder class. 2020-04-23 mtklein@google.com stack-aware codegen? 2020-04-23 mtklein@google.com restore in-place FMAs 2020-04-23 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-23 jvanverth@google.com Implement GrMtlOpsRenderPass::onClear. 2020-04-23 fmalita@chromium.org [skottie] Initial outer/inner glow Created with: gclient setdep -r src/third_party/skia@5fc5c8128ce0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: Ic4ebf48ec30532afb660611196f3887bf43495d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163052Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761973}
-
Wei Li authored
On Mac, the toolbar can be shown or hidden on full screen. The zoom bubble changes its anchor position when the toolbar visibility changes. We can not simply refresh the shown Zoom bubble if its anchor position changed. So we need to allow Zoom bubble to be closed in that case. Otherwise, double zoom bubbles may be shown as described in the bug. BUG=1072353 Change-Id: I5abc492e81b0e207556d528de3635e85f6bce9d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159315Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#761972}
-
Natalie Chouinard authored
This reverts commit e3d5c44e. Reason for revert: Flaky failures on multiple bots https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.TabsTest%23testUndo Original change's description: > Add tests for undo closure in stack tab switcher > > Bug: 1064445 > Change-Id: I31bf5c42e013868282d1d220d7d871f411331494 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150060 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Mei Liang <meiliang@chromium.org> > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#761720} TBR=yusufo@chromium.org,wychen@chromium.org,meiliang@chromium.org,yuezhanggg@chromium.org Change-Id: I447c525cdf6da5c69e200f775804fde888e67f9f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163386Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#761971}
-
Andrey Zaytsev authored
This CL is needed to land https://crrev.com/c/2160745 on the M83 branch. For more context see that CL. Bug: 1072432, 1015841 Change-Id: I7284f92d8db2c60fe7209b215b71c26e45770ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162925Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#761970}
-
Anders Hartvoll Ruud authored
This adds new tests that verify that invalid rules are ignored, and don't affect other valid rules. I also rewrote this test file to use utils.js more liberally. It makes individual tests harder to understand for the uninitiated, but it scales so much better as the number of test functions increases. Bug: 973830 Change-Id: Ie19d85042a0475180cc4bbee4ad202ea08adba73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161005 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#761969}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e57f0f5a22d..8094fa603805 Created with: gclient setdep -r src-internal@8094fa603805 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1067070 Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com Change-Id: I1f1ecbf7e0407da6d36acf6ca27913d839844a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163045Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761968}
-
Ryan Sturm authored
This didn't have the fixit label initially, so I happened to miss updating the expiry. Bug: 1061962 Change-Id: Ib4b9311dccf6fa489e2a2a9180d38d7b4328a009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163068 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#761967}
-
Tao Bai authored
- Added GetAllAwContent method in AwContentsLifecycleNotifier - Changed AwContentsLifecycleNotifier to store AwContents pointer. - Added AwPageLoadMetricsProvider which uses GetAllAwContent. Bug: 1072770 Change-Id: Ief07426218df2ca28249de66bba2147f0a64a403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158914Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#761966}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/160e12e11a72..00a02293c327 git log 160e12e11a72..00a02293c327 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 vapier@chromium.org cros_mark_android_as_stable: migrate to python3 only 2020-04-23 vapier@chromium.org cros_mark_chrome_as_stable: migrate to python3 only 2020-04-22 slangley@chromium.org reven: Do not run HW tests on reven builds. 2020-04-22 cjmcdonald@chromium.org run_pytest: Add '--quickstart' mode 2020-04-22 bpastene@chromium.org cros_chrome_sdk: Add support for --boards. 2020-04-22 morg@google.com Add (rammus|kukui)-arc-r to RVCPFQ boards 2020-04-22 lamontjones@chromium.org api: freshen python bindings. 2020-04-22 dburger@chromium.org Remove scheduling of qt_android_pfq, is retired. Created with: gclient setdep -r src/third_party/chromite@00a02293c327 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I5a8a81684df0608b37cbce1d66c78d9009c946fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163048Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761965}
-
Mason Freed authored
With this CL, if a declarative shadow root is already present when attachShadow() is called, the contents of this shadow root are removed, and the existing shadow root is returned. This is per Step 5 of the new spec [1], to allow coexistence of declarative content and custom element hydration code. This CL also adds an exhaustive test of all element types, both those supporting and disallowing shadow root attachment. [1] https://whatpr.org/dom/858.html#concept-attach-a-shadow-root Bug: 1042130 Change-Id: Ie9fc39eeb324934f3cb13ab2eb6bc8a82d99d667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159987 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#761964}
-
Alice Wang authored
This CL removes the helper method used for test debugging in BookmarkPersonalizedSigninPromoDismissTest. As the all the tests of this class are enabled since February and are not flaky. We can safely remove the helper method now. Bug: 1045480 Change-Id: I4758cc717af3e8ff0d3f23f76786877b3f251484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159219Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#761963}
-
Anders Hartvoll Ruud authored
The test creates a tree that has alternating ltr/rtl on each level, which means css-logical properties must constantly be re-interpreted (cascade-wise). It is added in preparation of reworking how css-logical properties works in StyleCascade. Change-Id: Id2b882cbfa3a58f9bb62b41fde16ce66d1ea0f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162926Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#761962}
-
David Bertoni authored
The WaitForExtensions* member functions return a mix of scoped_refptr<const Extension> and bare pointers. This CL makes the return types consistent. This is necessary for proper Extension instance lifetime management. Bug: 1073567 Change-Id: I584da49d9c9a7924ef63e5e52fd565175e5bd1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161380Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#761961}
-
Mark Yacoub authored
This reverts commit 28d8162b. Reason for revert: Getting DRM connector causes a significant delay when HDMI is connector to Kled. This code is not in use at the moment as Rendering Buffer Compression is not currently enabled on Intel devices. Original change's description: >Disable Render Buffer Compression on external displays. > >When Getting format modifiers, exclude I915_FORMAT_MOD_Y*_TILED_CCS >(Intel color control surface (CCS) for render compression) if it's not >an internal display. >This solves the bandwidth issue when driving more than 1 4K monitor with >rbc enabled. > >BUG=996011,996036,994341,979736 >TEST=HardwareDisplayControllerTest.ModifiersWithConnectorType > >Change-Id: I31ce046fb20557eb66340bdf131efa1437bd7484 >Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918941 >Commit-Queue: Mark Yacoub <markyacoub@google.com> >Commit-Queue: Daniele Castagna <dcastagna@chromium.org> >Reviewed-by: Daniele Castagna <dcastagna@chromium.org> >Cr-Commit-Position: refs/heads/master@{#715717} BUG=979736,b/146874982 Change-Id: I3083e08501ef91cb395c4e2f3940d0a5cbcfd1de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159758Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#761960}
-
Gauthier Ambard authored
Tests are failing on EG2 upstream. Bug: 1073932 Change-Id: I6397f83d02ed047593771c485fbad057103261e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162752Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#761959}
-
Noel Gordon authored
Look for one '-' instead of two '--', to process program options. Some users have old habits like typing -? for help, for example. Bug: 798943 Change-Id: I6d757b161ffb2082c8ad0a96e41a31f479969a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160955Reviewed-by:
Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#761958}
-