- 26 Nov, 2019 40 commits
-
-
Jiewei Qian authored
Bug: 1021813 Change-Id: Ie148398f2e670164c3acd82c666335c9d2a71781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921600 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#719087}
-
Jiewei Qian authored
Report system web app install error codes by profile category. Also report CRX Install errors (if occurs) and DisableReason if SWA is disabled somehow. Bug: 1021813 Change-Id: Id46bc63e451784b7ddf1d3bb8628af91bec98c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921599 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platforms where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: Ie59fa348b9715a95c1030a66d0316897f967e360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930822 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#719085}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: I3c96dc4acd12ed1bb848b384086065afa52e9149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930825 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#719084}
-
Antonio Gomes authored
BUG=78725 R=guidou@chromium.org Change-Id: Ib20bee0a0267a89a6f551c5b746063212b227edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933486Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#719083}
-
Tim Schumann authored
It's flaky on Win7 (32) builders. BUG: 1025335 TBR=msarda@chromium.org,svenzheng@google.com Change-Id: Ib9eb763d27ecee548b965c9829ae7d6e8da72244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936213Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#719082}
-
Carlos IL authored
The existing 'Insecure Content' setting will now disable autoupgrades for passive mixed content in sites it is set. This CL also removes support for the opt-out header. Bug: 988921, 1009562 Change-Id: I70734629d0f0a13d782a84ee75466c204992f8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929775 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#719081}
-
Ramin Halavati authored
Missing annotation in weblayer/browser/content_browser_client_impl.cc is blocking network traffic annotation trybots and is removed from tests until it is updated. Change-Id: Iafdf5ad8f2e5273cd8a23f138c3aa35a5b00a9c3 TBR: nicolaso@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936307Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#719080}
-
Jochen Eisinger authored
Bug: 873178 Change-Id: Ib1f56707705847f85df1f691cd01b33d4c7fb3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934331 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#719079}
-
Chris Lu authored
This change introduces InfobarTranslateSelectLanguageTableViewController to allow the user to change either the source or target language. It is populated by the InfobarTranslateLanguageSelectionConsumer protocol, and will use InfobarTranslateLanguageSelectionDelegate to send signals back to the coordinator about user selections. Bug: 1014959 Change-Id: Ibd6705ffac0f1beb924bc7170db353450b56343b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926134 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#719078}
-
Yuta Kasai authored
This patch is a part of FetchEvent WorkerTiming patches. This feature enables a service worker to attach PerformanceMark/PerformanceMeasure timings to a request during the fetch event handler. The timings will then be exposed to the page using blink::PerformanceResourceTiming. This patch prepares for passing a Mojo pending receiver for WorkerTimingContainer to blink::PerformanceResourceTiming. In order to identify a Mojo receiver corresponding to a FetchEvent, WebWorkerFetchContextImpl has a map from |request_id| to a pending receiver. This patch adds a method to take a Mojo pending receiver from content::WebWorkerFetchContextImpl. It's used to pass Mojo pending receivers to blink::PerformanceResourceTiming in later patches. Explainer : https://github.com/wanderview/fetchevent-worker-timing/blob/master/explainer.md Design doc: https://docs.google.com/document/d/1-ebnv7OFiVd3k2-jbtQGO5s3BKHIp7lRx3ujhgNKvB0 Bug: 900700 Change-Id: I3d1119362b2eabbce4df1d709f392a87ba42cc18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924343 Commit-Queue: Yuta Kasai <yutakasai@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719077}
-
Ricky Liang authored
GpuVideoAcceleratorFactories::SharedImageInterface returns nullptr when the GL context cannot be created or is lost. Bug: 982201 Bug: b:144805331 Change-Id: Ie97eb8c2a962c024a8acc6f1248ce5b4f5def0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932146Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1a549754468c..070dba7c5d32 Created with: gclient setdep -r src-internal@070dba7c5d32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Id6b785ad9c7b56448071a66daa19ac2cbc59cde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936116Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719075}
-
Hitoshi Yoshida authored
Implements Create() that creates a Blink object from a V8 object. In case we have an exception internally, Create() returns a nullptr. Bug: 839389 Change-Id: Iaebd4c1b2a7e9f510eed7a0d13bb5cd7999e9591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911799 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#719074}
-
Colin Blundell authored
Currently, user_prefs::UserPrefs::Get() is only needed within the context of WebLayer's safe browsing implementation on Android. However, it will shortly also be needed by WebLayer's SSL implementation (when we change that implementation to be based on the shared //components-level one rather than being a fork). SSL interstitials run on all platforms (concretely, Linux as well as Android). In preparation for that change, this CL moves the creation and ownership of WebLayer's user prefs service into BrowserContextImpl. This change both ensures that the PrefService is created and registered on all platforms rather than only Android and also aligns WebLayer with how user pref service creation and ownership is structured in other embedders in which user_prefs::UserPrefs::Get() is broadly used (e.g., Android WebView and Chrome). Bug: 1026591 Change-Id: Ibab57af127aca76f3944389896f538b1f2571e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930658Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#719073}
-
Martin Robinson authored
Similar to what happens for the Windows port, the AuraLinux accessibility implementation should walk up the transient window chain when returning parents of dialogs in transient windows. This fixes an issue where bubbles show up twice in the accessibility tree and where bubbles did not return their frame parents when calling atk_object_get_parent. Bug: 1024342 Change-Id: I15fc2db6c6d21a7368eae92798127e597ba8b0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919930 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#719072}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1f0fda29b7e8..e705827b369b git log 1f0fda29b7e8..e705827b369b --date=short --first-parent --format='%ad %ae %s' 2019-11-26 fancl@chromium.org Keep working directory clean 2019-11-26 dberris@chromium.org Vendor d3.js v5 Created with: gclient setdep -r src/third_party/catapult@e705827b369b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986772 Tbr: skyostil@google.com Change-Id: I728be8b1bf4fd248b766a1f01c81770fa3264b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936112Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719071}
-
Fredrik Söderquist authored
Rather than having |current_value_| be null when an animation is not active, have it point to the same value as |base_value_|. This avoids having to null-check |current_value_| for each access (in CurrentValue). Bug: 1017723 Change-Id: I39c56ec30ee9c92692db4f68be49a8094bf012b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932542Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#719070}
-
Yu-Hsuan Hsu authored
The change is related to CL:1926067. Add histogram information in histograms.xml to make the histogram visible on chromedashboard. BUG=b:144818607 Change-Id: I54e33685aa4f792e3d2e2e2f99c822a3cdd34fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933848 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#719069}
-
Igor authored
When the user session is stopped, we don't have access to user logs anymore, yet it's important to have information on the reason why the session was stopped. BUG=chromium:1014538 TEST=Check that reason is logged at sign out. Change-Id: I2869b000db5750cafba8566f8d1e13cb1c2369c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871673 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#719068}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I9db46c2bd8737240c0ead624b46dcb00ac7affd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935642Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#719067}
-
David Munro authored
Bug: chromium:1024718 Test: Build + CQ Change-Id: Icd5642e66beb4512090295e673421b5e002505e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935572 Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#719066}
-
Yuta Kasai authored
This patch is a part of FetchEvent WorkerTiming patches. This feature enables a service worker to attach PerformanceMark/PerformanceMeasure timings to a request during the fetch event handler. The timings will then be exposed to the page using blink::PerformanceResourceTiming. This patch prepares for passing a Mojo pending receiver for WorkerTimingContainer to blink::PerformanceResourceTiming. In order to identify a Mojo receiver corresponding to a FetchEvent, ServiceWorkerProviderContext has a map from |request_id| to a pending receiver. This patch adds a method to take a Mojo pending receiver from content::ServiceWorkerProviderContext to blink::ResourceFetcher. It's used to pass Mojo pending receivers to blink::PerformanceResourceTiming in later patches. There are two main changes. 1. A callback and a task runner in content::ServiceWorkerSubresourceLoaderFactory - A Mojo pending receiver to pass entries for workerTiming is stored in content::ServiceWorkerProviderContext when FetchEvent is dispatched from the subresource loader. 2. blink::FetchContext::TakePendingWorkerTimingReceiver() - Eventually blink::ResourceFetcher::HandleLoaderFinish() will take the Mojo pending receiver stored in content::ServiceWorkerProviderContext through blink::FrameFetchContext. Explainer : https://github.com/wanderview/fetchevent-worker-timing/blob/master/explainer.md Design doc: https://docs.google.com/document/d/1-ebnv7OFiVd3k2-jbtQGO5s3BKHIp7lRx3ujhgNKvB0 Bug: 900700 Change-Id: Idafcfe10fd4c718b063bb26d23309e105dcb1ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909676 Commit-Queue: Yuta Kasai <yutakasai@google.com> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I9181ef6b5abc33cdcebc3d0159b84a6d9434bab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934188Reviewed-by:
-
Tim Schumann authored
This reverts commit 492c7591. Reason for revert: Times out on Win7 tests (dbg) Link to instance: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/80319 From the logs: [ RUN ] CleanerSandboxInterface.DeleteService_HandleHeld ../../chrome/chrome_cleaner/engines/broker/cleaner_sandbox_interface_unittest.cc(809): error: Value of: service_handle.StartService() Actual: false (Failed to start 2E684A79ADD8581E0F0A57FB8FBF785B:The service did not respond to the start or control request in a timely fashion. (0x41D)) Expected: true Stack trace: Backtrace: base::debug::StackTrace::StackTrace [0x73FFA092+34] (o:\base\debug\stack_trace.cc:203) StackTraceGetter::CurrentStackTrace [0x0070905A+90] (o:\third_party\googletest\custom\gtest\internal\custom\stack_trace_getter.cc:24) testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x0071DDCA+74] (o:\third_party\googletest\src\googletest\src\gtest.cc:820) testing::internal::AssertHelper::operator= [0x0071D93B+75] (o:\third_party\googletest\src\googletest\src\gtest.cc:397) [ FAILED ] CleanerSandboxInterface.DeleteService_HandleHeld (312 ms) Original change's description: > Re-enable DeleteService_HandleHeld test > > crrev.com/c/1919544 is the potential fix for the test. > I have to enable the test to see if it really can fix > the test and then enable more disabled tests. > > Bug: 956016 > Change-Id: I9448cb928edf50e131e8c1c5886e7d26437b0aaa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928129 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718748} TBR=joenotcharles@chromium.org,svenzheng@chromium.org Change-Id: Ie64b3260ce0cefc21a62c9736bc869a120fb7733 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 956016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936267Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLDivElement> and DynamicTo<HTMLDivElement> as new downcast helper 2. Use IsA<HTMLDivElement>(element) in place of IsHTMLDivElement(element) Bug: 891908 Change-Id: Icf2b04b39e87af309a7fc5d66fbd402ae8ed8b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930765Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#719062}
-
Tim Schumann authored
This reverts commit 701b32b0. Reason for revert: Breaks Accessibility tests on Win7. Original change's description: > Include raw view elements in UI Automation tree dumps > > While working on tuning which nodes we include in the UI Automation > control and content views, I discovered that our tree dumper was only > dumping nodes in the control view. This CL applies a filter to dump the > raw view, which is a superset of the control view, giving us dumps that > are more complete. > > R=iapres@microsoft.com > > Bug: 1028345 > Change-Id: I98d53285abb77eb8490903f85a2c21e63e1f8c33 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935027 > Reviewed-by: Ian Prest <iapres@microsoft.com> > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#718915} TBR=kbabbitt@microsoft.com,iapres@microsoft.com Change-Id: I6052bbdb112189983433aed93dabf55db8e60cc6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028345,1028520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936247Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<HTMLDetailsElement>(element) in place of IsHTMLDetailsElement(element) Bug: 891908 Change-Id: Ibb0f5851d3f9649bd542635e88094a64ef4bbac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930764 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719060}
-
Kenichi Ishibashi authored
This is a follow-up CL of crrev.com/c/1933836. Remove deprecated ToInternalValue(). Instead, use TimeDelta::InMicroseconds(). Bug: 634507 Change-Id: I23ea205b77b910eee60e122b9374ffd501032be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935968Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b29f9faf. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" f5ab855c "Mark external/wpt/cookies/http-state/path-tests.htm as slow test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I6ad55ae0a752439e01c87d6d83b3aed8a5669657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935450Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719058}
-
Sergey Talantov authored
Since ContainerView was eliminated here: https://chromium-review.googlesource.com/c/chromium/src/+/1644758, manual call of CreateExampleView is required now. But for extra examples it is not called. BUG=1026180 Change-Id: I891c6099ff742110b62d870236acfcc25039579a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926131Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#719057}
-
Simon Que authored
Bug: 1025325 Change-Id: I463c52370c8eec7f7fd21a6cb7fa525918c3bb1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933830Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#719056}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a207daa8b57f..1a549754468c Created with: gclient setdep -r src-internal@1a549754468c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I18d5afafc67c3448b50eae2b93d3b94f4efebe47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936104Reviewed-by:
-
Jeonghee Ahn authored
This patch extend the previous patch below. (https://chromium-review.googlesource.com/c/chromium/src/+/1461355) If an element has a mouseover or mouse enter handler of some sort, There's something for the user to interact with. So it is reasonable to tell it could be focusable element. And this is also related to the patch below. (https://chromium-review.googlesource.com/c/chromium/src/+/1557870) Moving with SpatNav triggers a mouseover event. Conversely, some element having mouseover handler could be focusable. In this patch, element having mouseover or mouseenver event handler can be focusable. Change-Id: I3f338253ab8aa137a7b9fb5f6e35e324b2ee72c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859535 Commit-Queue: Jeonghee Ahn <jeonghee27.ahn@lge.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719054}
-
Tsuyoshi Horo authored
Bug: 1018640 Change-Id: Ic504359898ec4e6b4f7bc18876dafeb0378c192f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930250Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#719053}
-
Hajime Hoshi authored
This CL allows pages with media (HTMLMediaElement) to use back-forward cache. Bug: 1024794 Change-Id: Ib6f4835a7835a959d55f036bf6cde0672c7c7a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916522 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#719052}
-
Hans Wennborg authored
This reverts commit 0ff2da3a. Reason for revert: The new warning was reverted upstream (see bug). Original change's description: > Disable -Wdeprecated-copy with tip-of-tree Clang > > while we figure out how to handle this new warning. > > TBR=rnk > > Bug: 1028110 > Change-Id: I88be5c763bd0f2fcb40ebecc20990f96853d70c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932804 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718651} TBR=hans@chromium.org,rnk@chromium.org Change-Id: I0e0babea932ff9ae3fd92530cc96e1c6547429a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935111Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#719051}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3e7af41224ee..40a7dfc268b6 git log 3e7af41224ee..40a7dfc268b6 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e9b68f332a30..f65b212492ec (10 commits) 2019-11-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 0ec8ef3c..92fe999a (465 commits) 2019-11-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d44d61514749..f2637d0dd7eb (9 commits) Created with: gclient setdep -r src/third_party/skia@40a7dfc268b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None,chromium:None Tbr: bungeman@google.com Change-Id: I6993852ac1cf33c928d214562c0b97cf56583c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936094Reviewed-by:
-
Sergio Villar Senin authored
It was used to represent undefined values. We can easily remove it by making time_to_next_iteration_ an Optional<double>. Undefined values are now represented by base::nullopt. Bug: 737867 Change-Id: Ic216b56eb304091ce22b3bb336981c85fb246236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932554Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#719049}
-
liberato@chromium.org authored
This checks to see if |current_buffer_| has been cleared in DoDecode while looping over it. I don't see any path that would clear it without breaking out of that loop, except possibly for the reentrant DoDecode call in ReceivePictureBuffersFromClient. The trouble is that I don't believe that call can be reached without at least one post. If this fixes the problem, then more investigation is needed. Bug: 1012464 Change-Id: I72a7ad5e42c0ff2490831cbf4ac0bb62808c0d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935862 Auto-Submit: Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#719048}
-
