GitLab

This CL removes the code used by FindInPage pre-UI Refresh.

Bug: 800266, 879136
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I1b3ee786c19cebd54dc641fb7a7d71f5d4b1b8b6
Reviewed-on: https://chromium-review.googlesource.com/1233836
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592716}

The following preferences are removed from the persistent storage list
for incognito mode:
 - kClearedBlockedSiteNotificationChannels
 - kDRMSalt
 - kEnableDoNotTrack
 - kEnableDRM
 - kEnableHyperlinkAuditing
 - kEnableEncryptedMedia
 - kMediaStorageIdSalt
 - kPushMessagingAppIdentifierMap

These preferences are either never changed from incognito mode, or if
changed, they do not need to be written to user profile.

Bug: 861722
Change-Id: I52437e7ef3a141babb1a797092d3ae316a059761
Reviewed-on: https://chromium-review.googlesource.com/1233354
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592715}

DriveFS system service now supports search. Plumb IPCs to invoke it from
chrome and implement drive search when DriveFS flag is on.

BUG=chromium:854481

Change-Id: If62c1dc1e7da504e348e1056b983e5febc45f855
Reviewed-on: https://chromium-review.googlesource.com/1229715
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592714}

This CL removes the code used only by the old UI in the Toolbar
Button Factory.
In order to keep compilation intact, the methods are emptied, they are
not removed.

Bug: 800266
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id74766e69c9f06a7e44fa2c669789a4bc9822675
Reviewed-on: https://chromium-review.googlesource.com/1230677Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592713}

This CL removes the pre-UIRefresh code in BubblePresenter.

Bug: 884724
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia894f9c97f2d5b2d0b5aa26356aba3c471a05522
Reviewed-on: https://chromium-review.googlesource.com/1233703Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592712}

This removes some unnecessary abstractions and helps
with mojoification of Blink accessibility, and eventually
will help us to remove all of the code in
content/renderer/accessibility.

Bug: 882660
Change-Id: I504876e4ec5d7a50c439031b66c3d8d2525109e9
Reviewed-on: https://chromium-review.googlesource.com/1226200
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592711}

Invisible-static custom elements are still upgraded when they are
constructed through HTML parser. To make it clear, we are adding test
to confirm this behavior. This CL also make the previous test's
custom element constructor to not append a child to verify upgrades.

Previous change that defer upgrades of invisible="static" elements:
https://chromium-review.googlesource.com/c/chromium/src/+/1204373

Bug: 873057
Change-Id: If25afa4c1c77ecd70988d3d29cc5ab020247b8ea
Reviewed-on: https://chromium-review.googlesource.com/1235265
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592710}

Audio Player was using Shadow DOM's polyfil, aka Shady DOM which is
included in Polymer1. Chrome has had a fully working native Shadow DOM
for quite a while. The remaining Polymer WebUI has already been using
native Shadow DOM.

This fix is to make Audio Player elements and tests compatible with
Polymer2, tests still require further work to pass in Polymer2.

Replace all occurrences of:
"chrome://resources/polymer/v1_0/polymer/polymer.html"
with:
"chrome://resources/html/polymer.html"

The new polymer.html configures Polymer 1.0 to run with ShadowRoot
making these polymer elements be compatible with Polymer 2.0.

Fix Audio Player tests:

1. Audio Player is compound of 3 main Polymer elements:
* "audio-player": main component which use the other 2 below.
* "control-panel": buttons to control, like play, pause, next, etc.
* "track-list": List of all tracks to be played.

2. Files app and Audio player test utils, has the ability to query
elements deep in the ShadowRoot, however it requires an Array of
selectors instead of a simple string selector. For every element that
has a ShadowRoot, we need to provide an element on the selector array.
E.g.:
['audio-player', 'control-panel', '.some-class']: Gets "audio-player"
then selects in its shadowRoot for "control-panel", then selects
".some-class" in "control-panel" shadowRoot.

3. Define "trackListQuery" and "controlPanelQuery" to make simpler to
traverse these 2 Polymer sub-components.

4. Fix all selectors to make explicit the component traversal.

Test: browser_tests --gtest_filter="AudioPlayer*:OpenAudioFiles*"
Bug: 875525
Change-Id: I64e94452ff4cc8eb51137620013ad0cf00101f67
Reviewed-on: https://chromium-review.googlesource.com/1226478Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592709}

For the same reason as the existing code to strip '/showIncludes'.

Change-Id: I8b9180434d7ebee41b67117ce27ae054ddc948a9
Reviewed-on: https://chromium-review.googlesource.com/1235259Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Owen Rodley <orodley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592708}

https://skia.googlesource.com/skia.git/+log/4054351369df..52c63fdabb72


git log 4054351369df..52c63fdabb72 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 25c541e51cbd..2ecc8b712b08 (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@52c63fdabb72

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=reed@chromium.org

Change-Id: If06af720e61d40da10c993a5c50ead203c6d27b8
Reviewed-on: https://chromium-review.googlesource.com/1235415Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592707}

Support multiple bindings in DeviceManagerImpl so that the Device
Service can own a unique DeviceManagerImpl instance easily and
the unique UsbService instance will be owned by DeviceManagerImpl,
then we can git rid of DeviceClient after all users being converted
to mojom interface.

Bug: 699790
Change-Id: I8a62739796f99a98bf87a1ed71562c09cba9e050
Reviewed-on: https://chromium-review.googlesource.com/1221475
Commit-Queue: Donna Wu <donna.wu@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592706}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/48093e2673c6..137cb973fb0e

$ git log 48093e267..137cb973f --date=short --no-merges --format='%ad %ae %s'
2018-09-18 nverne Add VmStatus to StartVmResponse.

Created with:
  roll-dep src/third_party/cros_system_api

Bug: 884576
Change-Id: I14a5648257e09d87f35b5de0a735c614568cad22
Reviewed-on: https://chromium-review.googlesource.com/1235514Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592705}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/98555ca139f9..1c2f24da7847


Created with:
  gclient setdep -r src-internal@1c2f24da7847

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ieaae67a196b88a9417de0a5eeb11d00b9d05f257
Reviewed-on: https://chromium-review.googlesource.com/1235416Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592704}

This CL is a refactoring to remove PersistentHeapVector and its usage with Persistent<HeapVector>

design doc: https://docs.google.com/document/d/1yaPgNqed81gHm4nBQVJow6iiNaea5hDJSobNG_jkWg8/edit?usp=sharing

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I36b11b86ccfd0e0920d2ecf3a5575258a6d89c0a
Reviewed-on: https://chromium-review.googlesource.com/1218643
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592703}

This CL refines a previous test and the FakeServer so that it actually
tests what it is supposed to test.

The CL also does minor polish in the FakeServer code (so that I can
understand what is going on).

Double-checked by breaking the code.

Bug: 876308
Change-Id: I0885647c42ec029db0b76f998840c7378d3496c1
Reviewed-on: https://chromium-review.googlesource.com/1221311Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592702}

Use memory_instrumentation::OSMetrics::FillOSMemoryDump(), which
reads /proc/<pid>/statm, to get private bytes of a process, to avoid
contention with kswapd under heavy memory pressure.

BUG=chromium:872253
TEST=manual
R=cylee@chromium.org, sonnyrao@chromium.org, fdoray@chromium.org

Change-Id: I4d43933a39c3c89d8ebb81e3ccef20277cedb258
Reviewed-on: https://chromium-review.googlesource.com/1212246
Commit-Queue: Chinglin Yu <chinglinyu@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Cheng-Yu Lee <cylee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592701}

Supervised users have been gone for a long time.

Bug: 828890
Change-Id: I18b12e49ac10c445eabc7151e7f3b7995b5fa24d
Reviewed-on: https://chromium-review.googlesource.com/1231314
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592700}

It doesn't really do anything useful: It provides an observer mechanism
which only passes through SyncServiceObserver::OnStateChanged (so anyone
interested might just use that directly), and it has single, misnamed
method HasError() which is replaced by a global ShouldShowPassphraseError
helper.

Bug: none
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I0116b6cf5d3a814bc2b3fa51e79da7a3c2eebc63
Reviewed-on: https://chromium-review.googlesource.com/1230056Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592699}

This is almost the same cl as
https://chromium-review.googlesource.com/c/chromium/src/+/1226715

The previous cl was reverted because it broke linux-chromeos-dbg due to missing
"=0" for a virtual method of an abstract class (incorrect gn config meant the
compiler didn't pick it up). It's added in this cl. This is
the only change from the previous cl.

Bug: 881215
Change-Id: Iaf5ab6e3ee98c11b593dcc9d759527c4fb3b2168
Reviewed-on: https://chromium-review.googlesource.com/1235262Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592698}

This is a follow-up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1229739

Bug: 870606
Change-Id: I0b877b3b611e9696e9d8fe38c8091ec8fbe5b304
Reviewed-on: https://chromium-review.googlesource.com/1233102Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592697}

Adds ART build tools used for android builds, in particular
dexlayout and associated profile management.

Bug: 875276
Change-Id: I323e460dfca032a5b28a634d149d1f50c8563f3b
Reviewed-on: https://chromium-review.googlesource.com/1218584Reviewed-by: Grace Kloba <klobag@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592696}

MediaRouterDialogControllerViewsTest.OpenCloseMediaRouterDialog is failing
on the mac bot. The error logs are:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-cocoa-rel/1321
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8935002203177419984/+/steps/browser_tests_on__none__GPU_on_Mac/0/logs/MediaRouterDialogControllerViewsTest.OpenCloseMediaRouterDialog/0

Tbr: mfoltz@chromium.org
Bug: 883976
Change-Id: I9b7e42b65ec44a97a74d236c179e1698ef0c895e
Reviewed-on: https://chromium-review.googlesource.com/1235264Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592695}

ui::MenuModel (which ui::SimpleMenuModel inherits from) declares a
virtual method, `void MenuWillShow()`. SimpleMenuModel::Delegate
declares a similar method, `void MenuWillShow(SimpleMenuModel*)`. This
results in a conflict for any class that inherits from both
SimpleMenuModel and SimpleMenuModel::Delegate (which is not uncommon).

Resolve this by renaming the SimpleMenuModel::Delegate version to
`void SimpleMenuWillShow(SimpleMenuModel*)`.

Bug: 885198
Change-Id: I0581991fa7a12368007f6c082c461acb4833750c
Reviewed-on: https://chromium-review.googlesource.com/1230581Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592694}

The original CL has been reverted because it failed on USB browser
tests for the race condition between UsbDeviceManager::SetClient()
and UsbDeviceManagerClient::OnDeviceRemoved/Added() events.

Before this CL, two client bindings from UsbDeviceManager to Blink
have been made associated and a earlier connection is set up before
all requests to UsbDeviceManager in this CL.

The original CL's description:
> For UsbService::Observer, "OnDeviceRemovedCleanup" needs to be handled
> after "OnDeviceRemoved". But for mojom interface UsbDeviceManager,
> there is no way to provide such dependency among listeners.
>
> As all users will be converted from UsbService to UsbDeviceManager,
> to avoid the potential race condition, WebUsbServiceImpl is made
> listen to UsbChooserContext in this CL.
>
> Bug: 699790
> Change-Id: I1e3b45196552e987b7422b127651e1fb01e1618b
> Reviewed-on: https://chromium-review.googlesource.com/1210386

Bug: 699790
Change-Id: Ied803bf1e3b0fcc8daad14f6acd4a6d3ca98129f
Reviewed-on: https://chromium-review.googlesource.com/1226824
Commit-Queue: Donna Wu <donna.wu@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592693}

And remove yamaguchi.

BUG=None

Change-Id: Icac3b856995fb0b60b0b309825852715de99059b
Reviewed-on: https://chromium-review.googlesource.com/1235357Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592692}

This reverts commit 16355cba.

Reason for revert:
This seems to cause an ASAN failure on the CI. The error logs are:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29069
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934902171469785040/+/steps/interactive_ui_tests/0/logs/DownloadNotificationTest.IncognitoDownloadFile/0

Original change's description:
> More OfflineItemModel implementation
> 
> This CL makes OfflineItemModel inherit from DownloadUIModel
> 
> Bug: 881499
> Change-Id: I63270a79917bae87fdb4ae3531f9088f7900509e
> Reviewed-on: https://chromium-review.googlesource.com/1225888
> Commit-Queue: Min Qin <qinmin@chromium.org>
> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592645}

TBR=qinmin@chromium.org,shaktisahu@chromium.org

Change-Id: Ifdae8934bae3cf137fd2e4729f076f8df577241d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 881499
Reviewed-on: https://chromium-review.googlesource.com/1234099Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592691}

Make the initialization promise await DOMContentLoaded and then apply
i18n transforms to the video player DOM [1].

Minor: correct commentary, add commentary. Add assertions re document
readyState when the i18n template strings are applied.

[1] Applying i18n strings to an incomplete (readyState === 'loading')
DOM document makes no sense at all.

Test: browser_tests --gtest_filter="VideoPlayerBrowserTest*"
Bug: 884963
Change-Id: Ie5a25763c54c56e949edde40c7e06b8eaad230c4
Reviewed-on: https://chromium-review.googlesource.com/1233394
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592690}

BUG=875700

Change-Id: I8d54318dd4247d655d1e57d5d2dd358769082b83
Reviewed-on: https://chromium-review.googlesource.com/1235358Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592689}

Change-Id: I06fa719a2480e45d8a5d236210f7ae6243471e7e
Reviewed-on: https://chromium-review.googlesource.com/1235360
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#592688}

This reverts commit 310c1d6c.

Reason for revert:
This seems to cause a build failure on linux-chromeos-dbg.
The failure logs are below.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7896
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934907190108326448/+/steps/compile/0/logs/raw_io.output_failure_summary_/0

Original change's description:
> [On-device adaptive brightness] Create a BrightnessMonitor.
> 
> BrightnessMonitor receives brightness change signals from powerd and
> sends out notifications if the change is requested by user. We use
> this class instead of powerd directly because we need final/stablized
> user brightness instead of intermediate values (that are individually
> emitted by powerd). In order to wait for brightness to stablize, we
> use a timer that starts when a user brightness is detected and times
> out after a period of time if there's no more user brightness detected,
> or if the next brightness change is not triggered by the user.
> 
> BrightnessMonitor also notifies its observers as soon as a user
> brightness is detected so that an observer can decide what to do (e.g
> disable auto-adjustment).
> 
> Bug: 881215
> Change-Id: I2d9aefd8ff48eab37de9527d12657fd4dfeba793
> Reviewed-on: https://chromium-review.googlesource.com/1226715
> Reviewed-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Michael Martis <martis@chromium.org>
> Commit-Queue: Jia Meng <jiameng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592605}

TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org

Change-Id: I5e88966455c8bfab9e089580a0ba622c1a2c6026
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 881215
Reviewed-on: https://chromium-review.googlesource.com/1235260Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592687}

InstanceCountersMemoryDumpProvider.cc was not renamed as
snake case with no reason.

Bug: 768828
Change-Id: Icf323d551341647dd7d3beb637f949f3053c95a5
Reviewed-on: https://chromium-review.googlesource.com/1235354Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#592686}

Invalid timestamps can occur when a stream is closed. These timestamps
are represented by the minimum value of an int64. This change catches
this value and stops interpretting it as a valid timestamp. The
rendering pipeline was crashing when receiving negative timestamps.

Bug: b/115771591
Test: Play YT, Hit next/prev
Change-Id: I0809a9563aa1e865e4832cbecb6a54886a350f2f
Reviewed-on: https://chromium-review.googlesource.com/1235291Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Aidan Wolter <awolter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592685}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/75040d8b299c..98555ca139f9


Created with:
  gclient setdep -r src-internal@98555ca139f9

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I6515a4d2c5bca500a9b3c89418709c48059a2c42
Reviewed-on: https://chromium-review.googlesource.com/1235414Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592684}

The VAAPI JPEG decoder on some platforms won't convert the decoded images to the
I420 format, but will return the decoded images in their original pixel format.
This means a conversion must be done in the VAAPI wrapper to the expected I420
output format. This change adds a SamplingFormatChange test that will test
whether the conversion is successful for JPEGS with different sampling formats.

Additional cleanup:
* Added some comments for clarification

TEST=ran JDA tests on eve and grunt

Bug: 828119
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibade43422590268d774b8d330097e46a8a33bca1
Reviewed-on: https://chromium-review.googlesource.com/1218386Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592683}

Bug: 699790
Change-Id: I7fd6e119db118da8a00810e1015a4464d1a00cc4
Reviewed-on: https://chromium-review.googlesource.com/1224971Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Donna Wu <donna.wu@intel.com>
Cr-Commit-Position: refs/heads/master@{#592682}

When HasEquivalentAttributes is called, Element object was passed as
a parameter.
and it is never nullptr. so it can be changed to reference instead of pointer.

Bug: 874385
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I237a11e88236ef195ade12ee26b0722786f17e29
Reviewed-on: https://chromium-review.googlesource.com/1232810Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#592681}

https://skia.googlesource.com/skia.git/+log/6c1a7f2c78db..4054351369df


git log 6c1a7f2c78db..4054351369df --date=short --no-merges --format='%ad %ae %s'
2018-09-20 fmalita@chromium.org [skottie] Add support for external font loading


Created with:
  gclient setdep -r src/third_party/skia@4054351369df

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=reed@chromium.org

Change-Id: I3ec23d5d0884e8a794775c966660a9e6ca4808f4
Reviewed-on: https://chromium-review.googlesource.com/1235328Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592680}

Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I6805cf73d89312072404297206de3fb6c0d044be

TBR=perezju@chromium.org

Change-Id: I6805cf73d89312072404297206de3fb6c0d044be
Reviewed-on: https://chromium-review.googlesource.com/1234355Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#592679}

Bug: internal b/115797741
Change-Id: Ib7d5c836a83ad43b44712ce86fb13f224be01823
Reviewed-on: https://chromium-review.googlesource.com/1234965Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Felipe Salazar <felipesalazar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592678}

Following bot results are included.
9841 9844 9847 9852 9854 9857 9863 9867 9874 9877

2 lines were removed and 0 lines were deflaked by consecutive
results since 9840.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ic57f641a46a9a1b1cddee362a58340d6e27962c8
Reviewed-on: https://chromium-review.googlesource.com/1233053
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592677}