GitLab

Change assert in RecentTabsPage.destroy(). It always failed when the RecentTabsPage was closed without opening a recent tab.

BUG=

Review-Url: https://codereview.chromium.org/2595933002
Cr-Commit-Position: refs/heads/master@{#442885}

Some compilers, including MSVC, don't consider std::atomic as a POD-
compatible type which makes it impossible to include them in persistent
memory when using the object interface -- something which is obviously
desireable.

New "object" management embeds the type directly in the class/struct
definition and runs the default constructor of the type after allocation,
thus making the allocator compatible with a much greater range of types.

BUG=546019

Review-Url: https://codereview.chromium.org/2578323002
Cr-Commit-Position: refs/heads/master@{#442884}

Including:
- Removes the "multi-install" crash key from setup.exe.
- Removes some dead test code.
- Removes duplicated code in IsActivelyUsedIn.

BUG=577816

Review-Url: https://codereview.chromium.org/2619963005
Cr-Commit-Position: refs/heads/master@{#442883}

The title text color was being changed on the VC, so we need to reset it as well.

BUG=674493

Review-Url: https://codereview.chromium.org/2627753002
Cr-Commit-Position: refs/heads/master@{#442882}

Updating frame selection currently requires clean layout, as it calls
mostBackwardCaretPosition through SelectionAdjuster. One code path that
violates it is from Editor::appliedEditing, which is fixed by this patch.

BUG=679616

Review-Url: https://codereview.chromium.org/2626933002
Cr-Commit-Position: refs/heads/master@{#442881}

BUG=672258

Review-Url: https://codereview.chromium.org/2586063002
Cr-Commit-Position: refs/heads/master@{#442880}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyPage from the switch statement in parseSingleValue, and
calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIPage.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIPage.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIPage.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2618523003
Cr-Commit-Position: refs/heads/master@{#442879}

R=haraken
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2625053002
Cr-Commit-Position: refs/heads/master@{#442878}

Review-Url: https://codereview.chromium.org/2625753002
Cr-Commit-Position: refs/heads/master@{#442877}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyOutlineOffset from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIOutlineOffset.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIOutlineOffset.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIOutlineOffset.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2610813004
Cr-Commit-Position: refs/heads/master@{#442876}

This CL changes the views sign-in dialod to be tab modal and keeps the
views sync confirmation dialog and the sign-in erorr dialogs as window modal.

BUG=677012

Review-Url: https://codereview.chromium.org/2619963003
Cr-Commit-Position: refs/heads/master@{#442875}

BUG=577816

Review-Url: https://codereview.chromium.org/2601443002
Cr-Commit-Position: refs/heads/master@{#442874}

Now that Navigator's Supplements can retrieve the Navigator object with host(),
those Supplements don't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2611133002
Cr-Commit-Position: refs/heads/master@{#442873}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dd4cb049..8ba45f77

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2625963002
Cr-Commit-Position: refs/heads/master@{#442872}

Disable the implicitly generated special functions that perform copies and moves
according to the Google C++ Style Guide.

BUG=None

Review-Url: https://codereview.chromium.org/2595313002
Cr-Commit-Position: refs/heads/master@{#442871}

- Remove |options| set.
- Remove InitializeFrom* methods.
- Remove unused SetChannelFlags method.

BUG=577816

Review-Url: https://codereview.chromium.org/2621923002
Cr-Commit-Position: refs/heads/master@{#442870}

A method that checks if files of deleted profiles still exist was added in http://crrev.com/2546523003. We decided that it is ok to call NukeProfileFromDisk without checking if the files still exist because it fails silently. But we also show a log message that says that there are still files. This cl adds a condition to check if profile files still exist to avoid showing the wrong log message.

BUG=236244

Review-Url: https://codereview.chromium.org/2622853002
Cr-Commit-Position: refs/heads/master@{#442869}

BUG=577816

Review-Url: https://codereview.chromium.org/2622883002
Cr-Commit-Position: refs/heads/master@{#442868}

R=yhirano@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2625573003
Cr-Commit-Position: refs/heads/master@{#442867}

Introduce a mechanism for an incoming QuicAllowed cloud policy
to control QUIC protocol usage for new streams even after
IOThread initialization.
NetPrefObserver has been re-introduced to observe the change
(after it was removed in crrev.com/2140733002 and
crrev.com/2172543003).

BUG=658454
TEST=browser_tests --gtest_filter=*QuicAllowed*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2546533003
Cr-Commit-Position: refs/heads/master@{#442866}

This flag can be removed because all policy test servers provide
verification signatures.

BUG=275291

Review-Url: https://codereview.chromium.org/2606423002
Cr-Commit-Position: refs/heads/master@{#442865}

Otherwise, the painting will not take into consideration the new
value.

BUG=677903

Review-Url: https://codereview.chromium.org/2616343004
Cr-Commit-Position: refs/heads/master@{#442864}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2627453003
Cr-Commit-Position: refs/heads/master@{#442863}

BUG=554298

Review-Url: https://codereview.chromium.org/2625903003
Cr-Commit-Position: refs/heads/master@{#442862}

https://chromium.googlesource.com/chromium/src/+/c5291a0115a65

BUG=588060
TBR=joone.hur@intel.com

Review-Url: https://codereview.chromium.org/2628823002 .
Cr-Commit-Position: refs/heads/master@{#442861}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyOffsetPosition from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIOffsetPosition.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIOffsetPosition.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIOffsetPosition.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2613863002
Cr-Commit-Position: refs/heads/master@{#442860}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2627633002
Cr-Commit-Position: refs/heads/master@{#442859}

BUG=671585
TEST=download tgz file, and confirm that double-clicking the tgz file shows suggestions about extensions.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2553003003
Cr-Commit-Position: refs/heads/master@{#442858}

BUG=678688, 680007, 680008

Review-Url: https://codereview.chromium.org/2623853002
Cr-Commit-Position: refs/heads/master@{#442857}

Stop loading destroys the pending entry which leads to a crash in release.
Remove the call to stop.

BUG=679721

Review-Url: https://codereview.chromium.org/2623583005
Cr-Commit-Position: refs/heads/master@{#442856}

In HTMLAnchorElement::attributeChanged,

    params.name != hrefAttr && isLink()

should have been

    params.name != hrefAttr || isLink()

This CL fixes it, and improves code readability.

BUG=679669

Review-Url: https://codereview.chromium.org/2623163002
Cr-Commit-Position: refs/heads/master@{#442855}

This patch moves implementations of |Document::execCommand()| and
|queryCommand*()| to "DocumentExecCommand.cpp" from "Document.cpp" to avoid
including "core/editing/Editor.h" in "Document.cpp" and reduce source code size
for making compilation of "Document.cpp" faster.

BUG=258591
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2628753002
Cr-Commit-Position: refs/heads/master@{#442854}

BUG=670455

Review-Url: https://codereview.chromium.org/2624763002
Cr-Commit-Position: refs/heads/master@{#442853}

Override location of machine-local policy directory for both unit tests
and browser tests. This makes sure that any policy data the machine has
does not affect the test results.

BUG=630614

Review-Url: https://codereview.chromium.org/2612733003
Cr-Commit-Position: refs/heads/master@{#442852}

1) Make title row is 1dp bigger and text shifted down 2dp.
2) Make bottom row (tiles of icons) 1dp bigger.

BUG=663199
TEST=Verfied on local build.

Review-Url: https://codereview.chromium.org/2592583002
Cr-Commit-Position: refs/heads/master@{#442851}

This CL creates the Suggestions UI with a Collection View.

BUG=679369

Review-Url: https://codereview.chromium.org/2619353004
Cr-Commit-Position: refs/heads/master@{#442850}

Before this, the method existed on NewTabPageManager, but was never
actually called.

BUG=yeah

Review-Url: https://codereview.chromium.org/2613863007
Cr-Commit-Position: refs/heads/master@{#442849}

BUG=673904
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2619233005
Cr-Commit-Position: refs/heads/master@{#442848}

BUG=679349

Review-Url: https://codereview.chromium.org/2627663002
Cr-Commit-Position: refs/heads/master@{#442847}

Supports V8<Type>Partial::preparePrototypeAndInterfaceObject.

BUG=

Review-Url: https://codereview.chromium.org/2620013002
Cr-Commit-Position: refs/heads/master@{#442846}