GitLab

https://bugs.webkit.org/show_bug.cgi?id=66428

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView _setDrawingAreaSize:]): Made this file internal.
* UIProcess/API/mac/WKViewInternal.h: Removed _setDrawingAreaSize.
* UIProcess/DrawingAreaProxy.h: Made sizeDidChange private.


git-svn-id: svn://svn.chromium.org/blink/trunk@93337 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66456

Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
Reviewed by Adam Barth.

Spec is here: http://www.w3.org/TR/WebIDL/#es-operations.

Source/WebCore:

Test: fast/workers/worker-constructor.html

* bindings/js/JSWorkerCustom.cpp:
(WebCore::JSWorkerConstructor::constructJSWorker): Changed SyntaxError to TypeError.
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::V8Worker::constructorCallback): Changed SyntaxError to TypeError.

LayoutTests:

* fast/workers/worker-constructor-expected.txt: Changed SyntaxError to TypeError.

git-svn-id: svn://svn.chromium.org/blink/trunk@93336 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66445

Patch by John Bates <jbates@google.com> on 2011-08-18
Reviewed by Kenneth Russell.

* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::setTextureUpdated):

git-svn-id: svn://svn.chromium.org/blink/trunk@93335 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66250

Reviewed by Eric Seidel.

Convertikng the RenderTextControl* classes to use the LayoutUnit abstraction.

No new tests as no change in behavior.

* rendering/LayoutTypes.h:
(WebCore::layoutMod): Added a function to perform the modulo operation on LayoutUnits.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::hitInnerTextElement):
* rendering/RenderTextControl.h:
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::preferredContentWidth):
(WebCore::RenderTextControlMultiLine::baselinePosition):
* rendering/RenderTextControlMultiLine.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):
* rendering/RenderTextControlSingleLine.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@93334 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66239

Reviewed by Eric Seidel.

Converting inline rendering classes to use the LayoutUnit abstraction from ints.

No new tests as no change in functionality.

* rendering/InlineBox.h:
(WebCore::InlineBox::logicalFrameRect):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::logicalOverflowRect):
(WebCore::InlineTextBox::setLogicalOverflowRect):
(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::logicalTopVisualOverflow):
(WebCore::InlineTextBox::logicalBottomVisualOverflow):
(WebCore::InlineTextBox::logicalLeftVisualOverflow):
(WebCore::InlineTextBox::logicalRightVisualOverflow):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::culledInlineAbsoluteRects):
(WebCore::computeMargin):
(WebCore::RenderInline::culledInlineBoundingBox):
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):
(WebCore::RenderInline::lineHeight):
(WebCore::RenderInline::baselinePosition):
(WebCore::RenderInline::addDashboardRegions):
* rendering/RenderInline.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@93333 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66408

Reviewed by Adam Barth.

* xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processDOCTYPE):


git-svn-id: svn://svn.chromium.org/blink/trunk@93332 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66481

Reviewed by Alexey Proskuryakov.

Add a regression test since this bug has been fixed by r92695.

* editing/pasteboard/paste-delete-insertion-position-skip-paragraph-expected.txt: Added.
* editing/pasteboard/paste-delete-insertion-position-skip-paragraph.html: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@93331 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[WebWorkers][Chromium] Use v8 Isolates for in-process implementation of WebWorkers.
This adds an implementation of in-process dedicated workers to chromium port.
The crux of the matter is the reimplementation of WebWorkerClientImpl. WebWorkerClientImpl now
implements all three of Worker{Loader,Context,Object}Proxies and delegates the implementation to
WebKit's standard WorkerMessagingProxy.
For now, we have 3 implementations of workers in chromium WebKit:
  - In-process dedicated workers (this checkin)
  - Inter-process shared workers
  - Inter-process dedicated workers (defunct after this checkin)
This patch extracts some new common interfaces (NewWebWorkerBase and NewWebWorkerClient) for these
three implementations.
Removing the remainings of inter-process dedicated workers -related classes is left for a separate patch
(it will require coordinated changes on chromuium side).

Reviewed by David Levin.

* public/WebCommonWorkerClient.h:
* src/DatabaseObserver.cpp:
(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):
* src/LocalFileSystemChromium.cpp:
(WebCore::openFileSystemHelper):
* src/WebSharedWorkerImpl.h:
(WebKit::WebSharedWorkerImpl::newCommonClient):
* src/WebWorkerBase.h:
(WebKit::WebWorkerBase::view):
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::createWorkerContextProxy):
(WebKit::WebWorkerClientImpl::startWorkerContext):
(WebKit::WebWorkerClientImpl::terminateWorkerContext):
(WebKit::WebWorkerClientImpl::postMessageToWorkerContext):
(WebKit::WebWorkerClientImpl::hasPendingActivity):
(WebKit::WebWorkerClientImpl::workerObjectDestroyed):
(WebKit::WebWorkerClientImpl::connectToInspector):
(WebKit::WebWorkerClientImpl::disconnectFromInspector):
(WebKit::WebWorkerClientImpl::sendMessageToInspector):
(WebKit::WebWorkerClientImpl::postMessageToPageInspector):
(WebKit::WebWorkerClientImpl::postTaskToLoader):
(WebKit::WebWorkerClientImpl::postTaskForModeToWorkerContext):
(WebKit::WebWorkerClientImpl::postMessageToWorkerObject):
(WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject):
(WebKit::WebWorkerClientImpl::reportPendingActivity):
(WebKit::WebWorkerClientImpl::workerContextClosed):
(WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
(WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject):
(WebKit::WebWorkerClientImpl::workerContextDestroyed):
(WebKit::WebWorkerClientImpl::allowFileSystem):
(WebKit::WebWorkerClientImpl::openFileSystem):
(WebKit::WebWorkerClientImpl::allowDatabase):
(WebKit::WebWorkerClientImpl::dispatchDevToolsMessage):
(WebKit::WebWorkerClientImpl::view):
(WebKit::WebWorkerClientImpl::WebWorkerClientImpl):
(WebKit::WebWorkerClientImpl::~WebWorkerClientImpl):
* src/WebWorkerClientImpl.h:
(WebKit::WebWorkerClientImpl::newCommonClient):
* src/WebWorkerImpl.cpp:
(WebKit::WebWorkerImpl::newCommonClient):
* src/WebWorkerImpl.h:
* src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
* src/WorkerFileSystemCallbacksBridge.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@93330 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=58834

Patch by James Robinson <jamesr@chromium.org> on 2011-08-18
Reviewed by Darin Fisher.

Source/WebCore:

Handle the root or non-composited content with a GraphicsLayer rather than special case logic in
LayerRendererChromium. This layer's client is the NonCompositedContentHost, which routes the paint callbacks
through the LayerPainterChromium interface out to the WebView.  The root layer is special in two ways:
*) The root layer has a scroll offset, which changes how the visibleLayerRect maps to content space and applies a
    draw-time transform.
*) The root layer masks the alpha channel when drawing because of concerns about subpixel AA trashing the alpha
    channel.  The root layer is always opaque so this is fine.
*) The root layer does not have border texels and does have subpixel AA for text.

Covered by compositing/

* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::scrollPosition):
(WebCore::LayerChromium::setScrollPosition):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::rootLayer):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::viewportWidth):
(WebCore::LayerRendererChromium::viewportHeight):
* platform/graphics/chromium/NonCompositedContentHost.cpp: Added.
(WebCore::NonCompositedContentHost::NonCompositedContentHost):
(WebCore::NonCompositedContentHost::~NonCompositedContentHost):
(WebCore::NonCompositedContentHost::invalidateRect):
(WebCore::NonCompositedContentHost::invalidateEntireLayer):
(WebCore::NonCompositedContentHost::setScrollPosition):
(WebCore::NonCompositedContentHost::notifyAnimationStarted):
(WebCore::NonCompositedContentHost::notifySyncRequired):
(WebCore::NonCompositedContentHost::paintContents):
(WebCore::NonCompositedContentHost::showDebugBorders):
(WebCore::NonCompositedContentHost::showRepaintCounter):
* platform/graphics/chromium/NonCompositedContentHost.h: Added.
(WebCore::NonCompositedContentHost::create):
(WebCore::NonCompositedContentHost::graphicsLayer):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::scrollPosition):
(WebCore::CCLayerImpl::setScrollPosition):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::reallocateRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::viewportSize):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):
* src/WebViewImpl.h:

LayoutTests:

Update pixel baselines that changes due to subtle blending
differences, primarily on scrollbars. I don't know why these keep
changing.

* compositing/checkerboard-expected.png:
* platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
* platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
* platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
* platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
* platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-expected.png:
* platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:

git-svn-id: svn://svn.chromium.org/blink/trunk@93329 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66480

Reviewed by Tony Chang.

* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
(WebCore::ScrollAnimatorNone::PerAxisData::curveDerivativeAt):


git-svn-id: svn://svn.chromium.org/blink/trunk@93328 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66471

Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-18
Reviewed by Anders Carlsson.

* UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::createGtkMenu):

git-svn-id: svn://svn.chromium.org/blink/trunk@93327 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=52153

Reviewed by Antti Koivisto.

Source/WebCore:

Test: http/tests/cache/subresource-multiple-instances.html

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy):

LayoutTests:

* http/tests/cache/subresource-multiple-instances-expected.txt: Added.
* http/tests/cache/subresource-multiple-instances.html: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@93326 bbb929c8-8fbe-4397-9dbb-9b2b20218538

test_expectations.txt.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93325 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66420

Reviewed by Kent Tamura.

Converted the test.

* editing/pasteboard/block-wrappers-necessary-expected.txt: Added.
* editing/pasteboard/block-wrappers-necessary.html:
* platform/chromium-cg-mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/chromium-win-vista/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
* platform/gtk/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/gtk/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/mac/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/mac/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
* platform/qt/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
* platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.


git-svn-id: svn://svn.chromium.org/blink/trunk@93324 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66416

Reviewed by Kent Tamura.

Converted the test and also renamed the test to a more descriptive name.

* editing/pasteboard/5368833.html: Removed.
* editing/pasteboard/paste-blockquote-and-paragraph-break-expected.txt: Added.
* editing/pasteboard/paste-blockquote-and-paragraph-break.html: Copied from LayoutTests/editing/pasteboard/5368833.html.
* platform/chromium-linux/editing/pasteboard/5368833-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5368833-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/5368833-expected.txt: Removed.
* platform/gtk/editing/pasteboard/5368833-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/5368833-expected.png: Removed.
* platform/mac/editing/pasteboard/5368833-expected.png: Removed.
* platform/mac/editing/pasteboard/5368833-expected.txt: Removed.
* platform/qt/editing/pasteboard/5368833-expected.txt: Removed.


git-svn-id: svn://svn.chromium.org/blink/trunk@93323 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93322 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/chromium-cg-mac/fast/canvas/canvas-composite-expected.png:
* platform/chromium-win/fast/canvas/canvas-composite-expected.png:
* platform/chromium-win/fast/canvas/canvas-composite-transformclip-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93321 bbb929c8-8fbe-4397-9dbb-9b2b20218538

went missing in the first place.

* fast/frames/frame-set-scaling-3d-expected.png:
* fast/frames/frame-set-scaling-centered-expected.png:
* fast/frames/frame-set-scaling-expected.png:
* fast/frames/frame-set-scaling-rotate-expected.png:
* fast/frames/frame-set-scaling-skew-expected.png:

git-svn-id: svn://svn.chromium.org/blink/trunk@93320 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66479

Reviewed by Adam Roben.

Add missing includes.

* DumpRenderTree/LayoutTestController.cpp:
* DumpRenderTree/mac/CheckedMalloc.cpp:


git-svn-id: svn://svn.chromium.org/blink/trunk@93319 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66448

Reviewed by Kent Tamura.

Converted the test.

* editing/pasteboard/testcase-9507-expected.txt: Added.
* editing/pasteboard/testcase-9507.html:
* platform/chromium-linux/editing/pasteboard/testcase-9507-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/testcase-9507-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/testcase-9507-expected.txt: Removed.
* platform/gtk/editing/pasteboard/testcase-9507-expected.png: Removed.
* platform/gtk/editing/pasteboard/testcase-9507-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/testcase-9507-expected.png: Removed.
* platform/mac/editing/pasteboard/testcase-9507-expected.png: Removed.
* platform/mac/editing/pasteboard/testcase-9507-expected.txt: Removed.
* platform/qt/editing/pasteboard/testcase-9507-expected.txt: Removed.


git-svn-id: svn://svn.chromium.org/blink/trunk@93318 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66476

Reviewed by Adam Roben.

* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCSetException):
Use a WTF String here instead of an STL string.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
std::make_pair now takes rvalue references, so get rid of the template arguments and let
the compiler deduce them instead.


git-svn-id: svn://svn.chromium.org/blink/trunk@93317 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66475

Reviewed by Adam Roben.

Remove calls to isnan and isfinite with integer arguments.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::viewport):


git-svn-id: svn://svn.chromium.org/blink/trunk@93316 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixes <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
WebView is moved between windows with different backing scale factors

Reviewed by Anders Carlsson.

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
window at all) might have a different backing scale factor than the previous one.
(-[WebView _deviceScaleFactor]): Moved to the WebFileInternal category.

Source/WebKit2:

* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
window at all) might have a different backing scale factor than the previous one.
(-[WKView _deviceScaleFactor]): Moved to the new FileInternal category.

Tools:

Test that WebKit updates style when a WebView is moved between differently-scaled windows

* TestWebKitAPI/JavaScriptTest.cpp:
(TestWebKitAPI::runJSTest): Moved a little bit of code from here...
(TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
gtest's built-in error messages.

* TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
WKView * for convenience on Mac. Added compareJSResult helper function for implementing
those overloads.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.

* TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
(-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
(-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
(TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
(TestWebKitAPI::setPageLoaderClient): Set up the client.
(TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
(TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
SyntheticBackingScaleFactorWindow and returns it.
(TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
window, is moved to a differently-scaled window, and is taken out of the window.
(TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
WebKit1 and WebKit2.
(TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.

* TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.

* TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
(TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.

* TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
* TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
(-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
initializer.
(-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.

(-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
(-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
Overrides of NSWindow methods that WebKit uses to determine the device scale factor.

git-svn-id: svn://svn.chromium.org/blink/trunk@93315 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The device scale factor is no longer considered part of WebPageProxy's "view state". It now
has its own setter/getter. This made the code a little simpler and more similar to the page
scale factor. Each port-specific WebKit2 view is now responsible for calling
WebPageProxy::setDeviceScaleFactor whenever it thinks the device scale factor might have
changed.

Fixes <http://webkit.org/b/66466> WebKit2 requires every port-specific view to keep track of
the current device scale factor

Reviewed by Anders Carlsson.

* UIProcess/API/efl/PageClientImpl.cpp:
* UIProcess/API/efl/PageClientImpl.h:
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/PageClient.h:
* UIProcess/qt/QtWebPageProxy.h:
* UIProcess/win/WebView.h:
Removed deviceScaleFactor.

* UIProcess/API/mac/WKView.mm:
(-[WKView _deviceScaleFactor]): Added. Code came from PageClientImpl::deviceScaleFactor.
(-[WKView _windowDidChangeResolution:]): Changed to call WebPageProxy::setDeviceScaleFactor.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Initialize m_deviceScaleFactor.
(WebKit::WebPageProxy::viewStateDidChange): Removed device-scale-factor-related code.
(WebKit::WebPageProxy::setDeviceScaleFactor): Added. Records the new device scale factor and
tells the DrawingAreaProxy about it if it's actually changed.
(WebKit::WebPageProxy::creationParameters): Use m_deviceScaleFactor instead of calling out
to the PageClient.

* UIProcess/WebPageProxy.h: Added m_deviceScaleFactor and setDeviceScaleFactor, which
replaces the DeviceScaleFactor ViewStateFlag.
(WebKit::WebPageProxy::deviceScaleFactor): Inlined this now-simple getter.

git-svn-id: svn://svn.chromium.org/blink/trunk@93314 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* features.gypi:

git-svn-id: svn://svn.chromium.org/blink/trunk@93313 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
        https://bugs.webkit.org/show_bug.cgi?id=66460

        Reviewed by Pavel Feldman.

        Tests: http/tests/inspector/extensions-network-redirect.html
               inspector/extensions/extensions-network.html

        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI.InspectorExtensionAPI):
        (WebInspector.injectedExtensionAPI.Network.requestDispatch):
        (WebInspector.injectedExtensionAPI):
        (WebInspector.injectedExtensionAPI.Network.prototype.getHAR):
        (WebInspector.injectedExtensionAPI.defineDeprecatedProperty.getter):
        (WebInspector.injectedExtensionAPI.defineDeprecatedProperty):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer):
        (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
        (WebInspector.ExtensionServer.prototype._notifyRequestFinished):
        (WebInspector.ExtensionServer.prototype._onGetHAR):
        (WebInspector.ExtensionServer.prototype._onGetResourceContent):
        (WebInspector.ExtensionServer.prototype._requestId):
        (WebInspector.ExtensionServer.prototype._requestById):
        (WebInspector.ExtensionServer.prototype._onAddAuditCategory):
        (WebInspector.ExtensionServer.prototype._onAddAuditResult):
        (WebInspector.ExtensionServer.prototype._onStopAuditCategoryRun):
        (WebInspector.ExtensionServer.prototype.initExtensions):
        (WebInspector.ExtensionServer.prototype._onmessage):

2011-08-18  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
        https://bugs.webkit.org/show_bug.cgi?id=66460

        Reviewed by Pavel Feldman.

        * http/tests/inspector/extensions-network-redirect-expected.txt: Added.
        * http/tests/inspector/extensions-network-redirect.html: Renamed from LayoutTests/http/tests/inspector/extensions-resources-redirect.html.
        * http/tests/inspector/extensions-network-test.js: Renamed from LayoutTests/http/tests/inspector/extensions-resources-test.js.
        (extension_getRequestByUrl.onHAR):
        (extension_getRequestByUrl):
        * http/tests/inspector/extensions-resources-redirect-expected.txt: Removed.
        * http/tests/inspector/extensions-useragent-expected.txt:
        * http/tests/inspector/extensions-useragent.html:
        * inspector/extensions/extensions-api-expected.txt:
        * inspector/extensions/extensions-events-expected.txt:
        * inspector/extensions/extensions-events.html:
        * inspector/extensions/extensions-network-expected.txt: Renamed from LayoutTests/inspector/extensions/extensions-resources-expected.txt.
        * inspector/extensions/extensions-network.html: Renamed from LayoutTests/inspector/extensions/extensions-resources.html.


git-svn-id: svn://svn.chromium.org/blink/trunk@93312 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66243

Reviewed by Martin Robinson.

The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
call it only when the "load-status" change.

This change is important in the context of bug 28851, which aims to change the
order in which "progress finished" and "load finished" callbacks are called. In
this new scenario, at the progress callback the load will never be finished.

* tests/testwebview.c:
(test_webkit_web_view_grab_focus):

git-svn-id: svn://svn.chromium.org/blink/trunk@93311 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        [Windows] editing/input/password-echo-passnode2.html, editing/input/password-echo-passnode3.html,
        editing/input/password-echo-passnode.html, editing/input/password-echo-textnode.html
        failing on Windows since they were added
        https://bugs.webkit.org/show_bug.cgi?id=66461

        Reviewed by Adam Roben.

        Skip the above tests as window.textInputController is not supported on windows.

        * platform/win/Skipped:



git-svn-id: svn://svn.chromium.org/blink/trunk@93310 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=57785

Add missing Qt results for tests added in r93287.

Unreviewed gardening.

* platform/qt/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
* platform/qt/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93309 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Web Inspector: extract content loading functions from RawSourceCode to ContentProvider implementations.
https://bugs.webkit.org/show_bug.cgi?id=66237

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/content-providers.html

* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype._loadResourceContent):
(WebInspector.RawSourceCode.prototype._loadScriptContent):
(WebInspector.RawSourceCode.prototype._loadAndConcatenateScriptsContent):
(WebInspector.ScriptContentProvider):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):

LayoutTests:

* inspector/debugger/content-providers-expected.txt: Added.
* inspector/debugger/content-providers.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93308 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66142

Source/WebCore:

Added code that checks the parent RenderFlowThread of a RenderRegion and creates
a dependency for its referenced RenderFlowThread (from CSS style).

There are two cases:
1. A RenderRegion tries to display the flow thread that laid it out. In this case
the region will be ignored and will not participate in the flow threads regions list.
2. A RenderRegion tries to display a flow thread that contains another region that
tries to display the first region's flow thread. This one can be generalized with any
number of intermediate flow threads. In this case the recursion is detected and only the
first added region will actually be selected. The other region will be ignored. However,
when the recursion is removed the invalid regions will be recovered.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-18
Reviewed by David Hyatt.

Tests: fast/regions/flows-dependency-dynamic-remove.html
       fast/regions/flows-dependency-same-flow.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertPositionedObject):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::dependsOn):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::checkInvalidRegions):
(WebCore::RenderFlowThread::addDependencyOnFlowThread):
(WebCore::RenderFlowThread::removeDependencyOnFlowThread):
(WebCore::RenderFlowThread::pushDependencies):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
* rendering/RenderFlowThread.h:
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::~RenderRegion):
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::nodeAtPoint):
(WebCore::RenderRegion::attachRegion):
(WebCore::RenderRegion::detachRegion):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::parentFlowThread):
(WebCore::RenderRegion::isValid):
(WebCore::RenderRegion::setIsValid):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderFlowThreads):
(WebCore::writeLayers):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::renderFlowThreadWithName):
(WebCore::RenderView::layoutRenderFlowThreads):
* rendering/RenderView.h:
(WebCore::RenderView::hasRenderFlowThreads):
(WebCore::RenderView::isRenderFlowThreadOrderDirty):
(WebCore::RenderView::setIsRenderFlowThreadOrderDirty):
(WebCore::RenderView::renderFlowThreadList):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-18
Reviewed by David Hyatt.

* fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
* fast/regions/flows-dependency-dynamic-remove.html: Added.
* fast/regions/flows-dependency-same-flow-expected.txt: Added.
* fast/regions/flows-dependency-same-flow.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93307 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        [chromium] Updating test expectations.

        Unreviewed.

        * platform/chromium/test_expectations.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@93306 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        [chromium] Updating test expectations.

        Unreviewed.

        * platform/chromium/test_expectations.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@93305 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66233

Source/WebCore:

This is a next step towards splitting SourceFile into RawSourceCode and UISourceCode.
UISourceCode is a part of SourceFile's interface that is visible to ScriptsPanel.
UISourceCode represents a single entry in scripts panel's files select.

Reviewed by Pavel Feldman.

Test: inspector/debugger/ui-source-code.html

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/UISourceCode.js: Added.
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get id):
(WebInspector.UISourceCode.prototype.get url):
(WebInspector.UISourceCode.prototype.get isContentScript):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._didRequestContent):
(WebInspector.ContentProvider):
(WebInspector.ContentProvider.prototype.requestContent):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

LayoutTests:

Reviewed by Pavel Feldman.

* inspector/debugger/ui-source-code-expected.txt: Added.
* inspector/debugger/ui-source-code.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93304 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
device scale factor

Reviewed by Darin Adler.

Source/WebCore:

* WebCore.exp.in: Removed Frame::deviceScaleFactorChanged, added Page::setDeviceScaleFactor.

* css/MediaQueryEvaluator.cpp:
(WebCore::device_pixel_ratioMediaFeatureEval):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::devicePixelRatio):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::addDashboardRegions):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::deviceScaleFactor):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addDashboardRegions):
Changed to get the device scale factor from Page.

* loader/EmptyClients.h:
* page/Chrome.cpp:
* page/Chrome.h:
* page/ChromeClient.h:
Removed Chrome[Client]::deviceScaleFactor.

* page/Frame.cpp:
* page/Frame.h:
Removed deviceScaleFactorChanged. Made deviceOrPageScaleFactorChanged public.

* page/Page.cpp:
(WebCore::Page::Page): Initialize m_deviceScaleFactor.
(WebCore::Page::setDeviceScaleFactor): Added. Code came from
Frame::deviceScaleFactorChanged.

* page/Page.h: Added m_deviceScaleFactor.
(WebCore::Page::deviceScaleFactor): Added simple getter.

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
* src/ChromeClientImpl.h:
Removed deviceScaleFactor.

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.cpp:
* WebCoreSupport/ChromeClientEfl.h:
Removed deviceScaleFactor.

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
* WebCoreSupport/ChromeClientGtk.h:
Removed deviceScaleFactor.

Source/WebKit/haiku:

* WebCoreSupport/ChromeClientHaiku.cpp:
* WebCoreSupport/ChromeClientHaiku.h:
Removed deviceScaleFactor.

Source/WebKit/mac:

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
Moved code to calculate the device scale factor from here...

* WebView/WebView.mm:
(-[WebView _deviceScaleFactor]):
...to here.

(-[WebView _windowDidChangeResolution:]): Now calls Page::setDeviceScaleFactor.

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate): Removed pixelRatio.
(QWebPage::viewportAttributesForSize): Now calls Page::setDeviceScaleFactor.

* Api/qwebpage_p.h: Removed pixelRatio.

* WebCoreSupport/ChromeClientQt.cpp:
* WebCoreSupport/ChromeClientQt.h:
Removed deviceScaleFactor.

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
Removed deviceScaleFactor.

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.cpp:
* WebCoreSupport/ChromeClientWinCE.h:
Removed deviceScaleFactor.

Source/WebKit/wx:

* WebKitSupport/ChromeClientWx.cpp:
* WebKitSupport/ChromeClientWx.h:
Removed deviceScaleFactor.

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:
Removed deviceScaleFactor.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::hideFindIndicator):
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::deviceScaleFactor):
Changed to get the device scale factor from WebCore.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setDeviceScaleFactor):
* WebProcess/WebPage/WebPage.h:
Removed m_deviceScaleFactor. We always get the scale factor from WebCore now.

git-svn-id: svn://svn.chromium.org/blink/trunk@93303 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Dump-as-markup conversion: editing/pasteboard/paste-text-010.html and editing/pasteboard/paste-text-015.html
https://bugs.webkit.org/show_bug.cgi?id=66440

Reviewed by Kent Tamura.

Converted the tests.

* editing/pasteboard/paste-text-010-expected.txt: Added.
* editing/pasteboard/paste-text-010.html:
* editing/pasteboard/paste-text-015-expected.txt: Added.
* editing/pasteboard/paste-text-015.html:
* platform/chromium-linux/editing/pasteboard/paste-text-010-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/paste-text-015-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-010-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-010-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-015-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-015-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-010-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-015-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-010-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-010-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-015-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-015-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-010-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-015-expected.txt: Removed.


git-svn-id: svn://svn.chromium.org/blink/trunk@93302 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Dump-as-markup conversion: editing/pasteboard/paste-text-017.html and editing/pasteboard/paste-text-018.html
https://bugs.webkit.org/show_bug.cgi?id=66443

Reviewed by Kent Tamura.

Converted the tests.

* editing/pasteboard/paste-text-017-expected.txt: Added.
* editing/pasteboard/paste-text-017.html:
* editing/pasteboard/paste-text-018-expected.txt: Added.
* editing/pasteboard/paste-text-018.html:
* platform/chromium-linux/editing/pasteboard/paste-text-017-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/paste-text-018-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-017-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-017-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-018-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-018-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-017-expected.png: Removed.
* platform/gtk/editing/pasteboard/paste-text-017-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-018-expected.png: Removed.
* platform/gtk/editing/pasteboard/paste-text-018-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-017-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-017-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-018-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-018-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-017-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-018-expected.txt: Removed.


git-svn-id: svn://svn.chromium.org/blink/trunk@93301 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=65145

Reviewed by Nikolas Zimmermann.

Renamed the SVG-specific whitespace functions to call it "SVG space"
rather than just "whitespace". An alternative would have been to put
the functions into an SVG namespace instead of the top level WebCore
namespace.

* svg/SVGAnimateMotionElement.cpp:
(WebCore::parsePoint): Call skipOptionalSVGSpaces.
* svg/SVGAnimationElement.cpp:
(WebCore::parseKeySplines): Ditto.
* svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseViewBox): Ditto.
* svg/SVGLengthList.cpp:
(WebCore::SVGLengthList::parse): Call isSVGSpace and
skipOptionalSVGSpacesOrDelimiter.
* svg/SVGParserUtilities.cpp:
(WebCore::genericParseNumber): Call skipOptionalSVGSpacesOrDelimiter.
(WebCore::parseArcFlag): Ditto.
(WebCore::parseRect): Call skipOptionalSVGSpaces.
(WebCore::pointsListFromSVGData): Ditto.
(WebCore::parseGlyphName): Call skipOptionalSVGSpaces, isSVGSpace,
and skipOptionalSVGSpacesOrDelimiter.
(WebCore::parseDelimitedString): Call skipOptionalSVGSpaces.

* svg/SVGParserUtilities.h:
(WebCore::isSVGSpace): Renamed from isWhitespace. This better matches
the comment which specifically talks about SVG.
(WebCore::skipOptionalSVGSpaces): Renamed from skipOptionalSpaces.
(WebCore::skipOptionalSVGSpacesOrDelimiter): Renamed from
skipOptionalSVGSpacesOrDelimiter.

* svg/SVGPathStringSource.cpp:
(WebCore::SVGPathStringSource::moveToNextToken): Call skipOptionalSVGSpaces.
* svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): Ditto.
* svg/SVGStringList.cpp:
(WebCore::SVGStringList::parse): Call isSVGSpace and
skipOptionalSVGSpacesOrDelimiter.
* svg/SVGTransformable.cpp:
(WebCore::parseTransformParamList): Call skipOptionalSVGSpaces and
skipOptionalSVGSpacesOrDelimiter.
(WebCore::SVGTransformable::parseTransformAttribute): Call skipOptionalSVGSpaces.


git-svn-id: svn://svn.chromium.org/blink/trunk@93300 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66046

Reviewed by Alexey Proskuryakov.

* src/WebBindings.cpp:


git-svn-id: svn://svn.chromium.org/blink/trunk@93299 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66426

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Changed the branchTestPtr to branchTest32.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

Reviewed by Oliver Hunt.

Added a trivial test of mod-by-zero, which fails with the previous version
of the DFG speculative JIT.

* fast/js/mod-by-zero-expected.txt: Added.
* fast/js/mod-by-zero.html: Added.
* fast/js/script-tests/mod-by-zero.js: Added.
(mod):


git-svn-id: svn://svn.chromium.org/blink/trunk@93298 bbb929c8-8fbe-4397-9dbb-9b2b20218538