- 23 Jul, 2019 40 commits
-
-
Chris Harrelson authored
is on. Bug: 954331 Change-Id: Id6a87efe8a8027b4636a6bfeaab3c9b6f578ba5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709158Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#679862}
-
Andrew Grieve authored
Also relands follow-up: Remove obsolete flags, code clean-up. Original reviews: https://chromium-review.googlesource.com/c/chromium/src/+/1694090 https://chromium-review.googlesource.com/c/chromium/src/+/1692492 Reason for reland: * Now applies zipfile work-around to necessary scripts Bug: 981974, 983519 Change-Id: Idce36ea6102302444bd77bebec4e3c1058db3161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711817 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#679861}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4fbd1e670284..b451020e5f76 Created with: gclient setdep -r src-internal@b451020e5f76 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tinazwang@google.com,horo@google.com,yigu@google.com Change-Id: Ic96af6050386903a2d373f509afabea078493054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714344Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679860}
-
Aaron Leventhal authored
Makes debugging the serializer easier -- less noisy. The caret is not accessed as an object, it is accessed via caret and selection APIs on each platform. Bug: None Change-Id: Ie4f9422b21e0485a407af0e21258433572b3d080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707828Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#679859}
-
Francois Buergisser authored
Check whether the driver supports request API and open the decoder device earlier in the initialization to determine if Chromium will need to use new or legacy accelerators in the future. BUG=chromium:917279 TEST=VDA unittest with test-25fps.h264 and frame validation on Minnie 3.14 Change-Id: I5d3bb82d3c25bcb5414490e82ea8add978bb6635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709320Reviewed-by:Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#679858}
-
Erik Chen authored
Change-Id: I439a3c34c3407dcac66c4c8d3c07793811eab7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713248 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#679857}
-
Mohsen Izadi authored
This reverts commit fc049467. This causes some issues with backdrop filters (crbug/986206). This also reverts commit a843bfee which landed some cleanups after the above commit. TBR=kylechar BUG=986206 Change-Id: I4bca9752808da555f856bfeeb1ab1516b5e4efb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713442 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#679856}
-
Ahmed Fakhry authored
We should only reset the transforms of the mirror layers of the direct children of the desk container. BUG=866622 TEST=Manually Change-Id: Id2e386dcbb564b4aa46b358d1c3886e243c1af49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714293Reviewed-by:
-
Makoto Shimazu authored
promise_reject returns a promise and needs await. Bug: n/a Change-Id: Ida68b118be05268d9e74c9c22886f9064537e700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708663Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#679854}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2fb54ea4618d..a71ec4632a12 git log 2fb54ea4618d..a71ec4632a12 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 simonhatch@chromium.org Pinpoint - Simplified UI 2019-07-22 dberris@chromium.org Catapult: Add a flag to disable Android tests Created with: gclient setdep -r src/third_party/catapult@a71ec4632a12 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:982391,chromium:985223 TBR=zhanliang@google.com Change-Id: I18e245acda1993dc9c7ae63e13b236ec62fdba3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714090Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679853}
-
Yi Gu authored
The test is flaky on Win. See https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyYAsSBUZsYWtlIlVjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFBhZ2VMb2FkTWV0cmljc0Jyb3dzZXJUZXN0Lk5vUGFpbnRGb3JFbXB0eURvY3VtZW50SW5DaGlsZEZyYW1lDA TBR=johnidel@chromium.org Bug: 986642 Change-Id: I79f1c1a9fc9d827638398d28050abd31f1230b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714292Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#679852}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/592539fdee80..02407743bd72 git log 592539fdee80..02407743bd72 --date=short --no-merges --format='%ad %ae %s' 2019-07-22 dongja@google.com Vulkan: implement indirect dispatch 2019-07-22 jmadill@chromium.org Vulkan: Rename 'extents' param to 'glExtents'. Created with: gclient setdep -r src/third_party/angle@02407743bd72 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: Ib93a32e7bacef862a09eac15aa6e05d42dd5f983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714089Reviewed-by:
-
Andrew Xu authored
Bug: 985487 Change-Id: I7d23ae183ef3b17368c3b09b1dd35fe1559206a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708002 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#679850}
-
Andrew Grieve authored
Strictly a refecator to cut down on number of explicit rules. Change-Id: I3afad5ccd63d2347c69343df15014118780f512e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711978 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Chris Harrelson authored
Also, fix border-radius of the CALayer overlay to account properly for devicePixelRatio. TBR=sdy@chromium.org Bug: 983334 Change-Id: Ie30bfaa7430d9665ead15e8aaad6719c6ee7ba23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711068Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#679848}
-
Austin Tankiang authored
Bug: 632988 Change-Id: Ia4c1b0020958ba8e4243f4797945fc05d2c89400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706457Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#679847}
-
Eric Willigers authored
WPTs for getComputedStyle results for the following properties: - margin - inline-size, block-size - perspective-origin - transform-origin https://drafts.csswg.org/css-box-3/#propdef-margin https://drafts.csswg.org/css-logical-1/#dimension-properties https://drafts.csswg.org/css-transforms-2/#perspective-origin-property https://drafts.csswg.org/css-transforms-2/#transform-origin-property Change-Id: I7318446a148323649ff4f555855495b69e6c3992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708695 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#679846}
-
Paul Miller authored
Change-Id: Iba97e861e9eb3aef56ce016adc8b378135344b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711108 Auto-Submit: Paul Miller <paulmiller@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Ifd7531da65ac69f44d30adbd82507c2e59f90606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714386Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#679844}
-
Alexey Baskakov authored
Replace InstallFinalizer::Source with universal WebappInstallSource. Note that ExternalInstallSource is a strict subset of WebappInstallSource. This is a preparation CL: WebAppInstallFinalizer will need full WebappInstallSource information. Bug: 860583 Change-Id: I60630657fde9d2de5f48a3b99aa35536b2d0c6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710896 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#679843}
-
Jeremy Chinsen authored
In PDFiumEngine, pages are enlarged and inset based on the size of its surrounding shadows. With the introduction of two-up view, the sizes of shadows depend on the layout and the position of the page in a document. This CL adds the |two_up_view_| flag which denotes the current layout of PDFiumEngine. This CL also adds two helper functions to PDFiumEngine, InsetPage() and EnlargePage(), to extract the logic of computing the inset sizes and then using them to enlarge/inset pages. These two helper functions help manage the complexity of calculating page dimensions in PDFiumEngine. Bug: 51472 Change-Id: If81009880e208af5c4c256cf8fe6ecb9c4df6299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713428Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Cr-Commit-Position: refs/heads/master@{#679842}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b7dad440407e..f0c11b3aa2a7 git log b7dad440407e..f0c11b3aa2a7 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-23 reed@google.com add 'r'epeat option sans the HUD (to not complicate the profile) 2019-07-23 mtklein@google.com hoist tbl masks 2019-07-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-22 rmistry@google.com Fix G3 compile bot 2019-07-22 mtklein@google.com let JIT code hoist when possible 2019-07-22 csmartdalton@google.com ccpr: Unblacklist Radeon in MSAA mode Created with: gclient setdep -r src/third_party/skia@f0c11b3aa2a7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Change-Id: I86cd39351e06a803677b7a90fb8b853d4443ee38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714046Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/79b937fc949d..687f5a81a807 git log 79b937fc949d..687f5a81a807 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 eashanbhatt@google.com cros_test_unittest: Add Fetch Results Unittest 2019-07-23 vapier@chromium.org vm_unittest: disable flaky testSystemQemuPath 2019-07-22 alexlau@chromium.org cbuildbot: Add target to Android metadata Created with: gclient setdep -r src/third_party/chromite@687f5a81a807 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Id45bc74840e3e5aa33a96a062a5f2df5c8b2fafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714171Reviewed-by:
-
ShihYing Chen authored
Currently there is failed to load resource error when opening a new tab in chromeos guest session. The root cause is NTPResourceCache is hardcoded to not return new tab css resource for guest mode. This change remove incognito_new_tab_theme.css in NTP page. Bug: None Test: Manual Change-Id: I1e900b6e3a2e9614bf0dd175e34355cb6e66e851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712509Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: ShihYing Chen <shihyingchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#679839}
-
Noel Gordon authored
The eject button should be 3px left of the splitter (not 0px), and the label width computation should include that 3px splitter gap + the 6px margin either side of the label. See crbug.com/979162#c20 and crbug.com/979162#c21 for the computations of the values. The result would look like this: ____________________________________|‾‾‾‾‾| ;; |..6px..|____label_width____|..6px..|
⏏ | < 3px > ;; < splitter |_____| ;; However after CL:1617041, removable volume labels and the eject button are position: absolute. And the splitter bar can be used to reduce the width of the directory tree. Doing that causes the label text to '...' elide: removable volume labels are the only directory tree labels that do that (... elide) in Files app at this time! Including the 6px margin either side of the label in the width, causes the label text to completely elide (disappear) when the directory tree width is small. To avoid that and at least show some characters of the label text when elided, we _do not_ include the 6px margin either side of the label in its width computation, but do account for the 3px gap, width: calc(100% - 48px - 40px - 3px); which gets added in this CL (using right: 3px) to the eject button. If future developers wonder about it, this long-ish change log might help them understand the intricate CSS minutiae of the eject button. Bug: 979162 Change-Id: I73a9cd89ba5b88ba603301ba3187c86cb4875670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712350Reviewed-by:Noel Gordon <noel@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#679838}
-
Kyle Milka authored
When backspace is press on the image selection submenu it should return to the main backgrounds menu. Bug: 937570 Change-Id: I6f220a851966ee62eaf9b1f52f9ab2e9f9cc0d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709759 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#679837}
-
Julian Watson authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/7fce758d6770..80a8441a9d67 $ git log 7fce758d6..80a8441a9 --date=short --no-merges --format='%ad %ae %s' 2019-07-19 juwa vm_tools: plumb through export import cancellation messages 2019-07-08 ahassani system_api: Add Operation Enum to protobuf Created with: roll-dep src/third_party/cros_system_api Bug=chromium:978318 Change-Id: I6d5e141f51689b623444ff67106f80fa67286dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714191 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#679836}
-
Brian Sheedy authored
Removes the uploading of images to a GS bucket on failure in the GPU pixel tests, as it was only meant as a temporary measure to help debug an issue. The uploading code is still kept around for future use, but it is not called from anywhere. Bug: 983600 Change-Id: Id8d8158487d2f7dd79f944689f50c46a0d7d8cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714148 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#679835}
-
Stephen Chenney authored
Bug: 984223 Change-Id: I8cb6a3c661a7a56f52fe34d8a78f76eb32f6fdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706582 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Darwin Huang authored
No logic changes. (Many affected Windows type "objects" are really just struct pointers.) Reference: https://cs.chromium.org/chromium/src/base/win/windows_types.h?l=79 Change-Id: Ib7ab8cd5f36f57c053f47d49dfde1597ba05d553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710784 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#679833}
-
Sunny Sachanandani authored
DWM composition is limited to primary monitor's refresh rate. Prior to GPU vsync we would use DWM composition rate to drive begin frames. With GPU vsync we started using per monitor vblank to limit begin frames in case primary monitor had higher refresh rate, but this might be causing draw duration and omnibar latency regressions. MS platform team also suggested syncing to primary monitor only. In any case the correct approach would be to further limit begin frames based on event queries from 2 frames back. This CL makes the GPU vsync begin frames sync to primary monitor, and also makes the vsync thread a singleton since it doesn't have per-window state any more. Bug: 953970 Change-Id: Id3d3f043cb847172b1d6ba4bd38b087ceb2d8631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711215Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#679832}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 78b1d963. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" ee7626e7 "Fixing tranferFromimageBitmap-toBlob-offscreen.html to not be flaky" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I062e20312b171ddac719ce7833f2a30eff1e518b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713597Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679831}
-
Andrii Sagaidak authored
Currently, every experiment description div element receives an onclick event, which will do an action only if a condition holds. This PR will make a change to not add the onclick event if it's no-op. Bug: 986535 Change-Id: I2cde879823faa19f700b18e97c20e4e28dffd84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713599Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Andrii Sagaidak <ansagaid@microsoft.com> Cr-Commit-Position: refs/heads/master@{#679830}
-
Darin Fisher authored
A significant part of this CL is moving code off the IO thread and avoiding a number of thread hops as a result. Bug: 967834 Change-Id: I7d1ee6f82f07f74793ad80ab54da2dfb458e2796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672111 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#679829}
-
Aleks Totic authored
LayoutNGMixin is supposed to be a mixin base class for NG layout objects. It implements functionality common to NG layout object subclasses. LayoutNGMixin assumed that its base class was a subclass of LayoutBlockFlow. This is not always true. Some NG classes are a subclass of LayoutBlock. This CL splits LayoutNGMixin into 2 classes: - old LayoutNGMixin is renamed to LayoutNGBlockFlowMixin. It contains code shared between LayoutNG subclasses of LayoutBlockFlow - LayoutNGMixin is a brand new class that contains code shared between LayoutNG subclasses of LayoutBlock The original motivation for this change was need to share UpdateOutOfFlowBlockLayout between LayoutNGBlockFlow and LayoutNGFlexibleBox. This CL moves this method to LayoutNGMixin. LayoutNGFlexibleBox is now a subclass of LayoutNGMixin. There was also some minor cleanup. Most of it fit the pattern: if (IsLayoutNGMixin() || IsLayoutNGFlexibleBox()) and got simplified to if (IsLayoutNGMixin()) Bug: 958381 Change-Id: I5f2254c8d4fab9f4518e048564c867c436855a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711021 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#679828}
-
Yi Gu authored
The test is flaky on Win. See https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyZgsSBUZsYWtlIltjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUBodHRwL3Rlc3RzL2RldnRvb2xzL2VsZW1lbnRzL2VkaXQvZWRpdC1kb20tYWN0aW9ucy0xLmpzDA TBR=luoe@chromium.org NOTRY=true Bug: 985811 Change-Id: Ie224b703dc1b6c45765ff52f54e793aa46d9af87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714327Reviewed-by:
-
Gayane Petrosyan authored
Bug: 960982 Change-Id: I308196d1210ab9d3e45ea79c68a754cf1789660b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713276 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#679826}
-
Jeremy Chinsen authored
Currently draw_utils::GetPageInsetsForTwoUpView() checks that the |page_index| is greater than or equal to 0. Since |page_index| is size_t, it can never be less than 0. Change-Id: Ied708bec3f5bbfa8861b97e10ba584b66fbb59fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714207Reviewed-by:
-
Xing Liu authored
This CL adds a time randomizer for notification scheduler background task. Bug: 963283 Change-Id: I79f255733b01f6257fb39e603270345c2f08d706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708014 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#679824}
-
Hiroki Nakagawa authored
Bug: 986019 Change-Id: Ie0033961c6e4b00eec638006a580a86c81f695dc Notry: true Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714193Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#679823}
-
