GitLab

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/GotqYh_4mFA/KgO0qCCpXcMJ

BUG= 430788

Review URL: https://codereview.chromium.org/690033002

git-svn-id: svn://svn.chromium.org/blink/trunk@184898 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mac10.6 (deps) is used for all mac ports.

R=dpranke
BUG=none

Review URL: https://codereview.chromium.org/690943002

git-svn-id: svn://svn.chromium.org/blink/trunk@184897 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/692233004

git-svn-id: svn://svn.chromium.org/blink/trunk@184896 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SVGShapePainter is the only class to paint markers so the marker painter
class is all overhead. This patch moves the marker painter code into
SVGShapePainter.

BUG=412088

Review URL: https://codereview.chromium.org/693313003

git-svn-id: svn://svn.chromium.org/blink/trunk@184895 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Remove userPreferredLanguagesOverride().  It's unused.
- Rename canonicalizedLanguageIdentifier() to canonicalizeLanguageIdentifier().
- Make sure that platformLanguage() and userPreferredLanguages() return language
  codes with '-'.
- Optimize platformLanguage().  It shouldn't create a Vector every time.

BUG=

Review URL: https://codereview.chromium.org/703043002

git-svn-id: svn://svn.chromium.org/blink/trunk@184894 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We can remove unnecessary assertions and runtime null checks by this change.

BUG=
TEST=none; No behavior changes.

Review URL: https://codereview.chromium.org/704963002

git-svn-id: svn://svn.chromium.org/blink/trunk@184893 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We are implementing the Streams API. To make back-pressure take effect, we
should allow the resource loading customer such as XHR or the Fetch API
to read the data manually.
This CL adds a WebDataConsumerHandle to didReceiveResponse parameters.
This CL does not change the behavior as of now.

The tricky part is how to deal with a handle. As WebDataConsumerHandle
cannot be shared by multiple clients, we can't add the handle in the
response. Moreover, we assert that handle must be null when more than
one client exists in RawResource.cpp.

BUG=418879

Review URL: https://codereview.chromium.org/603903003

git-svn-id: svn://svn.chromium.org/blink/trunk@184892 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If we are overflow:hidden and have fixed-pos children we would transition
to impl-side scrolling. This was exposing another bug (304810)
where on impl-side where we do not correctly stop body elements from 
scrolling. This lead us to scroll elements on the impl-thread even 
if they need to be main-thread scrolled.

Here we do not short-circuit the main-thread requirements if
the frame is overflow:hidden. This is equivalent to our old
implementation, and lets gmail continue to be on impl-thread,
which is what abarth had originally changed that caused this issue.

BUG=411767
R=vollick@chromium.org

Review URL: https://codereview.chromium.org/699183004

git-svn-id: svn://svn.chromium.org/blink/trunk@184891 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All this does is associate the Range of the result with the start and end
accessibility object anf offset.

BUG=426414

Review URL: https://codereview.chromium.org/696533003

git-svn-id: svn://svn.chromium.org/blink/trunk@184890 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* nextNodeWithGreaterTabIndex:
  Set |currentTabIndex| to |winningTabIndex|
  They are same in the |if| block.  However |currentTabIndex| looks better.

* previousNodeWithLowerTabIndex:
  Remove isNonKeyboardFocusableShadowHost() check.  It's redandunt because
  shouldVisit() contains it.

BUG=
TEST=none; no behavior changes

Review URL: https://codereview.chromium.org/700313002

git-svn-id: svn://svn.chromium.org/blink/trunk@184889 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue is no longer web-exposed we should stop testing
it so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/703793002

git-svn-id: svn://svn.chromium.org/blink/trunk@184888 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is in preparation for column-span:all support.

This CL puts basic set renderer insertion needed by column-span:all into
place. Full support for set management (cope with dynamic changes after
inital layout, etc.) and actual support for layout will be introduced in
follow-up CLs. Likewise for layout tests.

Each column-span:all renderer needs a corresponding
RenderMultiColumnSpannerSet. This means that if there's column content
preceding and following the spanner, we need a RenderMultiColumnSet both
before and after it (while, without spanners, there'd never be any need
for more than one column set).

Some extra attention is required when inserting flow thread
descendants now, because we need to figure out if the renderer
inserted should trigger creation of a new column set or a spanner set.

Wrote some unit tests. Layout tests not possible at this time, since this
CL has no (intentional) web-facing changes.

BUG=347325

Review URL: https://codereview.chromium.org/688703003

git-svn-id: svn://svn.chromium.org/blink/trunk@184887 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rather than explicitly catching exceptions and generating promise
rejections, let the bindings code do the work.

R=jkarlin
BUG=392621

Review URL: https://codereview.chromium.org/694083002

git-svn-id: svn://svn.chromium.org/blink/trunk@184886 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add missing cases checking that first-line pseudo-element from ancestors
is ignored inside the grid.

TEST=fast/css-grid-layout/grid-container-ignore-first-line.html

BUG=395788

Review URL: https://codereview.chromium.org/702663002

git-svn-id: svn://svn.chromium.org/blink/trunk@184885 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SkCreateTypefaceFromCTFont implies fonts are non-local
(i.e. serialized as font name only, not the glyphs). This
does not work with the dynamically loaded fonts, so just
keep the SkTypeface we used to create in FontCustomPlatformDataMac
rather than create one from CTFont.

BUG=426088

Review URL: https://codereview.chromium.org/691733004

git-svn-id: svn://svn.chromium.org/blink/trunk@184884 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This assert is causing PPAPI tests to flakily fail on the Linux Chromium
ChromeOS trybot.

BUG=430344
TBR=zeeshanq@chromium.org

Review URL: https://codereview.chromium.org/704673005

git-svn-id: svn://svn.chromium.org/blink/trunk@184883 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We'd like to investigation how many pages will be affected by the feature [1].
This CL also adds counters for <input type=submit>, which is a typical
affected element.

[1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QpEoCwU0Ttg

BUG=141169

Review URL: https://codereview.chromium.org/706503002

git-svn-id: svn://svn.chromium.org/blink/trunk@184882 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test depends on the exact output of zlib, which may vary depending
on which CPU optimizations it's able to use.

BUG=430557
TBR=vsevik@chromium.org

Review URL: https://codereview.chromium.org/702183002

git-svn-id: svn://svn.chromium.org/blink/trunk@184881 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Prevent inherited style from propagating into a plugin placeholder. (patchset #3 id:40001 of https://codereview.chromium.org/669883003/)

Reason for revert:
Causing layout test fast/plugins/plugin-placeholder-inherit.html to fail.

Original issue's description:
> Prevent inherited style from propagating into a plugin placeholder.
> 
> Without setting 'all: initial', it's possible for text colours and such to be
> inherited by the placeholder, which is unexpected.
> 
> TEST=fast/plugins/plugin-placeholder-inherit.html
> BUG=364716
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184878

TBR=esprehn@chromium.org,mkwst@chromium.org,jbroman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=364716

Review URL: https://codereview.chromium.org/706623003

git-svn-id: svn://svn.chromium.org/blink/trunk@184880 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/702603003

git-svn-id: svn://svn.chromium.org/blink/trunk@184879 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Without setting 'all: initial', it's possible for text colours and such to be
inherited by the placeholder, which is unexpected.

TEST=fast/plugins/plugin-placeholder-inherit.html
BUG=364716

Review URL: https://codereview.chromium.org/669883003

git-svn-id: svn://svn.chromium.org/blink/trunk@184878 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<select multiple>, <select size=2-or-greater>, and <input
type=date/datetime-local/month/time/week> had a bug that they prevented
sequential focus navigation even if they were not focusabble.

Change nextNodeWithGreaterTabIndex() so that it uses adjustedTabIndex().

BUG=425937
TEST=automated

Review URL: https://codereview.chromium.org/681103003

git-svn-id: svn://svn.chromium.org/blink/trunk@184877 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test float-paginate-complex adds nothing over the other float-* tests,
except the case with a big line box. That case has been split out into
a new reftest: float-big-line.

R=mstensho@opera.com
BUG=386567

Review URL: https://codereview.chromium.org/699593003

git-svn-id: svn://svn.chromium.org/blink/trunk@184876 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch is a first step towards cleaning up StylesSidebarPane and
introduction of structured object instead of styleRule objects.

This patch removes styleRule.section property, and kills unneeded
section.uniqueProperties list.

R=vsevik, pfeldman

Review URL: https://codereview.chromium.org/699873002

git-svn-id: svn://svn.chromium.org/blink/trunk@184875 bbb929c8-8fbe-4397-9dbb-9b2b20218538

They are duplication of WebURLRequest::FetchRequestMode and WebURLRequest::FetchCredentialsMode.

BUG=N/A

Review URL: https://codereview.chromium.org/706543002

git-svn-id: svn://svn.chromium.org/blink/trunk@184873 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The new WebSocket implementation doesn't support the extension.

R=yhirano
BUG=339373

Review URL: https://codereview.chromium.org/706573003

git-svn-id: svn://svn.chromium.org/blink/trunk@184871 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This turns out to be the wrong way to solve the problem. We'll have to
think harder about the best way to support this (uncommon) use case.

BUG=429244
TBR=jww@chromium.org

Review URL: https://codereview.chromium.org/704723003

git-svn-id: svn://svn.chromium.org/blink/trunk@184870 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The style rules of tree elements became outdated after the rule was
edited. This patch adds synchronization for them as well.

BUG=430133
R=vsevik

Review URL: https://codereview.chromium.org/692073003

git-svn-id: svn://svn.chromium.org/blink/trunk@184869 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added an explicit column-gap, used column-count rather than column-width,
and removed some lines to make the test fit better in content_shell.

R=mstensho@opera.com
BUG=386567

Review URL: https://codereview.chromium.org/695283002

git-svn-id: svn://svn.chromium.org/blink/trunk@184868 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Ctrl+/Ctrl- shortcuts are already supported in hosted mode on linux
for some time. This patch adds the same supoprt for Cmd+/Cmd- shortcuts
on mac in hosted mode.

TBR=pfeldman

Review URL: https://codereview.chromium.org/702583003

git-svn-id: svn://svn.chromium.org/blink/trunk@184867 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dcheng
NOTRY=true

Review URL: https://codereview.chromium.org/702003003

git-svn-id: svn://svn.chromium.org/blink/trunk@184866 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/673163004

git-svn-id: svn://svn.chromium.org/blink/trunk@184865 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The revalidation headers ("if-modified-since", "if-none-match") should not be exposed to the ServiceWorker.

BUG=429570
TEST=http/tests/serviceworker/resources/fetch-request-no-freshness-headers-iframe.html

Review URL: https://codereview.chromium.org/703813002

git-svn-id: svn://svn.chromium.org/blink/trunk@184864 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings

This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings
(Ref: binding-methods changed:
static v8::Handle<v8::Object> associateObjectWithWrapperNonTemplate(ScriptWrappable*, const WrapperTypeInfo*, v8::Handle<v8::Object>, v8::Isolate*)
static v8::Handle<v8::Object> associateObjectWithWrapperNonTemplate(Node*, const WrapperTypeInfo*, v8::Handle<v8::Object>, v8::Isolate*)
static v8::Handle<v8::Object> associateObjectWithWrapper(PassRefPtr<T>, const WrapperTypeInfo*, v8::Handle<v8::Object>, v8:Isolate*)
static v8::Handle<v8::Object> associateObjectWithWrapper(T*, const WrapperTypeInfo*, v8::Handle<v8::Object>, v8::Isolate*))

BUG=424446

Review URL: https://codereview.chromium.org/695773002

git-svn-id: svn://svn.chromium.org/blink/trunk@184863 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=429176
R=apavlov

Review URL: https://codereview.chromium.org/706523003

git-svn-id: svn://svn.chromium.org/blink/trunk@184862 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There is a bug due to which source ranges in inherited styles sections
and pseudo elements style sections are not updated on the front-end
as the editing happens. This patch fixes it.

BUG=430129
R=vsevik

Review URL: https://codereview.chromium.org/698113006

git-svn-id: svn://svn.chromium.org/blink/trunk@184861 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Window has custom toV8 function, and Window inherits from EventTarget.
So, EventTarget also has custom toV8 because an EventTarget can be a
Window.

crrev.com/646523004 made Node to call EventTarget-version of
v8SetReturnValueForMainWorld because Node inherits from EventTarget,
and it calls toV8 function every time. It caused a perf regression.

This CL adds a new version of v8SetReturnValueForMainWorld for Node
and its subclasses so that they can use the fastest path.

class hierarchy:
    ScriptWrappable <-- EventTarget <--+-- Node <-- ...
                                       +-- Window
overloads:
    v8SetReturnValueForMainWorld(ScriptWrappable*)
        Optimized and very fast.
    v8SetReturnValueForMainWorld(EventTarget*)
        Uses custom toV8 function and slow.
    v8SetReturnValueForMainWorld(Node*)  <----------- NEW!!
        Optimized and very fast.
    v8SetReturnValueForMainWorld(Window*)
        Uses custom toV8 function and slow.

Before this CL:
Element matches EventTarget version of
v8SetReturnValueForMainWorld, and it's very slow.

After this CL:
Element matches Node version of
v8SetReturnValueForMainWorld, and it's very fast.

BUG=428707,235436

Review URL: https://codereview.chromium.org/684763004

git-svn-id: svn://svn.chromium.org/blink/trunk@184860 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Pesky overrun issues.

BUG=430351

Review URL: https://codereview.chromium.org/705663003

git-svn-id: svn://svn.chromium.org/blink/trunk@184859 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the grid and flexbox specs:
"the ::first-line and ::first-letter pseudo-elements do not apply to
grid/flex containers".
http://dev.w3.org/csswg/css-grid/#grid-containers
http://dev.w3.org/csswg/css-flexbox/#flex-containers

This was almost working right, except in the case that an ancestor was
setting the ::first-letter pseudo-element.

Modified RenderBlock::updateFirstLetter() in order to stop looking for
the first text child when you reach a grid or flexbox.
Added a few more cases to the current tests in order to check this
behavior.

TEST=css3/flexbox/flexbox-ignore-container-firstLetter.html
TEST=fast/css-grid-layout/grid-container-ignore-first-letter.html

BUG=430099

Review URL: https://codereview.chromium.org/686173006

git-svn-id: svn://svn.chromium.org/blink/trunk@184858 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch fixes CSS.getMatchedStylesForNode protocol method so that
it starts to report matched selectors for pseudo style matches.

R=vsevik, apavlov

Review URL: https://codereview.chromium.org/697773004

git-svn-id: svn://svn.chromium.org/blink/trunk@184857 bbb929c8-8fbe-4397-9dbb-9b2b20218538