- 05 Oct, 2018 40 commits
-
-
Vasilii Sukhanov authored
The dropdown shouldn't be closed on random clicks on Mac. The focus changes are already handled by the cross-platform code. Bug: 888491 Change-Id: Ic5d40f7de3ae32270716e2df33e9944a1120bc75 Reviewed-on: https://chromium-review.googlesource.com/c/1264595Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#597135}
-
Vasilii Sukhanov authored
Bug: 887914 Change-Id: I2e5c1be711c9242b5efc9a8d8013c95334bba0fb Reviewed-on: https://chromium-review.googlesource.com/c/1264679Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#597134}
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: Idc3b29bd5278166644650d7a248db0112be1373a Reviewed-on: https://chromium-review.googlesource.com/c/1258166 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#597133}
-
Scott Violet authored
AcceleratorDelegate's only purporse was to create AcceleratorRouter and route events to it. This made sense early in on mash work, but the separation is no longer useful. So, I removed AcceleratorDelegate and made AcceleratorRouter implement ::wm::AcceleratorDelegate. Renamed AcceleratorRouter to PreTargetAcceleratorHandler, to better indicate when this class is called and what it handles. Renamed AshFocusManagerFactory::Delegate to PostTargerAcceleratorHandler. Again, this better indicates it's responsibilities. PostTargerAcceleratorHandler also deals with focus changes, but I figure the name PostTargerAcceleratorHandler is better than Delegate. BUG=none TEST=covered by tests Change-Id: Ib92dd35b4bb87b8c0772a499564ee7d6e86c2175 Reviewed-on: https://chromium-review.googlesource.com/c/1263417 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#597132}
-
Ben Kelly authored
When a ServiceWorker script passes a Response back to FetchEvent.respondWith() the browser must get the resulting Response body data back to the outer network loader. For non-blob bodies this is currently done by creating a new mojo::DataPipe and copying the body into its producer handle. The pipe's consumer handle is then passed back to the outer loader. In many cases, however, there is already a mojo::DataPipe for the Response body created by the network code. Its sub-optimal to allocate a new pipe and copy data across to it in these cases. This CL will attempt to extract the underlying mojo::DataPipe from the Response and pass it directly back to the outer loader. Currently this will only trigger for cases where the FetchEvent.preloadResponse is passed to respondWith(). In the future, however, we should be able to make this work for "pass-through" cases where the Response is produced by fetch(). That work is ongoing in https://crrev.com/c/1251841. R=kinuko@chromium.org Bug: 884807 Change-Id: I5a2964ff2e9463492ef72e5b48c5f383ebf36a86 Reviewed-on: https://chromium-review.googlesource.com/c/1239394 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#597131}
-
Antonio Gomes authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates Android's WarmupURLFetcher and the respective unittests away from URLFetcher. Also, the CL relax an NOTREACHED scenario in TestSharedURLLoaderFactory, now that some tests call ::Clone on it. Bug: 879777 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I7b1664a141e409cc2cf43fe8a79eb771e9a9988b Reviewed-on: https://chromium-review.googlesource.com/c/1251641 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#597130}
-
Bruno Santos authored
This already happens for enterprise, guest and legacy supervised users. This change hides powerwash section also for managed child accounts. Bug: 891493 Change-Id: I3b573c56f2e09d4e9220415a1df0b191fe5d6cd0 Reviewed-on: https://chromium-review.googlesource.com/c/1258262Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Bruno Santos <brunoad@google.com> Cr-Commit-Position: refs/heads/master@{#597129}
-
Finnur Thorarinsson authored
TBR: twellington Bug: 860467 Change-Id: I7e8b0f0391befdab1e68fd52eaab6a4480f9882a Reviewed-on: https://chromium-review.googlesource.com/c/1264795Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#597128}
-
Adithya Srinivasan authored
This is a reland of 2eeb21dd Original change's description: > [FileSystem] Remove WebFileSystem > > - Adds blink.mojom.FileSystemManager to the frame and worker > registries, allowing it to be accessed directly from > ExecutionContext::GetInterfaceProvider()->GetInterface() > - Changes ownership of blink::FileSystemDispatcher: now owned by > ExecutionContext > - Omits render_frame_id_ from ChooseEntry > - Removes WebFileSystem and content::FileSystemDispatcher > > Bug: 787281, 873661 > Change-Id: Ie41d48c5a206b5d1f387fcee3bd47bc30a708f0f > Reviewed-on: https://chromium-review.googlesource.com/1217506 > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593983} Bug: 787281, 873661 Change-Id: Ic5d211e2102ebcfef12b51ad59c7eefc6373f5a6 Reviewed-on: https://chromium-review.googlesource.com/c/1258202Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#597127}
-
David Roger authored
Bug: 892372 Change-Id: I139ead7a8a8c9ded7150c31e0779bb8e03728ea7 Reviewed-on: https://chromium-review.googlesource.com/c/1264496Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#597126}
-
rbpotter authored
Ensure the rest of the UI gets re-enabled if an error is cleared Always focus the custom pages input if the custom radio button is clicked Bug: 892024, 892023 Change-Id: Iec93a4ca313dff63fc143aa90c916b3111f37a9a Reviewed-on: https://chromium-review.googlesource.com/c/1262412 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#597125}
-
rbpotter authored
This test was flaky when run with Polymer 2, specifically failing to find > 0 non-hidden list items in the dialog. This appears to have been due to a timing issue with the setTimeout() call in the test setup causing the test to fail inconsistently. This failure could not be reproduced locally with the original test. However, exchanging setTimeout() for waiting for the dialog to open resulted in the same failure occurring consistently with Polymer 2 (but not with Polymer 1). The failure was then fixed by adding Polymer.dom.flush() to ensure the dialog had finished filtering languages before querying for the items. Bug: 875454, 891955 Change-Id: I05c2b60ad0d12619e388a5469a0c1a0418e35a8c Reviewed-on: https://chromium-review.googlesource.com/c/1262973Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#597124}
-
rbpotter authored
Should close dialog on Cmd+Period not Cmd+Minus Bug: 892103 Change-Id: Ia2795c3ccc796c9afa676d401502dc4c3efa6005 Reviewed-on: https://chromium-review.googlesource.com/c/1262433 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#597123}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f98905e8f03c..2fb631023730 git log f98905e8f03c..2fb631023730 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 borenet@google.com Reland gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator Created with: gclient setdep -r src/third_party/depot_tools@2fb631023730 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ia6705b9bf3995b2945fa5edcdad9373bdd5fa794 Reviewed-on: https://chromium-review.googlesource.com/c/1264624Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597122}
-
Francois Doray authored
Apart from the code in resource_coordinator_features.cc/.h and the code in the memory_instrumentation/ sub-directory, the code in services/resource_coordinator/public/cpp is never used from child processes. This CL splits the resource_coordinator_cpp component into 3 separate components (resource_coordinator_cpp, resource_coordinator_features and memory_instrumentation) so that code that runs in child processes doesn't have to depend on all of services/resource_coordinator/public/cpp/ (this is important to avoid security concerns as we add functionality to services/resource_coordinator/public/cpp/). TBR=clamy@chromium.org Change-Id: Ic2045164621d99b11d218d1a01c5ce160a4dc855 Reviewed-on: https://chromium-review.googlesource.com/c/1250006 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#597121}
-
Florin Malita authored
virtual/gpu/fast/canvas/canvas-arc-circumference.html virtual/gpu/fast/canvas/canvas-drawImage-antiAlias.html virtual/gpu/fast/canvas/canvas-ellipse-circumference.html virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill.html virtual/gpu/fast/canvas/fillrect_gradient.html virtual/gpu/fast/canvas/gradient-add-second-start-end-stop.html virtual/gpu-rasterization/images/cross-fade-background-size.html TBR= Bug: 884166,889940,888675,802896 Change-Id: I43312a60d4e8784cd915533bda5cf54141160adb Reviewed-on: https://chromium-review.googlesource.com/c/1262895Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#597120}
-
Paul Jensen authored
Bug: 879211 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: Id3f234c20fb0bf28fab51a4697d8fab7b473ba73 Reviewed-on: https://chromium-review.googlesource.com/c/1207196 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#597119}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2343836c4210..5476e805a321 git log 2343836c4210..5476e805a321 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 oetuaho@nvidia.com Fix constructing void array zero nodes Created with: gclient setdep -r src/third_party/angle@5476e805a321 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890581 TBR=cwallez@chromium.org Change-Id: Id38bb6fa5c1d4bab11e459f18508e793b765be1c Reviewed-on: https://chromium-review.googlesource.com/c/1264627Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597118}
-
Scott Violet authored
If Window::UpdateLocalSurfaceIdFromEmbeddedClient() is called, then the ClientSurfaceEmbedder needs to be updated as well as the server. BUG=890969 TEST=covered by test Change-Id: Ic7fc94166cc5a3f495b01bdd63e41be16092b0d7 Reviewed-on: https://chromium-review.googlesource.com/c/1257365Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#597117}
-
A Olsen authored
Removes DeviceSettingsProvider dep on DeviceLocalAccount, since the settings package is to be moved into src/chromeos/settings, so the less deps it can have, the easier it will be to move. This change relies on the fact that there are two identical enums that are kept in sync - a proto one, and a native C++ one. The code already has a dependency on the proto, so we can easily switch to using that enum to avoid depending on DeviceLocalAccount. Bug: 446937 Change-Id: I1bddb3d7f35b208540f6f02fa027bc11c46d0903 Reviewed-on: https://chromium-review.googlesource.com/c/1264582Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#597116}
-
Rayan Kanso authored
Explicitly check for empty strings and add a WPT test. TBR=peter@chromium.org Change-Id: If969b56382a67419aaee742c47c470efebab95af Reviewed-on: https://chromium-review.googlesource.com/c/1264541Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#597115}
-
A Olsen authored
CrosSettings is an aggregator for all the different CrosSettingsProviders. This doesn't really make sense, since there are only two - DeviceSettingsProvider and SystemSettingsProivder. SystemSettingsProvider only has one read-write setting, and that setting sometimes requires special casing anyway - so not a good fit for an aggregator. ScopedCrosSettingsTestHelper has a function ReplaceProvider(string) that lets clients replace any one of the CrosSettingsProviders with a stub, by supplying the name of the setting of which the provider should be stubbed. But this actually only works for stubbing the DeviceSettingsProvider, since the stub only supports those settings. This change gets rid of the illusion that clients can stub a provider of their choice. Bug: 433840 Change-Id: Ica44494775e0ed756a07ec040732f4a740bab031 Reviewed-on: https://chromium-review.googlesource.com/c/1254282Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#597114}
-
Stephen Chenney authored
Mobile performance regressed when UMA and UKM metrics for the Rendering Core team were added to BeginMainFrame. We hypothesize that the primary cost is recording UMA on every frame for the new metrics, so this patch switches to recording UMA only every 30 seconds, or on frame destruction, when the UKM metrics are recorded. The plan is to monitor performance graphs to determine if this has the desired effect. For the ForcedLayout metric we may need to send the primary UMA metric only once per frame, not once per forced layout as is done now. That is a follow on patch. R=vmpstr@chromium.org BUG=890871,891003,891341 Change-Id: I2f4ec8bb9301cece98aef52463d671e4bebcd91e Reviewed-on: https://chromium-review.googlesource.com/c/1260443Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#597113}
-
Olivier Robin authored
Change-Id: Ice8b17739f5849f75feb03be4001cef7917572bf Reviewed-on: https://chromium-review.googlesource.com/c/1261399Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597112}
-
David 'Digit' Turner authored
Use C++11 default initializers to make ScopedTracer smaller and simpler. Surprisingly, this saves 12288 bytes in MonochromePublic.apk for the 32-bit ARM build! BUG=702718,708990 R=agrieve@chromium.org,lizeb@chromium.org,pasko@chromium.org,alexilin@chromium.org,primiano@chromium.org,picksi@chromium.org Change-Id: Ia1d3e936ec8b9cfe3c52b9cfc0b97a2a38ac7043 Reviewed-on: https://chromium-review.googlesource.com/c/1254723Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#597111}
-
Paul Jensen authored
Bug: 879209 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: Idf94d64fc56addd13b7fafbb3e49d477a4e8c4bd Reviewed-on: https://chromium-review.googlesource.com/c/1231735 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#597110}
-
Siddhartha authored
This CL is moving lifting out the loading from the resource bundle to the corresponding 'ssl_error_assistant_component'. The previous implementation was loading on-demand the bundled proto when needed. But, when the 'ssl_error_assistant_component' is ready, it's setting the received proto. As no SSL error occured, the bundled proto is not loaded and must be loaded on the UI thread. This is causing jank on the UI thread. Which can be seen on the bug 888555. The current proposition is to keep the bundle loading on-demand since error paths are not the common ones. But, for the 'ssl_error_assistant_component' path we proposed to also read the bundled proto and choose the most recent one before sending it to the error assistant on the UI thread. That way, most of the job is done before getting on the UI thread. NOTE: ReadErrorAssistantProtoFromResourceBundle is thread safe and can be executed on any thread. It can also be executed twice. R=fdoray@chromium.org, meacer@chromium.org CC=carlosil@chromium.org, agl@chromium.org Bug: 888555 Change-Id: Icd994f93c849b3c4d8b01d7921dff69f571397a8 Reviewed-on: https://chromium-review.googlesource.com/c/1247025 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#597109}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4bb1e4a1d50f..a1134509c91d git log 4bb1e4a1d50f..a1134509c91d --date=short --no-merges --format='%ad %ae %s' 2018-10-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 618ddbcb..d62b62d8 (596951:597059) 2018-10-05 titovartem@webrtc.org Switch webrtc from deprecated usages of NetworkSimulationInterface 2018-10-05 nisse@webrtc.org Set ChannelReceive transport at construction time. 2018-10-05 phensman@webrtc.org Remove @SuppressLint(NewApi) and guard @TargetApi methods 2018-10-05 mbonadei@webrtc.org Make modules/audio_mixer:audio_mixer_impl publicly visible. 2018-10-05 nisse@webrtc.org Delete support for VoIP metrics (RFC 3611 4.7) Created with: gclient setdep -r src/third_party/webrtc@a1134509c91d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1886ba2aabaea49195bbe20bfafeeb3b73d35a4d Reviewed-on: https://chromium-review.googlesource.com/c/1264626Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597108}
-
Henrik Grunell authored
Adds unit test for effects. Bug: 891202 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I16653e77faa5fc12d4462514b8cd73abbe74341b Reviewed-on: https://chromium-review.googlesource.com/c/1264535Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597107}
-
Rayan Kanso authored
I reproduced the failure locally, and then re-ran with the changes 100 time successfully TBR=peter@chromium.org Change-Id: Ieb60211fcd9c6beb1aec2b152f298335c4d9178b Reviewed-on: https://chromium-review.googlesource.com/c/1264640Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#597106}
-
Stephane Zermatten authored
Before this patch, AutofillAction would behave as follows: - when there are no cards or profile registered for autofill, the action would hang forever, as AutofillAssistantUiDelegate.showProfiles and showCards would return immediately without reporting any results. - when a card or profile was selected, the button would remain, but clicking on it would crash the application (as it would call a C++ callback that was already deleted). This patch attempts to guarantee that the callbacks that correspond to AutofillAssistantUiDelegate.Client::onAddressSelected and onCardSelected are called exactly once. With this patch: - when there are no cards, the callback is called with an empty guid which tells the action to fall back to manuall filling - buttons disappear once they're clicked. If that fails, the C++ layer ignores duplicate calls for the same callback, without crashing. Bug: 806868 Change-Id: I15bb1b1e6ee528c18cbd76763827e69dfe3f1726 Reviewed-on: https://chromium-review.googlesource.com/c/1264475Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#597105}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/56216d7832a4..de52d9ad295e git log 56216d7832a4..de52d9ad295e --date=short --no-merges --format='%ad %ae %s' 2018-10-05 sadrul@chromium.org scroll: Allow for more errors. Created with: gclient setdep -r src/third_party/catapult@de52d9ad295e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:892036 TBR=sullivan@chromium.org Change-Id: Ic8478361b73397bcad961ca65dc35681cf52910f Reviewed-on: https://chromium-review.googlesource.com/c/1264625Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597104}
-
Rune Lillesveen authored
Style sharing is removed and we should not need to avoid caching of matched properties in these cases. Change-Id: I5f6edee0ccd8da16f3361e17077b9b448a978f33 Reviewed-on: https://chromium-review.googlesource.com/c/1264638Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#597103}
-
Lan Wei authored
In order to improve the performance and eliminate the issues that the fake mouse move events cause to the testing and web developers, we should not send fake mouse move events during scroll. This is implemented behind a flag. We will update the hover effect after scroll finishes in a following patch. TBR=bokan@chromium.org,nzolghadr@chromium.org,dtapuska@chromium.org, dgozman@chromium.org Bug: 877132 Change-Id: I484d7457f13d66e8add6faf5bc6c6d14c805af75 Reviewed-on: https://chromium-review.googlesource.com/c/1262423 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#597102}
-
Roger McFarlane authored
This CL adds the PersonalDataManager as a History Service Observer and clears the data used to throttle upload events when the user deletes their browsing history data. Bug: 860285 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I14b1c697fc34e6a6f4afc6599ca60baed55cab5b Reviewed-on: https://chromium-review.googlesource.com/c/1255143Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#597101}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d61a9f0f0d98..263549ba0d66 Created with: gclient setdep -r src-internal@263549ba0d66 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I55b91c8ccb4f702a84c428c14236d80b9f5c7c26 Reviewed-on: https://chromium-review.googlesource.com/c/1264623Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597100}
-
Thomas Tangl authored
Already configure sync in the UnifiedConsentService when the sync engine is initialized, instead of waiting for sync to be active. Bug: 891706 Change-Id: I4f072e56820784f42ce9f2033724e43d8d5f5bf3 Reviewed-on: https://chromium-review.googlesource.com/c/1264656Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#597099}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a6262495da48..b3ce196a4d9d git log a6262495da48..b3ce196a4d9d --date=short --no-merges --format='%ad %ae %s' 2018-10-05 mtklein@google.com de-guard SK_LEGACY_TF_APPLY Created with: gclient setdep -r src/third_party/skia@b3ce196a4d9d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I7a069f33b293afc27dc1083d742bf2925aec4087 Reviewed-on: https://chromium-review.googlesource.com/c/1264622Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597098}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3b5960174f6d..497958d899c3 git log 3b5960174f6d..497958d899c3 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 stevenperron@google.com Removing HLSLCounterBuffer decorations when not needed. (#1954) 2018-10-04 jaebaek@google.com Validator: function scope variable at start of entry block #1923 Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@497958d899c3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I73ecd80882769b71034aa41b661c4ae8c9133325 Reviewed-on: https://chromium-review.googlesource.com/c/1264621Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597097}
-
Sigurdur Asgeirsson authored
Change-Id: Ib2e213b3ca883c0671b12bf8be864719a240feab Reviewed-on: https://chromium-review.googlesource.com/c/1259245Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#597096}
-